Bug#696225: apt: Progress output format problems on some locales
On Tue, Dec 18, 2012 at 12:13:30PM +0100, Guillem Jover wrote:
> Source: apt
> Version: 0.9.7.7
> Severity: minor
> Tags: patch
Thanks for your bugreport and your patch.
[..]
> There's a problem with apt's progress output on some locales, as the
> ellipsis are not marked for translation and one can get things like:
>
> S'està llegint la llista de paquets... 1%
> [...]
> S'està llegint la llista de paquets… Fet8%
>
> The attached patch should fix this, once those new strings are
> translated. Althought you might feel unconfortable applying this for
> wheezy as it might require a new call for translators.
I merged this into my branch now and it will be part of the next
upload. I think its fine for wheezy. While it does add two new
translatable strings its just like it is now if they are not
translated so nothing regresses.
Cheers,
Michael
> Thanks,
> Guillem
> From cd6630cbe7dd30535d933837a31d8dc61a894582 Mon Sep 17 00:00:00 2001
> From: Guillem Jover <guillem@debian.org>
> Date: Tue, 18 Dec 2012 11:41:24 +0100
> Subject: [PATCH] OpProgress: Mark strings for translation
>
> ---
> apt-pkg/contrib/progress.cc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/apt-pkg/contrib/progress.cc b/apt-pkg/contrib/progress.cc
> index 3170488..17a6b70 100644
> --- a/apt-pkg/contrib/progress.cc
> +++ b/apt-pkg/contrib/progress.cc
> @@ -176,7 +176,7 @@ void OpTextProgress::Update()
> if (OldOp.empty() == false)
> cout << endl;
> OldOp = "a";
> - cout << Op << "..." << flush;
> + cout << Op << _("...") << flush;
> }
>
> return;
> @@ -192,7 +192,7 @@ void OpTextProgress::Update()
> }
>
> // Print the spinner
> - snprintf(S,sizeof(S),"\r%s... %u%%",Op.c_str(),(unsigned int)Percent);
> + snprintf(S,sizeof(S),_("\r%s... %u%%"),Op.c_str(),(unsigned int)Percent);
> Write(S);
>
> OldOp = Op;
> --
> 1.8.1.rc0
>
Reply to: