Bug#728153: apt-cdrom should succeed if any drive succeeds

[David Kalnischkies <kalnischkies+debian@gmail.com>]

Hi John,

On Mon, Oct 28, 2013 at 10:44 PM, John Ogness <john.ogness@linutronix.de> wrote:
> [PATCH] apt-cdrom: succeed if any drive succeeds
>
> If there are multiple CDROM drives, `apt-cdrom add` will abort with an
> error if any of the drives do not contain a Debian CD. This is
> particularly a problem if apt-cdrom happens to check a drive with no CD
> first. Then it will abort without even searching the other drives.

I am not sure if ignoring errors is really a good idea. Maybe the drive is
empty or the CD has a million scratches, is upside down in the slot or other
"valid" error cases a user should be notified about.

In any case, the patch doesn't apply as the code changed around 0.9.9.
Is this version still not trying all drives before erroring out completely?

What we could do to collect the error messages without giving the Add()
calls a hint that previous invocations failed is:
_error->PushToStack() and the reverse _error->MergeWithStack().

If we are patching, there is similar code in DoIdent,
so this probably needs to be patched, too.


Best regards

David Kalnischkies