[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#613775: aptitude upgrades lose extended state (automatic status)

retitle 613775 MarkInstall calls with FromUser set to false
reassign 613775 aptitude 0.6.3-3.2

On Thu, Feb 17, 2011 at 14:05, Aaron M. Ucko <ucko@debian.org> wrote:
> First off, I'd like to thank you (David) for responding promptly and
> Sven for providing a user perspective while I was asleep.
> David Kalnischkies <kalnischkies+debian@gmail.com> writes:
>> In that case it would be an aptitude bug as it would call MarkInstall
>> with FromUser == true for requests which are not directly from the user
>> and should therefore not be marked as manual.
> [...]
>> So could you please describe more detailed why do you consider it a bug
>> in APT rather than in aptitude? Exact commands you use for example?
> Thanks for the explanation.  As my initial comment meant to indicate, I
> *don't* necessarily consider the bug to be in APT rather than aptitude,
> and merely assigned it to the former because it occurs only with newer
> versions thereof.  If you honestly feel that the change was fully
> correct and merely revealed a previously latent bug in aptitude, please
> feel free to reassign this report.  Sorry if that was unclear.

No problem. I haven't reassigned the bug instantly as i thought we
should discuss it before. So after that discussion i would strongly
recommend to switch aptitude in the future to use FromUser as needed.
In the meantime i have commited a quickfix which more or less restores
the old behavior in libapt-pkg - the changelog says:

+  * apt-pkg/depcache.cc:
+    - party revert fix in which marked all packages as manual
+      installed if the FromUser bit is set in the MarkInstall call.
+      The default for this bit is true and aptitude depends on the old
+      behavior so the package is only marked as manual if its not marked
+      ("old" behavior) or if automatic installation is enabled - which
+      aptitude disables always (see also #613775)

The complete patch is attached (one line as always) and i guess Michael
will merge/upload it in a short while.

Best regards

David Kalnischkies

P.S.: I hope aptitude gets revived - it has A LOT of users who will miss it!
"There's life in the old dog yet." (through, the german saying sounds much
better in my ears: "Totgesagte leben länger")

Attachment: apt-613775-quickfix-aptitude
Description: Binary data

Reply to: