Bug#500560: [patch] proxy auth percent encoding
Hi Jean-Baptiste Lallement,
2010/3/29 Jean-Baptiste Lallement <jeanbaptiste.lallement@gmail.com>:
> Tags: patch
Thanks for the patch!
> Here is a patch proposed to Ubuntu
Patches in Ubuntu/Debian (at least for APT) went to the vise versa
relatively fast as Michael is for both the "Gatekeeper" so pinging at
one place is mostly enough.
(but doesn't hurt - and i don't need to fiddle with lp) ;)
> It does the following things:
> - in QuoteString: escape '%'
> - unescape proxy credentials
> credentials need to be percent encoded in apt.conf (RFC3986)
I have modified it a bit:
- ParseQuoteWord includes a slightly modified code copy of DeQuoteString:
add the isxdigit() tests also here
- use of array-style addressing instead of funky pointer casting
- overload DeQuoteString to avoid the string-creation in URI::CopyFrom
- replace RFC number in the comment as you suggested
- add your changes to debian/changelog
- add two comments to be able to understand the hex-values still tomorrow
So in essence: Your patch - with a bit of juicy in my debian-sid :)
http://bazaar.launchpad.net/~donkult/apt/sid/revision/1985
Again: Thanks and best regards / Mit freundlichen Grüßen,
David Kalnischkies
Reply to: