[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#594435: Quoted strings in pin specifications do not work



On Mon, 2010-08-30 at 11:34 +0200, David Kalnischkies wrote:
> === modified file 'apt-pkg/versionmatch.cc'
> --- apt-pkg/versionmatch.cc     2010-06-28 15:38:08 +0000
> +++ apt-pkg/versionmatch.cc     2010-08-30 09:33:13 +0000
> @@ -118,7 +118,10 @@
>     
>     if (Type == Origin)
>     {
> -      OrSite = Data;
> +      if (Data[0] == '"' && Data.end()[-1] == '"')
> +        OrSite = Data.substr(1, Data.length() - 2);
> +      else
> +        OrSite = Data;
>        return;
>     }   
>  }

Is Data guaranteed to be non-empty here?  If not, you should check that
first.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: