On Wednesday 20 Jan 2010 12:15:03 Ritesh Raj Sarraf wrote: > > I rely on the --print-uris option in apt-offline. If the user uses the > > --print-uris option with the update command, they get a fake impression > > that the APT database is not GPG clean. > > > > Can/Should this be changed to not touch the database when using > > --print-uris ? Or is there another way I should handle it ? > Attached patch helps for my requirements with apt-offline. I'm sure there will be other places where the check for APT::Get::Simulate needs to be done. Regards, Ritesh -- Ritesh Raj Sarraf RESEARCHUT - http://www.researchut.com "Necessity is the mother of invention."
--- apt-pkg/acquire-item.cc.orig 2010-01-23 00:17:35.683393726 +0530 +++ apt-pkg/acquire-item.cc 2010-01-23 00:16:41.631390753 +0530 @@ -824,8 +824,10 @@ // name than DestFile because otherwise the http method will // send If-Range requests and there are too many broken servers // out there that do not understand them - LastGoodSig = DestFile+".reverify"; - Rename(Final,LastGoodSig); + if (_config->FindB("APT::Get::Simulate") == false) { + LastGoodSig = DestFile+".reverify"; + Rename(Final,LastGoodSig); + } } QueueURI(Desc);
Attachment:
signature.asc
Description: This is a digitally signed message part.