Bug#475770: apt: Not just on autoremove; untested patch

[David Kalnischkies <kalnischkies+debian@gmail.com>]

Hello Sam Brightman & Darío Griffo,

apt doesn't check many stuff: This is wrong, correct -
BUT you should not reach this code as a "normal" user.
NEVER as a normal user simply can't install/remove
packages from the system and this operation is therefore
prune to fail anyway. apt-get is only available for "normal"
user as it includes a simulation mode and source and
if it really executes this code there is something brutally wrong.
(The same applies to aptitude)

Looks like you have either Debug::NoLocking=1 or the
lockfile has pretty strange permissions, as otherwise:
dsklap:~$ LANG=C apt-get upgrade
E: Could not open lock file /var/lib/dpkg/lock - open (13: Permission denied)
E: Unable to lock the administration directory (/var/lib/dpkg/), are you root?

For the patch itself: I guess we should switch the logfile
to use FileFD (apt-pkg/contrib/fileutl.{cc,h}) as this would
handle most of the file related errors for us, e.g. if we run
out of disk space (pretty uncommon nowadays - but is one
of the error conditions which could led to this failure for root ).


Best regards / Mit freundlichen Grüßen,

David "DonKult" Kalnischkies