[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#540141: marked as done (bashisms in /etc/cron.daily/apt)



Your message dated Thu, 6 Aug 2009 12:02:37 +0200
with message-id <[🔎] 20090806115950.GA12598@debian.org>
and subject line Re: Bug#540141: bashisms in /etc/cron.daily/apt
has caused the Debian Bug report #540141,
regarding bashisms in /etc/cron.daily/apt
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
540141: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=540141
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: apt
Version: 0.7.22.1
Severity: important
User: debian-release@lists.debian.org
Usertags: goal-dash


Hey,

seems that apt has a bashism in /etc/cron.daily/apt, by using $RANDOM which
doesn't exist on dash:

corsac@hidalgo: checkbashisms /etc/cron.daily/apt
possible bashism in /etc/cron.daily/apt line 297 ($RANDOM):
    if [ -z "$RANDOM" ] ; then
possible bashism in /etc/cron.daily/apt line 301 ($RANDOM):
    TIME=$(($RANDOM % $RandomSleep))


Suggested solution is to use /dev/urandom like:

random="$(dd if=/dev/urandom count=1 2> /dev/null | cksum | cut -f1 -d" ")"

Cheers,
--
Yves-Alexis Perez


-- Package-specific info:

-- apt-config dump --

APT "";
APT::Architecture "amd64";
APT::Build-Essential "";
APT::Build-Essential:: "build-essential";
APT::Install-Recommends "false";
APT::Install-Suggests "false";
APT::Acquire "";
APT::Acquire::Translation "environment";
APT::Authentication "";
APT::Authentication::TrustCDROM "true";
APT::NeverAutoRemove "";
APT::NeverAutoRemove:: "^linux-image.*";
APT::NeverAutoRemove:: "^linux-restricted-modules.*";
Dir "/";
Dir::State "var/lib/apt/";
Dir::State::lists "lists/";
Dir::State::cdroms "cdroms.list";
Dir::State::userstatus "status.user";
Dir::State::status "/var/lib/dpkg/status";
Dir::Cache "var/cache/apt/";
Dir::Cache::archives "archives/";
Dir::Cache::srcpkgcache "srcpkgcache.bin";
Dir::Cache::pkgcache "pkgcache.bin";
Dir::Etc "etc/apt/";
Dir::Etc::sourcelist "sources.list";
Dir::Etc::sourceparts "sources.list.d";
Dir::Etc::vendorlist "vendors.list";
Dir::Etc::vendorparts "vendors.list.d";
Dir::Etc::main "apt.conf";
Dir::Etc::parts "apt.conf.d";
Dir::Etc::preferences "preferences";
Dir::Etc::preferencesparts "preferences.d";
Dir::Bin "";
Dir::Bin::methods "/usr/lib/apt/methods";
Dir::Bin::dpkg "/usr/bin/dpkg";
Dir::Log "var/log/apt";
Dir::Log::Terminal "term.log";
DPkg "";
DPkg::Pre-Install-Pkgs "";
DPkg::Pre-Install-Pkgs:: "/usr/bin/apt-listchanges --apt || test $? -ne 10";
DPkg::Pre-Install-Pkgs:: "/usr/sbin/dpkg-preconfigure --apt || true";
DPkg::Tools "";
DPkg::Tools::Options "";
DPkg::Tools::Options::/usr/bin/apt-listchanges "";
DPkg::Tools::Options::/usr/bin/apt-listchanges::Version "2";
Acquire "";
Acquire::Pdiffs "false";

-- (no /etc/apt/preferences present) --


-- /etc/apt/sources.list --

deb http://ftp.fr.debian.org/debian/ stable main contrib non-free
deb http://ftp.fr.debian.org/debian/ testing main contrib non-free
deb http://ftp.fr.debian.org/debian/ sid main contrib non-free
deb http://ftp.fr.debian.org/debian/ experimental main contrib non-free

deb-src http://ftp.fr.debian.org/debian/ stable main contrib non-free
deb-src http://ftp.fr.debian.org/debian/ sid main contrib non-free
deb-src http://ftp.fr.debian.org/debian/ experimental main contrib non-free

# kernel
#deb http://kernel-archive.buildserver.net/debian-kernel sid main 
#deb http://kernel-archive.buildserver.net/debian-kernel/ trunk main
#deb-src http://kernel-archive.buildserver.net/debian-kernel/ trunk main

# Multimedia
#deb http://ftp.debian-unofficial.org/debian sid main contrib non-free restricted 

# Perso
deb file:///home/corsac/debian/pkg-xfce/scripts/pbuilder/xfce/build ./
deb file:///home/corsac/debian/builds ./

#maemo
#deb http://www.ipi.fi/~pablo/sbox_amd64 /

#deb http://www.vislab.uq.edu.au/debian/ lenny/

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.30-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages apt depends on:
ii  debian-archive-keyring        2009.01.31 GnuPG archive keys of the Debian a
ii  libc6                         2.9-23     GNU C Library: Shared libraries
ii  libgcc1                       1:4.4.1-1  GCC support library
ii  libstdc++6                    4.4.1-1    The GNU Standard C++ Library v3

apt recommends no packages.

Versions of packages apt suggests:
pn  apt-doc                   <none>         (no description available)
ii  aptitude                  0.4.11.11-1+b2 terminal-based package manager
ii  bzip2                     1.0.5-3        high-quality block-sorting file co
ii  dpkg-dev                  1.15.3.1       Debian package development tools
ii  lzma                      4.43-14        Compression method of 7z format in
ii  python-apt                0.7.12.1       Python interface to libapt-pkg

-- no debconf information



--- End Message ---
--- Begin Message ---
Version: 0.7.22.1

On Thu, Aug 06, 2009 at 08:26:37AM +0200, Yves-Alexis Perez wrote:
> Hey,
> seems that apt has a bashism in /etc/cron.daily/apt, by using $RANDOM which
> doesn't exist on dash:
> 
> corsac@hidalgo: checkbashisms /etc/cron.daily/apt
> possible bashism in /etc/cron.daily/apt line 297 ($RANDOM):
>     if [ -z "$RANDOM" ] ; then
Just look two lines below.

> possible bashism in /etc/cron.daily/apt line 301 ($RANDOM):
>     TIME=$(($RANDOM % $RandomSleep))
Just look two lines above.

> random="$(dd if=/dev/urandom count=1 2> /dev/null | cksum | cut -f1 -d" ")"
Have you read line 299?

-- 
Julian Andres Klode  - Free Software Developer
   Debian Developer  - Contributing Member of SPI
   Ubuntu Member     - Fellow of FSFE

Website: http://jak-linux.org/   XMPP: juliank@jabber.org
Debian:  http://www.debian.org/  SPI:  http://www.spi-inc.org/
Ubuntu:  http://www.ubuntu.com/  FSFE: http://www.fsfe.org/


--- End Message ---

Reply to: