On 03-Jun-2009, Julian Andres Klode wrote:
> The jak branch follows PEP 8 naming conventions in almost all places
> now. Not finished yet are apt_pkg.Version, apt_pkg.PackageFile,
> apt_pkg.MetaIndex and apt.progress.*.
Thank you for this request for review.
The ‘tests/’ directory has many unit test modules, but many of them
seem to be using old names. Should they not be updated also in line
with these new names so they continue to work?
Also, in attempting to view the docstrings, I'm finding some of the
modules fail to import. for example:
=====
>>> import apt
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/bignose/Projects/debian/python-apt/jak/apt/__init__.py", line 24, in <module>
from apt.package import Package
File "/home/bignose/Projects/debian/python-apt/jak/apt/package.py", line 62, in <module>
class BaseDependency(object):
File "/home/bignose/Projects/debian/python-apt/jak/apt/package.py", line 82, in BaseDependency
if apt_pkg._COMPAT_0_7:
AttributeError: 'module' object has no attribute '_COMPAT_0_7'
=====
In the absence of working tests or even working imports, it's
difficult to assess this branch.
Good luck seeing some further progress to this!
--
\ “I see little commercial potential for the Internet for at |
`\ least ten years.” —Bill Gates, 1994 |
_o__) |
Ben Finney <ben@benfinney.id.au>
Attachment:
signature.asc
Description: Digital signature