[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#511556: small memleak in indexcopy



Package: apt
Version: 0.7.20
Tags: patch

This should never happen because Release is always there, but anyway just in 
case it is not.

diff -Naur apt-0.7.20.orig/apt-pkg/indexcopy.cc 
apt-0.7.20/apt-pkg/indexcopy.cc
--- apt-0.7.20.orig/apt-pkg/indexcopy.cc        2009-01-12 09:30:45.000000000 
+0200
+++ apt-0.7.20/apt-pkg/indexcopy.cc     2009-01-12 09:31:15.000000000 +0200
@@ -582,9 +582,10 @@
       string prefix = *I;

       // a Release.gpg without a Release should never happen
-      if(!FileExists(*I+"Release"))
+      if(!FileExists(*I+"Release")) {
+         delete MetaIndex;
         continue;
-
+      }

       // verify the gpg signature of "Release"
       // gpg --verify "*I+Release.gpg", "*I+Release"



-- 
pub 4096R/0E4BD0AB 2003-03-18 <people.fccf.net/danchev/key pgp.mit.edu>
diff -Naur apt-0.7.20.orig/apt-pkg/indexcopy.cc apt-0.7.20/apt-pkg/indexcopy.cc
--- apt-0.7.20.orig/apt-pkg/indexcopy.cc	2009-01-12 09:30:45.000000000 +0200
+++ apt-0.7.20/apt-pkg/indexcopy.cc	2009-01-12 09:31:15.000000000 +0200
@@ -582,9 +582,10 @@
       string prefix = *I; 
 
       // a Release.gpg without a Release should never happen
-      if(!FileExists(*I+"Release"))
+      if(!FileExists(*I+"Release")) {
+         delete MetaIndex;
 	 continue;
-
+      }
 
       // verify the gpg signature of "Release"
       // gpg --verify "*I+Release.gpg", "*I+Release"

Reply to: