Bug#499897: illustration
On 2008-11-24 07:29:40.00 Christian Perrier <bubulle@debian.org> wrote:
> I came back on the proposed patch after Joerg revived the discussion
> about this bug.
>
> Quoting Thomas Viehmann (tv@beamnet.de):
>
> > + if (_config->FindB("Acquire::Check-Valid-Until", true)) {
> > + if (time(NULL) > MetaIndexParser->GetValidUntil()) {
> > + _error->Warning(string("Release file expired, ignoring "+RealURI).c_str());
> > + return false;
> > + }
> > + }
> > +
>
> WRT i18n, the patch is incorrect, imho. It assumes that the ignored
> URL is to come after the "ignoring" word. Strings concatenation is
> nearly always a bad idea as the sentence structure might be different
> in other languages.
>
> My programming skills are low enough to not allow me to produce the
> right patch, but I think that something using "%s" in the localizable
> string would make it. Hopefully, everybody reading this will
> understand what I mean here..:-)
>
> It would also be good to put a translators comment to explain
> translators that "%s" is a URL.
The i18n-ability of my patch is fairly completely bogus.
Thanks, Christian for your advice, that should make it a lot more
likely to get right when redoing it.
Kind regards
T.
Reply to: