Bug#485943: apt-get dist-upgrade wants to install recommends of installed packages

[Michael Vogt <mvo@debian.org>]

On Thu, Jun 12, 2008 at 03:20:08PM +0200, Julian Andres Klode wrote:
> Package: apt
> Version: 0.7.14
> Severity: normal

Thanks for your bugreport.
 
> On dist-upgrade, with no new packages in the archive and no packages on hold,
> apt-get wants to install new recommends of installed packages.
> 
> aptitude works OK, and apt-get update does also work correctly.
[..]

Could you please check if the following patch fixes the problem?

=== modified file 'apt-pkg/depcache.cc'
--- apt-pkg/depcache.cc 2008-04-27 17:00:26 +0000
+++ apt-pkg/depcache.cc 2008-06-03 15:07:21 +0000
@@ -914,8 +914,9 @@
             {
               //FIXME: deal better with or-groups(?)
               DepIterator LocalStart = D;
-              
-              if(IsImportantDep(D) && Start.TargetPkg() ==
D.TargetPkg())
+
+              if(IsImportantDep(D) && !D.IsCritical() &&
+                 Start.TargetPkg() == D.TargetPkg())
                 {
                   if(!isPreviouslySatisfiedImportantDep)
			     {

Thanks, 
 Michael