[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#376777: apt-utils: apt-ftparchive fails to generate Contents files



On Fri, Jul 07, 2006 at 07:59:45PM +1000, Anthony Towns wrote:
> On Wed, Jul 05, 2006 at 11:31:51PM +1000, Anthony Towns wrote:
> > package apt-utils
> > tag 376777 - help
> > tag 376777 + patch
> > thanks
> > 
> > I'm pretty sure this bug is simply due to misuse of auto_ptr in writer.cc
> 
> Okay, I've no idea if this is right or not now; but it's not the real bug; and
> if it were, there's more to it than just that one assignment.
> 
> The real bug is in tagfile.cc, in particular the patch "fixing" Bug#350025
> -- using MMap doesn't work if your Fd is a pipe, which it is if you point
> apt-ftparchive at a suite that doesn't have an uncompressed Packages file,
> and ask it to generate Contents.
> 
> Fix is reverting the patch, at least for the case where your input file
> size is empty.

I put a branch that should fix the issue up at
http://people.ubuntu.com/~mvo/bzr/apt/tagfile-mmap-fix/

I send a patch to James asking for testing and will upload it to
experimental (along with some other fixes there). Once I got positive
feedback on the patch I will merge it into the sid version of apt and
upload.

The new version will use MMap if possible in tagfile and if not fall
back to the old implementation.

Thanks,
 Michael

-- 
Linux is not The Answer. Yes is the answer. Linux is The Question. - Neo



Reply to: