Bug#339533: marked as done (pkgCache::VerIterator::end() crashes on a default VerIterator)
Your message dated Mon, 28 Nov 2005 15:47:11 -0800
with message-id <E1EgsiF-0008PW-U3@spohr.debian.org>
and subject line Bug#339533: fixed in apt 0.6.43
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 16 Nov 2005 23:08:58 +0000
>From dburrows@vzavenue.net Wed Nov 16 15:08:58 2005
Return-path: <dburrows@vzavenue.net>
Received: from smtp.vzavenue.net ([66.171.59.140])
by spohr.debian.org with esmtp (Exim 4.50)
id 1EcWOf-000679-VH
for submit@bugs.debian.org; Wed, 16 Nov 2005 15:08:58 -0800
Received: from localhost.localdomain (244.173.171.66.subscriber.vzavenue.net [66.171.173.244])
by smtp.vzavenue.net (MOS 3.7.1-GA)
with ESMTP id DHP83361;
Wed, 16 Nov 2005 18:08:50 -0500 (EST)
Date: Wed, 16 Nov 2005 15:08:48 -0800
From: Daniel Burrows <dburrows@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: pkgCache::VerIterator::end() crashes on a default VerIterator
Message-ID: <[🔎] 20051116230848.GA9989@smtp.vzavenue.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
protocol="application/pgp-signature"; boundary="bp/iNruPH9dso1Pn"
Content-Disposition: inline
X-Reportbug-Version: 3.17
User-Agent: Mutt/1.5.11
X-Junkmail-Status: score=0/50, host=smtp.vzavenue.net
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-7.5 required=4.0 tests=BAYES_00,HAS_PACKAGE,
RCVD_IN_SORBS autolearn=no version=2.60-bugs.debian.org_2005_01_02
--bp/iNruPH9dso1Pn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Package: libapt-pkg-dev
Version: 0.6.42.3exp1
Severity: normal
Tags: patch
The following code should not crash, but it does:
pkgCache::VerIterator ver;
if(ver.end())
...;
The problem is that end() doesn't check whether Owner is NULL before
dereferencing it. The following patch fixes this crash:
--- orig/apt-pkg/cacheiterators.h
+++ mod/apt-pkg/cacheiterators.h
@@ -163,7 +163,7 @@
// Iteration
void operator ++(int) {if (Desc !=3D Owner->DescP) Desc =3D Owner->Desc=
P + Desc->NextDesc;};
inline void operator ++() {operator ++(0);};
- inline bool end() const {return Desc =3D=3D Owner->DescP?true:false;};
+ inline bool end() const {return Owner =3D=3D NULL || (Desc =3D=3D Owner=
->DescP?true:false);};
inline void operator =3D(const DescIterator &B) {Desc =3D B.Desc; Owner=
=3D B.Owner;};
=20
// Comparison
Daniel
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.14-2-686
Locale: LANG=3Den_US.UTF-8, LC_CTYPE=3Den_US.UTF-8 (charmap=3DUTF-8)
Versions of packages libapt-pkg-dev depends on:
ii apt [libapt-pkg-libc6.3-6-3 0.6.42.3exp1 Advanced front-end for dpkg
ii apt-utils 0.6.42.3exp1 APT utility programs
libapt-pkg-dev recommends no packages.
-- no debconf information
--bp/iNruPH9dso1Pn
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
iD8DBQFDe7wAch6xsM7kSXgRApnnAKCvVPy3N8fZdPU0Z7hMG5kdaEoQWQCeOSUD
84jMXMEur0l8ZPz6r9UcdEY=
=YmRO
-----END PGP SIGNATURE-----
--bp/iNruPH9dso1Pn--
---------------------------------------
Received: (at 339533-close) by bugs.debian.org; 28 Nov 2005 23:51:24 +0000
>From katie@ftp-master.debian.org Mon Nov 28 15:51:23 2005
Return-path: <katie@ftp-master.debian.org>
Received: from katie by spohr.debian.org with local (Exim 4.50)
id 1EgsiF-0008PW-U3; Mon, 28 Nov 2005 15:47:11 -0800
From: Michael Vogt <mvo@debian.org>
To: 339533-close@bugs.debian.org
X-Katie: $Revision: 1.60 $
Subject: Bug#339533: fixed in apt 0.6.43
Message-Id: <E1EgsiF-0008PW-U3@spohr.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Mon, 28 Nov 2005 15:47:11 -0800
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 6
Source: apt
Source-Version: 0.6.43
We believe that the bug you reported is fixed in the latest version of
apt, which is due to be installed in the Debian FTP archive:
apt-doc_0.6.43_all.deb
to pool/main/a/apt/apt-doc_0.6.43_all.deb
apt-utils_0.6.43_i386.deb
to pool/main/a/apt/apt-utils_0.6.43_i386.deb
apt_0.6.43.dsc
to pool/main/a/apt/apt_0.6.43.dsc
apt_0.6.43.tar.gz
to pool/main/a/apt/apt_0.6.43.tar.gz
apt_0.6.43_i386.deb
to pool/main/a/apt/apt_0.6.43_i386.deb
libapt-pkg-dev_0.6.43_i386.deb
to pool/main/a/apt/libapt-pkg-dev_0.6.43_i386.deb
libapt-pkg-doc_0.6.43_all.deb
to pool/main/a/apt/libapt-pkg-doc_0.6.43_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 339533@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Michael Vogt <mvo@debian.org> (supplier of updated apt package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Tue, 29 Nov 2005 00:17:07 +0100
Source: apt
Binary: apt-utils libapt-pkg-doc libapt-pkg-dev apt-doc apt
Architecture: source all i386
Version: 0.6.43
Distribution: unstable
Urgency: medium
Maintainer: APT Development Team <deity@lists.debian.org>
Changed-By: Michael Vogt <mvo@debian.org>
Description:
apt - Advanced front-end for dpkg
apt-doc - Documentation for APT
apt-utils - APT utility programs
libapt-pkg-dev - Development files for APT's libapt-pkg and libapt-inst
libapt-pkg-doc - Documentation for APT development
Closes: 57091 66325 146877 317718 338267 338356 339147 339533 340448
Changes:
apt (0.6.43) unstable; urgency=medium
.
* Merge bubulle@debian.org--2005/apt--main--0 up to patch-132:
* zh_CN.po: Completed to 510 strings(Closes: #338267)
* gl.po: Completed to 510 strings (Closes: #338356)
* added support for "/etc/apt/sources.list.d" directory
(closes: #66325)
* make pkgDirStream (a bit) more complete
* fix bug in pkgCache::VerIterator::end() (thanks to Daniel Burrows)
(closes: #339533)
* pkgAcqFile is more flexible now (closes: #57091)
* support a download rate limit for http (closes: #146877)
* included lots of the speedup changes from #319377
* add stdint.h to contrib/md5.h (closes: #340448)
* ABI change, library name changed (closes: #339147)
* Fix GNU/kFreeBSD crash on non-existing server file (closes: #317718)
* switch to libdb4.3 in build-depends
Files:
86dcec8dd5c5ab71401755f8c6c90107 785 admin important apt_0.6.43.dsc
5c1a3c6f879cc4caa7fb2ff94b2cb9a1 1461079 admin important apt_0.6.43.tar.gz
97b880c6781eee59905b77d9651c8d07 86140 doc optional apt-doc_0.6.43_all.deb
b6f866a82bc21ee833bd976fe95e3afa 109548 doc optional libapt-pkg-doc_0.6.43_all.deb
8d7e510a526d3cc18c9a0601ad787e9e 1194408 admin important apt_0.6.43_i386.deb
ed7c6826bf40acebb325fefe0e6449b8 79738 libdevel optional libapt-pkg-dev_0.6.43_i386.deb
d2202a74f11ebd30ccd7d0d347f2fdd3 195170 admin important apt-utils_0.6.43_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
iD8DBQFDi5S7liSD4VZixzQRAvqgAJ4g5eEn9hIE8QUlXPuqPvfGP8t9ewCdEvKr
KndSCF+btULzVqN5T13NQ5k=
=7FnP
-----END PGP SIGNATURE-----
Reply to: