Bug#265009: some more stuff
Hi,
a update for this bugreport/patch. It fixes the locales problem I
described in my earlier mail. It changes from querining LC_ALL to
LC_MESSAGES. Attached is a patch that need to be applyed after the
first patch :)
Another thing I noticed is that the patch has a certain performance
hit when it comes to searching even when LANG=C and no translated
descriptions are downloaded. I did some highly unscientific tests with
"time" and found that searching for "synaptic" increased:
apt (pure):
-----------
user: 2.6
sys: 0.2
apt(i18n):
----------
uses: 3.4
sys: 0.2
on my system. I think that this is a pretty big hit for the cache when
actually no additonal data is used. I have not yet figured how if
there is a way to avoid the hit. Comments on this are highly welcome
:)
thanks,
Michael
--
The first rule of holes is: when you find yourself in one, stop digging. - PJ
Linux is not The Answer. Yes is the answer. Linux is The Question. - Neo
diff -u apt-pkg/indexfile.cc apt-pkg/indexfile.cc
--- apt-pkg/indexfile.cc 11 Aug 2004 11:10:45 -0000
+++ apt-pkg/indexfile.cc 11 Aug 2004 13:32:45 -0000
@@ -113,7 +113,7 @@
const string Translation = _config->Find("APT::Acquire::Translation");
if (Translation.compare("environment") == 0)
- return std::setlocale(LC_ALL,NULL);
+ return std::setlocale(LC_MESSAGES,NULL);
else
return Translation;
}
Reply to: