[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#249251: marked as done (Broken prompt: "Install these packages without verification? [y/N]")



Your message dated Sun, 16 May 2004 17:32:03 -0400
with message-id <[🔎] E1BPTEp-0008S3-00@newraff.debian.org>
and subject line Fixed in upload of apt 0.6.24 to experimental
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 16 May 2004 10:15:57 +0000
>From thomas@luzat.com Sun May 16 03:15:57 2004
Return-path: <thomas@luzat.com>
Received: from smtp.soultwins.com [66.221.101.22] (qmailr)
	by spohr.debian.org with smtp (Exim 3.35 1 (Debian))
	id 1BPIgX-0003W0-00; Sun, 16 May 2004 03:15:57 -0700
Received: (qmail 10754 invoked from network); 16 May 2004 10:15:54 -0000
Received: from p50926980.dip.t-dialin.net (HELO deepthought.luzat.com) (80.146.105.128)
  by smtp.soultwins.com with SMTP; 16 May 2004 10:15:54 -0000
Received: from mojo-jojo.home.luzat.com (unknown [192.168.0.4])
	by deepthought.luzat.com (Postfix) with ESMTP id 681142C03948
	for <submit@bugs.debian.org>; Sun, 16 May 2004 12:15:44 +0200 (CEST)
Subject: Broken prompt: "Install these packages without verification? [y/N]"
From: Thomas Luzat <thomas@luzat.com>
Reply-To: thomas.luzat@gmx.net
To: submit@bugs.debian.org
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-WI15l02ixaq1Hnt6vBib"
Message-Id: <[🔎] 1084702543.32300.30.camel@mojo-jojo.home.luzat.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.5.7 
Date: Sun, 16 May 2004 12:15:43 +0200
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=0.0 required=4.0 tests=BAYES_01,RCVD_IN_DSBL 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 


--=-WI15l02ixaq1Hnt6vBib
Content-Type: multipart/mixed; boundary="=-4h3ANjwicWZJlnyQX4eW"


--=-4h3ANjwicWZJlnyQX4eW
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Package: apt
Version: 0.6.23
Tags: patch experimental

Hello!

I just noticed that, when installing a package which can't be
authenticated, the prompt whether one wants to really install it is
somewhat broken. The line is:

Install these packages without verification? [y/N]

I do not press Y here, just RETURN. It works as expected when entering Y
or N, but with only RETURN it installs instead of aborting as [y/N]
indicates.

Attached are two small patches which fix that:

1) apt-get.cc-YnPrompt-oldbehaviour.diff just fixes it.

2) apt-get.cc-YnPrompt.diff additionally accepts strings consisting only
of white-space to trigger the default action in YnPrompt. I find that
somewhat nicer.

Another suggestion would be adding a check for NOEXPR and return Default
if neither YESEXPR nor NOEXPR match, but on the other hand YnPrompt is
hardly ever used anyway... factoring those out from other tools might
make it more worthwhile :-)

Thanks!


--=-4h3ANjwicWZJlnyQX4eW
Content-Disposition: attachment; filename=apt-get.cc-YnPrompt.diff
Content-Type: text/x-patch; name=apt-get.cc-YnPrompt.diff; charset=UTF-8
Content-Transfer-Encoding: base64

NDdhNDgNCj4gI2luY2x1ZGUgPGN0eXBlLmg+DQoxMTRjMTE1DQo8IGJvb2wgWW5Qcm9tcHQoKQ0K
LS0tDQo+IGJvb2wgWW5Qcm9tcHQoYm9vbCBEZWZhdWx0ID0gdHJ1ZSkNCjEyOCwxMjljMTI5LDEz
NA0KPCAgICBpZiAoc3RybGVuKHJlc3BvbnNlKSA9PSAwKQ0KPCAgICAgICByZXR1cm4gdHJ1ZTsN
Ci0tLQ0KPiAgICBjb25zdCBjaGFyICpJID0gcmVzcG9uc2U7DQo+ICAgIGZvciAoSSA9IHJlc3Bv
bnNlOyBpc3NwYWNlKCpJKSAmJiAoKkkgIT0gMCk7ICsrSSk7DQo+IA0KPiAgICBpZiAoKkkgPT0g
MCkgew0KPiAgICAgICAgcmV0dXJuIERlZmF1bHQ7DQo+ICAgIH0NCjY5OWM3MDQNCjwgICAgICAg
aWYgKCFZblByb21wdCgpKQ0KLS0tDQo+ICAgICAgIGlmICghWW5Qcm9tcHQoZmFsc2UpKQ0K


--=-4h3ANjwicWZJlnyQX4eW
Content-Disposition: attachment; filename=apt-get.cc-YnPrompt-oldbehaviour.diff
Content-Transfer-Encoding: base64
Content-Type: text/x-patch; name=apt-get.cc-YnPrompt-oldbehaviour.diff; charset=UTF-8

MTE0YzExNA0KPCBib29sIFluUHJvbXB0KCkNCi0tLQ0KPiBib29sIFluUHJvbXB0KGJvb2wgRGVm
YXVsdCA9IHRydWUpDQoxMjljMTI5DQo8ICAgICAgIHJldHVybiB0cnVlOw0KLS0tDQo+ICAgICAg
IHJldHVybiBEZWZhdWx0Ow0KNjk5YzY5OQ0KPCAgICAgICBpZiAoIVluUHJvbXB0KCkpDQotLS0N
Cj4gICAgICAgaWYgKCFZblByb21wdChmYWxzZSkpDQo=


--=-4h3ANjwicWZJlnyQX4eW--

--=-WI15l02ixaq1Hnt6vBib
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBApz9Ov0hQ45rDw1YRAm3fAKDcMtbITSoa4NG1bK7M1t+Dmi/mZACdFogn
WwDz3HCBMRFQik+LBrKsyBg=
=CKBl
-----END PGP SIGNATURE-----

--=-WI15l02ixaq1Hnt6vBib--


---------------------------------------
Received: (at 249251-done) by bugs.debian.org; 16 May 2004 21:41:36 +0000
>From mdz@alcor.net Sun May 16 14:41:36 2004
Return-path: <mdz@alcor.net>
Received: from mta10.adelphia.net [68.168.78.202] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1BPTO4-0004XE-00; Sun, 16 May 2004 14:41:36 -0700
Received: from mizar.alcor.net ([69.167.148.207]) by mta10.adelphia.net
          (InterMail vM.5.01.06.08 201-253-122-130-108-20031117) with ESMTP
          id <20040516214106.OAKF8065.mta10.adelphia.net@mizar.alcor.net>
          for <249251-done@bugs.debian.org>;
          Sun, 16 May 2004 17:41:06 -0400
Received: from mdz by mizar.alcor.net with local (Exim 4.34)
	id 1BPTNZ-0003xw-G9
	for 249251-done@bugs.debian.org; Sun, 16 May 2004 14:41:05 -0700
Resent-From: mdz@alcor.net
Resent-Date: Sun, 16 May 2004 14:41:05 -0700
Resent-Message-ID: <20040516214105.GB14347@alcor.net>
Resent-To: 249251-done@bugs.debian.org
X-Original-To: mdz@csh.rit.edu
Received: from mail.csh.rit.edu [129.21.60.6]
	by localhost with IMAP (fetchmail-6.2.5)
	for mdz@localhost (single-drop); Sun, 16 May 2004 14:38:23 -0700 (PDT)
Received: from newraff.debian.org (newraff.debian.org [208.185.25.31])
	by blacksheep.csh.rit.edu (Postfix) with ESMTP id 33C1B9E60
	for <mdz@csh.rit.edu>; Sun, 16 May 2004 17:38:03 -0400 (EDT)
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1BPTEp-0008S3-00; Sun, 16 May 2004 17:32:03 -0400
From: Matt Zimmerman <mdz@debian.org>
To: control@bugs.debian.org
Cc: Matt Zimmerman <mdz@debian.org>,
	APT Development Team <deity@lists.debian.org>
X-Katie: $Revision: 1.49 $
Subject: Fixed in upload of apt 0.6.24 to experimental
Message-Id: <[🔎] E1BPTEp-0008S3-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Sun, 16 May 2004 17:32:03 -0400
Content-Type: application/pgp; format=text; x-action=sign
X-Bogosity: No, tests=bogofilter, spamicity=0.000000, version=0.90.0
Resent-Date: Sun, 16 May 2004 14:41:05 -0700
Delivered-To: 249251-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-0.8 required=4.0 tests=BAYES_00,
	MIME_HEADER_CTYPE_ONLY autolearn=no 
	version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 
X-CrossAssassin-Score: 2

tag 249251 + fixed-in-experimental

quit

This message was generated automatically in response to an
upload to the experimental distribution.  The .changes file follows.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 16 May 2004 14:18:53 -0700
Source: apt
Binary: apt-utils libapt-pkg-doc libapt-pkg-dev apt-doc apt
Architecture: source all i386
Version: 0.6.24
Distribution: experimental
Urgency: low
Maintainer: APT Development Team <deity@lists.debian.org>
Changed-By: Matt Zimmerman <mdz@debian.org>
Description: 
 apt        - Advanced front-end for dpkg
 apt-doc    - Documentation for APT
 apt-utils  - APT utility programs
 libapt-pkg-dev - Development files for APT's libapt-pkg and libapt-inst
 libapt-pkg-doc - Documentation for APT development
Closes: 249251
Changes: 
 apt (0.6.24) experimental; urgency=low
 .
   * YnPrompt fixes were inadvertently left out, include them (Closes:
     #249251)
Files: 
 bf22dfada06843b6247928a87ca3a36d 756 admin important apt_0.6.24.dsc
 3922a1120bdee37d4dbb21b228f031ef 1200739 admin important apt_0.6.24.tar.gz
 6a424c5f9b45db6aa655f2b4953e2479 70276 doc optional apt-doc_0.6.24_all.deb
 a82645e192b8ab8005f131aa9691cf35 99074 doc optional libapt-pkg-doc_0.6.24_all.deb
 f8bb7d288f590a620d27ad1c1fba6d1b 1004232 base important apt_0.6.24_i386.deb
 15663fe3216ad831b657a69264572e0f 71514 libdevel optional libapt-pkg-dev_0.6.24_i386.deb
 69879ea97454259e86d7de99169211d1 184244 admin optional apt-utils_0.6.24_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAp9wXArxCt0PiXR4RArDSAKDN9C7HgUMkKizOSygDrNLaBZ0G5ACfaczh
GLdjiHizdkoyPpEDDHo1j0E=
=Whtk
-----END PGP SIGNATURE-----



Reply to: