[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#192373: marked as done (apt-ftparchive: reports E: Unparsible control file)



Your message dated Mon, 19 May 2003 14:47:06 -0400
with message-id <E19Hpf8-0006EI-00@auric.debian.org>
and subject line Bug#192373: fixed in apt 0.5.5.1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 8 May 2003 00:50:28 +0000
>From p.lundkvist@telia.com Wed May 07 19:50:26 2003
Return-path: <p.lundkvist@telia.com>
Received: from maila.telia.com [194.22.194.231] 
	by master.debian.org with esmtp (Exim 3.12 1 (Debian))
	id 19DZcA-0002N8-00; Wed, 07 May 2003 19:50:26 -0500
Received: from debian.localnet (h90n1fls34o847.telia.com [213.65.155.90])
	by maila.telia.com (8.12.9/8.12.9) with ESMTP id h480oPOW023707;
	Thu, 8 May 2003 02:50:25 +0200 (CEST)
X-Original-Recipient: submit@bugs.debian.org
Received: from peter by debian.localnet with local (Exim 3.35 #1 (Debian))
	id 19DZbz-0000ol-00; Thu, 08 May 2003 02:50:15 +0200
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Peter Lundkvist <p.lundkvist@telia.com>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: apt-ftparchive: reports E: Unparsible control file
X-Mailer: reportbug 2.10.1
Date: Thu, 08 May 2003 02:50:14 +0200
Message-Id: <[🔎] E19DZbz-0000ol-00@debian.localnet>
Sender: Peter Lundkvist <p.lundkvist@telia.com>
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-12.3 required=4.0
	tests=BAYES_20,HAS_PACKAGE,PATCH_UNIFIED_DIFF
	autolearn=ham version=2.53-bugs.debian.org_2003_04_23
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_04_23 (1.174.2.15-2003-03-30-exp)

Package: apt-utils
Version: 0.5.5
Severity: normal
Tags: patch

Tracked down this problem to a changed return type of
pkgTagFile::pkgTagFile, but all usage of this function was
not updated.

Attached patch corrects all calls I found.

Peter



diff -ru apt-0.5.5.org/apt-inst/deb/debfile.cc apt-0.5.5/apt-inst/deb/debfile.cc
--- apt-0.5.5.org/apt-inst/deb/debfile.cc	2003-02-10 00:36:12 +0000
+++ apt-0.5.5/apt-inst/deb/debfile.cc	2003-05-07 23:23:44 +0000
@@ -239,7 +239,7 @@
    
    Control[Length] = '\n';
    Control[Length+1] = '\n';
-   if (Section.Scan(Control,Length+2) == false)
+   if (Section.Scan(Control,Length+2) != pkgTagSection::ScanSuccess)
       return _error->Error(_("Unparsible control file"));
    return true;
 }
@@ -257,7 +257,7 @@
    
    Control[Length] = '\n';
    Control[Length+1] = '\n';
-   return Section.Scan(Control,Length+2);
+   return Section.Scan(Control,Length+2) == pkgTagSection::ScanSuccess;
 }
 									/*}}}*/
 
diff -ru apt-0.5.5.org/cmdline/apt-cache.cc apt-0.5.5/cmdline/apt-cache.cc
--- apt-0.5.5.org/cmdline/apt-cache.cc	2003-04-27 02:47:44.000000000 +0000
+++ apt-0.5.5/cmdline/apt-cache.cc	2003-05-07 23:20:37.000000000 +0000
@@ -481,7 +481,7 @@
 	    pkgTagSection Tags;
 	    TFRewriteData RW[] = {{"Status",0},{"Config-Version",0},{}};
 	    const char *Zero = 0;
-	    if (Tags.Scan(Buffer+Jitter,VF.Size+1) == false ||
+	    if (Tags.Scan(Buffer+Jitter,VF.Size+1) != pkgTagSection::ScanSuccess ||
 		TFRewrite(stdout,Tags,&Zero,RW) == false)
 	    {
 	       _error->Error("Internal Error, Unable to parse a package record");
diff -ru apt-0.5.5.org/cmdline/apt-extracttemplates.cc apt-0.5.5/cmdline/apt-extracttemplates.cc
--- apt-0.5.5.org/cmdline/apt-extracttemplates.cc	2003-01-11 07:18:44.000000000 +0000
+++ apt-0.5.5/cmdline/apt-extracttemplates.cc	2003-05-07 23:19:30.000000000 +0000
@@ -172,7 +172,8 @@
 	if (Control == NULL) return false;
 	
 	pkgTagSection Section;
-	Section.Scan(Control, ControlLen);
+	if (Section.Scan(Control, ControlLen) != pkgTagSection::ScanSuccess)
+		return false;
 
 	Package = Section.FindS("Package");
 	Version = GetInstalledVer(Package);
diff -ru apt-0.5.5.org/cmdline/apt-sortpkgs.cc apt-0.5.5/cmdline/apt-sortpkgs.cc
--- apt-0.5.5.org/cmdline/apt-sortpkgs.cc	2003-01-11 07:18:44.000000000 +0000
+++ apt-0.5.5/cmdline/apt-sortpkgs.cc	2003-05-07 23:14:52.000000000 +0000
@@ -116,7 +116,7 @@
       }
       
       Buffer[I->Length] = '\n';      
-      if (Section.Scan((char *)Buffer,I->Length+1) == false)
+      if (Section.Scan((char *)Buffer,I->Length+1) != pkgTagSection::ScanSuccess)
       {
 	 delete [] Buffer;
 	 return _error->Error("Internal error, failed to scan buffer");
diff -ru apt-0.5.5.org/ftparchive/writer.cc apt-0.5.5/ftparchive/writer.cc
--- apt-0.5.5.org/ftparchive/writer.cc	2003-02-10 07:34:41.000000000 +0000
+++ apt-0.5.5/ftparchive/writer.cc	2003-05-07 23:25:17.000000000 +0000
@@ -525,7 +525,7 @@
    do
    {
       unsigned Pos;
-      if (Tags.Scan(Start,BlkEnd - Start) == false)
+      if (Tags.Scan(Start,BlkEnd - Start) != pkgTagSection::ScanSuccess)
 	 return _error->Error("Could not find a record in the DSC '%s'",FileName.c_str());
       if (Tags.Find("Source",Pos) == true)
 	 break;


-- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux debian 2.5.66-i4k #7 Sat Apr 19 17:40:57 CEST 2003 i686
Locale: LANG=sv_SE.ISO-8859-1, LC_CTYPE=sv_SE.ISO-8859-1

Versions of packages apt-utils depends on:
ii  apt [libapt-pkg-libc6.3-5-3. 0.5.5       Advanced front-end for dpkg
ii  libc6                        2.3.1-17    GNU C Library: Shared libraries an
ii  libdb2                       2:2.7.7.0-8 The Berkeley database routines (ru
ii  libgcc1                      1:3.3-0pre7 GCC support library
ii  libstdc++5                   1:3.3-0pre7 The GNU Standard C++ Library v3

-- no debconf information


---------------------------------------
Received: (at 192373-close) by bugs.debian.org; 19 May 2003 18:53:10 +0000
>From katie@auric.debian.org Mon May 19 13:53:10 2003
Return-path: <katie@auric.debian.org>
Received: from auric.debian.org [206.246.226.45] 
	by master.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 19Hpl0-0005YA-00; Mon, 19 May 2003 13:53:10 -0500
Received: from katie by auric.debian.org with local (Exim 3.35 1 (Debian))
	id 19Hpf8-0006EI-00; Mon, 19 May 2003 14:47:06 -0400
From: Adam Heath <doogie@debian.org>
To: 192373-close@bugs.debian.org
X-Katie: $Revision: 1.34 $
Subject: Bug#192373: fixed in apt 0.5.5.1
Message-Id: <E19Hpf8-0006EI-00@auric.debian.org>
Sender: Archive Administrator <katie@auric.debian.org>
Date: Mon, 19 May 2003 14:47:06 -0400
Delivered-To: 192373-close@bugs.debian.org

We believe that the bug you reported is fixed in the latest version of
apt, which is due to be installed in the Debian FTP archive:

apt-doc_0.5.5.1_all.deb
  to pool/main/a/apt/apt-doc_0.5.5.1_all.deb
apt-utils_0.5.5.1_i386.deb
  to pool/main/a/apt/apt-utils_0.5.5.1_i386.deb
apt_0.5.5.1.dsc
  to pool/main/a/apt/apt_0.5.5.1.dsc
apt_0.5.5.1.tar.gz
  to pool/main/a/apt/apt_0.5.5.1.tar.gz
apt_0.5.5.1_i386.deb
  to pool/main/a/apt/apt_0.5.5.1_i386.deb
libapt-pkg-dev_0.5.5.1_i386.deb
  to pool/main/a/apt/libapt-pkg-dev_0.5.5.1_i386.deb
libapt-pkg-doc_0.5.5.1_all.deb
  to pool/main/a/apt/libapt-pkg-doc_0.5.5.1_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 192373@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Adam Heath <doogie@debian.org> (supplier of updated apt package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Mon, 19 May 2003 12:30:16 -0500
Source: apt
Binary: apt-utils libapt-pkg-doc libapt-pkg-dev apt-doc apt
Architecture: source i386 all
Version: 0.5.5.1
Distribution: unstable
Urgency: low
Maintainer: APT Development Team <deity@lists.debian.org>
Changed-By: Adam Heath <doogie@debian.org>
Description: 
 apt        - Advanced front-end for dpkg
 apt-doc    - Documentation for APT
 apt-utils  - APT utility programs
 libapt-pkg-dev - Development files for APT's libapt-pkg and libapt-inst
 libapt-pkg-doc - Documentation for APT development
Closes: 192331 192355 192373
Changes: 
 apt (0.5.5.1) unstable; urgency=low
 .
   * Move the target of the example docs from doc to binary.  Closes:
     #192331
   * Fix api breakage that broke apt-ftparchive and apt-cache dumpavail, by
     backing out change that incorretly attempted to handle Package sections
     larger than 32k.  Closes: #192373
   * Fix never-ending loop with apt-get install -V.  Closes: #192355.
Files: 
 bd41224997ddfc737267d4270fd8e42a 719 admin important apt_0.5.5.1.dsc
 1fea535dbc9386fc61b520b418a20966 814578 admin important apt_0.5.5.1.tar.gz
 cd6debb9bbcb464560b10787de8a5695 60306 doc optional apt-doc_0.5.5.1_all.deb
 a7d97b5437ae08849d98739e12b25e00 92328 doc optional libapt-pkg-doc_0.5.5.1_all.deb
 6e81a0146674a8c17a2d10b2555d205d 709718 base standard apt_0.5.5.1_i386.deb
 f976eae9e31800cf3f057c238fa2a953 59742 devel optional libapt-pkg-dev_0.5.5.1_i386.deb
 d50d70a36fa6c25aa3a29cbdc51dee3e 147154 admin optional apt-utils_0.5.5.1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+ySLRiix9wovUpIkRAiHZAJ9eodbTSC9kFNfXbBP5myiGClR+RgCfT5zX
IDLuKEUcGduiGhTivGO1Vsk=
=TZt/
-----END PGP SIGNATURE-----



Reply to: