Bug#131779: Acknowledgement of maintainer-only report (apt: Have apt-get print the full version for updates and installs)
Quoting myself:
>
> I have been running this patch for almost a year without any problems.
Sorry about that, reportbug didn't include the file.
diff -ur apt-0.5.4/cmdline/apt-get.cc apt-0.5.4.ow.1/cmdline/apt-get.cc
--- apt-0.5.4/cmdline/apt-get.cc Sun Jul 1 18:59:04 2001
+++ apt-0.5.4.ow.1/cmdline/apt-get.cc Wed Oct 10 15:10:53 2001
@@ -142,7 +142,7 @@
// ---------------------------------------------------------------------
/* This prints out a string of space separated words with a title and
a two space indent line wraped to the current screen width. */
-bool ShowList(ostream &out,string Title,string List)
+bool ShowList(ostream &out,string Title,string List,string VersionsList)
{
if (List.empty() == true)
return true;
@@ -152,19 +152,38 @@
out << Title << endl;
string::size_type Start = 0;
+ string::size_type VersionsStart = 0;
while (Start < List.size())
{
- string::size_type End;
- if (Start + ScreenWidth >= List.size())
- End = List.size();
- else
- End = List.rfind(' ',Start+ScreenWidth);
-
- if (End == string::npos || End < Start)
- End = Start + ScreenWidth;
- out << " " << string(List,Start,End - Start) << endl;
- Start = End + 1;
+ if(_config->FindB("APT::Get::Show-Versions",false) == true &&
+ VersionsList.size() > 0) {
+ string::size_type End;
+ string::size_type VersionsEnd;
+
+ End = List.find(' ',Start);
+ VersionsEnd = VersionsList.find('\n', VersionsStart);
+
+ out << " " << string(List,Start,End - Start) << " (" <<
+ string(VersionsList,VersionsStart,VersionsEnd - VersionsStart) <<
+ ")" << endl;
+
+ Start = End + 1;
+ VersionsStart = VersionsEnd + 1;
+ } else {
+ string::size_type End;
+
+ if (Start + ScreenWidth >= List.size())
+ End = List.size();
+ else
+ End = List.rfind(' ',Start+ScreenWidth);
+
+ if (End == string::npos || End < Start)
+ End = Start + ScreenWidth;
+ out << " " << string(List,Start,End - Start) << endl;
+ Start = End + 1;
+ }
}
+
return false;
}
/*}}}*/
@@ -310,14 +329,17 @@
/* Print out a list of packages that are going to be removed extra
to what the user asked */
string List;
+ string VersionsList;
for (unsigned J = 0; J < Cache->Head().PackageCount; J++)
{
pkgCache::PkgIterator I(Cache,Cache.List[J]);
- if (Cache[I].NewInstall() == true)
- List += string(I.Name()) + " ";
+ if (Cache[I].NewInstall() == true) {
+ List += string(I.Name()) + " ";
+ VersionsList += string(Cache[I].CandVersion) + "\n";
+ }
}
- ShowList(out,_("The following NEW packages will be installed:"),List);
+ ShowList(out,_("The following NEW packages will be installed:"),List,VersionsList);
}
/*}}}*/
// ShowDel - Show packages to delete /*{{{*/
@@ -328,6 +350,7 @@
/* Print out a list of packages that are going to be removed extra
to what the user asked */
string List;
+ string VersionsList;
for (unsigned J = 0; J < Cache->Head().PackageCount; J++)
{
pkgCache::PkgIterator I(Cache,Cache.List[J]);
@@ -337,10 +360,12 @@
List += string(I.Name()) + "* ";
else
List += string(I.Name()) + " ";
+
+ VersionsList += string(Cache[I].CandVersion)+ "\n";
}
}
- ShowList(out,_("The following packages will be REMOVED:"),List);
+ ShowList(out,_("The following packages will be REMOVED:"),List,VersionsList);
}
/*}}}*/
// ShowKept - Show kept packages /*{{{*/
@@ -349,6 +374,7 @@
void ShowKept(ostream &out,CacheFile &Cache)
{
string List;
+ string VersionsList;
for (unsigned J = 0; J < Cache->Head().PackageCount; J++)
{
pkgCache::PkgIterator I(Cache,Cache.List[J]);
@@ -359,8 +385,9 @@
continue;
List += string(I.Name()) + " ";
+ VersionsList += string(Cache[I].CurVersion) + " => " + Cache[I].CandVersion + "\n";
}
- ShowList(out,_("The following packages have been kept back"),List);
+ ShowList(out,_("The following packages have been kept back"),List,VersionsList);
}
/*}}}*/
// ShowUpgraded - Show upgraded packages /*{{{*/
@@ -369,6 +396,7 @@
void ShowUpgraded(ostream &out,CacheFile &Cache)
{
string List;
+ string VersionsList;
for (unsigned J = 0; J < Cache->Head().PackageCount; J++)
{
pkgCache::PkgIterator I(Cache,Cache.List[J]);
@@ -378,8 +406,9 @@
continue;
List += string(I.Name()) + " ";
+ VersionsList += string(Cache[I].CurVersion) + " => " + Cache[I].CandVersion + "\n";
}
- ShowList(out,_("The following packages will be upgraded"),List);
+ ShowList(out,_("The following packages will be upgraded"),List,VersionsList);
}
/*}}}*/
// ShowDowngraded - Show downgraded packages /*{{{*/
@@ -388,6 +417,7 @@
bool ShowDowngraded(ostream &out,CacheFile &Cache)
{
string List;
+ string VersionsList;
for (unsigned J = 0; J < Cache->Head().PackageCount; J++)
{
pkgCache::PkgIterator I(Cache,Cache.List[J]);
@@ -397,8 +427,9 @@
continue;
List += string(I.Name()) + " ";
+ VersionsList += string(Cache[I].CurVersion) + " => " + Cache[I].CandVersion + "\n";
}
- return ShowList(out,_("The following packages will be DOWNGRADED"),List);
+ return ShowList(out,_("The following packages will be DOWNGRADED"),List,VersionsList);
}
/*}}}*/
// ShowHold - Show held but changed packages /*{{{*/
@@ -407,15 +438,18 @@
bool ShowHold(ostream &out,CacheFile &Cache)
{
string List;
+ string VersionsList;
for (unsigned J = 0; J < Cache->Head().PackageCount; J++)
{
pkgCache::PkgIterator I(Cache,Cache.List[J]);
if (Cache[I].InstallVer != (pkgCache::Version *)I.CurrentVer() &&
- I->SelectedState == pkgCache::State::Hold)
- List += string(I.Name()) + " ";
+ I->SelectedState == pkgCache::State::Hold) {
+ List += string(I.Name()) + " ";
+ VersionsList += string(Cache[I].CurVersion) + " => " + Cache[I].CandVersion + "\n";
+ }
}
- return ShowList(out,_("The following held packages will be changed:"),List);
+ return ShowList(out,_("The following held packages will be changed:"),List,VersionsList);
}
/*}}}*/
// ShowEssential - Show an essential package warning /*{{{*/
@@ -426,6 +460,7 @@
bool ShowEssential(ostream &out,CacheFile &Cache)
{
string List;
+ string VersionsList;
bool *Added = new bool[Cache->Head().PackageCount];
for (unsigned int I = 0; I != Cache->Head().PackageCount; I++)
Added[I] = false;
@@ -444,6 +479,7 @@
{
Added[I->ID] = true;
List += string(I.Name()) + " ";
+ //VersionsList += string(Cache[I].CurVersion) + "\n"; ???
}
}
@@ -468,13 +504,14 @@
char S[300];
snprintf(S,sizeof(S),_("%s (due to %s) "),P.Name(),I.Name());
List += S;
+ //VersionsList += "\n"; ???
}
}
}
delete [] Added;
return ShowList(out,_("WARNING: The following essential packages will be removed\n"
- "This should NOT be done unless you know exactly what you are doing!"),List);
+ "This should NOT be done unless you know exactly what you are doing!"),List,VersionsList);
}
/*}}}*/
// Stats - Show some statistics /*{{{*/
@@ -968,6 +1005,7 @@
"of sources.list\n"),Pkg.Name());
string List;
+ string VersionsList;
SPtrArray<bool> Seen = new bool[Cache.Head().PackageCount];
memset(Seen,0,Cache.Head().PackageCount*sizeof(*Seen));
pkgCache::DepIterator Dep = Pkg.RevDependsList();
@@ -979,8 +1017,9 @@
continue;
Seen[Dep.ParentPkg()->ID] = true;
List += string(Dep.ParentPkg().Name()) + " ";
+ //VersionsList += string(Dep.ParentPkg().CurVersion) + "\n"; ???
}
- ShowList(c1out,_("However the following packages replace it:"),List);
+ ShowList(c1out,_("However the following packages replace it:"),List,VersionsList);
}
_error->Error(_("Package %s has no installation candidate"),Pkg.Name());
@@ -1407,6 +1446,7 @@
if (Cache->InstCount() != ExpectedInst)
{
string List;
+ string VersionsList;
for (unsigned J = 0; J < Cache->Head().PackageCount; J++)
{
pkgCache::PkgIterator I(Cache,Cache.List[J]);
@@ -1418,11 +1458,13 @@
if (strcmp(*J,I.Name()) == 0)
break;
- if (*J == 0)
+ if (*J == 0) {
List += string(I.Name()) + " ";
+ VersionsList += string(Cache[I].CandVersion) + "\n";
+ }
}
- ShowList(c1out,_("The following extra packages will be installed:"),List);
+ ShowList(c1out,_("The following extra packages will be installed:"),List,VersionsList);
}
// See if we need to prompt
@@ -2038,6 +2080,7 @@
" -m Attempt to continue if archives are unlocatable\n"
" -u Show a list of upgraded packages as well\n"
" -b Build the source package after fetching it\n"
+ " -V Show verbose version numbers\n"
" -c=? Read this configuration file\n"
" -o=? Set an arbitary configuration option, eg -o dir::cache=/tmp\n"
"See the apt-get(8), sources.list(5) and apt.conf(5) manual\n"
@@ -2081,6 +2124,7 @@
CommandLine::Args Args[] = {
{'h',"help","help",0},
{'v',"version","version",0},
+ {'V',"verbose-versions","APT::Get::Show-Versions",0},
{'q',"quiet","quiet",CommandLine::IntLevel},
{'q',"silent","quiet",CommandLine::IntLevel},
{'d',"download-only","APT::Get::Download-Only",0},
diff -ur apt-0.5.4/doc/apt-get.8.sgml apt-0.5.4.ow.1/doc/apt-get.8.sgml
--- apt-0.5.4/doc/apt-get.8.sgml Sun Jul 8 00:29:40 2001
+++ apt-0.5.4.ow.1/doc/apt-get.8.sgml Thu Jan 31 17:30:03 2002
@@ -292,6 +292,12 @@
Configuration Item: <literal/APT::Get::Show-Upgraded/.
</VarListEntry>
+ <VarListEntry><term><option/-V/</><term><option/--verbose-versions/</>
+ <ListItem><Para>
+ Show full versions for upgraded and installed packages.
+ Configuration Item: <literal/APT::Get::Show-Versions/.
+ </VarListEntry>
+
<VarListEntry><term><option/-b/</><term><option/--compile/</>
<term><option/--build/</>
<ListItem><Para>
Reply to: