Bug#89066: marked as done (libapt-pkg-dev; Doesn't compile with -pedantic)
Your message dated Mon, 20 Aug 2001 22:46:30 -0600 (MDT)
with message-id <Pine.LNX.3.96.1010820224454.12485A-100000@wakko.deltatee.com>
and subject line Fixed in apt 0.5.4
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Darren Benham
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 9 Mar 2001 20:58:43 +0000
>From daniel@adsl-63-193-247-253.dsl.snfc21.pacbell.net Fri Mar 09 14:58:43 2001
Return-path: <daniel@adsl-63-193-247-253.dsl.snfc21.pacbell.net>
Received: from adsl-63-193-247-253.dsl.snfc21.pacbell.net [::ffff:63.193.247.253]
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 14bTyE-0008F1-00; Fri, 09 Mar 2001 14:58:43 -0600
Received: from daniel by adsl-63-193-247-253.dsl.snfc21.pacbell.net with local (Exim 3.22 #1 (Debian))
id 14bTyB-0003kV-00
for <submit@bugs.debian.org>; Fri, 09 Mar 2001 12:58:39 -0800
To: Debian GNU/Linux bug list <submit@bugs.debian.org>
Subject: libapt-pkg-dev; Doesn't compile with -pedantic
Content-Type: text/plain; charset=US-ASCII
From: Daniel Schepler <schepler@math.berkeley.edu>
Date: 09 Mar 2001 12:58:37 -0800
Message-ID: <87itliwtfm.fsf@adsl-63-193-247-253.dsl.snfc21.pacbell.net>
Lines: 66
MIME-Version: 1.0
Sender: Daniel Schepler <daniel@adsl-63-193-247-253.dsl.snfc21.pacbell.net>
Delivered-To: submit@bugs.debian.org
Package: libapt-pkg-dev
Version: 0.5.3
Severity: normal
Tags: patch
When I try to compile a program using libapt-pkg using the -pedantic
flag, it produces the following errors:
g++ -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/include/kde -I/usr/include/qt -I/usr/X11R6/include -g -ansi -D_XOPEN_SOURCE -D_BSD_SOURCE -Wbad-function-cast -Wcast-align -Wundef -Wconversion -fno-exceptions -fno-check-new -Wall -pedantic -W -Wpointer-arith -Wmissing-prototypes -Wwrite-strings -Wno-long-long -Wnon-virtual-dtor -fno-builtin -c pkgview.cc
In file included from aptpkg.hh:8,
from pkgview.cc:2:
/usr/include/apt-pkg/configuration.h: In method `int Configuration::FindI(basic_string<char,string_char_traits<char>,__default_alloc_template<true,0> >, bool = 0) const':
/usr/include/apt-pkg/configuration.h:73: call of overloaded `FindI(const char *, bool &)' is ambiguous
/usr/include/apt-pkg/configuration.h:72: candidates are: int Configuration::FindI(const char *, int = 0) const
/usr/include/apt-pkg/configuration.h:73: int Configuration::FindI(basic_string<char,string_char_traits<char>,__default_alloc_template<true,0> >, bool = 0) const
/usr/include/apt-pkg/configuration.h:73: warning: control reaches end of non-void function `Configuration::FindI(basic_string<char,string_char_traits<char>,__default_alloc_template<true,0> >, bool) const'
In file included from aptpkg.hh:9,
from pkgview.cc:2:
/usr/include/apt-pkg/pkgsystem.h: In method `bool pkgSystem::Initialize(Configuration &)':
/usr/include/apt-pkg/pkgsystem.h:75: warning: unused parameter `class Configuration & Cnf'
/usr/include/apt-pkg/pkgsystem.h: In method `int pkgSystem::Score(const Configuration &)':
/usr/include/apt-pkg/pkgsystem.h:86: warning: unused parameter `const class Configuration & Cnf'
Here are patches which fix the compilation errors, and incidentally
the warnings too.
--- /usr/include/apt-pkg/configuration.h.orig Mon Feb 19 23:03:17 2001
+++ /usr/include/apt-pkg/configuration.h Fri Mar 9 12:22:03 2001
@@ -70,7 +70,7 @@
string FindFile(const char *Name,const char *Default = 0) const;
string FindDir(const char *Name,const char *Default = 0) const;
int FindI(const char *Name,int Default = 0) const;
- int FindI(string Name,bool Default = 0) const {return FindI(Name.c_str(),Default);};
+ int FindI(string Name,int Default = 0) const {return FindI(Name.c_str(),Default);};
bool FindB(const char *Name,bool Default = false) const;
bool FindB(string Name,bool Default = false) const {return FindB(Name.c_str(),Default);};
string FindAny(const char *Name,const char *Default = 0) const;
--- /usr/include/apt-pkg/pkgsystem.h.orig Mon Feb 19 23:03:17 2001
+++ /usr/include/apt-pkg/pkgsystem.h Fri Mar 9 12:22:41 2001
@@ -72,7 +72,7 @@
/* Load environment specific configuration and perform any other setup
necessary */
- virtual bool Initialize(Configuration &Cnf) {return true;};
+ virtual bool Initialize(Configuration & /* Cnf */) {return true;};
/* Type is some kind of Globally Unique way of differentiating
archive file types.. */
@@ -83,7 +83,7 @@
/* Evauluate how 'right' we are for this system based on the filesystem
etc.. */
- virtual signed Score(Configuration const &Cnf) {return 0;};
+ virtual signed Score(Configuration const & /* Cnf */) {return 0;};
pkgSystem();
virtual ~pkgSystem() {};
-- System Information
Debian Release: testing/unstable
Kernel Version: Linux frobnitz 2.4.2 #1 Thu Feb 22 00:43:58 PST 2001 i686 unknown
Versions of the packages libapt-pkg-dev depends on:
ii apt 0.5.3 Advanced front-end for dpkg
^^^ (Provides virtual package libapt-pkg-libc6.2-3-2-3.1)
---------------------------------------
Received: (at 89066-done) by bugs.debian.org; 21 Aug 2001 04:46:46 +0000
>From jgg@debian.org Mon Aug 20 23:46:46 2001
Return-path: <jgg@debian.org>
Received: from cast-ext.ab.videon.ca [206.75.216.34]
by master.debian.org with smtp (Exim 3.12 1 (Debian))
id 15Z3R3-0000yS-00; Mon, 20 Aug 2001 23:46:42 -0500
Received: (qmail 1390 invoked from network); 21 Aug 2001 04:46:39 -0000
Received: from unknown (HELO wakko.deltatee.com) ([24.108.173.63]) (envelope-sender <jgg@debian.org>)
by cast-ext.ab.videon.ca (qmail-ldap-1.03) with SMTP
for <56708-done@bugs.debian.org>; 21 Aug 2001 04:46:39 -0000
Received: from localhost
([127.0.0.1] helo=wakko.deltatee.com ident=jgg)
by wakko.deltatee.com with smtp (Exim 3.16 #1 (Debian))
id 15Z3Qt-0003KS-00; Mon, 20 Aug 2001 22:46:31 -0600
Date: Mon, 20 Aug 2001 22:46:30 -0600 (MDT)
From: Jason Gunthorpe <jgg@debian.org>
X-Sender: jgg@wakko.deltatee.com
To: 56708-done@bugs.debian.org, 59432-done@bugs.debian.org,
65691-done@bugs.debian.org, 86954-done@bugs.debian.org,
88913-done@bugs.debian.org, 89066-done@bugs.debian.org,
89066-done@bugs.debian.org, 89121-done@bugs.debian.org,
89152-done@bugs.debian.org, 89671-done@bugs.debian.org,
89762-done@bugs.debian.org, 89854-done@bugs.debian.org,
90027-done@bugs.debian.org, 92025-done@bugs.debian.org,
92033-done@bugs.debian.org, 92757-done@bugs.debian.org,
93057-done@bugs.debian.org, 93652-done@bugs.debian.org,
94286-done@bugs.debian.org, 94618-done@bugs.debian.org,
95823-done@bugs.debian.org, 97364-done@bugs.debian.org,
97520-done@bugs.debian.org, 97520-done@bugs.debian.org,
97809-done@bugs.debian.org, 98272-done@bugs.debian.org,
98353-done@bugs.debian.org, 98468-done@bugs.debian.org,
98695-done@bugs.debian.org, 98928-done@bugs.debian.org,
99671-done@bugs.debian.org, 99974-done@bugs.debian.org,
100046-done@bugs.debian.org, 100325-done@bugs.debian.org,
100590-done@bugs.debian.org, 101071-done@bugs.debian.org,
101565-done@bugs.debian.org, 102293-done@bugs.debian.org,
102421-done@bugs.debian.org, 102867-done@bugs.debian.org,
102951-done@bugs.debian.org, 103020-done@bugs.debian.org,
105377-done@bugs.debian.org, 105606-done@bugs.debian.org,
106591-done@bugs.debian.org, 106911-done@bugs.debian.org,
106914-done@bugs.debian.org, 107362-done@bugs.debian.org,
107362-done@bugs.debian.org, 107395-done@bugs.debian.org,
107395-done@bugs.debian.org, 108968-done@bugs.debian.org
Subject: Fixed in apt 0.5.4
Message-ID: <Pine.LNX.3.96.1010820224454.12485A-100000@wakko.deltatee.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Delivered-To: 89066-done@bugs.debian.org
apt (0.5.4) unstable; urgency=low
* M68k config.guess patch. Closes: #88913
* Bi-yearly test on OpenBSD and Solaris
* Doc updates. Closes: #89121, #89854, #99671, #98353, #95823, #93057,
#97520, #102867, #101071, #102421, #101565, #98272, #106914,
#105606, #105377
* Various cosmetic code updates. Closes: #89066, #89066, #89152
* Add "pre-auto" as an option for DSelect::Clean (run autoclean after
update).
* More patches from Alfredo for Vendors and more SHA-1 stuff
* Fix for AJ's 'desire to remove perl-5.005' and possibly other
similar situations. Closes: #56708, #59432
* no_proxy and ftp. Closes: #89671
* Philippe Batailler's man page patches.
* Fix for display bug. Closes: #92033, #93652, #98468
* Use more than 16bits for the dep ID. Some people ran out..
Closes: #103020, #97809, #102951, #99974, #107362, #107395, #107362,
#106911, #107395, #108968
* Reordered some things to make dante and FTP happier. Closes: #92757
* James R. Van Zandt's guide.sgml updates. Closes: #90027
* apt-ftparchive copes with no uncompressed package files + contents.
* French man pages from philippe batailler - well sort of. They
don't build yet..
* run-parts. Closes: #94286
* 'apt-cache policy' preferences debug tool.
* Whatever. Closes: #89762
* libstdc++ and HURD. Closes: #92025
* More apt-utils verbage. Closes: #86954
* Fliped comparision operator. Closes: #94618
* Used the right copyright file. Closes: #65691
* Randolph's G++3 patches.
* Fixed no_proxy tokanizing. Closes: #100046
* Strip Config-Version when copying status to available. Closes: #97520
* Segfault with missing source files. Closes: #100325
* EINTR check. Closes: #102293
* Various changes to the locking metholodgy for --print-uris.
Closes: #100590
* Lame LD_LIBRARY_PATH thing. Closes: #98928
* apt-cache search searchs provide names too now. Closes: #98695
* Checksum and long lines problem. Closes: #106591
* .aptignr and empty files are just a warning. Closes: #97364
Reply to: