Bug#94286: apt: should ignore .dpkg-new and the like in apt.conf.d

[Matt Zimmerman <mdz@debian.org>]

On Tue, Apr 17, 2001 at 11:06:29PM +0200, Yann Dirson wrote:

> Package: apt
> Version: 0.5.3
> Severity: normal
> 
> If a packages fails to install, and apt stops while a package has left a
> .dpkg-new file in apt.conf.d, both files (old and new) are taken into
> account in the next run.  This may not be critical for apt-listchanges, but
> who knows what can be placed there at some time.
> 
> Also, I suspect .dpkg-old and .dpkg-dist may lurk there and cause the same
> problem.

Here is a patch.  I still say that apt should ignore everything by default,
and only accept filenames matching a certain pattern.

--- apt-pkg/contrib/configuration.cc    Tue Apr 17 20:35:30 2001
+++ apt-pkg/contrib/configuration.cc.old        Tue Apr 17 20:35:02 2001
@@ -690,9 +690,8 @@
 bool ReadConfigDir(Configuration &Conf,string Dir,bool AsSectional,
                    unsigned Depth)
 {   
-   static const char *BadExts[] = {".disabled",
-                                   ".dpkg-old",".dpkg-dist", ".dpkg-new",
-                                  ".rpmsave",".rpmorig","~",",v",0};
+   static const char *BadExts[] = {".disabled",".dpkg-old",".dpkg-dist",
+                                  ".rpmsave",".rpmorig","~",",v",0};
    
    DIR *D = opendir(Dir.c_str());
    if (D == 0)


-- 
 - mdz