[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1101192: marked as done (xflock4: bashism: fails with '52: arithmetic expression: expecting primary: "2**31 - 1"')

Your message dated Sat, 29 Mar 2025 09:54:22 +0000
with message-id <E1tyStS-004mz1-HG@fasolo.debian.org>
and subject line Bug#1101192: fixed in xfce4-session 4.20.2-2
has caused the Debian Bug report #1101192,
regarding xflock4: bashism: fails with '52: arithmetic expression: expecting primary: "2**31 - 1"'
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1101192: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1101192
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: xfce4-session
Version: 4.20.2-1
Severity: important
File: /usr/bin/xflock4
Tags: upstream

Hallo,

xflock4 has a bashism in the arithmetic expression in line 52:

 52 ret=$(echo $(dbus-send --session \
 53                        --dest=org.xfce.SessionManager \
 54                        --print-reply=literal \
 55                        --reply-timeout=$((2**31 - 1)) \
 56                        --type=method_call \
 57                        /org/xfce/SessionManager \
 58                        org.xfce.Session.Manager.Lock))

This only works if sh is symlinked to bash and breaks with dash, which is the
default in Debian.

With /usr/bin/sh -> bash:

$ sh
sh-5.2$ echo $((2**31 - 1))
2147483647

With /usr/bin/sh -> dash:

$ sh
$ echo $((2**31 - 1))
sh: 1: arithmetic expression: expecting primary: "2**31 -1"

Proposed solution: Just hardcode MAXINT as 2147483647 into the script instead
of calculating it on the fly. It is a magick number anyways, nothing is gained by
the calculation.

Grüße,
Sven.

-- System Information:
Debian Release: trixie/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'unstable'), (400, 'testing'), (1, 'experimental-debug')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.12.17-amd64 (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages xfce4-session depends on:
ii  libatk1.0-0t64         2.56.0-3
ii  libc6                  2.41-6
ii  libcairo-gobject2      1.18.4-1+b1
ii  libcairo2              1.18.4-1+b1
ii  libgdk-pixbuf-2.0-0    2.42.12+dfsg-2
ii  libglib2.0-0t64        2.84.0-2
ii  libgtk-3-0t64          3.24.49-2
ii  libgtk-layer-shell0    0.9.0-2
ii  libice6                2:1.1.1-1
ii  libpango-1.0-0         1.56.3-1
ii  libpolkit-gobject-1-0  126-2
ii  libsm6                 2:1.2.4-1
ii  libx11-6               2:1.8.12-1
ii  libxfce4ui-2-0         4.20.1-1
ii  libxfce4util7          4.20.1-1
ii  libxfce4windowing-0-0  4.20.2-1
ii  libxfconf-0-3          4.20.0-1
ii  x11-xserver-utils      7.7+11
ii  xfce4-settings         4.20.1-1
ii  xfconf                 4.20.0-1

Versions of packages xfce4-session recommends:
ii  dbus-user-session [default-dbus-session-bus]  1.16.2-2
ii  dbus-x11 [dbus-session-bus]                   1.16.2-2
ii  libglib2.0-bin                                2.84.0-2
ii  libpam-systemd [logind]                       257.4-3
ii  systemd-sysv                                  257.4-3
ii  upower                                        1.90.7-1
ii  xfce4-screensaver                             4.18.4-1
ii  xfdesktop4                                    4.20.1-1
ii  xfwm4                                         4.20.0-1

Versions of packages xfce4-session suggests:
ii  fortune-mod  1:1.99.1-9
ii  sudo         1.9.16p2-1

-- no debconf information

--- End Message ---
--- Begin Message --- 
Source: xfce4-session
Source-Version: 4.20.2-2
Done: Yves-Alexis Perez <corsac@debian.org>

We believe that the bug you reported is fixed in the latest version of
xfce4-session, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1101192@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Yves-Alexis Perez <corsac@debian.org> (supplier of updated xfce4-session package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 29 Mar 2025 09:38:45 +0100
Source: xfce4-session
Architecture: source
Version: 4.20.2-2
Distribution: unstable
Urgency: high
Maintainer: Debian Xfce Maintainers <debian-xfce@lists.debian.org>
Changed-By: Yves-Alexis Perez <corsac@debian.org>
Closes: 1101192
Changes:
 xfce4-session (4.20.2-2) unstable; urgency=high
 .
   * Urgency=high for security fix.
   * d/patches: import upstream patch to fix bashism in xflock4
     (Closes: #1101192)
Checksums-Sha1:
 7b95c678470009cee128acc52c0e6c0fd802b8b5 1918 xfce4-session_4.20.2-2.dsc
 b43daa4e8ea93408e059b20fb35f77ff07ed0794 15808 xfce4-session_4.20.2-2.debian.tar.xz
 5d8e33a0e4233962ba4c871cabf4eefaf86d61e4 15672 xfce4-session_4.20.2-2_amd64.buildinfo
Checksums-Sha256:
 f1849d7da77515a4ca54577a75c9248c7f258d50d93a368bda291df968937cbe 1918 xfce4-session_4.20.2-2.dsc
 d69152b2ad2737a72a1a550638bec76b8e4b297dd3985b880918480e0e88e581 15808 xfce4-session_4.20.2-2.debian.tar.xz
 f5b805cbf3b3503c2a3a1b4a8a0781d1d0fbb89e9a127afd1370f5e4600b0b10 15672 xfce4-session_4.20.2-2_amd64.buildinfo
Files:
 b07cbb077176b140c504636fcf9ae9dc 1918 xfce optional xfce4-session_4.20.2-2.dsc
 b9105de5d7419b81795be86bbff21ae0 15808 xfce optional xfce4-session_4.20.2-2.debian.tar.xz
 a18406e87ab412669d7745c47fde27de 15672 xfce optional xfce4-session_4.20.2-2_amd64.buildinfo


-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEE8vi34Qgfo83x35gF3rYcyPpXRFsFAmfntCEACgkQ3rYcyPpX
RFu+WAf+OO9RTmZXT4qNJoXqAOHiEQBdALL07O5RKfb2ERhERZzzYtowGWaNdQvS
tFvm3la68NicCXFPaCKPYPuk3QS3LHGDM6ACsX8DSBoz0wgu5Pdh5fd+OIWECcsE
nP263uLOhq5O69KX+A+pTFWaKHKkFNmVH8RYd6SQ95N3Ib/w5mL/+7hRyNYaTtDR
TnyR8vwwUAs+GwbfyRazh4t9WPzv0S0vB84RFHRaF3eCJOA4BvB8vEar8C3D8f+W
kBkhQRlrdzYHvAKtlMO65tDA3W4I5ahCAnqwikGtrdGAPwdW6XQ2U6+o24sjZK1z
egR5dklFwRxBnrvfSbzvZxyOzPprwg==
=ta8G
-----END PGP SIGNATURE-----

Attachment: pgpZxB_LdRU29.pgp
Description: PGP signature


--- End Message ---
Reply to: