Bug#1088782: xfce4-dev-tools FTCBFS: runs xdt-csource/xdt-csource

[Helmut Grohne <helmut@subdivi.de>]

Source: xfce4-dev-tools
Version: 4.16.0-1
Tags: patch upstream
User: debian-cross@lists.debian.org
Usertags: ftcbfs

xfce4-dev-tools fails to cross build from source, because it runs
xdt-csource/xdt-csource, which is a host architecture executable and
cannot be run. The purpose here is generating test-xdt-csource-data.c,
which is needed for testing the package. However, cross builds usually
are built with nocheck, so this file actually is not needed. The reason
it is still generated is that it is listed in BUILT_SOURCES. It is not
necessary to list it there, because automake implies that
test-xdt-csource-data.c is needed for test-xdt-csource-data.o.
BUILT_SOURCES is mostly needed for #included headers. Simply dropping
BUILT_SOURCES makes the cross build succeed. Looking closer at the
native build, one then notices that the step generating
test-xdt-csource-data.c moves from dh_auto_build to dh_auto_test as
expected. I'm attaching a patch for your convenience.

Helmut

--- xfce4-dev-tools-4.18.1.orig/tests/Makefile.am
+++ xfce4-dev-tools-4.18.1/tests/Makefile.am
@@ -23,7 +23,6 @@
 	$(GLIB_LIBS)
 
 DISTCLEANFILES = test-xdt-csource-data.c
-BUILT_SOURCES = test-xdt-csource-data.c
 
 test-xdt-csource-data.c: Makefile $(srcdir)/data/data.bin $(srcdir)/data/data.txt
 	$(top_builddir)/xdt-csource/xdt-csource --extern --build-list data_bin $(srcdir)/data/data.bin data_txt $(srcdir)/data/data.txt > test-xdt-csource-data.c