[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1031968: libxfconf-0-dev fails to build with valac installed



Package: libxfconf-0-dev
Version: 4.18.0-1
Severity: serious
Tags: ftbfs patch
Justification: fails to build from source (but built successfully in the past)

Dear Maintainer,

To reproduce the problem please follow these steps:

$ sudo apt install valac
$ apt-get source libxfconf-0-dev
$ cd xfconf-4.18.0
$ dpkg-buildpackage -j`nproc`

Output:
================================================================================
...
   dh_compress
   dh_fixperms
   dh_missing
dh_missing: warning: usr/share/vala/vapi/libxfconf-0.deps exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/share/vala/vapi/libxfconf-0.vapi exists in debian/tmp but is not installed to anywhere
	The following debhelper tools have reported what they installed (with files per package)
	 * dh_install: gir1.2-xfconf-0 (1), libxfconf-0-3 (2), libxfconf-0-dev (5), xfconf (5)
	 * dh_installdocs: gir1.2-xfconf-0 (0), libxfconf-0-3 (0), libxfconf-0-dev (1), xfconf (0)
	 * dh_installman: gir1.2-xfconf-0 (0), libxfconf-0-3 (0), libxfconf-0-dev (0), xfconf (1)
	If the missing files are installed by another tool, please file a bug against it.
	When filing the report, if the tool is not part of debhelper itself, please reference the
	"Logging helpers and dh_missing" section from the "PROGRAMMING" guide for debhelper (10.6.3+).
	  (in the debhelper package: /usr/share/doc/debhelper/PROGRAMMING.gz)
	Be sure to test with dpkg-buildpackage -A/-B as the results may vary when only a subset is built
	If the omission is intentional or no other helper can take care of this consider adding the
	paths to debian/not-installed.
dh_missing: error: missing files, aborting
make: *** [debian/rules:7: binary] Error 255
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
================================================================================

To fix the issue I propose including valac to package build dependencies
and include vala api files to libxfconf-0-dev.

This vala api files are useful when you wish to build some xfce plugins
from vala sources. One example is xfce4-notes-plugin which I was trying
to build and found that some vala api files are missing in Debian
distribution.

Possible fix follows (check the patch).


-- System Information:
Debian Release: bookworm/sid
  APT prefers testing
  APT policy: (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-3-amd64 (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=ru_RU.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8), LANGUAGE=ru_RU:ru
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages libxfconf-0-dev depends on:
ii  gir1.2-xfconf-0       4.18.0-1
ii  libglib2.0-dev        2.74.5-1
ii  libxfconf-0-3         4.18.0-1
ii  pkg-config            1.8.1-1
ii  pkgconf [pkg-config]  1.8.1-1

libxfconf-0-dev recommends no packages.

libxfconf-0-dev suggests no packages.

-- no debconf information
diff -Naur xfconf-4.18.0-orig/debian/control xfconf-4.18.0/debian/control
--- xfconf-4.18.0-orig/debian/control	2022-12-10 10:48:30.000000000 +0300
+++ xfconf-4.18.0/debian/control	2023-02-26 05:03:43.079063926 +0300
@@ -9,6 +9,7 @@
                intltool,
                libgirepository1.0-dev,
                libxfce4util-dev (>= 4.17.3),
+               valac,
                xfce4-dev-tools (>= 4.16)
 Rules-Requires-Root: no
 Standards-Version: 4.6.1
diff -Naur xfconf-4.18.0-orig/debian/libxfconf-0-dev.install xfconf-4.18.0/debian/libxfconf-0-dev.install
--- xfconf-4.18.0-orig/debian/libxfconf-0-dev.install	2020-11-14 13:01:16.000000000 +0300
+++ xfconf-4.18.0/debian/libxfconf-0-dev.install	2023-02-26 05:02:28.854000853 +0300
@@ -3,3 +3,4 @@
 usr/lib/*/pkgconfig
 usr/share/gir-1.0/*
 usr/share/gtk-doc
+usr/share/vala/vapi/*

Reply to: