Bug#1004837: XFCE Window Buttons not visible after Debian upgrade
Control: tags -1 + patch
Control: tags -1 + fixed-upstream
Hi maintainer,
having the same upgrade experience as the original poster, this prevents me
from promoting users to upgrade yet.
This is probably an upstream bug #188, which has been fixed this February:
https://gitlab.xfce.org/xfce/xfce4-panel/-/issues/188
Could you please backport the upstream fix, as in the provided debpatch?
Best regards,
Tomas
diff -Nru xfce4-panel-4.16.2/debian/changelog xfce4-panel-4.16.2/debian/changelog
--- xfce4-panel-4.16.2/debian/changelog 2021-02-27 17:29:44.000000000 +0100
+++ xfce4-panel-4.16.2/debian/changelog 2022-04-28 16:20:27.000000000 +0200
@@ -1,3 +1,10 @@
+xfce4-panel (4.16.2-1.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix upstream bug #188: some windows do not appear in the panel.
+
+ -- Tomas Tintera <trosos@seznam.cz> Thu, 28 Apr 2022 16:20:27 +0200
+
xfce4-panel (4.16.2-1) unstable; urgency=medium
* New upstream version 4.16.2
diff -Nru xfce4-panel-4.16.2/debian/patches/series xfce4-panel-4.16.2/debian/patches/series
--- xfce4-panel-4.16.2/debian/patches/series 2021-02-27 17:29:44.000000000 +0100
+++ xfce4-panel-4.16.2/debian/patches/series 2022-04-28 16:20:27.000000000 +0200
@@ -1,2 +1,3 @@
01_support-non-multiarch-modules.patch
02_pager-size-for-viewport.patch
+03_disconnect-size-allocate.patch
diff -Nru xfce4-panel-4.16.2/debian/patches/03_disconnect-size-allocate.patch xfce4-panel-4.16.2/debian/patches/03_disconnect-size-allocate.patch
--- xfce4-panel-4.16.2/debian/patches/03_disconnect-size-allocate.patch 1970-01-01 01:00:00.000000000 +0100
+++ xfce4-panel-4.16.2/debian/patches/03_disconnect-size-allocate.patch 2022-04-28 16:20:27.000000000 +0200
@@ -0,0 +1,46 @@
+Origin: upstream, https://gitlab.xfce.org/xfce/xfce4-panel/-/merge_requests/66/diffs
+Date: Thu, 31 Oct 2019 17:20:31 +0100
+Subject: Fix some window buttons not appearing in the panel
+
+This is a backport of an upstream fix to odd behavior of the tasklist widget
+where closing a window would not reposition remaining window buttons and/or
+where new window buttons would not appear.
+
+Bug-Debian: https://bugs.debian.org/1004837
+Bug: https://gitlab.xfce.org/xfce/xfce4-panel/-/issues/188
+Applied-Upstream: https://gitlab.xfce.org/xfce/xfce4-panel/-/commit/9881894b9588d36da69901f15215009c8debf1ac
+
+---
+
+--- xfce4-panel-4.16.2.orig/plugins/tasklist/tasklist-widget.c
++++ xfce4-panel-4.16.2/plugins/tasklist/tasklist-widget.c
+@@ -2871,20 +2871,6 @@ xfce_tasklist_button_geometry_changed2 (
+
+
+
+-static gboolean
+-xfce_tasklist_button_size_allocate (GtkWidget *widget,
+- GdkRectangle *allocation,
+- gpointer user_data)
+-{
+- XfceTasklistChild *child = user_data;
+- /* Make sure the icons have the correct size */
+- xfce_tasklist_button_icon_changed (child->window, child);
+-
+- return TRUE;
+-}
+-
+-
+-
+ #ifdef GDK_WINDOWING_X11
+ static void
+ xfce_tasklist_button_geometry_changed (WnckWindow *window,
+@@ -3560,8 +3546,6 @@ xfce_tasklist_button_new (WnckWindow *
+ G_CALLBACK (xfce_tasklist_button_button_release_event), child);
+
+ /* monitor window changes */
+- g_signal_connect (G_OBJECT (child->button), "size-allocate",
+- G_CALLBACK (xfce_tasklist_button_size_allocate), child);
+ g_signal_connect (G_OBJECT (window), "icon-changed",
+ G_CALLBACK (xfce_tasklist_button_icon_changed), child);
+ g_signal_connect (G_OBJECT (window), "name-changed",
Reply to: