Your message dated Sun, 27 Nov 2022 22:22:43 +0500 with message-id <CANeoM1HvmWA7EQH84SgCLe7pZrfSDf+4WmUfj7s+jcEDiQ_t-w@mail.gmail.com> and subject line Re: libxfce4ui-common: xfce4-keyboard-shortcuts.xml is not valid XML has caused the Debian Bug report #989708, regarding libxfce4ui-common: xfce4-keyboard-shortcuts.xml is not valid XML to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org immediately.) -- 989708: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=989708 Debian Bug Tracking System Contact owner@bugs.debian.org with problems
--- Begin Message ---
- To: submit@bugs.debian.org
- Subject: libxfce4ui-common: xfce4-keyboard-shortcuts.xml is not valid XML
- From: Louis-Philippe Véronneau <pollo@debian.org>
- Date: Thu, 10 Jun 2021 21:50:19 -0400
- Message-id: <f88609b0-e400-ddce-f340-f2db31114bf1@debian.org>
Package: libxfce4ui-common Version: 4.16.0-1 Severity: important Control: forwarded -1 https://gitlab.xfce.org/xfce/libxfce4ui/-/issues/44 Control: tags -1 patch Dear maintainers, xfce4-keyboard-shortcuts.xml, installed to /etc/xdg/xfce4/xfconf/xfce-perchannel-xml/xfce4-keyboard-shortcuts.xml, is not valid XML. Indeed, from the line 88 to the line 95, <Super> is used instead of `<Super>. Sadly, this crashes libs used to parse XML, like Python's xml.etree.ElementTree. This bug has been reported upstream, but I've attached a patch to this bug report. Maybe it's not too late for it to make it to Bullseye? Cheers, -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ Louis-Philippe Véronneau ⢿⡄⠘⠷⠚⠋ pollo@debian.org / veronneau.org ⠈⠳⣄diff --git a/debian/patches/0001_Invalid_XML.patch b/debian/patches/0001_Invalid_XML.patch new file mode 100644 index 0000000..137a747 --- /dev/null +++ b/debian/patches/0001_Invalid_XML.patch @@ -0,0 +1,30 @@ +This patch fixes invalid XML introduced in upstream commit +b7a75bf99a6fb4ffffebeb2476d71209bafef29d. +See https://gitlab.xfce.org/xfce/libxfce4ui/-/issues/44 for more details. +Index: libxfce4ui/libxfce4kbd-private/xfce4-keyboard-shortcuts.xml +=================================================================== +--- libxfce4ui.orig/libxfce4kbd-private/xfce4-keyboard-shortcuts.xml ++++ libxfce4ui/libxfce4kbd-private/xfce4-keyboard-shortcuts.xml +@@ -85,14 +85,14 @@ + <property name="<Primary>F10" type="string" value="workspace_10_key"/> + <property name="<Primary>F11" type="string" value="workspace_11_key"/> + <property name="<Primary>F12" type="string" value="workspace_12_key"/> +- <property name="<Super>KP_Left" type="string" value="tile_left_key"/> +- <property name="<Super>KP_Right" type="string" value="tile_right_key"/> +- <property name="<Super>KP_Up" type="string" value="tile_down_key"/> +- <property name="<Super>KP_Down" type="string" value="tile_up_key"/> +- <property name="<Super>KP_Page_Up" type="string" value="tile_up_right_key"/> +- <property name="<Super>KP_Home" type="string" value="tile_up_left_key"/> +- <property name="<Super>KP_End" type="string" value="tile_down_left_key"/> +- <property name="<Super>KP_Next" type="string" value="tile_down_right_key"/> ++ <property name="<Super>KP_Left" type="string" value="tile_left_key"/> ++ <property name="<Super>KP_Right" type="string" value="tile_right_key"/> ++ <property name="<Super>KP_Up" type="string" value="tile_down_key"/> ++ <property name="<Super>KP_Down" type="string" value="tile_up_key"/> ++ <property name="<Super>KP_Page_Up" type="string" value="tile_up_right_key"/> ++ <property name="<Super>KP_Home" type="string" value="tile_up_left_key"/> ++ <property name="<Super>KP_End" type="string" value="tile_down_left_key"/> ++ <property name="<Super>KP_Next" type="string" value="tile_down_right_key"/> + </property> + </property> + </channel> diff --git a/debian/patches/series b/debian/patches/series new file mode 100644 index 0000000..b145cce --- /dev/null +++ b/debian/patches/series @@ -0,0 +1 @@ +0001_Invalid_XML.patchAttachment: OpenPGP_signature
Description: OpenPGP digital signature
--- End Message ---
--- Begin Message ---
- To: 989708-done@bugs.debian.org
- Subject: Re: libxfce4ui-common: xfce4-keyboard-shortcuts.xml is not valid XML
- From: Akbarkhon Variskhanov <akbarkhon.variskhanov@gmail.com>
- Date: Sun, 27 Nov 2022 22:22:43 +0500
- Message-id: <CANeoM1HvmWA7EQH84SgCLe7pZrfSDf+4WmUfj7s+jcEDiQ_t-w@mail.gmail.com>
- In-reply-to: <CANeoM1FKB1t0roWPJOS8Oz81SoTkGrB0+W=RAZURdOjQqQGUCA@mail.gmail.com>
- References: <CANeoM1FKB1t0roWPJOS8Oz81SoTkGrB0+W=RAZURdOjQqQGUCA@mail.gmail.com>
Source: libxfce4ui Source-Version: 4.17.2-1
--- End Message ---