[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#950437: marked as done (garcon: encoding of .directory files differs depending on locale)

Your message dated Thu, 03 Dec 2020 19:11:45 -0800
with message-id <87czzql0y6.fsf@yucca>
and subject line Re: garcon: encoding of .directory files differs depending on locale
has caused the Debian Bug report #950437,
regarding garcon: encoding of .directory files differs depending on locale
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
950437: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=950437
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: garcon
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: environment locale
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

When built with the C locale, some files differ from when built with a
UTF-8 locale, such as xfce-screensavers.directory:

Icon=preferences-desktop-screensaver
Name=Screensavers
Name[am]=መመልከቻ·​ማዳኛ	 
Name[ar]=حافظات·​الشاشة	 
Name[ast]=Curiapantal​les	 
Name[be]=Ахоўнікі·​экра

The encoding of the file also varies.

The attached patch works around this by exporting LC_ALL=C.UTF-8 in
debian/rules, ensuring all builds use a UTF-8 locale.


Thanks for maintaining garcon.


live well,
  vagrant


From 0e8418abdfdd062ec372f73bb3a45e5bb1bc6ed9 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sat, 1 Feb 2020 08:32:08 -0800
Subject: [PATCH] debian/rules: export LC_ALL=C.UTF-8 to ensure reproducible
 builds regardless of locale.

---
 debian/rules | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/debian/rules b/debian/rules
index c0a9c6a..931e87d 100755
--- a/debian/rules
+++ b/debian/rules
@@ -3,6 +3,9 @@
 export DEB_LDFLAGS_MAINT_APPEND=-Wl,-z,defs -Wl,--as-needed -Wl,-O1
 export DEB_BUILD_MAINT_OPTIONS=hardening=+all
 
+# Use C.UTF-8 locale to ensure reproducible builds
+export LC_ALL=C.UTF-8
+
 %:
 	dh $@
 
-- 
2.20.1

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
On 2020-02-01, Vagrant Cascadian wrote:
> On 2020-02-01, Vagrant Cascadian wrote:
>> When built with the C locale, some files differ from when built with a
>> UTF-8 locale, such as xfce-screensavers.directory:
>>
>> Icon=preferences-desktop-screensaver
>> Name=Screensavers
>> Name[am]=መመልከቻ·​ማዳኛ	 
> ...
>> The attached patch works around this by exporting LC_ALL=C.UTF-8 in
>> debian/rules, ensuring all builds use a UTF-8 locale.
>
> On looking into the issue a little deeper and after a few more test
> builds, this doesn't seem to consistantly address the issue; I believe
> the issue is a race condition in intltool.

It appears to be building reproducibly reliably now that intltool was
fixed in unstable, so marking this bug as done.

live well,
  vagrant

Attachment: signature.asc
Description: PGP signature


--- End Message ---
Reply to: