[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#964799: libexo-helpers: starting thunderbird fails for some mailto URIs



Package: libexo-helpers
Version: 0.12.4-1
Severity: normal
Tags: patch
X-Debbugs-Cc: nis.martensen@web.de

Dear Maintainer,

Thunderbird fails to get launched for certain mailto URIs, while it
works perfectly fine with many others. To reproduce, try

/usr/share/xfce4/exo-1/exo-compose-mail-1 mozilla-remote \
thunderbird "mailto:foo?body=b%29a";

Thunderbird fails to start and this returns 1. If you change the "%29"
to "%28", it works as expected.

This can be fixed by passing subject and body to thunderbird uri-escaped
(see patch below). This works reliably and is also the approach used by
xdg-email when launching thunderbird.

The bug still exists in upstream git. Will you forward this report or do
you want me to do it?

------
--- /usr/share/xfce4/exo-1/exo-compose-mail-1.orig	2019-01-24 23:24:08.000000000 +0100
+++ /usr/share/xfce4/exo-1/exo-compose-mail-1	2020-07-09 23:50:51.322792198 +0200
@@ -80,8 +80,8 @@
 	$command .= ",cc='" . join(",", @cc) . "'";
 	$command .= ",bcc='" . join(",", @bcc) . "'";
 	$command .= ",attachment='" . join(",", @attachments) . "'";
-	$subject and $command .= ",subject='$subject'";
-	$body and $command .= ",body='$body'";
+	$subject and $command .= ",subject=" . uri_escape($subject);
+	$body and $command .= ",body=" . uri_escape($body);

 	# and add the parameters to the argv
 	push (@argv, '-compose');
@@ -94,8 +94,8 @@
 	$command .= ",cc='" . join(",", @cc) . "'";
 	$command .= ",bcc='" . join(",", @bcc) . "'";
 	$command .= ",attachment='" . join(",", @attachments) . "'";
-	$subject and $command .= ",subject='$subject'";
-	$body and $command .= ",body='$body'";
+	$subject and $command .= ",subject=" . uri_escape($subject);
+	$body and $command .= ",body=" . uri_escape($body);
 	$command .= ')';

 	# and add the parameters to the argv

------


-- System Information:
Debian Release: 10.4

Versions of packages libexo-helpers depends on:
ii  libexo-common  0.12.4-1

-- debsums errors found:
debsums: changed file /usr/share/xfce4/exo-1/exo-compose-mail-1 (from libexo-helpers package)


Reply to: