[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#922718: /usr/bin/xflock4: please support xfce4-screensaver



Control: retitle -1 screen locking does not work without lightdm
Control: severity -1 important

> In xflock4, please support xfce4-screensaver, which is a mate-screensaver
> fork targeted at Xfce4 integration.
> 
> If installed, it should get the same priority as mate-screensaver (probably
> one higher).

If possible, please also recommend xfce4-screensaver in xfce4-session.
This ensures screen locking works out of the box in environments without
lightdm running, e.g. under X2go or RDP, in an LTSP environment using
LDM, and probably quite a few others.

A patch is attached.

I would very much suggest to upload this as a Debian patch before buster
full freeze, even though it should of course be fixed upstream. I
personally know about some hundred desktops that do not (aand cannot)
use lightdm (see above), so this breaks quite an important use case if
not fixed.

-nik
diff -Nru xfce4-session-4.12.1/debian/changelog xfce4-session-4.12.1/debian/changelog
--- xfce4-session-4.12.1/debian/changelog	2017-10-21 14:39:23.000000000 +0200
+++ xfce4-session-4.12.1/debian/changelog	2019-02-19 21:50:35.000000000 +0100
@@ -1,3 +1,11 @@
+xfce4-session (4.12.1-6.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Support and recommend xfce4-screensaver for environments without
+    lightdm (like remote desktop or LTSP; closes: #922718).
+
+ -- Dominik George <natureshadow@debian.org>  Tue, 19 Feb 2019 21:50:35 +0100
+
 xfce4-session (4.12.1-6) unstable; urgency=medium
 
   * debian/control:
diff -Nru xfce4-session-4.12.1/debian/control xfce4-session-4.12.1/debian/control
--- xfce4-session-4.12.1/debian/control	2017-10-21 14:20:13.000000000 +0200
+++ xfce4-session-4.12.1/debian/control	2019-02-19 21:50:28.000000000 +0100
@@ -39,6 +39,7 @@
             systemd-sysv [linux-any] | systemd-shim,
             upower,
             x11-xserver-utils,
+            xfce4-screensaver,
             xfdesktop4,
             xfwm4
 Suggests: fortunes-mod, sudo
diff -Nru xfce4-session-4.12.1/debian/patches/03_xflock4-update-lockers-list.patch xfce4-session-4.12.1/debian/patches/03_xflock4-update-lockers-list.patch
--- xfce4-session-4.12.1/debian/patches/03_xflock4-update-lockers-list.patch	2017-10-21 14:15:19.000000000 +0200
+++ xfce4-session-4.12.1/debian/patches/03_xflock4-update-lockers-list.patch	2019-02-19 21:49:42.000000000 +0100
@@ -1,11 +1,12 @@
 --- a/scripts/xflock4
 +++ b/scripts/xflock4
-@@ -27,7 +27,9 @@ export PATH
+@@ -27,7 +27,10 @@ export PATH
  # Lock by xscreensaver or gnome-screensaver, if a respective daemon is running
  for lock_cmd in \
      "xscreensaver-command -lock" \
 -    "gnome-screensaver-command --lock"
 +    "light-locker-command --lock" \
++    "xfce4-screensaver-command --lock" \
 +    "gnome-screensaver-command --lock" \
 +    "mate-screensaver-command --lock"
  do

Attachment: signature.asc
Description: PGP signature


Reply to: