Bug#922160: lightdm: Add elogind support

[Mark Hindley <mark@hindley.org.uk>]

On Tue, Feb 12, 2019 at 08:27:40PM +0100, Ansgar wrote:
> Mark Hindley writes:
> > diff --git a/debian/control b/debian/control
> > index fff913a..88aebb8 100644
> > --- a/debian/control
> > +++ b/debian/control
> > @@ -33,7 +33,7 @@ Package: lightdm
> >  Architecture: any
> >  Depends: adduser,
> >           dbus,
> > -         libpam-systemd [linux-any] | consolekit,
> > +         libpam-systemd [linux-any] | logind | consolekit,
> 
> If a package "runlogind" is introduced it would satisfy this
> dependency, but...
> 
> > +@@ -15,3 +16,4 @@
> > + # Setup session
> > + session   required pam_unix.so
> > + session   optional pam_systemd.so
> > ++session   optional pam_elogind.so
> 
> ... pam_runlogind.so would be missing here.  So it looks like arbitrary
> providers of logind are not supported, only those listed in the PAM
> configuration.
> 
> Shouldn't the dependency list `elogind [linux-any]` instead of a virtual
> package then?

Actually it would be libpam-elogind [linux-any], but your point is still well made.

There appears to be a desire to have a virtual pacakge available for all
providers of the Dbus login1 API. See #917431 and #915407.

For packages which utilise PAM @common-session adding the virtual logind
dependency will suffice as libpam-elogind provides a pam-auth module.

As /etc/pam.d/lightdm-greeter doesn't source common-session (should it?), the
extra line is required.

Thanks

Mark