Bug#915423: xfce4-session: reproducible build (usrmerge): embeds path of rm found via PATH

[Andreas Henriksson <andreas@fatal.se>]

On Thu, Jan 03, 2019 at 09:40:03PM +0100, Yves-Alexis Perez wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
> 
> On Thu, 2019-01-03 at 20:21 +0100, Andreas Henriksson wrote:
> > In your case the RM_CMD define is passed to g_spawn_sync function.
> > That function takes a flags argument where you could add
> > G_SPAWN_SEARCH_PATH. 
[...]
> To be honest, I didn't actually investigated why the rm command was needed.
> Considering that, I'll upload with a patch just hardcoding RM_CMD to rm.

Please also note the previous/above comment about G_SPAWN_SEARCH_PATH
flag, which I think you will need as well (or AIUI g_spawn_sync will
*not* search in PATH).

https://developer.gnome.org/glib/stable/glib-Spawning-Processes.html#g-spawn-sync
https://developer.gnome.org/glib/stable/glib-Spawning-Processes.html#GSpawnFlags

> 
> Will that pose a problem wrt. reproducibility if I don't remove the autotools
> logic around?

Reproducible problem only hits for files shipped in your binary
packages, so you don't need to touch the autoconf stuff if you sidestep
it since those files are not shipped.

Regards,
Andreas Henriksson