[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#915925: libxfce4util: Uses vendor-specific patch series file (ubuntu.series)



Hi,

On Thu, Dec 13, 2018 at 10:37:38PM +0100, Chris Lamb wrote:
> > > Please migrate away from such series files and consider alternatives
> > > such differing source packages or modify the build process to behave
> > > conditionally or to conditionally patch files explicitly.
> […] 
> > is there a documented way to actually do that in a simple/maintainable way
> 
> I'm not aware of a documented way that matches this description, alas.

Indeed, the ctte decision didn't provide any migration path.

> I've had some brief discussions with in Mattia (CC'd) that might be
> useful though; he had migrated away from an foo.series in another
> package and I had mooted writing a possible "include"-able .mk snippet.

I moved avay from foo.series in hexchat.
https://salsa.debian.org/debian/hexchat/commit/dd1b936d907d664c0f9e10119778d99228591f60
That thing seems to work correctly, but it's kind of horrible.  At least
you don't have to distiguish between ubuntu-specific and debian-specific
patches.

Another way would be to wrap the ubuntu specific code in #ifdef and set
that conditionally in d/rules.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature


Reply to: