Bug#915423: xfce4-session: reproducible build (usrmerge): embeds path of rm found via PATH

[Ansgar Burchardt <ansgar@debian.org>]

Source: xfce4-session
Version: 4.12.1-6
Severity: normal
Tags: patch
User: md@linux.it
Usertags: usrmerge
Control: user reproducible-builds@lists.alioth.debian.org
Control: usertag -1 + environment

Dear Maintainer,

According to reproducible build tests xfce4-session gets built
differently on a merged-usr system vs a non-merged system.

The package embeds the full path of rm. Since PATH defaults to
/usr/bin before /bin, the first will be used on a usrmerged system
where they're both essentially the same thing, but /usr/bin/rm does
not exist on non-merged systems.

The attached patch passes `RM=/bin/rm` to explicitly set the path.

Regards,
Ansgar

diff -Nru xfce4-session-4.13.1/debian/changelog xfce4-session-4.13.1/debian/changelog
--- xfce4-session-4.13.1/debian/changelog	2018-08-22 14:26:25.000000000 +0200
+++ xfce4-session-4.13.1/debian/changelog	2018-12-03 19:46:56.000000000 +0100
@@ -1,3 +1,10 @@
+xfce4-session (4.13.1-1.1) UNRELEASED; urgency=medium
+
+  * Explicit pass `RM=/bin/rm` to configure to make build reproducible
+    between merged-usr and non-merged-usr systems.
+
+ -- Ansgar Burchardt <ansgar@debian.org>  Mon, 03 Dec 2018 19:46:56 +0100
+
 xfce4-session (4.13.1-1) experimental; urgency=medium
 
   * New upstream version 4.13.1
diff -Nru xfce4-session-4.13.1/debian/rules xfce4-session-4.13.1/debian/rules
--- xfce4-session-4.13.1/debian/rules	2018-08-22 14:26:25.000000000 +0200
+++ xfce4-session-4.13.1/debian/rules	2018-12-03 19:46:43.000000000 +0100
@@ -21,7 +21,7 @@
 endif
 
 override_dh_auto_configure:
-	dh_auto_configure -- --disable-legacy-sm --with-backend=$(BACKEND)
+	dh_auto_configure -- RM=/bin/rm --disable-legacy-sm --with-backend=$(BACKEND)
 
 %:
 	dh $@