[Pkg-xfce-devel] Bug#735478: Different patch

[ibaldo at adinet.com.uy (Ivan Baldo)]

     Hello.
     It happens for Montevideo, Uruguay too.
     I looked at the source and the patch from Christoph will make an 
assertion when viewing the forecast summary or something like that: at 
line 490 of weather-summary.c is called get_data_f (weatherdata, 
TEMP_MAX) and inside get_data_f() in weather-data.c NULL is checked for.
     There aren't any other users of the xml_dayf::hi element.
     The code can be changed safely to just put "NA" there or any other 
string, even an empty string (anything but NULL):

diff -urN xfce4-weather-plugin-0.7.4/panel-plugin/weather-parsers.c 
xfce4-weather-plugin-0.7.4.allow_empty_hi/panel-plugin/weather-parsers.c
--- xfce4-weather-plugin-0.7.4/panel-plugin/weather-parsers.c 2011-02-02 
18:31:29.000000000 -0200
+++ 
xfce4-weather-plugin-0.7.4.allow_empty_hi/panel-plugin/weather-parsers.c 
2014-01-17 16:21:15.399088000 -0200
@@ -301,7 +301,8 @@
        if (NODE_IS_TYPE (cur_node, "hi"))
          {
            ret->hi = DATA (cur_node);
-          g_assert (ret->hi != NULL);
+          if (ret->hi == NULL)
+            ret->hi = g_strdup ("NA");
          }
        else if (NODE_IS_TYPE (cur_node, "low"))
          {

     Thanks for uploading it!
     Bye.
P.s.: thanks Christoph for your analysis and initial patch though!!!

-- 
Ivan Baldo - ibaldo at adinet.com.uy - http://ibaldo.codigolibre.net/
 From Montevideo, Uruguay, at the south of South America.
Freelance programmer and GNU/Linux system administrator, hire me!
Alternatives: ibaldo at codigolibre.net - http://go.to/ibaldo