[Pkg-xfce-devel] State of goodies: Part 2

[ema at debian.org (Emanuele Rocca)]

* Yves-Alexis Perez <corsac at corsac.net>, [2007-05-25 19:13 +0200]:
>  On ven, 2007-05-25 at 12:11 +0100, Simon Huggins wrote:
>  > xfce4-screenshooter-plugin/debian/changelog
>  > 	Doesn't work on amd64 at least.
>  It works on etch/amd64.

>  > 	Seems to create random filenames even when cancel is pressed.  It
>  > 	killed itself from my panel on use after three times too.
>  It's fixed in 1.0.0.

Well, actually #420242 has been reported against 1.0.0-2.
With 1.0.0-3 I cannot reproduce the bug, but the patch you proposed
(g_freeing filename) causes the following (at least on sparc):

*** glibc detected *** /usr/lib/xfce4-screenshooter-plugin/xfce4/panel-plugins/xfce4-screenshooter-plugin: double free or corruption (fasttop): 0x003c84b8 ***
** Message: Screenshot: screen changed: 0

** Message: No valid plug window.

(xfce4-panel:365): Gtk-CRITICAL **: gtk_socket_get_id: assertion `GTK_WIDGET_ANCHORED (socket)' failed

** (xfce4-panel:365): CRITICAL **: An item was unexpectedly removed: "Screenshot".

Without the patch everything works correctly, saying 'Cancel' the
screenshot is not created and saying 'Ok' it is created properly.

The only annoying thing is that even if you decide not to save the file,
the default filename keeps changing (Screenshot-5.png ->
Screenshot-6.png).

Simon, could you please test 1.0.0-3 on amd64 (with and without the
g_free patch)?

Thanks.
ciao,
    ema
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-xfce-devel/attachments/20070603/75ef72de/attachment.pgp