[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[Pkg-xfce-devel] Re: [Pkg-xfce-commits] r472 - desktop/trunk/libxfce4mcs/debian

Salut Jani!

On Sun, Feb 05, 2006 at 04:38:47PM +0000, Jani Monoses wrote:
> Modified:
>    desktop/trunk/libxfce4mcs/debian/changelog
>    desktop/trunk/libxfce4mcs/debian/control
>    desktop/trunk/libxfce4mcs/debian/libxfce4mcs-client-2.install
>    desktop/trunk/libxfce4mcs/debian/libxfce4mcs-dev.install
>    desktop/trunk/libxfce4mcs/debian/libxfce4mcs-manager-2.install
> Log:
> make libxfce4mcs package work for the new 4.3 lib too

> Modified: desktop/trunk/libxfce4mcs/debian/changelog
> ===================================================================
> --- desktop/trunk/libxfce4mcs/debian/changelog	2006-02-02 16:43:49 UTC (rev 471)
> +++ desktop/trunk/libxfce4mcs/debian/changelog	2006-02-05 16:38:45 UTC (rev 472)
> @@ -1,3 +1,11 @@
> +libxfce4mcs (4.2.3-2) UNRELEASED; urgency=low
> +
> +  * Make .so library version matching more generic to catch soname bumps
> +    and to be consistent with libxfce4util and libxfcegui4
> +  * Add myself to uploaders field
> +
> + -- Jani Monoses <jani@ubuntu.com>  Sun,  5 Feb 2006 16:56:43 +0200

Sorry, I meant to reply to this ages ago.

I don't think this should be committed.  I thought if you were going to
make 4.3 changes you were going to do them separately.

Also, I'm not happy with these changes.  I'd want the package to not
build (or at least not usefully ship a library) if the soname changed
and noone noticed.  I don't think the packaging should ever encompass
more than one version of the library as there may be specific things
that are needed for each.  I guess I'm just not comfortable with the way
this has been done.  If you can persuade me it's technically the right
thing to do (or others can) then I'm happy to accept it but I think, if
you want changes like these, then unless you talk about them first then
they should go in a separate branch.


 -+//   If at first you don't succeed, destroy all evidence that you   \\+-
-+<<                               tried.                               >>+-
 -+\\                                                                  //+-
        Colocate your server with http://www.blackcatnetworks.co.uk

Reply to: