-
0cb99ef6
by Dylan Baker at 2025-11-14T13:56:23-08:00
docs: Add sha sums for 25.3.0
-
7e61052f
by Dylan Baker at 2025-11-17T09:54:24-08:00
.pick_status.json: Update to 018f45f9812cb5b728e2eb32a5b350efdd9ac90f
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
4bd93089
by Benjamin Cheng at 2025-11-17T09:54:25-08:00
radv/video: Align each layer of encode DPB to 256
VCN requires the luma/chroma VAs to be 256 aligned. On VCN5, the
collocated buffer was not 256 aligned which can cause these VAs to be
unaligned.
This fixes VVL PositiveVideoEncodeH264.Basic on VCN5.
Fixes: 37e71a5cb24 ("radv/video: add support for AV1 encoding")
Reviewed-by: David Rosca <david.rosca@amd.com>
(cherry picked from commit 884849587569919b7ef40021da70e6858d93cbe9)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
b475bf8f
by Alyssa Rosenzweig at 2025-11-17T09:54:26-08:00
nir/sweep: fix use-after-free with dominance LCA
Either we need to save this pointer or toss it.
==146166==ERROR: AddressSanitizer: heap-use-after-free on address 0x7bfe77013920 at pc 0x7b9e6fd5b978 bp 0x7ffc30ef18e0 sp 0x7ffc30ef18d8
READ of size 4 at 0x7bfe77013920 thread T0
#0 0x7b9e6fd5b977 in get_header ../src/util/ralloc.c:83
#1 0x7b9e6fd5b977 in ralloc_parent ../src/util/ralloc.c:382
#2 0x7b9e6fd5b977 in reralloc_size ../src/util/ralloc.c:198
#3 0x7b9e6fd5b977 in reralloc_array_size ../src/util/ralloc.c:241
#4 0x7b9e705f83c2 in range_minimum_query_table_resize ../src/util/range_minimum_query.c:21
#5 0x7b9e7018af1d in realloc_info ../src/compiler/nir/nir_dominance_lca.c:33
#6 0x7b9e7018af1d in nir_calc_dominance_lca_impl ../src/compiler/nir/nir_dominance_lca.c:126
#7 0x7b9e6ff9815c in nir_metadata_require ../src/compiler/nir/nir_metadata.c:42
#8 0x7b9e6ff998e4 in nir_metadata_require_most ../src/compiler/nir/nir_metadata.c:200
#9 0x7b9e6f8aab4d in st_finalize_nir ../src/mesa/state_tracker/st_glsl_to_nir.cpp:735
#10 0x7b9e6f0afb14 in st_create_common_variant ../src/mesa/state_tracker/st_program.c:858
#11 0x7b9e6f0be2d3 in st_get_common_variant ../src/mesa/state_tracker/st_program.c:973
#12 0x7b9e6f0bf9cf in st_precompile_shader_variant ../src/mesa/state_tracker/st_program.c:1478
#13 0x7b9e6f0bf9cf in st_finalize_program ../src/mesa/state_tracker/st_program.c:1596
#14 0x7b9e6f8b0127 in st_link_glsl_to_nir ../src/mesa/state_tracker/st_glsl_to_nir.cpp:633
#15 0x7b9e6f8b3611 in st_link_shader ../src/mesa/state_tracker/st_glsl_to_nir.cpp:816
#16 0x7b9e6f7bcf51 in link_program ../src/mesa/main/shaderapi.c:1412
#17 0x7b9e6f7bcf51 in link_program_error ../src/mesa/main/shaderapi.c:1474
#18 0x0000004020b0 in main._omp_fn.0 /home/alyssa/shader-db/run.c:872
#19 0x7f9e7893dd65 in GOMP_parallel (/lib64/libgomp.so.1+0xdd65) (BuildId: 9cc501fdca53b5d4ab094f709486781c98573bc9)
#20 0x000000400d6a in main /home/alyssa/shader-db/run.c:689
#21 0x7f9e78011574 in __libc_start_call_main (/lib64/libc.so.6+0x3574) (BuildId: 48c4b9b1efb1df15da8e787f489128bf31893317)
#22 0x7f9e78011627 in __libc_start_main@GLIBC_2.2.5 (/lib64/libc.so.6+0x3627) (BuildId: 48c4b9b1efb1df15da8e787f489128bf31893317)
#23 0x000000401014 in _start (/home/alyssa/shader-db/run+0x401014) (BuildId: a83b8d830cc265be3f54ea3e7a21a0fb5156624b)
0x7bfe77013920 is located 0 bytes inside of 64-byte region [0x7bfe77013920,0x7bfe77013960)
freed by thread T0 here:
#0 0x7f9e782e5beb in free.part.0 (/usr/lib64/libasan.so.8+0xe5beb) (BuildId: cab80046dbc1c97c6e14490acc37d079701f8d9a)
#1 0x7b9e6fd5bc39 in unsafe_free ../src/util/ralloc.c:319
#2 0x7b9e6fd5bc39 in ralloc_free ../src/util/ralloc.c:264
#3 0x7b9e70063d81 in nir_sweep ../src/compiler/nir/nir_sweep.c:219
#4 0x7b9e6f0bf499 in st_finalize_program ../src/mesa/state_tracker/st_program.c:1585
#5 0x7b9e6f8b0127 in st_link_glsl_to_nir ../src/mesa/state_tracker/st_glsl_to_nir.cpp:633
#6 0x7b9e6f8b3611 in st_link_shader ../src/mesa/state_tracker/st_glsl_to_nir.cpp:816
#7 0x7b9e6f7bcf51 in link_program ../src/mesa/main/shaderapi.c:1412
#8 0x7b9e6f7bcf51 in link_program_error ../src/mesa/main/shaderapi.c:1474
#9 0x0000004020b0 in main._omp_fn.0 /home/alyssa/shader-db/run.c:872
previously allocated by thread T0 here:
#0 0x7f9e782e5e4b in realloc.part.0 (/usr/lib64/libasan.so.8+0xe5e4b) (BuildId: cab80046dbc1c97c6e14490acc37d079701f8d9a)
#1 0x7b9e6fd5a883 in resize ../src/util/ralloc.c:167
#2 0x7b9e705f83c2 in range_minimum_query_table_resize ../src/util/range_minimum_query.c:21
#3 0x7b9e7018af1d in realloc_info ../src/compiler/nir/nir_dominance_lca.c:33
#4 0x7b9e7018af1d in nir_calc_dominance_lca_impl ../src/compiler/nir/nir_dominance_lca.c:126
#5 0x7b9e6ff9815c in nir_metadata_require ../src/compiler/nir/nir_metadata.c:42
#6 0x7b9e6ff998e4 in nir_metadata_require_most ../src/compiler/nir/nir_metadata.c:200
#7 0x7b9e6f8b0ede in st_link_glsl_to_nir ../src/mesa/state_tracker/st_glsl_to_nir.cpp:550
#8 0x7b9e6f8b3611 in st_link_shader ../src/mesa/state_tracker/st_glsl_to_nir.cpp:816
#9 0x7b9e6f7bcf51 in link_program ../src/mesa/main/shaderapi.c:1412
#10 0x7b9e6f7bcf51 in link_program_error ../src/mesa/main/shaderapi.c:1474
#11 0x0000004020b0 in main._omp_fn.0 /home/alyssa/shader-db/run.c:872
Fixes: 17876a00afa ("nir: Add a faster lowest common ancestor algorithm")
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com>
Reviewed-by: Mel Henning <mhenning@darkrefraction.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
(cherry picked from commit 65fcdf4c81d4309257a4ca6471332a7d56e68729)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
1f1b69c3
by Connor Abbott at 2025-11-17T09:54:26-08:00
tu: Handle case where pipeline writes unused color attachments
With VK_EXT_unused_attachments, we may have a case where the FS writes
to attachments 0 and 1, both have valid formats and are enabled, yet the
renderpass only has 1 color attachment. In this case we would set
RB_PS_MRT_CNTL to 2, but since we never emitted RB_MRT_BUF_INFO[1] and
so on, we would get garbage attachment info from the last render pass
and end up writing to an attachment that doesn't exist.
Fix this by disabling attachments that are unused. We can't move setting
RB_PS_MRT_CNTL to emitting when we emit color RT state, because then we
have the inverse problem of a FS that writes to attachments 0 and 1, a
renderpass that has 2 attachments, but a blend state that only includes
1 attachment (and therefore disables color writes for attachment 1). At
least one side (blending or RT emission) has to assume that the other
side may have more RTs enabled and disable the rest of the RTs up to
MAX_RTS.
Fixes: c2eb768eb22 ("tu: Expose VK_EXT_dynamic_rendering_unused_attachments")
(cherry picked from commit 6064e3a7d82ecd31f54f5a77c01ce4253f0e79fe)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
d22a20de
by Lionel Landwerlin at 2025-11-17T09:54:27-08:00
brw: fixup 64bit atomics emulation on 2D array images
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: ce7208c3ee ("brw: add support for texel address lowering")
Acked-by: Nanley Chery <nanley.g.chery@intel.com>
(cherry picked from commit b3cc54731f1952c2eab05826be5a4dbca07fadf4)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
d29700fc
by Yiwei Zhang at 2025-11-17T09:54:30-08:00
venus: use seq_cst for ring cs and tail update ordering
To avoid incompatibility between the compiler implementations used by
the driver and the renderer, seq_cst ordering is picked here, which has
required a full mfence instruction. Then the renderer side acquire is
ensured to be ordered after the cache flush of ring cs updates.
Perf wise, there's no regression in headless vkmark runs. In theory,
the overhead introduced here weighs trivially as compared to the ring
cs encode/decode part. So we should go for better robustness.
Test: venus on windows guest works with renderer on Linux
Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/14277
(cherry picked from commit 07d059f3e20179266c12d5a59bde6a8249306bd2)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
8b20f433
by Lionel Landwerlin at 2025-11-17T09:54:31-08:00
brw: fix SIMD lowering of sampler messages with fp16 data
We need to make sure the data part returned by sampler messages is
always aligned to a physical register. Just like the residency data
lives in a single physical register after the data.
Lowering a vec3 16bits per components led to a half a physical
register allocation which then confused the descriptor lowering
(expecting physical register units).
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 295734bf88 ("intel/fs: fix residency handling on Xe2")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12794
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com>
(cherry picked from commit 61d6aea401743177e30d286ce6946525f30c8df9)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
19cab16a
by Daniel Schürmann at 2025-11-17T09:54:32-08:00
nir/opt_large_constants: Fix dead deref instructions accessing lowered variables
It could happen that unused derefs weren't removed
if DCE wasn't called prior to nir_opt_large_constants.
Cc: mesa-stable
(cherry picked from commit 0d70716c8a5e4a4dddf777a0c9529ada69f8aee1)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
1f6d6533
by Timur Kristóf at 2025-11-17T09:54:32-08:00
radv: Disable sparse mapping when unsupported by VM
Also disable the sparse binding queue and other related features.
Using sparse on GFX6-8 can cause GPU hangs at the moment.
Cc: mesa-stable
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
(cherry picked from commit 1c8881fc605936d403d95426d813cced66d003c2)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
1cbce7ea
by Timur Kristóf at 2025-11-17T09:54:33-08:00
ac/gpu_info: Disable sparse VM mappings pre-Polaris, for now
Disable sparse mappings on GFX7-8 due to GPU hangs in the VK CTS,
except Polaris where it happens to work "well enough" to pass
the VK CTS and run some games already.
Cc: mesa-stable
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
(cherry picked from commit 567e1b56ef9de920401f834a3f595faf978f9bc0)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
51a21fa5
by David Rosca at 2025-11-17T09:54:34-08:00
vulkan/video: Fix coding AV1 seq_choose_screen_content_tools = 1
Fixes: 724655bfc6b ("vulkan/video: add support for AV1 encoding to runtime")
Reviewed-by: Hyunjun Ko <zzoon@igalia.com>
Reviewed-by: Benjamin Cheng <benjamin.cheng@amd.com>
(cherry picked from commit 22803f0d503065c1e7756c076ec0440f6626dd82)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
b951bbc5
by David Rosca at 2025-11-17T09:54:35-08:00
radv/video: Fix coding allow_screen_content_tools and force_integer_mv
This was copied from radeonsi which expected seq_force_screen_content_tools = 2
and seq_force_integer_mv = 2.
Fixes: 37e71a5cb24 ("radv/video: add support for AV1 encoding")
Reviewed-by: Benjamin Cheng <benjamin.cheng@amd.com>
(cherry picked from commit 3858a6a696dfa4106ff81f69f99cc0662e58679f)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
8ddecf22
by Christoph Pillmayer at 2025-11-17T09:54:35-08:00
nir: Fix preseved metadata in sort_unstructured_blocks
Fixes: c859ea5783b ("nir: Add a sort_unstructured_blocks() helper")
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Mel Henning <mhenning@darkrefraction.com>
(cherry picked from commit 8db66767a9f0243bcd0da32891a005db548ab126)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
7bdac1e6
by David Rosca at 2025-11-17T09:54:36-08:00
radv/video: Fix coding used_by_curr_pic_lt_flag
Fixes: d68a1fc0d43 ("radv/video: port hevc slice header encoding from radeonsi")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/14301
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
(cherry picked from commit 3abb2707e2dee5975fd453f2026c615d2a2d6f1a)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
f966640d
by Calder Young at 2025-11-17T09:54:36-08:00
brw: fix SIMD lowering of fp16 sampler message data with multiple components
Fixes: 61d6aea4 ("brw: fix SIMD lowering of sampler messages with fp16 data")
Closes: mesa/mesa#13149
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
(cherry picked from commit d6fbbfef5ca656a6344346c785dc409024ede32e)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
8c796df8
by Erik Faye-Lund at 2025-11-17T09:54:37-08:00
pan/kmod: fix priority query logic
The PANFROST_JM_CTX_PRIORITY values aren't bitmasks, but enum values.
But the kernel interface uses the BIT()-macro on them, so we need to do
the same. We don't have the macro, but it's trivial to do this with a
bitshift instead.
Fixes: f04dbf0bc0b ("pan/kmod: query and cache available context priorities from KMD")
CID: 1666511
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com>
(cherry picked from commit 37a7a157e8b8aed9631a0687d7018641b0255db0)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
5238c8d0
by Erik Faye-Lund at 2025-11-17T09:54:38-08:00
panfrost: remove stale code
This code was no longer needed after switching to os_read_file, but I
accidentally left it around, whoops!
Fixes: 49183bfb791 ("pan/bi: use os_read_file-helper")
CID: 1665295
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com>
(cherry picked from commit d77279fa9b60b3566821f6041a1db361c484f706)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
ddb16614
by Patrick Lerda at 2025-11-17T09:54:38-08:00
r600: fix rv770 read scratch compatibility
The flag mega_fetch should be set on rv770 for a
read scratch operation (as written in the r700
documentation p357). Without this flag, read scratch
does not work and a gpu hang could be triggered.
Here are the tests fixed:
shaders/glsl-predication-on-large-array: fail pass
spec/glsl-1.10/execution/temp-array-indexing/glsl-fs-giant-temp-array: fail pass
spec/glsl-1.10/execution/temp-array-indexing/glsl-vs-giant-temp-array: fail pass
spec/glsl-1.30/execution/fs-large-local-array: fail pass
spec/glsl-1.30/execution/fs-large-local-array-vec2: fail pass
spec/glsl-1.30/execution/fs-large-local-array-vec3: fail pass
spec/glsl-1.30/execution/fs-large-local-array-vec4: fail pass
spec/glsl-1.30/execution/fs-multiple-large-local-arrays: fail pass
Fixes: 9c48a139b08f ("r600g: Support emitting scratch ops")
Signed-off-by: Patrick Lerda <patrick9876@free.fr>
(cherry picked from commit f8de09a811fc1f5b8733e1a36bafd55c778139be)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
8a428651
by Dylan Baker at 2025-11-19T09:23:46-08:00
.pick_status.json: Update to 7a3bfd1f7913819db315e6db8b42520a2d862690
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
fce07c7f
by David Rosca at 2025-11-19T09:23:51-08:00
radeonsi/vce: Add workaround for unaligned input surface
VCE requires 16x16 aligned input surface. Blit into an internal
scratch surface when input surface is not 16 aligned.
Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/14270
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
(cherry picked from commit 17c015c2de7f4a8c5a2459e332424030f2e89ecc)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
229e6040
by Lionel Landwerlin at 2025-11-19T09:23:52-08:00
brw: fix workaround fence rlen field
send.ugm (1|M0) r125 r0 null:0 0x0 0x0200651F {$9} // wr:1+0, rd:0; fence invalid flush type scoped to tile
When destination of Send(s) is not null, the response length must not be 0.
Should only affect DG2 products.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: mesa-stable
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com>
(cherry picked from commit 4816318887d63dddca16480cd953e336662324ad)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
9fbbbc99
by Olivia Lee at 2025-11-19T09:23:52-08:00
panvk/csf: fix uninitialized read in draw context
We check fn_set_fbds_provoking_vertex_stride == 0 to determine whether a
previous function variant has already been allocated, so this value must
be initialized to zero before we start the loop. We could fix this by
explicitly initializing just that field, but I figure it's simpler and
safer to just zero-initialize the whole struct.
Signed-off-by: Olivia Lee <olivia.lee@collabora.com>
Fixes: 885805560f9 ("panvk/csf: fix case where vk_meta is used before PROVOKING_VERTEX_MODE_LAST")
Reviewed-by: Eric R. Smith <eric.smith@collabora.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
(cherry picked from commit e899bc8be8cb725ca7a4a76ffccf2888db3db751)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
1d97f7da
by Olivia Lee at 2025-11-19T09:23:53-08:00
panvk/csf: explicitly set ls_sb_slot in set_fbds_provoking_vertex
SB_ID(LS) is currently equal to zero, so this is not a behavior change,
but worth setting it explicitly for clarity and in case the sb
assignments change.
Signed-off-by: Olivia Lee <olivia.lee@collabora.com>
Fixes: 885805560f9 ("panvk/csf: fix case where vk_meta is used before PROVOKING_VERTEX_MODE_LAST")
Reviewed-by: Eric R. Smith <eric.smith@collabora.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
(cherry picked from commit ebbf05f9d2f98bb0d93a527f660195200fd0ba61)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
db8281fd
by Lionel Landwerlin at 2025-11-19T09:23:54-08:00
anv: fixup load_ubo lowering
Use ult like nir_lower_explicit_io.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: mesa-stable
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com>
(cherry picked from commit 775f8ec105c77c0d294e62d1a76e8e1165ad4ca2)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
e4d77530
by Lionel Landwerlin at 2025-11-19T09:23:54-08:00
anv: ensure slab allocated memory matches image requirements
The VMA of VkDeviceMemory has to accomodate all the resources that can
be bound to it. For sparse images it's 64KiB alignment, for other
tiled images it's 4KiB. But we also have a workaround that requires a
64KiB alignment for Tile4 images.
The initial version of the slab allocator missed the 4KiB alignment.
This fix adds the workaround handling too.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: dabb012423 ("anv: Implement anv_slab_bo and enable memory pool")
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
(cherry picked from commit 401b2066b053ab4882d90a76628e3edfd70be936)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
a7ed5d61
by Timothy Arceri at 2025-11-19T09:23:55-08:00
mesa: fix _mesa_update_texture_matrices()
_math_matrix_is_dirty() should only be used to decide if we need to
run _math_matrix_analyse(). We already decided that we had a new
texture matrix when we called _mesa_update_texture_matrices() so
we need to set _TexMatEnabled correctly otherwise we might
incorrectly return _NEW_FF_VERT_PROGRAM | _NEW_FF_FRAG_PROGRAM in
the following if-statement.
Fixes: ec978e002f59 ("mesa: only update fixed-func programs on texture matrix enablement changes")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/14286
Reviewed-by: Emma Anholt <emma@anholt.net>
(cherry picked from commit b0047be0c253d1fdaf8ba015704deb5380ce7fc3)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
57ea82d8
by Karol Herbst at 2025-11-19T09:23:55-08:00
rusticl/kernel: fix clGetKernelSuggestedLocalWorkSizeKHR implementation
There were two issues:
1. The global_work_offset parameter is optional but we errored on NULL
2. We didn't return the reqd_work_group_size when set on the kernel.
Fixes: 376d1e6667a ("rusticl: implement cl_khr_suggested_local_work_size")
(cherry picked from commit 810dca450cde704f9ba9238963d94b6860acf08a)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
eb51b0b3
by Karol Herbst at 2025-11-19T09:23:56-08:00
rusticl/kernel: Do not run kernels with a workgroup size beyond work_dim
When no workgroup size is specified we try to run with the most optimal one
possible. However we didn't take into account that we shouldn't run a
workgroup of higher dimensionality than requested by the application.
Fixes: 376d1e6667a ("rusticl: implement cl_khr_suggested_local_work_size")
(cherry picked from commit d46be8fbf2cf784c2c940c3524b4cf5fcc020853)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
9618c54d
by Natalie Vock at 2025-11-19T09:23:57-08:00
aco/insert_nops: Consider s_setpc target susceptible to VALUReadSGPRHazard
Some GPU hangs witnessed in the wild on RDNA4 in Control and Arc Raiders
seem to point towards closest-hit shaders reading a stale value for the
SGPR pair containing the currently-executing shader's address.
This SGPR pair was read by VALU in the preceding traversal shader,
making it susceptible to VALUReadSGPRHazard. Inserting
VALUReadSGPRHazard mitigations before accessing the s_setpc target seems
to fix the hang. We don't have conclusive proof that this is hazardous,
but given that all signs point towards it and we have a reasonably
simple workaround, let's roll with this for now to mitigate the hangs.
Cc: mesa-stable
(cherry picked from commit 1243d575a576881b463a0b1dff92a09e429f095b)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
e583dc11
by Yiwei Zhang at 2025-11-19T09:23:57-08:00
venus: avoid re-imported dma-buf to have a larger map size
If the allocation originates from the same instance, the tracker map
size follows the allocationSize. After export and re-import, mapping the
whole dma-buf can exceed the original map size. This change backs out
the offending changes.
Test: dEQP-VK.api.external.memory.*.suballocated.host_visible.*
Fixes: 442f242a495 ("venus: requests whole blob mem size for non-dedicated import")
(cherry picked from commit c259ea24eea24868cfd0556316e1daaec6277321)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
3c8fb620
by Yiwei Zhang at 2025-11-19T09:23:58-08:00
venus: properly fix the blob mem mapping size
There's a single underlying bo mapping shared by the initial alloc here
and the later import of the same. The mapping size has to be initialized
with the real size of the created blob resource, since the app can query
the exported native handle size for re-import. e.g. lseek dma-buf size
Similar to virtgpu_bo_create_from_device_memory, the app can do multiple
imports with different sizes for suballocation. So on the initial
import, the mapping size has to be initialized with the real size of the
backing blob resource.
Backport-to: 25.3
(cherry picked from commit 0afc408cb9b66c15a20485557d89377eb95cebd6)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
d9cbd8ce
by David Rosca at 2025-11-19T09:23:58-08:00
radeonsi/vcn: Reduce allocated size for pre-encode recon pics
We use 4x downscale for pre-encode, so we don't need full size
pre-encode reconstructed pictures.
Cc: mesa-stable
Reviewed-by: Benjamin Cheng <benjamin.cheng@amd.com>
(cherry picked from commit 1f83e731451b84b16cc1fa2f04b46a71a66e43ff)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
5dde2812
by Erik Faye-Lund at 2025-11-19T09:23:59-08:00
mesa/main: correct formatquery error-handling
Most of the time, we remember to check for both extensions. But in one
case, it seems we forgot the GLES extension. Whoops.
Let's switch to a helper here, so we don't have to repeat the logic over
and over again.
Fixes: b4c0c514b10 ("mesa: add OES_texture_buffer and EXT_texture_buffer support")
Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com>
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
(cherry picked from commit 9d5e0c1ad27102f496161bee4ee0011d0f5c4b3b)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
798ec2e2
by Erik Faye-Lund at 2025-11-19T09:23:59-08:00
mesa/st: do not enable EXT_texture_buffer_object with rgba only
GL_EXT_texture_buffer_object requires support for alpha, luminance,
luminance-alpha and intensity formats. If we can't support those, we
can't enable the extension.
Fixes: 45ca7798dc3 ("glsl: handle interactions between EXT_gpu_shader4 and texture extensions")
Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com>
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
(cherry picked from commit 6f2b8c3f615af6a38b3da3fb5094b8b4390e64f2)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
28874a99
by Lionel Landwerlin at 2025-11-19T09:39:00-08:00
anv: consider 64bit atomics on similar formats with mutable images
vkd3d-proton uses a R32G32_UINT image with MUTABLE
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: ed77f67e44 ("anv: add emulated 64bit integer storage support")
Acked-by: Nanley Chery <nanley.g.chery@intel.com>
(cherry picked from commit 73bf51dba087bb30378a5773c59033099254db42)
Conflicts:
src/intel/ci/anv-adl-vkd3d-fails.txt
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
e0669e19
by Dylan Baker at 2025-11-21T14:22:46-08:00
.pick_status.json: Update to 7c193ffef1a8316b4b666c9c2ec5afdd2035dd89
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
052f8bde
by Eric R. Smith at 2025-11-21T14:22:47-08:00
pan: fix a bifrost disassembly assert failure
We were overflowing an array during bifrost disassembly. This was
only a problem if the user explicitly set an environment variable,
so unlikely to occur in casual use, and also only could be triggered
in very specific, dense code. But we still should get this right!
The specific CTS test that caused the assert is:
'dEQP-VK.graphicsfuzz.stable-quicksort-for-loop-with-injection'
with environment variable `BIFROST_MESA_DEBUG=shaders`. One of the
shaders has a clause with 6 constants (the maximum) and this overflowed
the array because we assume we always have an extra slot (used for
modifier processing).
Cc: mesa-stable
Reviewed-by: Christoph Pillmayer <christoph.pillmayer@arm.com>
(cherry picked from commit 65ba14519ea23193c85cc20729dd31194a49382c)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
aaca86cd
by Mel Henning at 2025-11-21T14:22:48-08:00
zink: Return zink_device in create_logical_device
Fixes: 015eda4a4186c ("zink: deduplicate VkDevice and VkInstance")
Reviewed-by: Dave Airlie <airlied@redhat.com>
(cherry picked from commit f0dc8c0224fce3c2288ee30a4ec4bed088e06c72)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
81f1cefc
by Mel Henning at 2025-11-21T14:22:49-08:00
zink: Make screen->queue_lock a pointer
Fixes: 015eda4a4186c ("zink: deduplicate VkDevice and VkInstance")
Reviewed-by: Dave Airlie <airlied@redhat.com>
(cherry picked from commit dff1b9d4e9f0b66dc60ddafdd0f6726adfa8b47d)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
3b6f03bd
by Mel Henning at 2025-11-21T14:22:49-08:00
zink: Create one queue lock per device
We currently only create one queue per queue family on the device. The
device can be shared between multiple zink_screens, so having one lock
per screen can still lead to multiple locks per queue. Fix this by
allocating queue_lock along with the device.
This fixes an issue that was causing crashes with nvk+zink and
QtWebEngine with QTWEBENGINE_FORCE_USE_GBM=1 This can be reproduced by
resizing the window in either:
* anki - https://apps.ankiweb.net/ or
* Qt's simplebrowser example
https://doc.qt.io/qt-6/qtwebengine-webenginewidgets-simplebrowser-example.html
which would then cause this dmesg error:
nouveau 0000:01:00.0: anki[92007]: Failed to find syncobj (-> in): handle=40
along with a context loss.
With VK_LOADER_LAYERS_ENABLE=VK_LAYER_KHRONOS_validation we would additionally
get warnings like:
Validation Error: [ UNASSIGNED-Threading-MultipleThreads-Write ] | MessageID = 0xa05b236e
vkQueueSubmit(): THREADING ERROR : object of type VkQueue is simultaneously used in current thread 139824449189568 and thread 139823901816512
Objects: 1
[0] VkQueue 0x557a666783e0
Fixes: 015eda4a4186c ("zink: deduplicate VkDevice and VkInstance")
Reviewed-by: Dave Airlie <airlied@redhat.com>
(cherry picked from commit 9acce36652b4c56948a5333c729d3b5646190b3d)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
7c1705c1
by Mel Henning at 2025-11-21T14:22:50-08:00
zink: Lock queue_lock in zink_destroy_screen
Fixes: 015eda4a4186c ("zink: deduplicate VkDevice and VkInstance")
Reviewed-by: Dave Airlie <airlied@redhat.com>
(cherry picked from commit 018178842efafda13344e2726901f22d470fce1b)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
5b6d0438
by Mel Henning at 2025-11-21T14:22:50-08:00
zink: Lock around screen_debug_marker_{begin,end}
vkQueueBeginDebugUtilsLabelEXT and vkQueueEndDebugUtilsLabelEXT
require queue to be externally synchronized, which means these functions
require the lock. Unfortunately, there's no guarantee that the debug
markers will be matched in the multithreaded case, but I suppose this is
better than crashing.
Fixes: 015eda4a4186c ("zink: deduplicate VkDevice and VkInstance")
Reviewed-by: Dave Airlie <airlied@redhat.com>
(cherry picked from commit 80db8171debdf68edcc64ddd73280a95fb1a8367)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
8069763b
by Yonggang Luo at 2025-11-21T14:22:51-08:00
ci/microsoft: Downgrading WinFlexBison.win_flex_bison to version 2.5.24
This is achieved by provide version parameter to winget-cli
Fixes: 9592686ca0d ("ci/windows: Use winget to install packages and install Microsoft.WindowsWDK.10.0.26100")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13968
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
(cherry picked from commit 84cce2a739100dca3e1ab3616d3c29a1174538d4)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
58854773
by Samuel Pitoiset at 2025-11-21T14:22:53-08:00
radv: fix RB+ for depth-only with unused attachments
When there are no color outputs in the rendering state, but color write
enable/write aren't masked out (which seems legal with
VK_EXT_dynamic_rendering_unused_attachments), the driver must emit
CB_DISABLE to disable CB rendering completely.
Otherwise, if there is also a depth/stencil attachment in the rendering
state, CB0 is always set to 32_R for RB+. That means, the pixel shader
would still export fragments but to the previously bound color
attachment.
VKCTS is missing coverage.
Fixes: 4580293ab2c ("radv: implement RB+ depth-only rendering for better perf")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/14319
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
(cherry picked from commit 168a8d0b520aa09105e633b9857ea62d44a98adc)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
72c77df9
by Lionel Landwerlin at 2025-11-21T14:22:54-08:00
anv: Wa_18040903259 only applies to RCS when in GPGPU mode
Sadly this probably won't change anything in terms of perf as the CCS
engine has a bunch of other restrictions.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 243c01c703 ("anv/iris: implement Wa_18040903259")
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com>
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com>
(cherry picked from commit 07b7de35cca7142948e435697b1da1e69a67f747)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
3134ebd3
by Pierre-Eric Pelloux-Prayer at 2025-11-21T14:22:55-08:00
radeonsi/sqtt: clear out sqtt bo on resize
If the resizing fails, we shouldn't use the destroyed bo anymore.
Fixes: 5794a86f191 ("radeonsi/sqtt: support sqtt buffer auto-resizing")
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
(cherry picked from commit bac9d17ead01467258e706973fdf193b9da26062)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
54828a0b
by Yurii Kolesnykov at 2025-11-21T14:22:57-08:00
loader: Wrap nouveau_zink_predicate with HAVE_LIBDRM
Signed-off-by: Yurii Kolesnykov <root@yurikoles.com>
Fixes: 265afd9bfde ("loader: Don't fall back to nouveau GL without zink")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/14290
Reviewed-by: Mel Henning <mhenning@darkrefraction.com>
(cherry picked from commit 4913177b1477306809224a097f3a1ed26ab996e9)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
4eac81ed
by Matt Turner at 2025-11-21T14:22:58-08:00
meson: Fix sysprof-capture-4 dependency
The versioning scheme changed in v45.0 (the previous version was
3.48.0). As such, this version check would wrongly accept e.g. 48.0.
Fixes: e9341568fa9 ("meson: require sysprof-capture-4 >= 4.49.0")
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
(cherry picked from commit ad149423002363b2ebd6fb225851febeb4039b1b)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
1400d547
by Dylan Baker at 2025-11-21T14:37:39-08:00
.pick_status.json: Update to bcedc88f2142d9a2b277c7b848b744e13d426f76
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
6cd6fc82
by Dylan Baker at 2025-12-01T09:16:12-08:00
.pick_status.json: Update to 076a3834374b2ccd43dd1c7ce73f44795d601300
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
1e2bf818
by Rob Clark at 2025-12-01T09:16:29-08:00
freedreno/a6xx: Fix UB in convert_color()
Swizzle can include PIPE_SWIZZLE_0/_1 (4 and 5) which result in indexing
beyond the channel array.
Reported-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Fixes: 76e350671f3b ("freedreno/a6xx: Sysmem clear fixes")
Signed-off-by: Rob Clark <rob.clark@oss.qualcomm.com>
(cherry picked from commit f0465ced7f9924d0be8e219ed0afe907994bd516)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
005d8a87
by Matt Turner at 2025-12-01T09:16:29-08:00
meson: Let -Ddraw-use-llvm=false work for R300 on non-x86
Prior to commit b8b38d38b1c ("meson: reinstate LLVM requirement for r300
and enforce it for i915 too") it was possible to build and use r300 for
architectures that do not have LLVM (e.g., alpha).
The only SWTCL chips are integrated graphics in x86 systems, and are not
available in discrete cards.
Fixes: b8b38d38b1c ("meson: reinstate LLVM requirement for r300 and enforce it for i915 too")
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
(cherry picked from commit 4235c39a9a8378f1e2dc0899dd4c3c941f27b887)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
fb984d28
by Eric Engestrom at 2025-12-01T09:16:30-08:00
meson: auto-disable `amd-use-llvm` when `llvm=disabled`
The option's description is:
> Whether to use LLVM for the AMD drivers, if LLVM is included.
Let's disable it right away if LLVM is disabled, to avoid configurations
like the one in the issue below from failing.
Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/14306
(cherry picked from commit 69bb927ebfc40b81b30e38a59c1aa4b0593f73e8)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
0648e0a2
by Eric Engestrom at 2025-12-01T09:16:31-08:00
meson: auto-disable `draw-use-llvm` when `llvm=disabled`
The option's description is:
> Whether to use LLVM for the Gallium draw module, if LLVM is included.
Let's disable it right away if LLVM is disabled, to avoid some
configurations from failing.
Cc: mesa-stable
(cherry picked from commit 37c7d19e46a4863c120186a99ac0344c2dd31260)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
4988213f
by Dave Airlie at 2025-12-01T09:16:32-08:00
dozen: return INCOMPATIBLE_DRIVER on instance create failure
When probing on generic Linux platforms, the loading of d3d12 and
the first init of could fail, but the error returned causes a
loader warning to be printed.
Use the correct error return to stop this.
Cc: mesa-stable
(cherry picked from commit c00b66fa71aba9dd980a3568239576f1ef9a8cd7)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
c9a52df8
by Lionel Landwerlin at 2025-12-01T09:16:33-08:00
brw: compute final copy propagation resulting source
Fixes this test on Xe2+:
INTEL_DEBUG=no32 ./deqp-vk -n dEQP-VK.spirv_assembly.instruction.maint9_vectorization.bit_field_u_extract.result_v16i-base_v16i-offset_s64u-count_s16i
Generate invalid code for that platform:
and(16) g37<1>UW g65<16,4,4>UW 0x000fUW { align1 1H I@5 };
ERROR: Invalid register region for source 0. See special restrictions section.
Several helpers like has_subdword_integer_region_restriction() do not
see the final type of the source, so compute it early.
Maybe new_src could be used in more cases. Being conservative for now.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: mesa-stable
Reviewed-by: Francisco Jerez <currojerez@riseup.net>
(cherry picked from commit 8f9acc0150439dd21e2004967425701bd4a8a523)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
3cdda99e
by Eric Engestrom at 2025-12-01T09:16:33-08:00
ci: use $CI_TRON_JOB_PRIORITY tag on all ci-tron jobs
Moving `ci-tron:priority:` out of the variable because an empty value
will not be authorized, and this makes it obvious if that bug ever
happens (job will not be picked up and gitlab will complain that
`ci-tron:priority:` is not a tag registered by any runner), instead of
getting picked up by any runner that will then reject (fail) the job.
(This is caused by GitLab's API not allowing tags to be enforced when
picking up jobs, resulting in jobs with missing tags being picked up by
any runner, like the bug we had with the generic fd.o runners a few
months ago.)
v2 (Martin Roukala):
* use the priority tags in all amdgpu jobs
* add missing tags in etnaviv jobs
* add missing tags in broadcom jobs
Cc: mesa-stable
(cherry picked from commit 53fe1f39a02d2b68eb2f0101bd88d4ea6d77bda8)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
33abe4a4
by Hyunjun Ko at 2025-12-01T09:16:34-08:00
vulkan/video: Fix H.265 long-term reference handling
Without these fixes, H.265 streams using long-term references would
fail to decode correctly as the decoder wouldn't distinguish between
short-term and long-term reference frames.
Fixes: 896f95a37e ("vulkan/video: fix h265 decoding with LT enabled.")
Signed-off-by: Hyunjun Ko <zzoon@igalia.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
(cherry picked from commit 01de6ac1340114dac47b27e6f5d243c4c1c399a8)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
6599a0ea
by Patrick Lerda at 2025-12-01T09:16:34-08:00
r600: fix error filters compatibility
The shader-db functionality was interfering with the error
filters.
Two new options are added: R600_DEBUG=shaderdb and
R600_DEBUG=precompile. The option precompile is added
to maintain the compatibility with the shader-db repository.
This change fixes 22 of these tests:
deqp-gles31/functional/debug/error_filters/case_.*: warn pass
deqp-gles31/functional/debug/error_groups/case_.*: warn pass
Fixes: 28d6a5af252f ("r600: Add shader precompile and shader-db support.")
Signed-off-by: Patrick Lerda <patrick9876@free.fr>
(cherry picked from commit f005c0b5adc975c247effb250798a4eba625e1ef)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
e32d0815
by Ian Forbes at 2025-12-01T09:16:35-08:00
svga: Check if Stencil buffer is NULL
Fixes a nullptr dereference on older HW versions.
Fixes: f29d9398242 ("svga: rework framebuffer state")
Signed-off-by: Ian Forbes <ian.forbes@broadcom.com>
(cherry picked from commit 4e16a5b68bbec9351a524e369176a3e62c7e72f5)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
bbbee1f8
by Rob Clark at 2025-12-01T09:16:36-08:00
freedreno: Fix internal VBO reference leak
It appears that this extra ref is no longer needed. And not dropped
anywhere.
Fixes: b3133e250e1c ("gallium: add pipe_context::resource_release to eliminate buffer refcounting")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/14315
Signed-off-by: Rob Clark <rob.clark@oss.qualcomm.com>
(cherry picked from commit cccdbbc3605ad89ebc43efd1ab9703ca0f0dba67)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
1f1f0d5a
by Tapani Pälli at 2025-12-01T09:16:36-08:00
drirc/iris: add drirc to disable threaded context
Cc: mesa-stable
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
(cherry picked from commit 4daabf76b4fad4ba1e8fd6cfc700f5faaf35f62c)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
e6c814c4
by Tapani Pälli at 2025-12-01T09:16:37-08:00
drirc: set intel_disable_threaded_context for Amnesia The Bunker
Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/14084
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
(cherry picked from commit 21f646d19696e12fd771d35165414530bbd71c5e)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
7882a413
by Faith Ekstrand at 2025-12-01T09:16:37-08:00
vulkan/drm-syncobj: Stop returning early waiting for sync files
In the WAIT_ALL case in spin_wait_for_sync_file(), we were returning the
moment we saw the first success. However, this isn't a wait-all, it's a
bad wait-any. We should instead just continue on to check the next sync
until we've ensured that every sync in the array has a sync file. The
only reason this wasn't blowing up in our face is because it only
affects non-timeline drivers (pretty rare these days) and because most
of the places where we use WAIT_PENDING on non-timeline drivers is to
guard a sync file export and those typically have only a single sync in
the array.
Cc: mesa-stable
Reviewed-by: Gurchetan Singh <gurchetansingh@google.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
(cherry picked from commit e4e619d68532c882e6d1ececb8b4a6d3e5a48b0d)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
93d5e37c
by Samuel Pitoiset at 2025-12-01T09:16:38-08:00
radv: fix per-submit RGP captures on video queues
SQTT user data packets aren't supported either.
Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
(cherry picked from commit af461de0265734b0989074d6f9d615621a0e3231)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
54277ca7
by Valentine Burley at 2025-12-01T09:16:38-08:00
egl: Disable kopper on Android
Kopper is not supported on Android, and attempting to use it breaks zink
on the platform.
Disable kopper automatically when running on Android, fixing zink without
`LIBGL_KOPPER_DISABLE`.
Fixes: 3294cad3415 ("egl: Rename dri2_detect_swrast() and also detect kopper")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/14331
Signed-off-by: Valentine Burley <valentine.burley@collabora.com>
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
Reviewed-by: Antonio Ospite <antonio.ospite@collabora.com>
(cherry picked from commit 8a1ea724b49f0f18a8d4609e9f7ee191a084d718)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
e1eaedbd
by Lionel Landwerlin at 2025-12-01T09:16:39-08:00
nir: fix lower_printf with no arguments
SPIRV generated printf with no arguments have an undef source (not the
expected deref).
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: mesa-stable
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com>
(cherry picked from commit 6940b8fcd714a1b596cc672935e36b2c59c53f33)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
45bd0be0
by Lionel Landwerlin at 2025-12-01T09:16:40-08:00
spirv: fix printf generation
Not having the uses_printf will drop the printf info in serialization.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: mesa-stable
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com>
(cherry picked from commit 67faf6dfbdadfc9d19859bcb9fe6dfc77d2edb78)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
97d5911e
by Lionel Landwerlin at 2025-12-01T09:16:40-08:00
nir/lower_printf: fix array alignment
The pointer arithmetic doesn't need a 4byte alignment, otherwise
everything is broken.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: mesa-stable
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com>
(cherry picked from commit d24633023fce91f15a76041aa0e32b98421a5e8c)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
142c3923
by Lionel Landwerlin at 2025-12-01T09:16:41-08:00
nir/lower_printf: fix missing singleton add
If we're using the singleton, we need to add to it.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: mesa-stable
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
(cherry picked from commit 4b9aa9dc91c5deb18c4e5b4e0c2e50012a8663d1)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
8e9da720
by Natalie Vock at 2025-12-01T09:16:41-08:00
radv/rt: Keep updated nodes always active
In updateable AS, we keep all nodes active even if they're
degenerate/NaN, because too many games ignore API rules about not
making inactive nodes active (and some vendor tips outright advise this
behavior). We also need to match this by keeping everything active in
the update side. The ALWAYS_ACTIVE macro has been long removed and
replaced by VK_BVH_BUILD_FLAG, too. Since updating only happens to
updateable AS, don't even check for the flag, just implement the
always-active handling.
Cc: mesa-stable
(cherry picked from commit bc1eea90b961c8a3bb4dcf8124e850ef777c35a3)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
681e8b7e
by Natalie Vock at 2025-12-01T09:16:42-08:00
radv/rt: Correctly copy culling flags when updating to separate AS
This was missing and led to the field being uninitialized.
Cc: mesa-stable
(cherry picked from commit b7f011e6535b118fc058441d4527cdd5f33e15ea)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
c2058172
by David Rosca at 2025-12-01T09:16:48-08:00
radeonsi/vcn: Fix maybe uninitialized warning
Backport-to: 25.3
Reviewed-by: Benjamin Cheng <benjamin.cheng@amd.com>
(cherry picked from commit 1884b03a10e87d5bd0528593a2f0814a1f8f7711)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
11d5d20e
by Ian Romanick at 2025-12-01T09:16:49-08:00
brw: Force allow_spilling when spill_all is set
This ensures that g0 is reserved for spilling since there is going to be
spilling.
Fixes: 8bca7e520ce ("intel/brw: Only force g0's liveness to be the whole program if spilling")
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
(cherry picked from commit 1fc2f52d36211c753bb94cd5d46ec1c4d3d0dd46)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
f21dca71
by Calder Young at 2025-12-01T09:16:50-08:00
anv: Fix ray query shadow stack buffer size
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com>
Cc: mesa-stable
(cherry picked from commit 09e8a540876877723d15fff0e511e9abc274254e)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
1430b06e
by Pierre-Eric Pelloux-Prayer at 2025-12-01T09:16:51-08:00
mesa: fix function prototype
Replace void* by GLvoid* and add GLAPIENTRY to match the gl_API.xml
version.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/14164
Fixes: ae75b59cb52 ("glthread, tc: Fix buffer release with glthread and tc")
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
(cherry picked from commit 671e943c9b96e8d518eedaf972bb095b61b8ad09)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
5693ff3e
by Emma Anholt at 2025-12-01T09:16:52-08:00
tu: Fix leak of compute shader pipeline->base.executables_mem_ctx;
Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/14358
(cherry picked from commit 89da258e71983d7f89f1f0b81552995a2c824ccc)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
0e019bd7
by Timothy Arceri at 2025-12-01T09:16:52-08:00
util/driconf: Add linux version of Penumbra fixes
Cc: mesa-stable
(cherry picked from commit d10036362f6fbcc164cbd68686fbc8b62df18e3c)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
7b0ce4bd
by Tapani Pälli at 2025-12-01T09:16:53-08:00
anv: add furmark workaround layer
Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/14274
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
(cherry picked from commit ba89826b750512b6ad0691fc2f970ae740e9ca52)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
a977cd49
by Calder Young at 2025-12-01T09:16:54-08:00
intel: Fix calculation of max_scratch_ids on fused devices
The subslice IDs provided by the SR0.0 EU register are not adjusted to account
for fusing, so the upper bound max_scratch_ids can vary from device to device
depending on what specific slices were fused during manufacturing.
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: mesa-stable
(cherry picked from commit c0d809820f35378928f719c1e2ddba9a41d5fbd9)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
0997cc67
by Benjamin Cheng at 2025-12-01T09:16:54-08:00
radv/video: Fix num_ref_idx_l{0,1} related overrides
Since we only support 1 L0/L1 ref, the default num refs in the PPS
should always be 0. With that there never any need to set the override
flag in the slice header (until more references are supported).
Also the ref pic list modifications should be clamped to the size of the
ref pic list.
This fixes an issue seen with dEQP-VK.video.encode.h264.i_p_b_13_*.
Cc: mesa-stable
Reviewed-by: David Rosca <david.rosca@amd.com>
(cherry picked from commit 2e21eec921f6a854085e37fe1200e243d611fa1e)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
e9956932
by Benjamin Cheng at 2025-12-01T09:16:55-08:00
radv/video: Fix H264/H265 reference selection
The order of pReferenceSlots is not well-defined by spec. Instead we
need to look at the RefPicList0/1 which provides slot indices.
Cc: mesa-stable
Reviewed-by: David Rosca <david.rosca@amd.com>
(cherry picked from commit ab56ce154bbb7fbec19ccffb40cf4c1e8085230d)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
de081cee
by Benjamin Cheng at 2025-12-01T09:16:56-08:00
radv/video: Override direct_spatial_mv_pred to 1
VCN always uses spatial direct mode.
Cc: mesa-stable
Reviewed-by: David Rosca <david.rosca@amd.com>
(cherry picked from commit 9e37969179f46bc90282dc3107175c93e9f45b29)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
212f734e
by Qiang Yu at 2025-12-01T09:16:56-08:00
glsl: support barrier() for task and mesh shader
It was ignored when translating glsl to nir.
Fixes: d52452a486c ("glsl: allow barrier builtin functions for mesh shader")
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
(cherry picked from commit 2f6a034528bc4f8a2cdeae9e7b36645ded4fa465)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
610dbae3
by Dylan Baker at 2025-12-02T10:11:59-08:00
.pick_status.json: Update to a71b4a4b954dcfc1667dc1b36f1f25ac02d3469b
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
3e8ecfed
by Aitor Camacho at 2025-12-02T10:12:06-08:00
vulkan/cmd_queue: Use vk_strdup and free allocated string memory
Fixes: 9082715ab01 ("vk/cmd_queue: generate copies for string struct members")
Reviewed-by: Karmjit Mahil <karmjit.mahil@igalia.com>
Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Signed-off-by: Aitor Camacho <aitor@lunarg.com>
(cherry picked from commit 16c98f4f180203ba73ce4c1eab20eb666f3b3d2b)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
27a88241
by Gurchetan Singh at 2025-12-02T11:00:27-08:00
util: fix arithmetic on a pointer to void warning
Otherwise, the following error is observed:
src/util/cache_ops_x86_clflushopt.c:40:22:
error: arithmetic on a pointer to void is a GNU extension [-Werror,-Wgnu-pointer-arith]
40 | void *end = start + size;
| ~~~~~ ^
src/util/cache_ops_x86_clflushopt.c:44:9:
error: arithmetic on a pointer to void is a GNU extension [-Werror,-Wgnu-pointer-arith]
44 | p += cpu_caps->cacheline;
| ~ ^
This works with GNU extension enabled, but does lead to warnings
with Clang.
v2: Add to trial_c + trial_cpp checks (Erik)
v3: use c_msvc_compat_args to avoid fixing other instances of this issue (Erik)
Fixes: 555881e5749 ("util/cache_ops: Add some cache flush helpers")
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
(cherry picked from commit 14cfe14626062ca36ecb62b1b1bf7e14228300b3)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
1ee37555
by Tapani Pälli at 2025-12-02T11:00:27-08:00
anv: add vk_wsi_disable_unordered_submits and enable for GTK
See radv change 0d9d45db4e1 for further explanation.
Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/14354
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
(cherry picked from commit b2b5e83894a4e1dec0cd62f73f5598dd4e50c264)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
c24290a9
by David Rosca at 2025-12-02T11:00:27-08:00
radv/video: Fix AV1 quantization map maxQIndexDelta value
Fixes: ae6ea69c851 ("radv: Implement VK_KHR_video_encode_quantization_map")
Reviewed-by: Benjamin Cheng <benjamin.cheng@amd.com>
(cherry picked from commit 2b2914d81fc930fbce3d596e9d6b11298670505c)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
9586b509
by Lionel Landwerlin at 2025-12-02T11:01:45-08:00
vulkan/runtime: track dynamic descriptor offsets for RT pipelines
Dynamic descriptors are mapped an array of offsets provided through
vkCmdBindDescriptorSets*() commands.
When pipelines are compiled with independent sets layouts, the
implementation might have to do additional runtime calculation to
figure out what offset in the contiguous array maps to what dynamic
descriptor in the pipeline layout.
For graphics pipelines you can always compute that information when
binding the shaders. There is always a limited amount of shaders (5
max).
For ray tracing pipelines, there could be lots of shaders to process
at every pipeline binding call. Besides there is no interface from the
runtime to the driver to list all the shaders used at the moment.
So do that tracking in the runtime and pass the information down to
the driver through the cmd_set_rt_state() vfunc.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 69a04151db ("vulkan/runtime: add ray tracing pipeline support")
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com>
(cherry picked from commit 5c53c6e693c1067065d2fe12bfe94066af93f2fe)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
48d55072
by Lionel Landwerlin at 2025-12-02T11:01:45-08:00
anv: fix broken ray tracing dynamic descriptors
We completely missed that handling.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: e76ed91d3f ("anv: switch over to runtime pipelines")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/14284
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com>
(cherry picked from commit 0ca870c6f3eb215345185e4396901623dc51f190)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
2213869a
by Dylan Baker at 2025-12-03T08:40:24-08:00
.pick_status.json: Update to ac37885fc85203c08f09345c637b6a21f642ed66
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
84caa703
by Ian Romanick at 2025-12-03T08:40:27-08:00
lavapipe: fp16 flrp must also be lowered
Prevents failures with fp16 in lavapipe and Zink on lavapipe when
"nir/lower_flrp: Check and set shader_info::flrp_lowered" is
applied. Lowering with an incomplete mask on the first call to
nir_lower_flrp will prevent later calls (with the complete mask) from
doing anything.
Fixes: b38879f8c5f ("vallium: initial import of the vulkan frontend")
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
(cherry picked from commit 341e2d328336788e30e480000c46564d76a510d0)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
d110b38d
by Aitor Camacho at 2025-12-03T08:40:30-08:00
vulkan/wsi: Fix double destroy of present_id_timeline at swapchain create
Fixes: c888da3d48a ("vulkan/wsi: Add mechanism to wait for WSI semaphore unsignal.")
Reviewed-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Aitor Camacho <aitor@lunarg.com>
(cherry picked from commit df19ec302093b5e47c0d7556ea41af47d2b7af67)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
a1afc107
by Gil Pedersen at 2025-12-03T08:40:31-08:00
intel: Add PIPE_FORMAT_R10G10B10X2_UNORM support
This utilizes the RGBX format faking logic from e8cd7a30 to enable
PIPE_FORMAT_R10G10B10X2_UNORM renderer support using swizzling.
This format is needed for better HDR rendering support in the iris driver, to
support the Proton / Wine DXGI implementation, which requires an RGBA ordered
renderer for its Vulkan implementation. This in turn requires the Wayland
display to support both alpha and opaque formats. The check currently fails,
since only PIPE_FORMAT_R10G10B10A2_UNORM is exposed when Gallium (iris) is
the DRI Wayland renderer.
Cc: mesa-stable
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
(cherry picked from commit 858364be71efb5d78333b06c36b2abf9776210fc)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
de09b486
by Lionel Landwerlin at 2025-12-03T11:17:49-08:00
anv: add 32-wide subgroup requirement heuristic
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13052
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com>
Tested-by: Sushma Venkatesh Reddy <sushma.venkatesh.reddy@intel.com>
Cc: mesa-stable
(cherry picked from commit 296325b787f29ca8e55d49e3365767967483733a)
Stable:
- `nir_src_as_alu` is still alled `nir_src_as_alu_instr`
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
0cfce3ff
by Icenowy Zheng at 2025-12-03T11:23:49-08:00
pvr: enable samplerMirrorClampToEdge feature
This is forgotten when advertising the corresponding extension, which
leads to inconsistency, thus fail of
dEQP-VK.api.info.vulkan1p2.feature_extensions_consistency CTS testcase.
Enable the corresponding feature too. I ran all CTS tests with
"mirror_clamp_to_edge" in name, which are all skipped with NotSupported
before (because of the feature being not advertised), and gain
3695/11140 Pass with the remaining ones still NotSupported (no Fail).
This also makes the feature extension consistency CTS testcase Pass too.
Fixes: 4d34c07b7a9f ("pvr: advertise VK_KHR_sampler_mirror_clamp_to_edge")
Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
(cherry picked from commit ab9e148bfb10c1a442741a23ea4afe09226fa520)
Conflicts:
src/imagination/vulkan/pvr_physical_device.c
(File has been renamed since branchpoint)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
9685a1fb
by Dylan Baker at 2025-12-03T12:31:36-08:00
docs/relnotes/25.3.0: Escape some rst language constructs
That are from the gitlog, which we don't currently escape.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
e6a8e132
by Sushma Venkatesh Reddy at 2025-12-03T22:24:03+00:00
drirc: Add anv_assume_full_subgroups for Detroit: Become Human
Add workaround to assume full 32-thread subgroups. This fixes rendering
corruption when running the Detriot: Become Human game using anv driver.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/14120
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
(cherry picked from commit 36d7cd0514b4adae424fbc84f46024660e2ab78b)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
68d31c28
by Yiwei Zhang at 2025-12-03T15:02:48-08:00
venus: fix racy semaphore feedback counter update
Previously, we update the sfb dst slot upon vn_SignalSemaphore so that
vn_GetSemaphoreCounterValue can poll just the feedback slot itself.
However, that can race with pending sfb cmds that are going to update
the slot value, ending up with stuck sync progression.
This change fixes it by disallowing vn_SignalSemaphore to touch the sfb
dst slot. To ensure counter query being monotonic, vn_GetSemaphoreCounterValue
now takes the greater of signaled counter and the sfb counter read.
Test with dEQP-VK.synchronization* group:
- w/o this: stuck shows up within 2 min with 8 parallel deqp runs
- with this: no stuck for multiple full runs of the same
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/14304
Fixes: 5c7e60362cb ("venus: enable timeline semaphore feedback")
(cherry picked from commit 829bd406c04566962268138195ecb2c4d78da5cf)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
-
c030e531
by Dylan Baker at 2025-12-03T22:02:09-08:00
docs: add release notes for 25.3.1
-
5005a508
by Dylan Baker at 2025-12-03T22:02:48-08:00
VERSION: bump for 25.3.1
Signed-off-by: Dylan Baker <dylan.c.baker@intel.com>