[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1094494: marked as done (xorg-common: 20x11-common_process-args: fails on xsession executable with args)

Your message dated Sat, 08 Nov 2025 11:32:11 +0000
with message-id <E1vHhAx-00G9Rd-2a@fasolo.debian.org>
and subject line Bug#1094494: fixed in xorg 1:7.7+24+deb13u1
has caused the Debian Bug report #1094494,
regarding xorg-common: 20x11-common_process-args: fails on xsession executable with args
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1094494: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1094494
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: xorg-common
Version: 1:7.7+24
X-Debbugs-CC: debian-xfce@lists.debian.org

(Cc debian-xfce on the off-chance this will get considered a lightdm
bug, but as far as i can tell i'd consider it an xorg-common one)

The change[0] switching from `which` to `command -v` for looking up the
selected X session executable made some more simplifications, among
them removing `${1%% *}`, i.e. a bash expansion to only use the first
word of `$1`.

This causes login for sessions that have arguments in their start
invocation to fail; in my case that's with

 - lightdm 1.32.0-6+b1
 - herbstluftwm 0.9.5-3+b1


Herbstluftwm has `Exec=herbstluftwm --locked` in its
`/usr/share/xsessions/herbstluftwm.desktop`, i.e. a parameter in
addition to the executable name itself. I read somewhere that only
single-dash options may be allowed in .desktop files, but the issue is
the same with just `-l` as argument. Also i guess there's more window
managers that are started with parameters.

Since Debian has `/etc/X11/Xsession` as "session-wrapper" (at least
that's the lightdm term), i.e. script that gets called with the actual
window manager as parameter, we get all of that `Exec=` value in
`argv[1]`, no splitting is done; see  [1].

In effect, since the simplifications done in [0] and released to sid in
1:7.7+24, 20x11-common_process-args now does
`which "herbstluftwm --locked"`, finds there is no command
"herbstluftwm --locked" and goes to the fallback session.

This worked before, up to and including in xorg-common 1:7.7+23.2. I
would suggest to re-introduce the "${1%% *}" expression in
20x11-common_process-args. I haven't researched what other display
managers and window managers do, if this really is unique to the
herbstluftwm/lightdm combination, this might instead be a lightdm bug,
and the fix might be to do parameter splitting before launching the
session wrapper script.


[0] https://salsa.debian.org/xorg-team/xorg/-/commit/2e1755166a88c8631d1ed88fac4f7f63b05f29dd
[1] https://github.com/canonical/lightdm/blob/main/src/seat.c#L940

best,
   dario

--- End Message ---
--- Begin Message --- 
Source: xorg
Source-Version: 1:7.7+24+deb13u1
Done: Jeremy Bícha <jbicha@ubuntu.com>

We believe that the bug you reported is fixed in the latest version of
xorg, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1094494@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jeremy Bícha <jbicha@ubuntu.com> (supplier of updated xorg package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 07 Nov 2025 14:43:44 -0500
Source: xorg
Built-For-Profiles: noudeb
Architecture: source
Version: 1:7.7+24+deb13u1
Distribution: trixie
Urgency: medium
Maintainer: Debian X Strike Force <debian-x@lists.debian.org>
Changed-By: Jeremy Bícha <jbicha@ubuntu.com>
Closes: 1094494
Changes:
 xorg (1:7.7+24+deb13u1) trixie; urgency=medium
 .
   * Team upload
 .
   [ Jochen Sprickerhof ]
   * 20x11-common_process-args: Only use the first word for command -v
     (Closes: #1094494)
Checksums-Sha1:
 f4568c693e7242c87bb29bb98f4422e759e78f24 2002 xorg_7.7+24+deb13u1.dsc
 d859f4c609cdffe6911691fec3cffa730951ee03 234192 xorg_7.7+24+deb13u1.tar.xz
 222652efd51f30dbe88278850f8190045b47b395 7186 xorg_7.7+24+deb13u1_source.buildinfo
Checksums-Sha256:
 9774f8e48f9883d6ac7e907bc58c7f9b8e4899f8f16a0749d9e65951c0fbe9da 2002 xorg_7.7+24+deb13u1.dsc
 e08f0221d87683d1caa73fc07788c95aa81b2c86842ff1b55b6f24dfd378659a 234192 xorg_7.7+24+deb13u1.tar.xz
 9b34799faf349eaf22c8c792c435f2f2452621fe8fbb5fcde2f73f6d43cfb018 7186 xorg_7.7+24+deb13u1_source.buildinfo
Files:
 bab7fcfa281976601f40d86cbc4c2740 2002 x11 optional xorg_7.7+24+deb13u1.dsc
 8942351825568445784608991cce9ccb 234192 x11 optional xorg_7.7+24+deb13u1.tar.xz
 698d7775ca3e64490b05b8cfc1013eaf 7186 x11 optional xorg_7.7+24+deb13u1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEETQvhLw5HdtiqzpaW5mx3Wuv+bH0FAmkOTkQACgkQ5mx3Wuv+
bH2v5g/+LpMV5hojXct4BJZdcu+WmdeKUxh7dMRMPyXMDNPEsOKMXRC5+hkLb1fx
7U7kcO5mAhLXo32worhuLgqIw4muDYa2GrJu+7ZkS31N8jNeicGQKsbjnBPGN5Y8
N1ZgmL3cqqEqZ+q3nBHUNGbm27+8vJAgGn1iU4e2HB81RlarWENNpHwHI4tasZZ5
9fEykQv+U4IU8XgomK1nzBwhFUpasIgCAgbr+FP0+PhnXrvsohrA8CORXzpedBDA
JNOIbvOXDXiMCpFf7AQ5LR0456q1iai2rxvRLw4KWvGqdOXwD3/cnMn9ICnCUcmY
tFBtj+fLFPb5FHLNLy45ZomKyqWhhq/Z8ijEI9I8NfJ8AZxW6dSH3vDrWEXVTzBj
2Y8jRnAZvBgdTfOyyvNAItTjiamQcojGPrwBUQoVrUaJA5G7byKcxs6SxGz1q1aZ
XKIc6EozvvY52f7IEYMFkqx3rbvznRt9LS/7sglbbnGx05nY+LKQlACW7cjbIeH2
JjouD7WGdIP1rG0BrhQOdIbf2F7ZEseE9yr3RzoWk2TPYqilK2dmDI2ih3J9kmWz
oCwDRH+kU0YhKkRqmtpuZZiMxUaLzDPnQFc/id1JhM+Zcqu5Y4pvt8rueyYWSg5N
R16KERFjVE+MIcAINoxwhz3AAGT6P6dKULRhpEd/xvgMB0hn53U=
=q6TJ
-----END PGP SIGNATURE-----

Attachment: pgpFLJu1PxNOX.pgp
Description: PGP signature


--- End Message ---
Reply to: