[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1094494: marked as done (xorg-common: 20x11-common_process-args: fails on xsession executable with args)

Your message dated Mon, 01 Sep 2025 07:50:29 +0000
with message-id <E1uszJ7-005kN7-1X@fasolo.debian.org>
and subject line Bug#1094494: fixed in xorg 1:7.7+25
has caused the Debian Bug report #1094494,
regarding xorg-common: 20x11-common_process-args: fails on xsession executable with args
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1094494: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1094494
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: xorg-common
Version: 1:7.7+24
X-Debbugs-CC: debian-xfce@lists.debian.org

(Cc debian-xfce on the off-chance this will get considered a lightdm
bug, but as far as i can tell i'd consider it an xorg-common one)

The change[0] switching from `which` to `command -v` for looking up the
selected X session executable made some more simplifications, among
them removing `${1%% *}`, i.e. a bash expansion to only use the first
word of `$1`.

This causes login for sessions that have arguments in their start
invocation to fail; in my case that's with

 - lightdm 1.32.0-6+b1
 - herbstluftwm 0.9.5-3+b1


Herbstluftwm has `Exec=herbstluftwm --locked` in its
`/usr/share/xsessions/herbstluftwm.desktop`, i.e. a parameter in
addition to the executable name itself. I read somewhere that only
single-dash options may be allowed in .desktop files, but the issue is
the same with just `-l` as argument. Also i guess there's more window
managers that are started with parameters.

Since Debian has `/etc/X11/Xsession` as "session-wrapper" (at least
that's the lightdm term), i.e. script that gets called with the actual
window manager as parameter, we get all of that `Exec=` value in
`argv[1]`, no splitting is done; see  [1].

In effect, since the simplifications done in [0] and released to sid in
1:7.7+24, 20x11-common_process-args now does
`which "herbstluftwm --locked"`, finds there is no command
"herbstluftwm --locked" and goes to the fallback session.

This worked before, up to and including in xorg-common 1:7.7+23.2. I
would suggest to re-introduce the "${1%% *}" expression in
20x11-common_process-args. I haven't researched what other display
managers and window managers do, if this really is unique to the
herbstluftwm/lightdm combination, this might instead be a lightdm bug,
and the fix might be to do parameter splitting before launching the
session wrapper script.


[0] https://salsa.debian.org/xorg-team/xorg/-/commit/2e1755166a88c8631d1ed88fac4f7f63b05f29dd
[1] https://github.com/canonical/lightdm/blob/main/src/seat.c#L940

best,
   dario

--- End Message ---
--- Begin Message --- 
Source: xorg
Source-Version: 1:7.7+25
Done: Timo Aaltonen <tjaalton@debian.org>

We believe that the bug you reported is fixed in the latest version of
xorg, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1094494@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Timo Aaltonen <tjaalton@debian.org> (supplier of updated xorg package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 01 Sep 2025 10:07:30 +0300
Source: xorg
Built-For-Profiles: noudeb
Architecture: source
Version: 1:7.7+25
Distribution: unstable
Urgency: medium
Maintainer: Debian X Strike Force <debian-x@lists.debian.org>
Changed-By: Timo Aaltonen <tjaalton@debian.org>
Closes: 1094494
Changes:
 xorg (1:7.7+25) unstable; urgency=medium
 .
   [ Jochen Sprickerhof ]
   * 20x11-common_process-args: Only use the first word for command -v
     (Closes: #1094494)
Checksums-Sha1:
 3cfe52b5c3af3136c26783de65085f4b744eab07 1970 xorg_7.7+25.dsc
 e76f56ae159d534f75f2076845e9774a20ef8614 234264 xorg_7.7+25.tar.xz
 d118368f4a0853c256074b85e2522e57226ac4fc 7287 xorg_7.7+25_source.buildinfo
Checksums-Sha256:
 db706e466582d2b2573fe3fcec7e1bf43fb47b7ddd3bd552e85a67c27b66190c 1970 xorg_7.7+25.dsc
 3c14a64b4f419e250c2ef34e197b2e0ea3c6c5e5037d7939ddeb4437471be0f6 234264 xorg_7.7+25.tar.xz
 0c49033592f186c06f2100d5bc602872555f74b988909e4c3b297e1b5aa4b798 7287 xorg_7.7+25_source.buildinfo
Files:
 794094d527f8cfe8a601a39869776a7c 1970 x11 optional xorg_7.7+25.dsc
 7d8a707829972ac434f50020ab1cf7ba 234264 x11 optional xorg_7.7+25.tar.xz
 6f561aa604025dc25765f738c1ca0080 7287 x11 optional xorg_7.7+25_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdS3ifE3rFwGbS2Yjy3AxZaiJhNwFAmi1SoYACgkQy3AxZaiJ
hNwZFxAAhRyBBxmf5ICeSXfGMeX4El3hQ11LU49CkR5bVhb7fiHv5UcfJQ8YMWLO
It39aWBQNfVy5MSiztxTMmG43zCKGkFU4b6RVohJprWa9fBC4KmnTHMJBMFhqe09
qfgQKIcrtIpzdway2vU9u57gts8A/UuuLvdGk3HnrQpGcKx9bPKqN2P7bZ7nhA9t
QGMANeBc1y0qQ2+2HmX1dIhB5SihzpApse5qyeP1KvLG8DA1XoDeByirTuDbKR4P
JzRwQMK/FvtnfEDnk8eoJzqJwVa/YQYyDmmZkh30wi7kSRWCBXk9dMsJ+cPFPoo1
3txHgpB/1Ux58DWaj18LYhkZ7JM4SOfK9MmLXDhjn2/AF96CLXLPXxiThXQQ/nb4
YH7JpmC2rid/zyKDL9NtR4YnxKrdLKX9zEnDAr7KzYmE2GLAL+D1Bvmf+3DOJ2uY
dEjvl/7F9XGx3QuCV8sKXEWeD57R547xJdQD/VSsUndPlM6Uue+BIH34Hb+m5IXA
6E59YCPnegBoM16SwI33wFaTi/GBieLGnvzzYp99a5z2+5Yv+k80v9OyPiL6lJWX
ak+2ifGe33zWepKVdXnuW6XTEzsPCf4ZeDFn0sM5hYT7tE7k8YVeRSVeWZgqwlQq
3TydyRAnccy+ZvYgMYuGs+STGqtJsWzV0E1fWqiWGWNRdd44bUM=
=+ow9
-----END PGP SIGNATURE-----

Attachment: pgpsmfcgsDdga.pgp
Description: PGP signature


--- End Message ---
Reply to: