[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1087438: marked as done (Generates incorect is_valid_enum checks for bitfields)

Your message dated Mon, 27 Jan 2025 21:45:03 +0000
with message-id <E1tcWul-00Gv7K-T9@fasolo.debian.org>
and subject line Bug#1087438: fixed in wayland 1.23.1-1
has caused the Debian Bug report #1087438,
regarding Generates incorect is_valid_enum checks for bitfields
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1087438: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1087438
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: libwayland-bin
Version: 1.23.0-1+b1
Severity: important

Hi,

wayland-scanner <= 1.23.0 has a bug where it misgenerates the is_valid
checks for bitfields thus breaking compositors e.g. using recent wlroots
as they reject valid dmabuf or layer surface bitfields, e.g.:

```
static inline bool
zwlr_layer_surface_v1_anchor_is_valid(uint32_t value, uint32_t version) {
        uint32_t valid = 0;
        if (version >= 1)
                valid |= ZWLR_LAYER_SURFACE_V1_ANCHOR_TOP;
        if (version >= 1)
                valid |= ZWLR_LAYER_SURFACE_V1_ANCHOR_BOTTOM;
        if (version >= 1)
                valid |= ZWLR_LAYER_SURFACE_V1_ANCHOR_LEFT;
        if (version >= 1)
                valid |= ZWLR_LAYER_SURFACE_V1_ANCHOR_RIGHT;
        return (value & ~valid) == 0;
}
```

which fails for bitfields where more than one value is set. 

This is fixed in upstream commit
f72f2aec55705faceaa6e1a40ad13d0f0b037cd2 and version 1.23.1.

where the check looks like

```
static inline bool
zwlr_layer_surface_v1_anchor_is_valid(uint32_t value, uint32_t version) {
        uint32_t valid = 0;
        if (version >= 1)
                valid |= ZWLR_LAYER_SURFACE_V1_ANCHOR_TOP;
        if (version >= 1)
                valid |= ZWLR_LAYER_SURFACE_V1_ANCHOR_BOTTOM;
        if (version >= 1)
                valid |= ZWLR_LAYER_SURFACE_V1_ANCHOR_LEFT;
        if (version >= 1)
                valid |= ZWLR_LAYER_SURFACE_V1_ANCHOR_RIGHT;
        return (value & ~valid) == 0;
}
```

Would be great if wayland could be updated in unstable.

Cheers,
 -- Guido


-- System Information:
Debian Release: trixie/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'unstable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: arm64

Kernel: Linux 6.11.4-amd64 (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages libwayland-bin depends on:
ii  libc6      2.40-3
ii  libexpat1  2.6.3-1
ii  libxml2    2.12.7+dfsg+really2.9.14-0.1

libwayland-bin recommends no packages.

libwayland-bin suggests no packages.

-- no debconf information

--- End Message ---
--- Begin Message --- 
Source: wayland
Source-Version: 1.23.1-1
Done: Dylan Aïssi <daissi@debian.org>

We believe that the bug you reported is fixed in the latest version of
wayland, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1087438@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dylan Aïssi <daissi@debian.org> (supplier of updated wayland package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 27 Jan 2025 22:06:33 +0100
Source: wayland
Architecture: source
Version: 1.23.1-1
Distribution: unstable
Urgency: medium
Maintainer: Debian X Strike Force <debian-x@lists.debian.org>
Changed-By: Dylan Aïssi <daissi@debian.org>
Closes: 1087438 1094276
Changes:
 wayland (1.23.1-1) unstable; urgency=medium
 .
   * Team upload.
   * New upstream release (Closes: #1094276, #1087438)
Checksums-Sha1:
 28720f3117270a8c510f4497febaf572db232f95 2613 wayland_1.23.1-1.dsc
 56a55eb419f3ecf8a7ebdc726db43d2d734e5632 370199 wayland_1.23.1.orig.tar.gz
 6da28d58c7d39a0ec1f1b33f762763dba7e6b136 16369 wayland_1.23.1-1.diff.gz
 5b42a5baa80b3c9031e1be29c6b177dc5f4c7d54 13284 wayland_1.23.1-1_amd64.buildinfo
Checksums-Sha256:
 7d515f00be434c1728b4137bcc90b9cde78706e01ac536f6631f8cfd367a3be0 2613 wayland_1.23.1-1.dsc
 158ec49af498f2558c7fbf7e8b070d010d4e270cc6076003a18a6c813f87e244 370199 wayland_1.23.1.orig.tar.gz
 862336ac2d3b136bc27fd9553a6e18a4c9bdbd34ed4b3df9df406eca86202323 16369 wayland_1.23.1-1.diff.gz
 f630defbc830f1ab902b97561de3990830fc0fe1a56d99ef489fbdeaca35b086 13284 wayland_1.23.1-1_amd64.buildinfo
Files:
 c4f8e79f8f848ddf6ec0926412e6a8cb 2613 x11 optional wayland_1.23.1-1.dsc
 8f703ce7e26d4ab990e807721d3e9f3f 370199 x11 optional wayland_1.23.1.orig.tar.gz
 6808536dfcbd7ce8b93f7831cb958131 16369 x11 optional wayland_1.23.1-1.diff.gz
 dc70b5d973149073df3eac55fdfffb7b 13284 x11 optional wayland_1.23.1-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEmjwHvQbeL0FugTpdYS7xYT4FD1QFAmeX9r4ACgkQYS7xYT4F
D1QT7xAAqzHrmMhjgk4s7sSjN+2J2NYw2Oc04NmR++pkZtkanJaH3JN9Ki2SIgpJ
sHLAMpsjjxt319s4oz/BJZTkCxVnEf/qD9REaYqLce0kXa5SyoKT98icQ5dfsAoQ
3d5bE/t23snGIKrsEZxUyvhctMRIYGrjey3fEG9jYsC9I6fPfrI7Z8TdShR2ulce
3uPq43trdzC3J5GRUggRed4NIhdKU0hzxbVOql7+/gJpelVd0vmT9tJqUIU9v3or
vEJ1bgossaPYazdD41j6v0ZxBm/Q8bAGhxpuJmrZXtyysny0CvbZRmb04vhSeZi5
njiEhpsR/nV+woc3NYDqhF9lpoX3tHTPJ4A8dG0NJVixPKgX5ekt69ocFTJkCfaD
r/0fbqp2O8C2sD2OPS0W/YNEQNhV1LMb4jCGakCDrNmpcLyEzYY4JHcTVTxDsBJS
pBfBAWzgN65VTtcO73eu7RqB46TwEzAyU1UdnDe93ctB/DFJ6vB8bOoLy96OWOtn
fFuOreVc+0RUY6rYPh7+aFHfLfNXbufPm9pgSjgalnjUN+YrJICiFTnVHSF8cVxu
NjchFufu7b3+cBf8I2xPJUgNUU6RgcnQ3hx2PDNtwOTW3K1sdOQyHaRKF0wS640S
xvD1rbnOr5Pc1JJtyXsbowDuIJ3W/CnGs5e3O/F6KaiEHaKVZ/o=
=JYHu
-----END PGP SIGNATURE-----

Attachment: pgpOZFjgdTU3S.pgp
Description: PGP signature


--- End Message ---
Reply to: