[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1087279: marked as done (xserver-xorg-video-vesa FTBFS: error: implicit declaration of function 'outb')

Your message dated Fri, 24 Jan 2025 09:23:50 +0000
with message-id <E1tbFuo-00HBIS-4T@fasolo.debian.org>
and subject line Bug#1087279: fixed in xserver-xorg-video-vesa 1:2.6.0-2
has caused the Debian Bug report #1087279,
regarding xserver-xorg-video-vesa FTBFS: error: implicit declaration of function 'outb'
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1087279: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1087279
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: xserver-xorg-video-vesa
Version: 1:2.6.0-1
Severity: serious
Tags: ftbfs
Justification: fails to build from source (but built successfully in the past)

Hi,

xserver-xorg-video-vesa fails to *cross* build from source for e.g.
riscv64 with the following failure:

| make[3]: Entering directory '/<<PKGBUILDDIR>>/build/src'
| /bin/bash ../libtool  --tag=CC   --mode=compile riscv64-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../../src -I..   -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/xorg -fvisibility=hidden -I/usr/include/pixman-1 -I/usr/include/X11/dri -I/usr/include/libdrm   -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o vesa.lo ../../src/vesa.c
| libtool: compile:  riscv64-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../../src -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/xorg -fvisibility=hidden -I/usr/include/pixman-1 -I/usr/include/X11/dri -I/usr/include/libdrm -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c ../../src/vesa.c  -fPIC -DPIC -o .libs/vesa.o
| ../../src/vesa.c: In function 'VESAValidMode':
| ../../src/vesa.c:415:18: warning: passing argument 1 of 'free' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
|   415 |         free(mode->name);
|       |              ~~~~^~~~~~
| In file included from /usr/include/xorg/os.h:54,
|                  from /usr/include/xorg/misc.h:119,
|                  from /usr/include/xorg/xf86str.h:37,
|                  from /usr/include/xorg/xf86.h:44,
|                  from ../../src/vesa.h:34,
|                  from ../../src/vesa.c:48:
| /usr/riscv64-linux-gnu/include/stdlib.h:687:25: note: expected 'void *' but argument is of type 'const char *'
|   687 | extern void free (void *__ptr) __THROW;
|       |                   ~~~~~~^~~~~
| ../../src/vesa.c: In function 'VESALoadPalette':
| ../../src/vesa.c:1437:12: error: implicit declaration of function 'outb' [-Wimplicit-function-declaration]
|  1437 |            outb(pVesa->ioBase + VGA_DAC_WRITE_ADDR, idx);
|       |            ^~~~
| ../../src/vesa.c:1431:18: error: implicit declaration of function 'inb' [-Wimplicit-function-declaration]
|  1431 |            (void)inb(pVesa->ioBase + VGA_IOBASE_COLOR + VGA_IN_STAT_1_OFFSET); \
|       |                  ^~~
| ../../src/vesa.c:1438:12: note: in expansion of macro 'VESADACDelay'
|  1438 |            VESADACDelay();
|       |            ^~~~~~~~~~~~
| make[3]: *** [Makefile:490: vesa.lo] Error 1
| make[3]: Leaving directory '/<<PKGBUILDDIR>>/build/src'
| make[2]: *** [Makefile:445: all-recursive] Error 1
| make[2]: Leaving directory '/<<PKGBUILDDIR>>/build'
| make[1]: *** [Makefile:377: all] Error 2
| make[1]: Leaving directory '/<<PKGBUILDDIR>>/build'
| dh_auto_build: error: cd build && make -j1 returned exit code 2
| make: *** [debian/rules:25: build-arch] Error 25
| dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit status 2

Now a cross build failure is not a FTBFS, but if you look at old build
logs for e.g. riscv64 and arm64 on buildd.d.o, you can see:

https://buildd.debian.org/status/fetch.php?pkg=xserver-xorg-video-vesa&arch=arm64&ver=1%3A2.6.0-1&stamp=1699449242&raw=0
| ../../src/vesa.c: In function ‘VESALoadPalette’:
| ../../src/vesa.c:1437:12: warning: implicit declaration of function ‘outb’ [-Wimplicit-function-declaration]
|  1437 |            outb(pVesa->ioBase + VGA_DAC_WRITE_ADDR, idx);
|       |            ^~~~
| ../../src/vesa.c:1431:18: warning: implicit declaration of function ‘inb’ [-Wimplicit-function-declaration]
|  1431 |            (void)inb(pVesa->ioBase + VGA_IOBASE_COLOR + VGA_IN_STAT_1_OFFSET); \
|       |                  ^~~

So, this implicit declaration already happened earlier and what changed
now is that it became an error. Indeed, reproducible builds are seeing
this for native builds on arm64:

https://tests.reproducible-builds.org/debian/rbuild/unstable/arm64/xserver-xorg-video-vesa_2.6.0-1.rbuild.log.gz

So this is a native !x86 FTBFS and thus rc.

Helmut

--- End Message ---
--- Begin Message --- 
Source: xserver-xorg-video-vesa
Source-Version: 1:2.6.0-2
Done: Emilio Pozuelo Monfort <pochu@debian.org>

We believe that the bug you reported is fixed in the latest version of
xserver-xorg-video-vesa, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1087279@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Emilio Pozuelo Monfort <pochu@debian.org> (supplier of updated xserver-xorg-video-vesa package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 24 Jan 2025 09:37:25 +0100
Source: xserver-xorg-video-vesa
Architecture: source
Version: 1:2.6.0-2
Distribution: unstable
Urgency: medium
Maintainer: Debian X Strike Force <debian-x@lists.debian.org>
Changed-By: Emilio Pozuelo Monfort <pochu@debian.org>
Closes: 1087279
Changes:
 xserver-xorg-video-vesa (1:2.6.0-2) unstable; urgency=medium
 .
   * Team upload.
   * Only build on x86 platforms. Closes: #1087279.
   * control: switch to pkgconf.
   * Switch copyright to DEP-5, thanks Zixing Liu.
Checksums-Sha1:
 aef0a26fb51ffc2d96caf819d8beca2c62b1c0f4 2242 xserver-xorg-video-vesa_2.6.0-2.dsc
 86610efb676fb72da181ff358e6f63e7c1e5054a 407558 xserver-xorg-video-vesa_2.6.0.orig.tar.gz
 0e998f2decf87eebf5f7543d71433c6966b1ad48 13915 xserver-xorg-video-vesa_2.6.0-2.diff.gz
 417d79523e0c6b25cf69589c9d91c2ba523ccbe7 8605 xserver-xorg-video-vesa_2.6.0-2_source.buildinfo
Checksums-Sha256:
 12a7140a23ab40a038c0cba8d7488a237a5726a69d5279b3baefa149dfeefd51 2242 xserver-xorg-video-vesa_2.6.0-2.dsc
 dbf3f95bd0b598ac7e7fc9774b37dc387eb4f805f63e93f720a577c23500881c 407558 xserver-xorg-video-vesa_2.6.0.orig.tar.gz
 d64d5e6b98344c22d105437377d52a5f16af2fff226ec7c22cb7ca8d9287d8df 13915 xserver-xorg-video-vesa_2.6.0-2.diff.gz
 2d608c1bc0db1b3efd80ae979128ee875bdda53697770c0a61c1cac026074c6e 8605 xserver-xorg-video-vesa_2.6.0-2_source.buildinfo
Files:
 fc2c05eabd92ddfec9d63cfd3b28ecd9 2242 x11 optional xserver-xorg-video-vesa_2.6.0-2.dsc
 d4724e0178d5f3fe0d0da0e9a202d84f 407558 x11 optional xserver-xorg-video-vesa_2.6.0.orig.tar.gz
 c7e9794a56d91682e9208f51a5119434 13915 x11 optional xserver-xorg-video-vesa_2.6.0-2.diff.gz
 2f5cea97bd237e404324c0e004be6da1 8605 x11 optional xserver-xorg-video-vesa_2.6.0-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEcJymx+vmJZxd92Q+nUbEiOQ2gwIFAmeTUfsACgkQnUbEiOQ2
gwI1jg//VDPdDGmdTGoohWOUcr0NOFFnOUMqW2wMin9rA11OvIdy3W281GZl3NWb
dP4Jfb6B9/hwQv7AclROxhUVKRqyy6xtxh7gAZ2xzc6TBzingev9f9zu6vmyo/Qo
lDQJ4NIpIYWtY7znNL1jvnEhpmAnXx5sNay1ENR9B/QEMY5ErJeWQwbnwKqv70uC
F5geSA7y3msCeaQwIhLn8cF+JdCa6HzjtkV/5ptMABdS0POy575kxkiIsQc09Qdj
GknsnJyspGmYTf3KX3I7/YaEdBMve6WYNpdKCWKEMh6EM6D0zlKzf1XJx0E1AIWu
moVlFOCnC69prkl7b+3myEMexYJ7Xl+rQJrKZ2i6kRXAfNqV/CXlhIMDNKBigrYD
+NFE1elSveViyw4HY55WKn02ZOkRb/Qk1pXFOVuMnWEozoRPwQLxWb5e9lHYXHVs
aev3IBwBFd0aYTgyWqJZUkTInSkG57zFPWe09qktr77FtY30oYB6SyGD7NJWXtSJ
YWTnngofJDYZYPcmaLu4WRwDorpV7jv7aTQY0fzZWX3B8KNgCAjQBrZi6lIHTAXs
T9SKbHEQDIP6ApItkQY0Ao7BSICiOs0YCveA/+v1eNkdgymBqzybV2tq/hW/J1z0
/iRd9PZrdOHxAqo5zWZwPv3WB397koaqyduJNd0aG0r5nHNs8Pw=
=uht9
-----END PGP SIGNATURE-----

Attachment: pgpuLudIH02C2.pgp
Description: PGP signature


--- End Message ---
Reply to: