-
8d6e7513
by Alan Coopersmith at 2022-05-07T10:31:31-07:00
Build xz tarballs instead of bzip2
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
f704f8cf
by Alan Coopersmith at 2022-05-07T10:36:59-07:00
gitlab CI: add a basic build test
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
794367d1
by Alan Coopersmith at 2022-05-07T10:58:54-07:00
Fix spelling/wording issues
Found by using:
codespell --builtin clear,rare,usage,informal,code,names
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
01c0b036
by Taylor R Campbell at 2022-05-07T18:09:36+00:00
Fix ctype(3) users.
The API requires "unsigned char" arguments.
Signed-off-by: Thomas Klausner <tk@giga.or.at>
-
11384211
by Alan Coopersmith at 2022-05-07T11:21:03-07:00
Stop memory leak in GetResourcePixmapPath()
Fixes issue reported by Oracle Parfait static analyzer:
Error: Memory leak
Memory leak [memory-leak] (CWE 401):
Memory leak of pointer pointer allocated with XtMalloc((strlen(value.addr) + 1))
at line 700 of lib/libXaw/src/Pixmap.c in function 'GetResourcePixmapPath'.
pointer allocated at line 679 with XtMalloc((strlen(value.addr) + 1))
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
49cec541
by Alan Coopersmith at 2022-05-07T11:21:03-07:00
Stop memory leak in error paths in XawTextSinkConvertPropertyList()
Fixes issues reported by Oracle Parfait static analyzer:
Error: Memory leak
Memory leak [memory-leak] (CWE 401):
Memory leak of pointer pointer allocated with XtCalloc(1, 144)
at line 1586 of lib/libXaw/src/TextSink.c in function 'XawTextSinkConvertPropertyList'.
pointer allocated at line 1570 with XtCalloc(1, 144)
pointer leaks when XawFindArgVal(params, "font") != NULL at line 1573
and argval->value != NULL at line 1574
and XLoadQueryFont(screen->display, argval->value) == NULL at line 1577.
Memory leak [memory-leak] (CWE 401):
Memory leak of pointer pointer allocated with XtCalloc(1, 144)
at line 1605 of lib/libXaw/src/TextSink.c in function 'XawTextSinkConvertPropertyList'.
pointer allocated at line 1570 with XtCalloc(1, 144)
pointer leaks when argval->value == NULL at line 1574
and XawFindArgVal(params, "foreground") != NULL at line 1593
and argval->value != NULL at line 1594
and XAllocNamedColor(...) == 0 at line 1595.
Memory leak [memory-leak] (CWE 401):
Memory leak of pointer pointer allocated with XtCalloc(1, 144)
at line 1622 of lib/libXaw/src/TextSink.c in function 'XawTextSinkConvertPropertyList'.
pointer allocated at line 1570 with XtCalloc(1, 144)
pointer leaks when argval->value == NULL at line 1574
and XawFindArgVal(params, "background") != NULL at line 1610
and argval->value != NULL at line 1611
and XAllocNamedColor(...) == 0 at line 1612.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
9129b6db
by Thomas E. Dickey at 2022-07-04T08:49:41-04:00
issue #6: fix typo in XawMax parameter in GetBlockBoundaries
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
c37efe7e
by Alan Coopersmith at 2023-02-25T09:21:46-08:00
Remove "All rights reserved" from Oracle copyright notices
Oracle no longer includes this term in our copyright & license notices.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
02d6fcb2
by Alan Coopersmith at 2023-02-28T11:50:15-08:00
Add .git-blame-ignore-revs to hide whitespace commits from git blame
To use this in your local repo clone, you will need to either run
`git blame --ignore-revs-file .git-blame-ignore-revs`
or set it permanently with
`git config blame.ignoreRevsFile .git-blame-ignore-revs`
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
f7246b98
by Alan Coopersmith at 2023-02-28T14:12:09-08:00
Replace calls to index() with strchr()
Use C standard API instead of old BSD equivalent
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
ebf701e9
by Alan Coopersmith at 2023-03-04T10:44:45-08:00
configure: Use LT_INIT from libtool 2 instead of deprecated AC_PROG_LIBTOOL
AC_PROG_LIBTOOL was replaced by LT_INIT in libtool 2 in 2008,
so it's time to rely on it.
Clears autoconf warnings:
configure.ac:13: warning: The macro `AC_PROG_LIBTOOL' is obsolete.
configure.ac:13: You should run autoupdate.
aclocal.m4:3465: AC_PROG_LIBTOOL is expanded from...
configure.ac:13: the top level
libtoolize: Consider adding 'AC_CONFIG_MACRO_DIRS([m4])' to configure.ac,
libtoolize: and rerunning libtoolize and aclocal.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
78eb3c75
by Alan Coopersmith at 2023-03-15T16:29:53-07:00
libXaw 1.0.15
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
32435818
by Alan Coopersmith at 2023-03-28T12:10:58-07:00
Set close-on-exec when opening files
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
2f99a415
by Walter Harms at 2023-05-12T23:03:32+02:00
add examples
provide some examples to support the documentation
-
e67c7ff2
by Walter Harms at 2023-05-13T19:08:12+02:00
add xawhisto
-
55c2ab7c
by Walter Harms at 2023-06-18T21:04:43+02:00
add simple widget demo
-
571c764a
by Walter Harms at 2023-06-18T21:05:34+02:00
expand for simple widget demo
-
c5a5fcea
by Alan Coopersmith at 2023-09-21T18:12:57-07:00
Variable scope reductions as suggested by cppcheck
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
77533b88
by Alan Coopersmith at 2023-09-21T18:12:57-07:00
Handle redundantInitialization warnings from cppcheck
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
e1b03077
by Alan Coopersmith at 2023-09-23T09:42:20-07:00
Use C99 designated initializers where appropriate
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
1b5fe7cf
by Alan Coopersmith at 2023-09-23T09:51:42-07:00
gitlab CI: add xz-utils to container for "make distcheck"
Also update to latest ci-templates
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
a6cd58c9
by Alan Coopersmith at 2024-02-13T17:46:44-08:00
unifdef NCR
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
04a5e1a7
by Alan Coopersmith at 2024-02-13T17:47:21-08:00
unifdef sony
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
dbd28c70
by Alan Coopersmith at 2024-02-13T17:48:19-08:00
unifdef QNX4
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
b6de2199
by Alan Coopersmith at 2024-02-13T17:51:04-08:00
unifdef AIXV3 || __SCO__
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
bce0fc28
by Alan Coopersmith at 2024-02-13T18:03:20-08:00
unifdef __osf__
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
84f62d9c
by Alan Coopersmith at 2024-02-13T18:04:06-08:00
unifdef __UNIXOS2__
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
6bbdea68
by Alan Coopersmith at 2024-02-13T18:10:16-08:00
Remove unused sharedlib.c
It was only built by Imake if SUNSHLIB was defined.
SUNSHLIB was only set in the Imake configs for SunOS versions < 5
(i.e. before Solaris 2.0).
It has never been used in the autoconf builds.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
239a9d1f
by Alan Coopersmith at 2024-02-17T14:48:34-08:00
unifdef ISC
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
5c23a1f5
by Thomas E. Dickey at 2024-02-28T20:48:23-05:00
build-fix
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
eb5cbbd6
by Thomas E. Dickey at 2024-02-28T20:48:29-05:00
fix missing-initializer warnings
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
36ac4334
by Thomas E. Dickey at 2024-02-28T20:48:36-05:00
quiet conversion-warnings with casts
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
785ba6f4
by Thomas E. Dickey at 2024-02-28T20:48:43-05:00
provide fallback for deprecated isascii/toascii
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
f181d10b
by Thomas E. Dickey at 2024-02-28T20:48:49-05:00
reduce compiler-warnings using casts
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
6ded4c04
by Thomas E. Dickey at 2024-03-02T11:28:34-05:00
cppcheck scope and assignment warnings
-
d696cf91
by Thomas E. Dickey at 2024-03-02T16:40:07+00:00
manpage: adjust line-breaks to avoid embedded full-stops
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
080e6e49
by Thomas E. Dickey at 2024-03-02T16:40:07+00:00
manpage: assume .EX/.EE macros
Branden Robinson says macros have to go after ".TH"; the existing macros did
not match the format used in groff, etc., and can be simply removed. The
".TQ" macro is used only without a parameter, causing an extra space to be
emitted (and fixed that by dropping the parameter).
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
cc1e73a8
by Thomas E. Dickey at 2024-03-02T16:40:07+00:00
manpage: improve formatting consistency of bold/italics
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
ff9312d9
by Thomas E. Dickey at 2024-03-02T16:25:29-05:00
fix references to uninitialized data when constructing argument-lists
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
1b1d164c
by Thomas E. Dickey at 2024-03-02T16:25:40-05:00
reduce variable-length argument lists to match the existing code
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
f4906b8a
by Thomas E. Dickey at 2024-03-02T16:36:03-05:00
delete unused assignments
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
3841474f
by Thomas E. Dickey at 2024-03-02T16:57:55-05:00
add check for null pointer, avoid dereferencing
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
a3fb3213
by Thomas E. Dickey at 2024-03-02T16:58:06-05:00
add check for null pointer, avoid dereferencing
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
5815fc38
by Thomas E. Dickey at 2024-03-02T16:58:12-05:00
add check for null pointer, avoid dereferencing
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
96e4ac3a
by Thomas E. Dickey at 2024-03-02T16:58:18-05:00
add check for null pointer, avoid dereferencing
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
28b5ce87
by Thomas E. Dickey at 2024-03-02T16:58:23-05:00
add check for null pointer, avoid dereferencing
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
95e93cfd
by Thomas E. Dickey at 2024-03-02T16:58:37-05:00
add check for null pointer, avoid dereferencing
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
ce94a168
by Thomas E. Dickey at 2024-03-02T16:58:43-05:00
add check for null pointer, avoid dereferencing
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
9aba0a92
by Thomas E. Dickey at 2024-03-04T03:38:27-05:00
split-up assignments which give unnecessary compiler-warnings
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
d33708e3
by Thomas E. Dickey at 2024-03-04T03:38:38-05:00
scan-build(clang-17) reports possible null dereference, add checks
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
fd4b2ce6
by Thomas E. Dickey at 2024-03-04T03:53:29-05:00
fix clang/gcc warnings for undefined behavior, also fix a bug
XtConvertAndStore may update the XrmValue value, changing its size.
clang and gcc warn about undefined behavior in the case-statement
following the call (which uses the size), but do not explain what
the problem is. Since this code is not intended to handle changes
of the size, simply reject that case. That quiets the gcc warnings
and is actually all that is needed for correctness. clang still
complains (neither knows what the call does), but can be quieted
by initializing the variable before calling the function.
The code happens to work without the fix as long as it is not
used to convert between resource types which would increase the
size.
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
b116d033
by Thomas E. Dickey at 2024-03-04T03:53:39-05:00
clang/gcc warnings about undefined behavior (minor bug-fix)
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
d0fcbd97
by Thomas E. Dickey at 2024-03-04T18:08:47-05:00
amend change to XawListChange()
My previous commit in July 2019
build-fixes when _CONST_X_STRING is defined
modified the interface of XawListChange() to use "_Xconst char *"
to fix builds when the Xt symbol _CONST_X_STRING is defined (which
makes the String typedef "const").
While this fixed building Xaw, clients which use Xaw were impacted.
Changing that function to use String resolves both problems.
(report by Karl Berry).
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
c07b1728
by Thomas E. Dickey at 2024-03-10T10:03:25-04:00
make the examples configurable as (interactive) unit-tests
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
254e1f65
by Thomas E. Dickey at 2024-03-10T14:31:35+00:00
delete code which is never used
-
f14ba54e
by Thomas E. Dickey at 2024-03-10T16:25:47+00:00
libXaw 1.0.16: amends XawListChange() prototype, plus code-cleanup