[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1066112: marked as done (weston: Enable support to libseat launcher in weston 10)

Your message dated Tue, 22 Oct 2024 17:58:16 +0200
with message-id <CA+6XHwQrxd1eD_q5zk2gqa7N7o2_CfYRB7trJd0Fsprcr0XTbg@mail.gmail.com>
and subject line Re: Bug#1066112: weston: Enable support to libseat launcher in weston 10
has caused the Debian Bug report #1066112,
regarding weston: Enable support to libseat launcher in weston 10
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1066112: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066112
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: weston
Version: 10.0.1-1
Severity: wishlist
Tags: patch
X-Debbugs-Cc: carlos.melara@toradex.com

Dear Maintainers, hi.

First of all, thanks for maintaining weston in Debian.

Weston 10 is using the default build options set by upstream plus
screenshare and systemd features enabled via a debian/rules override of
dh_auto_configure. This basically covers the major cases for PCs and
servers, but for embedded systems and people not wanting to use systemd
(and logind), this is a problem.

Weston has support for using libseat for seat management/launching
weston via the launcher-libseat option (it's turned off by default in
meson_options.txt), but weston 11 libseat launcher became the default [1]
and recently (weston 12) the libseat launcher has become the one and
only official launcher supported by upstream weston [2].

Taking this into consideration and the outcome of Init systems and
systemd GR [3], I'd like to check with you the possibility of enabling the
support for libseat launcher in stable via a proposed-updates upload to
bookworm.

I did rebuild bookworm's version with the option enabled and tested it a
bit in my notebook. I've also used abi-compliance-checker to check if
this could have caused any ABI change in libweston and it didn't. I'll
provide the debdiff output for you to check.

Also, should you answer positively, I can do a more exhaustive testing
and check if we don't introduce any errors when running with elogind and
systemd-logind.

Cheers,
Charles

[1] https://www.collabora.com/news-and-blog/news-and-events/weston-11-whats-new-whats-next.html
[2] https://www.collabora.com/news-and-blog/news-and-events/weston-12-highlights-and-changes.html
[3] https://www.debian.org/vote/2019/vote_002

P.S. I don't think this system info is going to help since I've built in
bookworm chroot.

-- System Information:
Debian Release: trixie/sid
  APT prefers testing
  APT policy: (900, 'testing'), (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.6.15-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=pt_BR.UTF-8, LC_CTYPE=pt_BR.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

diff -u weston-10.0.1/debian/changelog weston-10.0.1/debian/changelog
--- weston-10.0.1/debian/changelog
+++ weston-10.0.1/debian/changelog
@@ -1,3 +1,11 @@
+weston (10.0.1-1+deb12u1) bookworm; urgency=medium
+
+  * Team upload.
+  * debian/control: add libseat-dev to Build-Depends.
+  * debian/rules: enable libseat support. (Closes: #<bug_number>)
+
+ -- Carlos Henrique Lima Melara <carlos.melara@toradex.com>  Tue, 12 Mar 2024 12:54:10 -0300
+
 weston (10.0.1-1) unstable; urgency=medium
 
   * New upstream release.
diff -u weston-10.0.1/debian/control weston-10.0.1/debian/control
--- weston-10.0.1/debian/control
+++ weston-10.0.1/debian/control
@@ -26,6 +26,7 @@
                libpixman-1-dev (>= 0.25.2),
                libpipewire-0.3-dev,
                libpng-dev,
+               libseat-dev,
                libsystemd-dev,
                libudev-dev (>= 136),
                libva-dev,
diff -u weston-10.0.1/debian/rules weston-10.0.1/debian/rules
--- weston-10.0.1/debian/rules
+++ weston-10.0.1/debian/rules
@@ -2,7 +2,8 @@
 
 override_dh_auto_configure:
 	dh_auto_configure -- -Dscreenshare=true \
-		-Dsystemd=true
+		-Dsystemd=true \
+		-Dlauncher-libseat=true
 
 override_dh_auto_test:
 	mkdir -p $(CURDIR)/debian/tmp/tmp/xdgruntimedir

--- End Message ---
--- Begin Message --- 
Version: 14.0.0-2~bpo12+1

Le ven. 27 sept. 2024 à 21:24, Carlos Henrique Lima Melara
<charles@debian.org> a écrit :
>
> Since this is done and use proposed-updates to add a new feature might
> be a stretch, feel free to close the bug.
>

--- End Message ---
Reply to: