[Git][xorg-team/lib/mesa][debian/bookworm-backports] 163 commits: docs: update sha sums for 24.2.2

Dylan Aïssi pushed to branch debian/bookworm-backports at X Strike Force / lib / mesa

Commits:

f2999bf7
by Dylan Baker at 2024-09-06T08:56:27-07:00
```
docs: update sha sums for 24.2.2
```

9b3264fc

by Eric Engestrom at 2024-09-16T18:54:31+02:00

.pick_status.json: Update to 8b272c8d8c419ecb7aee0257563c9489b675f4ef

da902ab6

by Jose Maria Casanova Crespo at 2024-09-16T18:57:32+02:00

v3d: v3d_resource Use LINEAR layout for importing with INVALID modifier

v3d_resource_from_handle when importing a DRM_FORMAT_MOD_INVALID
considered that if we had a render-only device the resource layout was
linear and if we didn't have render-only the resource layout was tiled.

This change honors the resource creation with the SCANOUT flag
independently of the availability of the render-only for the
DRM_FORMAT_MOD_INVALID modifier.

It also fixes most of the failing piglit text for:

spec@ext_image_dma_buf_import@ext_image_dma_buf_import.*

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11594
Cc: mesa-stable
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30946>
(cherry picked from commit 5fed6bee19be40782a2e3bc76648d3177b4e02d9)

3b938aa4

by Karol Herbst at 2024-09-16T18:57:44+02:00

rusticl: do not use CL vector types in bindings and code

Bindgen seems to miscompile them and I kinda thought I've done this
already in the past, but apparently not.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11722
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30710>
(cherry picked from commit 93e96da9458c9d0348f2390dc0bea67cf140b1a0)

064d484d

by Rob Clark at 2024-09-16T19:00:06+02:00

freedreno/drm: Fix ring_heap flags

RING_FLAGS has FD_BO_HINT_COMMAND so we can't mask out the _FD_BO_HINTS.

Fixes: a3fb2b07aa29 ("freedreno: Add bo usage hints")
Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31050>
(cherry picked from commit 0adaf920147a105704dda2f79299559058e68740)

344af7b9

by Samuel Pitoiset at 2024-09-16T19:00:07+02:00

radv: fix allocating sparse descriptor buffers in the 32-bit addr space

There are two bugs:
- VK_KHR_maintenance5 added VkBufferUsageFlags2CreateInfoKHR, so
checking for pCreateInfo->usage is incomplete
- this was also missing the usage flag for descriptor buffer with samplers

This fixes recent VKCTS coverage in
dEQP-VK.binding_model.descriptor_buffer.*.

Fixes: 059391b6311 ("radv: use 32bit va range for sparse descriptor buffers")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31054>
(cherry picked from commit eab5b453cd4ff5ff1f5d056f7a1fdb0cd7a6543e)

8e4b36ac

by Mohamed Ahmed at 2024-09-16T19:00:08+02:00

nvk: Use stride in the explicit modifier case for linear images

Fixes: f1fdffa1b2e5 (nvk: Support image creation with modifiers)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31045>
(cherry picked from commit af15cceff44d7ecc234fe61d2d81bf811c9e2e66)

dc465140

by Samuel Pitoiset at 2024-09-16T19:00:09+02:00

radv: disable shaders linking with ESO when nextStage of VS/TES isn't present

For example, if the application wants to create linked shaders with
VS/TCS/TES but the next stage of TES isn't present, the driver would
have to compile shader variants (ie. nextStage could be NONE,TES,GS).

This isn't supported by RADV without re-compiling all shaders twice,
and it's also likely less optimal than compiling unlinked shaders.

This fixes recent CTS
dEQP-VK.shader_object.link.linked_linked_linked_unlinked_unlinked.*

Fixes: 37d7c2172b2 ("radv: add support for creating/destroying shader objects")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31062>
(cherry picked from commit 868272c2e9b543a52634676732689761aa394e9d)

97570a03

by Konstantin Seurer at 2024-09-16T19:04:37+02:00

gallium,st/mesa: Add and set pipe_image_view::is_2d_view_of_3d

This will be useful for lavapipe since the Z-coordinate has to be
ignored for 2D view accesses.

Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31038>
(cherry picked from commit aa072b137bd8cda592fe9035bfc24591bede4ace)

412fbc16

by Konstantin Seurer at 2024-09-16T19:04:37+02:00

lavapipe: Implement VK_EXT_image_2d_view_of_3d with sparse textures

The following things needed to be fixed:
- lp_build_tiled_sample_offset has to use the block size of the
  underlying 3D texture. Remaining calculations use the dimensions of
  the view since the z-coordinate is undefined and has to be ignored.
- The layer offset must be calculated using llvmpipe_get_texel_offset.

Fixes: d747c4a ("lavapipe: Implement sparse buffers and images")
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31038>
(cherry picked from commit 1ad1b356fc3713cabc0feea27e5aee56cae2199e)

3ab24753

by Konstantin Seurer at 2024-09-16T19:04:37+02:00

lavapipe: Do not adjust imageGranularity for different block sizes

Fixes: d747c4a ("lavapipe: Implement sparse buffers and images")
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31038>
(cherry picked from commit a53f11261f43455dc977cbe1daaa45121cea62da)

9b83bf0b

by Mary Guillemard at 2024-09-16T19:05:00+02:00

panvk: Ensure to clear dirty dynamic state in panvk_cmd_draw

This was missing and causing dynamic state to remain dirty once set.

Signed-off-by: Mary Guillemard <mary.guillemard@collabora.com>
Fixes: 1f57aae4e4f ("panvk: Move vkCmdDraw* functions to their own file")
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31089>
(cherry picked from commit e47e94f9f2a3012c21f580de7a101733cc8f047e)

1d257834

by Juan A. Suarez Romero at 2024-09-16T19:08:24+02:00

Revert "v3d: never replace a mapped bo"

This reverts commit 0b85476d864b8894396b2b1c74da5889850bdc6e.

When mapping a BO in v3d, the map keeps forever until freeing the BO. If
later the map is required again, we reuse the map instead of doing the
map from scratch.

This saves calling map/unmap continuously, as well as a mechanism to
keep control of the map usage, like a reference count.

Thus, when reallocating a BO, if it is mapped it just means the map was
used in the past, but not necessarily it is in use right now.

The reverted commit was causing performance regressions in multiple
applications, reducing from 60fps to 5fps.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11783
Backport-to: 24.2
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31049>
(cherry picked from commit c84be162a1eb3375ea068facabe4257eb74a4181)

518e7dd2

by Juan A. Suarez Romero at 2024-09-16T19:08:24+02:00

v3d: do not rebind a sampler view already rebound

As sampler view can be used multiple times, do not attempt to rebind if
it was already bound.

This fixes a crash when replaying half-life-2-v2.trace.

Backport-to: 24.2
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31049>
(cherry picked from commit 8338e2082e73feeccc7d54aeaba04602b6133ce4)

b3a3758c

by Eric Engestrom at 2024-09-16T19:09:24+02:00

.pick_status.json: Mark 5632a6e24f9053385e01a6464599ef4ba00e0c98 as denominated

e06a183e

by Daniel Stone at 2024-09-16T19:09:28+02:00

ci/alpine: Fix shellcheck errors

Signed-off-by: Daniel Stone <daniels@collabora.com>
Fixes: 34753cefd828 ("ci/alpine: use llvm variables")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30978>
(cherry picked from commit 9937ea5c1ce916cbbacaa3dfac459890b138c6e9)

cc79ae7c

by Lionel Landwerlin at 2024-09-16T19:09:29+02:00

anv: selectively disable binding table usage on Gfx20

Workaround broken Gfx20 dynamic BTI.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: e9f63df2f2 ("intel/dev: Enable LNL PCI IDs without INTEL_FORCE_PROBE")
Backport-to: 24.2
Reviewed-by: Rohan Garg <rohan.garg@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30931>
(cherry picked from commit 05dc524c75da7a406648baee920ef1382eb0a16f)

4a30e3ba

by Jesse Natalie at 2024-09-16T19:09:30+02:00

d3d12: Fix shader selector hash to hash array instead of pointer-to-array

Fixes: 116d0bf7 ("d3d12: Set fractional var masks")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31083>
(cherry picked from commit 0ae4afe0340fea44566bb1c8199d08bac423fb4e)

272a53db

by Sviatoslav Peleshko at 2024-09-16T19:11:56+02:00

brw: Fix mov cmod propagation when there's int signedness mismatch

If there's difference between scan_inst dest type and inst src type we
should be more careful, because difference in signedness can cause
incorrect results after the propagation.

Updated ror-default.trace hash, as the change fixes misrendering there.

Fixes: b23432c5 ("intel/fs: Fix a cmod prop bug when the source type of a mov doesn't match the dest type of scan_inst")
Signed-off-by: Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30998>
(cherry picked from commit fa51595c7f1fb0311371a256cc0a5c1cc2e11d9a)

fd84af25

by Jordan Justen at 2024-09-16T19:11:56+02:00

intel/dev: Fix warning for max_threads_per_psd when devinfo->verx10 == 120

Although we don't want to rely on hwconfig for devinfo->verx10 == 120,
due to the dependence on closed source software, we do check to see if
hwconfig reports different values in the DEVINFO_HWCONFIG macro.

Matt was seeing this warning on 8086:a7a0:

> MESA: warning: INTEL_HWCONFIG_TOTAL_PS_THREADS (128) != devinfo->max_threads_per_psd (64)

Reported-by: Matt Turner <mattst88@gmail.com>
Fixes: 3e4f73b3a0e ("intel/dev: Update hwconfig => max_threads_per_psd for Xe2")
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31077>
(cherry picked from commit c5c349a690288c8f3a4caa888bea37cbb851d2f0)

a3a75c63

by Dave Airlie at 2024-09-16T19:11:56+02:00

vl/bitstream: use an int32_t for se encoding.

This seems to fix a bug found with radv and ffmpeg encoding

Fixes: 1782ab4d8bab ("util: add a bitstream encoder for video stream headers.")
Acked-by: Hyunjun Ko <zzoon@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31086>
(cherry picked from commit 62320232deaf95095028893beb5cbe6175f3b630)

8df5f285

by Dave Airlie at 2024-09-16T20:23:25+02:00

radv/video: handling encoding both sps and pps in same buffer

This API should allow encoding these back to back into the same
buffer, so handle it properly.

Cc: mesa-stable
Reviewed-by: Hyunjun Ko <zzoon@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31086>
(cherry picked from commit 7531f6fd9c678689a0524be373b56cc250187077)

[Eric: drop anv changes, as 3ec8f7f99598076d4cc30 "anv/video: initial
support for h264 encoding" is not in 24.2]

49a6ecb5

by David Heidelberg at 2024-09-16T20:23:48+02:00

nir_lower_mem_access_bit_sizes: Assert when 0 components or bits are requested

Prevent the accidental passing of 0 components or bits, as it makes no sense.

Cc: mesa-stable
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Suggested-by: Karol Herbst <kherbst@redhat.com>
Signed-off-by: David Heidelberg <david@ixit.cz>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31103>
(cherry picked from commit 6bf7b5bcd804f7c6e8b678b109138a1b733e4e54)

e66946ff

by Mike Blumenkrantz at 2024-09-16T20:23:49+02:00

zink: delete erroneous kopper assert

certain present modes aren't supported by zink,
but that doesn't mean the driver needs to crash if
the driver supports them

cc: mesa-stable

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31121>
(cherry picked from commit 3db1a91bfe949bcda24fd3b8b7324b0616973c2d)

9e93ce2d

by Iván Briano at 2024-09-16T20:23:58+02:00

anv: be consistent about aux usage with modifiers

In c1a7d520f3f, we disabled AUX usage for imported images when they are
using an explicit modifier that doesn't support it.
We need to do the same when the modifier is picked by the driver,
otherwise the memory requirements reported for an exported image don't
match those we report for import.

Fixes: c1a7d520f3f ("anv: Disable aux if the explicit modifier lacks it")

Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31051>
(cherry picked from commit e4ee0a2ce1a7f47a45964bef3d51bc8f38b4b926)

dcaf22d0

by David Rosca at 2024-09-16T20:24:01+02:00

meson/megadriver: Add megadriver_libdir argument

To be able to install symlinks to megadriver in different directory.

Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31079>
(cherry picked from commit 39f7ed5412a65aa32135a22acbd9e2bcb208165a)

b51ea6a4

by David Rosca at 2024-09-16T20:31:52+02:00

targets/va: Build va driver into libgallium when building with dri

Currently va driver and dri driver are two separate libraries, when
radeonsi is enabled both libraries contain amdgpu winsys. radeonsi
needs shared winsys to ensure sync between OpenGL and VAAPI works.
Build va driver into libgallium to avoid having two instances of amdgpu
winsys.

Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11598
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31079>
(cherry picked from commit 212d57f7e6701a4f307c2c049a0e3eccfce58965)

8a96aa9a

by David Rosca at 2024-09-16T20:32:35+02:00

targets/vdpau: Build vdpau driver into libgallium when building with dri

Currently vdpau driver and dri driver are two separate libraries, when
radeonsi is enabled both libraries contain amdgpu winsys. radeonsi
needs shared winsys to ensure sync between OpenGL and VDPAU works.
Build vdpau driver into libgallium to avoid having two instances of amdgpu
winsys.

Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31079>
(cherry picked from commit b6faf586e65be3a0c6c18e4ba66b9cb10892e9b9)

a6205717

by Sviatoslav Peleshko at 2024-09-16T20:40:44+02:00

mesa: Reset vbo attributes after flushing them to Current in glPopAttrib

Fixes: 2fe771f4 ("vbo: use FlushVertices flags properly and clear NeedFlush correctly")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11498
Signed-off-by: Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31107>
(cherry picked from commit 1aa7218a1f779ba70eeaec9c6d8997975f3abd0f)

4342a4ea

by Boris Brezillon at 2024-09-16T20:40:45+02:00

pan/kmod: Don't cap VM bind operations to one

Looks like some leftovers from a debugging session.

Fixes: 97f6a62f7ef8 ("pan/kmod: Add a backend for panthor")
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Rebecca Mckeever <rebecca.mckeever@collabora.com>
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com>
Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com>
Reviewed-by: John Anthony <john.anthony@arm.com>
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30969>
(cherry picked from commit 2149a04de3efb0dc2ae9cfb82653b75799f4365b)

1efb5eb6

by David Heidelberg at 2024-09-16T20:44:27+02:00

freedreno/ir3: Use nir_lower_mem_access_bit_sizes instead custom lowering

 - More robust.
 - Handles properly UBO cases, needed for proper OpenCL support (rusticl).
 - Resolved KHR-GL46.gpu_shader_fp64.fp64.max_uniform_components failure.

Fixes: f5ce806ed73a ("freedreno/ir3: Add wide load/store lowering")
Reviewed-by: Rob Clark <robdclark@freedesktop.org>
Co-authored-by: Rob Clark <robclark@freedesktop.org>
Signed-off-by: David Heidelberg <david@ixit.cz>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30961>
(cherry picked from commit 78a121b8cfc446ecb90bcbe2923f9a86703a06e8)

45e15734

by Mike Blumenkrantz at 2024-09-16T20:44:29+02:00

zink: fix sparse bo deallocation

this loop was not correctly iterating the dynarray

cc: mesa-stable

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31124>
(cherry picked from commit bb16203a8d8ee8934a53bc00801e8a85babef59c)

80c9ca15

by Dave Airlie at 2024-09-16T20:44:31+02:00

radv: Fix radeon_enc_code_ue with values over 2^16

This ports this fixes from radeonsi:

138ba42a8705 ("radeonsi/vcn: Fix radeon_enc_code_ue with values over 2^16")

Cc: mesa-stable
Reviewed-by: Lynne <dev@lynne.ee>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31135>
(cherry picked from commit e89f4a48fd1296aec98cdce95834277cb0834205)

cb191d1b

by Dave Airlie at 2024-09-16T20:44:32+02:00

radv/video: fix encode reference slot counting

This needs the max of slot indices.

Fixes: 54d499818ca9 ("radv/video: add initial support for encoding with h264.")
Reviewed-by: Lynne <dev@lynne.ee>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31135>
(cherry picked from commit 8d08e92199979237e28c6e768b6f8d72a41891e9)

4a8d3deb

by Dave Airlie at 2024-09-16T20:44:33+02:00

radv/video/enc: report pps overrides in feedback for h265

radv does change h265 usually so report in feedback info.

Fixes: 967e4e09dee8 ("radv/video: add h265 encode support")
Reviewed-by: Lynne <dev@lynne.ee>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31135>
(cherry picked from commit 7c6e3c70b6c18a4ccd1e6c13d3d1e3561be9d2ec)

099de7a9

by Kenneth Graunke at 2024-09-16T20:44:35+02:00

intel/brw: Use NUM_BRW_OPCODES in can_omit_write() check

The intention here is to detect ALU hardware instructions, but not
virtual instructions that haven't been explicitly whitelisted.

For some reason we had arbitrarily hardcoded 128 here, but our virtual
opcodes don't start at 128.  They start at NUM_BRW_OPCODES.  So, use
that instead.

This prevents regressions later when we delete some opcodes, shifting
some virtual opcodes into the 72-128 range.

Cc: mesa-stable
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Reviewed-by: Rohan Garg <rohan.garg@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30828>
(cherry picked from commit ab0b9b679202dac10f390ffeb53a983ac22ba26f)

ce70d51e

by Georg Lehmann at 2024-09-16T20:44:36+02:00

nir/opt_sink: do not sink load_ubo_vec4 out of loops

Same reason as for load_ubo.

Fixes: d199d65c3af ("nir/nir_opt_move,sink: Include load_ubo_vec4 as a load_ubo instr.")

Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30906>
(cherry picked from commit 1ec3cc2aed4f8381879ac52e09aafb977e9aabdf)

be004d47

by Georg Lehmann at 2024-09-16T20:44:37+02:00

nir/opt_sink: do not sink inverse_ballot out of loops

Inverse_ballot result is undefined if the input is not dynamically uniform.
And sinking out of loops might make the input divergent.

Fixes: 18a0ff137ff ("nir: sink/move inverse_ballot like moves")

Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30906>
(cherry picked from commit 91f8e32a85fa31afc37bb1308927f5b890410854)

618c4c12

by Rhys Perry at 2024-09-16T20:44:38+02:00

nir/opt_if: fix fighting between split_alu_of_phi and peel_initial_break

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Fixes: 6b4b04473986 ("nir/opt_loop: add loop peeling optimization")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11822
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31002>
(cherry picked from commit 4f44a944bb2f671f9c7c83e91493c54e0f6f5b3c)

1e0d723c

by Rhys Perry at 2024-09-16T20:44:39+02:00

nir/opt_loop: skip peeling if the break is non-trivial

If this nir_if contains continues or other breaks, we can't move it
outside the loop.

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Fixes: 6b4b04473986 ("nir/opt_loop: add loop peeling optimization")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31002>
(cherry picked from commit af3b099e0aee49fe37e41698ec02d6ad74686a9f)

7f69a490

by Rhys Perry at 2024-09-16T20:44:40+02:00

nir/opt_loop: skip peeling if the loop ends with any kind of jump

Any kind of jump prevents us from moving it to the top of the loop, not
just breaks.

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Fixes: 6b4b04473986 ("nir/opt_loop: add loop peeling optimization")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31002>
(cherry picked from commit 64ac601049042b4be3ca610a8d75aa79cf893fdc)

b73ffb6b

by Konstantin Seurer at 2024-09-16T20:44:41+02:00

radv: Work around broken terrain in Warhammer III

Hiding storage support for depth formats forces the game to take a
different, working path for terrain height map initialization.

cc: mesa-stable

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31152>
(cherry picked from commit bacf9752f4dbfd0c11995bd4cce0050cb8c2a606)

4cb4dc1b

by Lucas Stach at 2024-09-16T20:44:42+02:00

etnaviv: emit all PA shader attributes

While the rnndb fix increased the size of the driver internal
structures to be able to hold all data for the currently supported
number of varyings, it didn't change the state emission, so only
a subset of the PA shader attribute states was emitted.

Use the define from rnndb to avoid such inconsistencies.

Fixes: 11ffb20b7072 ("etnaviv: Update headers from rnndb")
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31032>
(cherry picked from commit a71003b1b88fa603a07f79b8038f52bd2fdd0f4a)

486539be

by Dylan Baker at 2024-09-16T20:44:43+02:00

iris: Run checks that do not require resources before creating them

This avoids the need to free the resource if we decide to return early.

Fixes: c8df09ebd4f ("iris: More gracefully fail in resource_from_user_memory")
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Reviewed-by: Rohan Garg <rohan.garg@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30306>
(cherry picked from commit 0422eed255f0fa7bc2c33d7b61145e6070c2b5ac)

7e5192cb

by Dylan Baker at 2024-09-16T20:51:46+02:00

anv: if queue is NULL in vm_bind return early

In the error handling path we end up creating a vk_sync and then later
we vk_sync_wait() on it. If that wait fails somehow we'll end up calling
vk_queue_set_lost(&queue->vk, ...) which would segfault if queue is
NULL.

If we end up in this situation (no queue), return directly whatever the
backend's vm_bind function returned, propagating the error up if
necessary.

Fixes: dd5362c78a1 ("anv/xe: try harder when the vm_bind ioctl fails")
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31048>
(cherry picked from commit ed8d1d3c9b18172debae808820e6b6a371e7dbc3)

c489fe8d

by llyyr at 2024-09-16T20:51:56+02:00

vulkan/wsi/wayland: fix suboptimal flag being ignored with explicit sync

Signed-off-by: llyyr <llyyr.public@gmail.com>
Fixes: 5f7a5a27ef1b ("wsi: Implement linux-drm-syncobj-v1")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31122>
(cherry picked from commit 5450306a36355327a1b1eedceeacd787482c08e0)

e961135e

by David Heidelberg at 2024-09-16T20:52:05+02:00

ci/freedreno: move disabled a530 entries back to main gitlab-ci.yml

Fixes: 9442571664e5 ("ci: separate hiden jobs to -inc.yml files")
Signed-off-by: David Heidelberg <david@ixit.cz>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31177>
(cherry picked from commit 52c014a453a3e6baf20444705f52d5cfcc1589e4)

54630d22

by Rohan Garg at 2024-09-16T20:52:34+02:00

intel/compiler: use the correct cache enum for loads and stores

Fixes: 74efde7 ('intel/brw/xehp+: Drop redundant arguments of lsc_msg_desc*()')

Signed-off-by: Rohan Garg <rohan.garg@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30742>
(cherry picked from commit daea7e1651dc1d43e645ac3b9d867767257e014d)

8e8cde25
by Timo Aaltonen at 2024-09-17T14:42:22+03:00
```
rules: Migrate to llvm-19.
```

1c6a0812

by Timo Aaltonen at 2024-09-17T14:43:25+03:00

clc-find-opencl-headers.diff: Fix finding the opencl headers with llvm-19.

4912411e
by Timo Aaltonen at 2024-09-17T14:43:46+03:00
```
releasing package mesa version 24.2.2-1+exp1
```

cab8b6df

by Samuel Pitoiset at 2024-09-17T17:12:18+02:00

radv/rt: skip shaders cache for pipelines created with the capture/replay flag

Otherwise, if a pipeline is found in cache it will use a different
shader arena for allocation and the capture replay shader group handles
won't match.

Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31188>
(cherry picked from commit f88cf56087c07f6a3c2f530d140405368d7237cd)

4440f16c

by Eric Engestrom at 2024-09-17T17:13:35+02:00

.pick_status.json: Update to 45377dc5c46c4f449307c7efc28a1b66a57cf6aa

2e32cdaf

by Samuel Pitoiset at 2024-09-17T17:13:36+02:00

radv: fix lowering the view index to an input varying for FS

When multiview is used and the FS is compiled separately with GPL, the
view index still needs to be lowered, otherwise it's crashing later.

The lowering doesn't need to know the previous stage because ViewIndex
is a global thing (ie. it's neither a per-vertex or a per-primitive
varying).

This fixes recent
dEQP-VK.pipeline.pipeline_library.graphics_library.misc.other.view_index_from_device_index_*_pre_rasterization

Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31192>
(cherry picked from commit 656d7e887ab1711c0a3f6606b53995cef878cad7)

a0da2bc1

by Tapani Pälli at 2024-09-17T17:13:37+02:00

iris: fix issues with memory object updates via glBufferSubData

Disable aysnc mapping in case we are updating a external memobj.

Fixes following Piglit tests:
   spec@ext_external_objects@vk-pix-buf-update-errors
   spec@ext_external_objects@vk-vert-buf-update-errors

Cc: mesa-stable
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29303>
(cherry picked from commit 0e02de5a50cbbd89db5715ecc534d3b4c546d882)

00c6a487

by Lionel Landwerlin at 2024-09-17T17:13:37+02:00

brw: use a builder of the size of the physical register for uniforms

Should avoid any partial write non-sense on Xe2+.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 339630ab05 ("brw: enable A64 loads source rematerialization")
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31010>
(cherry picked from commit c16b27f66f2711480694231022bd02f53aef7c0d)

0722d2a0

by Lionel Landwerlin at 2024-09-17T17:13:38+02:00

brw: fix vecN rebuilds

When loading a 64bit address from the push constants, we'll load a
vec2, so we need to allocate 2 GRFs and MOV each component.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11831
Fixes: 339630ab05 ("brw: enable A64 loads source rematerialization")
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31010>
(cherry picked from commit 45377dc5c46c4f449307c7efc28a1b66a57cf6aa)

318f75ef

by Eric Engestrom at 2024-09-18T10:25:47+02:00

.pick_status.json: Update to ad3e6bb06a8e598be2381dfe2f5947f872b76bcd

cb29f5e0

by David Rosca at 2024-09-18T10:25:50+02:00

radeonsi: Disable EFC on VCN 2.2

VCN 2.2 doesn't support EFC.

Cc: mesa-stable

Reviewed-by: Leo Liu <leo.liu@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31198>
(cherry picked from commit 009017c33cc6e20b98763eb23ef43beb8cbe34b4)

f35ed83b

by Georg Lehmann at 2024-09-18T10:25:52+02:00

nir/instr_set: fix fp_fast_math

We can't just ignore the flags of the match, we need the union.

Fixes: 666647acaed ("nir: track some float controls bits per instruction")

Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31195>
(cherry picked from commit a3d6a770c0ca17e1d0ac69a614c945712ac8d4c1)

0a9bd166

by Samuel Pitoiset at 2024-09-18T10:25:53+02:00

radv,aco: fix legacy vertex attributes when offset >= stride on GFX6-7

The indexing needs to be adjusted and the best solution seems to
use soffset instead of const_offset, it's simpler and generate less
prologs than passing the vertex binding strides to the prolog.

Fixes dEQP-VK.pipeline.*.vertex_input.legacy_vertex_attributes.*stride_1*.

Fixes: 38cbc3c605f ("radv: advertise VK_EXT_legacy_vertex_attributes")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31209>
(cherry picked from commit 15b1790a1e9ef12bcfa0259dea370c3206de4c26)

b9fd84e9

by Samuel Pitoiset at 2024-09-18T10:28:07+02:00

radv: fix lowering VS inputs when offset >= stride on GFX6-7

This was supposed to be >=.

Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31209>
(cherry picked from commit ad3e6bb06a8e598be2381dfe2f5947f872b76bcd)

8a1843d3
by Eric Engestrom at 2024-09-18T18:28:24+02:00
```
docs: add release notes for 24.2.3
```
b235da67
by Eric Engestrom at 2024-09-18T18:30:19+02:00
```
VERSION: bump for 24.2.3
```
ebd2c2e6
by Eric Engestrom at 2024-09-18T19:17:33+02:00
```
docs: add sha sum for 24.2.3
```

d7d41493

by Timo Aaltonen at 2024-09-19T09:29:06+03:00

Merge branch 'upstream-unstable' into debian-unstable

3505a6e9
by Timo Aaltonen at 2024-09-19T09:31:42+03:00
```
version bump
```
e2c687b0
by Timo Aaltonen at 2024-09-20T21:56:07+03:00
```
patches: Fix build on armel/armhf with llvm-19.
```
aa54c4ff
by Timo Aaltonen at 2024-09-20T21:57:13+03:00
```
releasing package mesa version 24.2.3-1
```

2f14dd86

by Eric Engestrom at 2024-09-23T17:02:33+02:00

.pick_status.json: Update to 00c94e0cd4d46b093c20b2ec2be35ab3de3cb8a6

80965926

by Eric Engestrom at 2024-09-23T17:24:25+02:00

.pick_status.json: Mark 4b51a2c9daa92f39a2045ca48f707eb3cdb79018 as denominated

9c20fdda

by Lionel Landwerlin at 2024-09-23T17:24:25+02:00

brw: fix virtual register splitting to not go below physical register size

Otherwise we can end up generating invalid assembly not following
destination/source alignments requirements.

Fixes the following tests:

dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_4.tan_frag
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_2.tan_frag
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_1.tan_frag
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_3.tan_frag

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Backport-to: 24.2
Reviewed-by: Rohan Garg <rohan.garg@intel.com>
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com>
Reviewed-by: Francisco Jerez <currojerez@riseup.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31206>
(cherry picked from commit ed64eccab0537e70cb97c51695216a0b55426e21)

d19704bf

by Konstantin Seurer at 2024-09-23T17:24:25+02:00

radv: Initialize sqtt state before meta state

Sqtt needs to be initialized before BVH build pipelines are compiled to
avoid crashes on startup.

Fixes: 5fa22f9 ("radv: regroup all tools initialization in one helper")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31207>
(cherry picked from commit 60c53f5e63dd0a2e46032704719ec0666589528d)

36fb8e65

by Lucas Fryzek at 2024-09-23T17:24:25+02:00

drisw: Copy entire buffer ignoring damage regions

swapping buffers with damage is supposed to swap the entire buffer
and only pass the damage region as a hint to compositor as to what
updated. This change forces drisw to copy the entire buffer as there
is no method right now to check what was updated.

Fixes: cda627eb48a4e740bbfd687caee9037d6bdb09af
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31210>
(cherry picked from commit 755e795e4c0d2660129c14998425f7dd3299bdf9)

3799f13b

by Lucas Fryzek at 2024-09-23T17:24:25+02:00

egl/dri/wl: Move swrast damage region from put to swap

Pass application provided damage region to the compositor instead
of damaging the entire display. This also gives us the possibility
in the future to have put image only copy the parts of the framebuffer
that were modified.

Fixes: fa465e34cadacb7d29a664006b5d73bc2a8d9cf3
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31210>
(cherry picked from commit 32af15384de821269f9ec8b11effa0fc4961acee)

81b1e835

by Samuel Pitoiset at 2024-09-23T17:24:25+02:00

radv: fix assigning mesh shader outputs when clip/cull distances are read in FS

The per-primitive output offsets need to be recomputed.

Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31224>
(cherry picked from commit 5c897d00ef052e838a93559a743634f16eb0ffe3)

2df813ac

by Patrick Lerda at 2024-09-23T17:24:25+02:00

iris: fix iris_ensure_indirect_generation_shader() memory leak

This change ensures that all these allocations are using
the same memory context.

For instance, this issue is triggered with:
"piglit/bin/arb_shader_image_load_store-host-mem-barrier -auto -fbo":
Indirect leak of 32816 byte(s) in 1 object(s) allocated from:
    #0 0x7f49a35447ef in __interceptor_malloc (/usr/lib64/libasan.so.6+0xb17ef)
    #1 0x7f49998e4b4f in ralloc_size ../src/util/ralloc.c:118
    #2 0x7f49998e7521 in create_slab ../src/util/ralloc.c:801
    #3 0x7f49998e7521 in gc_alloc_size ../src/util/ralloc.c:840
    #4 0x7f49998e7d11 in gc_zalloc_size ../src/util/ralloc.c:868
    #5 0x7f49999a6126 in nir_alu_instr_create ../src/compiler/nir/nir.c:682
    #6 0x7f49999cba48 in clone_alu ../src/compiler/nir/nir_clone.c:217
    #7 0x7f49999cc85a in clone_instr ../src/compiler/nir/nir_clone.c:456
    #8 0x7f49999cee3a in clone_block ../src/compiler/nir/nir_clone.c:529
    #9 0x7f49999cee3a in clone_cf_list ../src/compiler/nir/nir_clone.c:583
    #10 0x7f49999d03be in clone_function_impl ../src/compiler/nir/nir_clone.c:660
    #11 0x7f49999d13f7 in nir_function_impl_clone ../src/compiler/nir/nir_clone.c:678
    #12 0x7f4999a0e2c5 in lower_call_function_impl ../src/compiler/nir/nir_functions.c:397
    #13 0x7f4999a0e2c5 in function_link_pass ../src/compiler/nir/nir_functions.c:430
    #14 0x7f4999a0e2c5 in function_link_pass ../src/compiler/nir/nir_functions.c:408
    #15 0x7f4999a0e2c5 in nir_function_instructions_pass ../src/compiler/nir/nir_builder.h:108
    #16 0x7f4999a0e2c5 in nir_link_shader_functions ../src/compiler/nir/nir_functions.c:452
    #17 0x7f499ca30b8f in link_libintel_shaders ../src/gallium/drivers/iris/iris_program_cache.c:329
    #18 0x7f499ca30b8f in iris_ensure_indirect_generation_shader ../src/gallium/drivers/iris/iris_program_cache.c:374
    #19 0x7f499d185267 in gfx9_emit_indirect_generate ../src/gallium/drivers/iris/iris_indirect_gen.c:593
    #20 0x7f499d119c79 in iris_upload_indirect_shader_render_state ../src/gallium/drivers/iris/iris_state.c:8744
    #21 0x7f499fe86b01 in iris_indirect_draw_vbo ../src/gallium/drivers/iris/iris_draw.c:233
    #22 0x7f499fe86b01 in iris_draw_vbo ../src/gallium/drivers/iris/iris_draw.c:343
    #23 0x7f499a174e43 in tc_call_draw_indirect ../src/gallium/auxiliary/util/u_threaded_context.c:3828
    #24 0x7f499a1557fe in batch_execute ../src/gallium/auxiliary/util/u_threaded_context.c:453
    #25 0x7f499a1557fe in tc_batch_execute ../src/gallium/auxiliary/util/u_threaded_context.c:504
    #26 0x7f499a167f26 in _tc_sync ../src/gallium/auxiliary/util/u_threaded_context.c:761
    #27 0x7f499a168888 in tc_texture_map ../src/gallium/auxiliary/util/u_threaded_context.c:2783
    #28 0x7f49986f2631 in pipe_texture_map ../src/gallium/auxiliary/util/u_inlines.h:556
    #29 0x7f49986f2631 in _mesa_map_renderbuffer ../src/mesa/main/renderbuffer.c:494
    #30 0x7f49991af7ca in readpixels_memcpy ../src/mesa/main/readpix.c:260
    #31 0x7f49991af7ca in _mesa_readpixels ../src/mesa/main/readpix.c:898
    #32 0x7f499931ee23 in st_ReadPixels ../src/mesa/state_tracker/st_cb_readpixels.c:575
    #33 0x7f49991b40b5 in read_pixels ../src/mesa/main/readpix.c:1199
    #34 0x7f49991b40b5 in _mesa_ReadnPixelsARB ../src/mesa/main/readpix.c:1216
    #35 0x7f49991b4a20 in _mesa_ReadPixels ../src/mesa/main/readpix.c:1231
...
SUMMARY: AddressSanitizer: 323648 byte(s) leaked in 201 allocation(s).

Fixes: 5438b1910464 ("iris: enable generated indirect draws")
Signed-off-by: Patrick Lerda <patrick9876@free.fr>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31313>
(cherry picked from commit b6b363c47838576609a92cdbf81753f6b2b9b446)

706c8a9b

by José Roberto de Souza at 2024-09-23T17:34:33+02:00

anv: Fix context id or exec queue used to open perf stream

It was always using device->context_id what is not valid in i915 when
has_vm_control is true or when running with Xe KMD.

But anv_AcquireProfilingLockKHR() don't have the queue information so
at least for now we will only support queries in a single queue.

And for consistency doing the same in
anv_QueueSetPerformanceConfigurationINTEL() although here we have the
queue parameter but queries are only supported in render engine
so it would only expose other queues if user set some parameters.

Cc: 24.2 <mesa-stable>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30652>
(cherry picked from commit c5d79d533a90ba19031f474a830343b7fa819383)

5e06c9d2

by José Roberto de Souza at 2024-09-23T17:42:26+02:00

anv: Add warning about mismatch between query queues

Cc: 24.2 <mesa-stable>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30652>
(cherry picked from commit 0a19d92ca5139e3804f769ef19c4c25609e73266)

0eaba0ef

by José Roberto de Souza at 2024-09-23T17:43:10+02:00

anv: Make sure all previous vm binds are done before execute perf query pool

The query pool batch buffer or other bos could not be bound when
exec starts.

Cc: 24.2 <mesa-stable>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30652>
(cherry picked from commit 141e7eaca7306c0b613acef6279fda982a0b6ba9)

2ba449a7

by José Roberto de Souza at 2024-09-23T17:43:11+02:00

anv: Check if vkCreateQueryPool() is being created in a supported queue

Turns out not even VK CTS was calling
vkEnumeratePhysicalDeviceQueueFamilyPerformanceQueryCountersKHR()
to check if queue supports query.
So here adding a explicity check in our implementation of
vkCreateQueryPool().

https://github.com/KhronosGroup/VK-GL-CTS/pull/482

Cc: 24.2 <mesa-stable>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30652>
(cherry picked from commit dec5a624e9bca24720c59d02c6a14f2e0c9f5f77)

31d25801

by José Roberto de Souza at 2024-09-23T17:43:13+02:00

anv: Fix condition to clear query pool with blorp

The comment above says it all, only when queue is not protected that
it is possible to clear query pool with blorp but it was checking
the opposite.

Fixes: d5b05265077a ("anv: propagate protected information for blorp operations")
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31239>
(cherry picked from commit 89c6fa1883fce20ddd6c4441b6f5e3af95f691da)

5daed0f4

by Patrick Lerda at 2024-09-23T17:44:09+02:00

i915: fix vertex atan regression

This is a regression happening with the commit 87b99d579772 ("nir: use copysign for atan").
Indeed, the opcode "copysign" was generating an incompatible i915 sequence.

For instance, this issue is triggered with
"deqp-gles2 --deqp-case=dEQP-GLES2.functional.shaders.operator.angle_and_trigonometry.atan2.highp_float_vertex":
deqp-gles2: ../src/compiler/nir/nir_lower_int_to_float.c:239: lower_alu_instr: Assertion `nir_alu_type_get_base_type(info->output_type) != nir_type_int && nir_alu_type_get_base_type(info->output_type) != nir_type_uint' failed.

Fixes: c4cec8423153 ("nir/i915g/r300/nv30: skip marking varyings as flat in some drivers")
Signed-off-by: Patrick Lerda <patrick9876@free.fr>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31315>
(cherry picked from commit 6e994fdb6eb01b553fa75a41bf271ba92da49f66)

db3da0d3

by Lionel Landwerlin at 2024-09-23T17:44:16+02:00

clc: find opencl headers from the installed llvm/clang location

A number of people report the headers not being found when running
intel-clc. I've run into the same issue but only on the most recent
Ubuntu version.

Signed-off-by: Lionel Landwerlin <llandwerlin@gmail.com>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30711>
(cherry picked from commit 0f6fa4679d6705660b83579a20fb50cfad2c0184)

24d87151

by Eric Engestrom at 2024-09-24T18:54:34+02:00

.pick_status.json: Update to bf41cf2eeffca5ec102e67f9c5e9f2c65deae43f

0d670136

by Lionel Landwerlin at 2024-09-24T18:54:41+02:00

anv: fix missing tracking for alpha-to-coverage runtime changes

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 9926aedc96 ("anv: enable EDS3 AlphaToCoverageEnable & RasterizationSamples")
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31196>
(cherry picked from commit fb3ae17d9616f9db1fc673059e61fe8465cc12a1)

1ae35236

by Lionel Landwerlin at 2024-09-24T18:54:43+02:00

anv: Only flush render target cache when detecting RT changes

We setup an empty render target when there are no color attachments,
which effectively makes it a different surface state. In most cases
the compiler will insert a null-rt bit in the extended descriptor
which means the RT isn't even accessed. But in some cases like
alpha-to-coverage output + depth/stencil write, we will access the
render target because using the null-rt will prevent alpha-to-coverage
from happening.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 2bd304bc8f ("anv: Skip the RT flush when doing depth-only rendering.")
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31196>
(cherry picked from commit badb3f6301d47f922ce52839ae77b0e851b1011e)

4bdf370f

by Lionel Landwerlin at 2024-09-24T18:54:44+02:00

iris: ensure null render target for specific cases

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: mesa-stable
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31196>
(cherry picked from commit 9b42215e0d6762151e3063fd83e779dee17ad058)

3db0f836

by Lionel Landwerlin at 2024-09-24T19:05:35+02:00

brw: move null_rt control up a layer

We'll want to tune this setting based on other parameters.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Backport-to: 24.2
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31196>
(cherry picked from commit b45ce7d43edb2ad784bbe2aafea339d50a15f779)

951ffef8

by Lionel Landwerlin at 2024-09-24T19:13:34+02:00

brw: disable null_rt only if color output does not affect other outputs

We found out that some HW changes on Xe2 make the HW avoid reading the
blend state if we're using the null_rt bit in the extended descriptor.

Since the alpha_to_coverage bit resides in the blend state, that state
is ignored and writes are going through to the depth/stencil buffers.

Disable null_rt in the color outputs if the color outputs can affect
other outputs (through alpha_to_coverage & omask).

Fixes tests in this pattern on Xe2 :

dEQP-VK.pipeline.*.multisample.alpha_to_coverage_no_color_attachment.*

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Backport-to: 24.2
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31196>
(cherry picked from commit 35ea8b6cd26bcea93f7157bacea4c781b45fd0aa)

fbc56751

by Boris Brezillon at 2024-09-24T19:13:37+02:00

pan/va: Fix nir_op_pack_uvec4_to_uint

We don't have a generic v4i8 on Valhall, we have to lower it to two
v2i8. Fortunately, bi_make_vec_to() hides the Bifrost/Valhall
differences, so use that for nir_op_pack_uvec4_to_uint.

Fixes: 934b0f1add1a ("pan/bi: Respect swizzles for more vector ops")
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Eric R. Smith <eric.smith@collabora.com>
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31280>
(cherry picked from commit dc1a7b94a80078a4701d84fbeb1d3427dc10c366)

7458491d

by Benjamin Otte at 2024-09-24T19:13:39+02:00

nvk: Don't emit critical messages during init

vk_error() is used for application errors with
VK_DEBUG_REPORT_ERROR_BIT_EXT.

Don't emit those for old hardware or old kernels.

Related: https://gitlab.gnome.org/GNOME/gtk/-/issues/7020

Fixes: 4db1bd584659 ("nvk/nvkmd: Implement dev and pdev for nouveau")
Signed-off-by: Benjamin Otte <otte@redhat.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31289>
(cherry picked from commit 9f612155fc378d5cf4a679c5903a2e4ace3c0e69)

4cef5b5a

by Iván Briano at 2024-09-24T19:13:42+02:00

anv: free shaders on rt pipeline compile error

We have not yet added the shaders to the pipeline->shaders array at
this point. If we couldn't compile (or were asked not to) the
pipeline, we were leaking references to any shaders found in the cache.
This would manifest as an assert on device destruction:
vk_pipeline_cache_destroy: Assertion `cache->object_cache->entries == 0' failed.

Fixes: 58c9f817cbe ("anv: fix pipeline executable properties with graphics libraries")

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31298>
(cherry picked from commit 1a45c8827b39c5c43c93393eed2319f6d805c965)

f11a326c

by Iván Briano at 2024-09-24T19:13:44+02:00

anv: skip rt pipeline compile if we found all shaders

When no pipeline cache is provided by the application and we rely on the
internal one, cache hits are not counted as such.
This was causing us to return COMPILE_REQUIRED on some cases where all
shaders had been found in the cache, as well as some unnecessary extra
processing in the case that we did have to compile the pipeline.

Fixes: 1dacea10f35 ("anv: implement caching for ray tracing pipelines")

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31298>
(cherry picked from commit 2e1c278e3d2e379a6d566d5aa75d7c1739886430)

2153e873

by Kenneth Graunke at 2024-09-24T19:13:47+02:00

intel/brw: Don't include sync.nop in INTEL_DEBUG instruction counts

In an earlier commit, I made us stop counting sync.nops in the shader
statistics we use for shader-db (brw_debug_log_message) and fossil-db
(stats->instructions = ...).  However, I missed adjusting the printout
for INTEL_DEBUG.

Fixes: 1497f4e0c2c4 ("intel/fs: Don't include sync.nop in instruction count statistics")
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31311>
(cherry picked from commit 878ae9708a9bc438849d11fed1df4f491c4084c1)

ac4deee5

by David Rosca at 2024-09-24T19:13:49+02:00

radeonsi/vcn: Don't reuse context with multiple VCN instances

Kernel does VCN instance scheduling per context, so when we have
multiple instances we should use new context to be able to utilize
all of them.
Another issue is with AV1, VCN 3 and VCN 4 only support AV1 on
first instance. Kernel parses IBs and switches to first instance when
it detects AV1, but this only works for first submitted IB in context.
The CS would be rejected if we first decode/encode other codecs, kernel
schedules on second instance (default) and then we try to decode/encode AV1.

Cc: mesa-stable

Reviewed-by: Leo Liu <leo.liu@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31249>
(cherry picked from commit 712e49f13729c5b7ff7f25b1fad0eea1c00e47be)

c17a0fb1

by Lionel Landwerlin at 2024-09-24T19:13:50+02:00

anv: add missing pipeline instance multiplier

Fix zink/anv tests : dEQP-GLES3.functional.fbo.multiview.samples_*

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11911
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31341>
(cherry picked from commit f81dc17e7d90b5280ba41ec9d3e13b53d3e24703)

12db0d43

by Sviatoslav Peleshko at 2024-09-24T19:13:52+02:00

anv: Update XeSS workaround executable names for Satisfactory 1.0

Fixes: 8b36d230 ("anv: workaround XeSS for Satisfactory")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11915
Signed-off-by: Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com>
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31343>
(cherry picked from commit 78a664b584f6adce368fa4b02438c014daede28e)

f8342726

by Eric Engestrom at 2024-09-25T12:39:31+02:00

.pick_status.json: Update to f6e7520b139f45971cdfa027aee29405c13c726d

5e9a09b6

by Konstantin Seurer at 2024-09-25T12:39:35+02:00

lavapipe: Fix report_ray_intersection affecting terminated rays

Fixes dEQP-VK.ray_tracing_pipeline.amber.flags-accept-first.

Fixes: d99e95e ("lavapipe: Implement VK_KHR_ray_tracing_pipeline")
Reviewed-by: Friedrich Vock <friedrich.vock@gmx.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31186>
(cherry picked from commit 4824bcdd5dc85eecf0f80dab9dbc09e1a26198ae)

fc783e6d

by Konstantin Seurer at 2024-09-25T12:39:40+02:00

lavapipe: Do not return in report_ray_intersection

report_ray_intersection should not terminate invocations.

Fixes: d99e95e ("lavapipe: Implement VK_KHR_ray_tracing_pipeline")
Reviewed-by: Friedrich Vock <friedrich.vock@gmx.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31186>
(cherry picked from commit 466bbaf40f62a4021440906b9487d477c0273156)

c56802bf

by Konstantin Seurer at 2024-09-25T12:39:41+02:00

radv: Fix report_ray_intersection affecting terminated rays

Fixes dEQP-VK.ray_tracing_pipeline.amber.flags-accept-first.

cc: mesa-stable

Reviewed-by: Friedrich Vock <friedrich.vock@gmx.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31186>
(cherry picked from commit 25b09b9c5a435d1442ae67650a7217af9fa4f07f)

dbee14f0

by Samuel Pitoiset at 2024-09-25T12:39:43+02:00

aco: fix descriptor leaking when printing assembly with CLRX

This can explode the maximum number of descriptors.

Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31344>
(cherry picked from commit 087ef34b9ccef5beb671a65a2069c375574fb38d)

417370b3

by Mike Blumenkrantz at 2024-09-25T12:39:45+02:00

vk/image: fix view creation for planar video aspects

drivers do implement this

cc: mesa-stable

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31318>
(cherry picked from commit c4d6d9254ab2d9b92ee5ece4d6e4cf8fa3facc1a)

a1ba335a

by Samuel Pitoiset at 2024-09-25T12:39:49+02:00

radv: do not keep executable info when compiling shaders for ESO

This is completely useless and it's wasting memory.

Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31345>
(cherry picked from commit a9095f0dbf6deae508b43eeb993d2a4427d66ccd)

67add854

by Eric Engestrom at 2024-09-28T14:22:40+02:00

.pick_status.json: Update to a74ebffc6a6193445231563cdaa4494933b6c281

0aa2d2ce

by Valentine Burley at 2024-09-28T14:35:09+02:00

freedreno/devices: Fix A740v3 from Quest 3

Based on a patch by weab chan.

The chip_id wasn't getting picked up with the capital B, so use lowercase hex values
like everywhere else.

Move it as a separate entry and turn on enable_tp_ubwc_flag_hint as the Quest 3 ships
with blob version 7xx, and expose the name as FD740v3 for clarity.

Unify the raw_magic_regs with a740, but as noted by Danylo in the initial enablement, set
RB_DBG_ECO_CNTL to 1 on a740v3 in magic_regs.

Fixes image corruption issues on this device.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10316
Fixes: 0b5097081a3 ("freedreno/devices: Add A740v3 from Quest 3")
Signed-off-by: Valentine Burley <valentine.burley@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31328>
(cherry picked from commit 7968b356f8cabe862f91d2d82e98195b4b8bb78a)

6ca857a8

by Nikita Popov at 2024-09-28T14:35:13+02:00

gallium: Don't pass avx512er and avx512pf features on LLVM 19

These target features have been remove in LLVM 19, and cause
warnings like the following to be printed:

    '-avx512er' is not a recognized feature for this target (ignoring feature)
    '-avx512pf' is not a recognized feature for this target (ignoring feature)

Do not pass these target features on LLVM 19 and newer.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11870
Reviewed-by: Dave Airlie <airlied@redhat.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31321>
(cherry picked from commit a8eed9cca26b1c4b6526be7d042adec6703a30ae)

b9d71b96

by Iván Briano at 2024-09-28T14:35:47+02:00

vulkan: use standard sample locations if there's no VkPipelineSampleLocationsStateCreateInfoEXT

If the pipeline is created with no
VkPipelineSampleLocationsStateCreateInfoEXT, but
VK_DYNAMIC_STATE_SAMPLE_LOCATIONS_ENABLE_EXT is set, we end up
dereferencing a NULL pointer.

Fixes future dEQP-VK.pipeline.*.extended_dynamic_state.*.sample_locations_enable_no_create_info

Fixes: 1deb83fb86d ("vulkan: Add more dynamic multisample states")

Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31377>
(cherry picked from commit 101a803858e7ffdaf50d3adf571a6a566463276f)

24589d82

by Colin Marc at 2024-09-28T14:41:51+02:00

vulkan/video: set HEVC nuh_temporal_id_plus1 and nal_unit_type correctly

This is only relevant for hierarchical coding using sub-layers.

Fixes: 72f52329cd7 ("vulkan/video: add a nal_unit lookup for hevc")

Reviewed-by: Hyunjun Ko <zzoon@igalia.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Colin Marc <hi@colinmarc.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31303>
(cherry picked from commit 2cf5ef37bab492fe70e4ea4119ff7b3772f839dc)

288a6890

by Colin Marc at 2024-09-28T14:41:52+02:00

radv/video: set TemporalId correctly

This is only relevant for hierarchical coding using sub-layers.

Fixes: 967e4e09dee ("radv/video: add h265 encode support")
Reviewed-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Colin Marc <hi@colinmarc.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31303>
(cherry picked from commit 88dacc3d80522f0b6a7188da73886432fc651e15)

d0cc8a43

by Dave Airlie at 2024-09-28T14:41:53+02:00

radv/video/enc: report pictureAccessGranularity of CTB size.

Reviewed-by: Lynne <dev@lynne.ee>
Fixes: 967e4e09dee ("radv/video: add h265 encode support")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31158>
(cherry picked from commit c78e32da3bd5a274b656b52b79273564cbfbfc9d)

23a04fc9

by Dave Airlie at 2024-09-28T14:41:54+02:00

radv/video: add encode field for vcn4

Reviewed-by: Lynne <dev@lynne.ee>
Fixes: 967e4e09dee ("radv/video: add h265 encode support")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31158>
(cherry picked from commit db5312f842c37189edd476f662b76e728b23722c)

b8d43cf0

by Dave Airlie at 2024-09-28T14:41:55+02:00

radv/video: handle missing h265 feedback struct.

I'm not sure this should be missing, but handle if if it is.

Reviewed-by: Lynne <dev@lynne.ee>
Fixes: 7c6e3c70b6c1 ("radv/video/enc: report pps overrides in feedback for h265")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31158>
(cherry picked from commit a59efe40b2be25f18de6afb24b497f8e538e36b8)

30c54336

by Thomas Wagner at 2024-09-28T14:41:57+02:00

llvmpipe: Fix external memory object reference

Make the external memory object a reference counted object. Without
that deleting the memory object in OpenGL would also delete and unmap
the memfd, which causes any operation on a texture or buffer that is
bound to that memory object to access invalid memory.

Fixes: 1608a815e33 ("llvmpipe: add support for EXT_memory_object(_fd)")
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31022>
(cherry picked from commit af16ec6e0c98c70f64fccd9901dd1d869a72fec8)

660ddc29

by Thomas Wagner at 2024-09-28T14:41:58+02:00

llvmpipe: Unmap DMA buffer to release all resources

If the buffer is not unmapped then a reference to the DMA buffer
is still kept. The DRM device is then not properly cleaned up.
This can cause the application to keep a DRM device open which is
still DRM master without any visible open file descriptors.

Fixes: d74ea2c117f ("llvmpipe: Implement dmabuf handling")
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31022>
(cherry picked from commit 39156b6cd4dbdfaf158220ae6f81749206031820)

66f32ddd

by Thomas Wagner at 2024-09-28T14:41:59+02:00

llvmpipe: properly save llvmpipe_memory_allocation in memory_object

Importing an opaque fd no longer returns the mapped pointer but
a pointer to llvmpipe_memory_allocation to support both memfds and
dma bufs. This saves the pointer with the correct type and we can
unwrap the mapped data in a correct way.

Fixes: d74ea2c117f ("llvmpipe: Implement dmabuf handling")
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31022>
(cherry picked from commit 3e01c15fa7170fd173c0a07e495640d92df81b0d)

bcb9c3d4

by Lionel Landwerlin at 2024-09-28T14:42:03+02:00

zink: avoid host transfer usage with sparse

It's not a requirement to support this for implementations. Also
doesn't make much sense...

Fixes
KHR-GL46.sparse_texture_clamp_tests.SparseTextureClampLookupResidency
on Anv with VK_EXT_host_image_copy enabled.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: f24891269d ("zink: check/use suboptimal HIC during ici init")
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31391>
(cherry picked from commit fe57b1022108c8b2284b5995e767f9f9c875e70d)

b362b71c

by Iván Briano at 2024-09-28T14:45:35+02:00

anv: allocate sparse descriptor buffers from the correct heap

When allocating a buffer normally, this flag gets to the allocator from
the memory requirements, but when sparse bindings are created we were
checking for them but never setting them.
Fixes sparse descriptor buffers on Xe2.
Makes the failure on TRTT more obvious.

Fixes: c6a91f16952 ("anv: add new heap/pool for descriptor buffers")
Fixes: 692e1ab2c1e ("anv: get rid of the second dynamic state heap")

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31372>
(cherry picked from commit a4cbc903a80f31d303e4bb4d0f1a0bc76d957d95)

6e137386

by Daniel Svensson at 2024-09-28T14:45:57+02:00

zink: add spirv_info_h dep to libzink.

Build dependency of zink_compiler.c.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11926
Fixes: a09c5d55ed7 ("spirv: Auto-generate spirv_info.h")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31407>
(cherry picked from commit 55e1a596f6c5f89dc2cef5708c50ece0b025218d)

5f10f872

by Mike Blumenkrantz at 2024-09-28T14:45:59+02:00

zink: check HAVE_LIBDRM for xf86drm.h include

cc: mesa-stable

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31408>
(cherry picked from commit d1f6e52de271954f678f1f4cacfc53c36877833c)

7b1e3ccc

by Faith Ekstrand at 2024-09-28T14:46:00+02:00

nvk: Handle aspects in D32_S8_UINT copies

Fixes: 3572f5cd7e27 ("nvk: add support for D32_SFLOAT_S8_UINT")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31410>
(cherry picked from commit 62eccb66a691416fbe117d2e228351e43d42fc82)

e44d3904

by Mohamed Ahmed at 2024-09-28T14:46:01+02:00

nvk: Block off non-2D DRM format modifier images

Fixes: cd428e01d787 ("nvk: Advertise VK_EXT_image_drm_format_modifier")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30044>
(cherry picked from commit 5990de9182dd91a5b2b81296110310191776deef)

ea9848fb

by Eric Engestrom at 2024-10-01T12:45:50+02:00

.pick_status.json: Update to 85bc72ad263e0c6620fe8c74d29e68411971013b

afb4dc2d

by Rhys Perry at 2024-10-01T12:46:03+02:00

aco/tests: update assembler tests for llvm

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Backport-to: 24.2
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31316>
(cherry picked from commit 9fb97085d1e637245e1e63cfc690a89f3f7d320f)

15a04962

by Rhys Perry at 2024-10-01T12:46:05+02:00

aco: workaround hazards in emit_long_jump

fossil-db (navi31):
Totals from 29 (0.04% of 79395) affected shaders:
CodeSize: 17612888 -> 17615096 (+0.01%)

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Backport-to: 24.2
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31316>
(cherry picked from commit 7f092cbd91c7df88f4de4ad6d8994d514b6bb119)

de4dc7aa

by Corentin Noël at 2024-10-01T12:46:07+02:00

virgl: Avoid a race condition on handle removal

We were unlocking the bo handles hash table right after removing the bo handle
and afterward closing it. This leads to race conditions where the handle could
have been re-acquired on another thread. As the kernel would return the same
bo handle and do not reference count them, this leads to it being used after
being closed.

Signed-off-by: Corentin Noël <corentin.noel@collabora.com>
Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
cc: mesa-stable

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31421>
(cherry picked from commit bef454f22778c6a1393185ddcc5dbcdc7868d679)

cc8578e1

by David Heidelberg at 2024-10-01T12:46:08+02:00

freedreno/ir3: mad.x24 is not safe to lower

Fixes following piglit tests on Adreno 630:
program@execute@builtin@builtin-char-mad_sat-1.0.generated
program@execute@builtin@builtin-uchar-mad_sat-1.0.generated

Cc: mesa-stable
Reviewed-by: Connor Abbott <cwabbott0@gmail.com>
Signed-off-by: David Heidelberg <david@ixit.cz>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31334>
(cherry picked from commit c36cc1fdf2564ce0bb468e10633dd1c78652fcf9)

82bd5ccd

by David Heidelberg at 2024-10-01T12:46:09+02:00

freedreno/ir3: Do not allow 16-bit mad.x24

Doesn't work with half registers. For 16-bit operations, there is mad.x16.

Cc: mesa-stable
Reviewed-by: Connor Abbott <cwabbott0@gmail.com>
Signed-off-by: David Heidelberg <david@ixit.cz>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31334>
(cherry picked from commit 51f04dc804262029cf32066ae24a8c66f8e36014)

bb20e969

by Patrick Lerda at 2024-10-01T12:46:10+02:00

r600/sfn: fix class Shader object m_register_allocations memory leak

For instance, this issue is triggered with "piglit/bin/glsl-fs-loop -auto -fbo":
Indirect leak of 120 byte(s) in 5 object(s) allocated from:
    #0 0x7f8e7930ef57 in operator new(unsigned long) (/usr/lib64/libasan.so.6+0xb2f57)
    #1 0x7f8e6dc8c68a in __gnu_cxx::new_allocator<std::_List_node<nir_intrinsic_instr*> >::allocate(unsigned long, void const*) /usr/include/c++/11.4.0/ext/new_allocator.h:127
    #2 0x7f8e6dc8c68a in std::allocator_traits<std::allocator<std::_List_node<nir_intrinsic_instr*> > >::allocate(std::allocator<std::_List_node<nir_intrinsic_instr*> >&, unsigned long) /usr/include/c++/11.4.0/bits/alloc_traits.h:464
    #3 0x7f8e6dc8c68a in std::__cxx11::_List_base<nir_intrinsic_instr*, std::allocator<nir_intrinsic_instr*> >::_M_get_node() /usr/include/c++/11.4.0/bits/stl_list.h:443
    #4 0x7f8e6dc8c68a in std::_List_node<nir_intrinsic_instr*>* std::__cxx11::list<nir_intrinsic_instr*, std::allocator<nir_intrinsic_instr*> >::_M_create_node<nir_intrinsic_instr* const&>(nir_intrinsic_instr* const&) /usr/include/c++/11.4.0/bits/stl_list.h:635
    #5 0x7f8e6dc8c68a in void std::__cxx11::list<nir_intrinsic_instr*, std::allocator<nir_intrinsic_instr*> >::_M_insert<nir_intrinsic_instr* const&>(std::_List_iterator<nir_intrinsic_instr*>, nir_intrinsic_instr* const&) /usr/include/c++/11.4.0/bits/stl_list.h:1912
    #6 0x7f8e6dc8c68a in std::__cxx11::list<nir_intrinsic_instr*, std::allocator<nir_intrinsic_instr*> >::push_back(nir_intrinsic_instr* const&) /usr/include/c++/11.4.0/bits/stl_list.h:1213
    #7 0x7f8e6dc8c68a in r600::Shader::scan_instruction(nir_instr*) ../src/gallium/drivers/r600/sfn/sfn_shader.cpp:655
    #8 0x7f8e6dc8cc2a in r600::Shader::scan_shader(nir_function const*) ../src/gallium/drivers/r600/sfn/sfn_shader.cpp:554
    #9 0x7f8e6dcab5bc in r600::Shader::process(nir_shader*) ../src/gallium/drivers/r600/sfn/sfn_shader.cpp:526
    #10 0x7f8e6dcabae1 in r600::Shader::translate_from_nir(nir_shader*, pipe_stream_output_info const*, r600_shader*, r600_shader_key const&, r600_chip_class, radeon_family) ../src/gallium/drivers/r600/sfn/sfn_shader.cpp:494
    #11 0x7f8e6da5bf15 in r600_shader_from_nir ../src/gallium/drivers/r600/r600_sfn.cpp:111
    #12 0x7f8e6da5db2c in r600_pipe_shader_create ../src/gallium/drivers/r600/r600_shader.c:198
    #13 0x7f8e6da95c62 in r600_shader_select ../src/gallium/drivers/r600/r600_state_common.c:961
    #14 0x7f8e6da9c09f in r600_update_derived_state ../src/gallium/drivers/r600/r600_state_common.c:1888
    #15 0x7f8e6da9c09f in r600_draw_vbo ../src/gallium/drivers/r600/r600_state_common.c:2219
    #16 0x7f8e6d55229d in u_vbuf_draw_vbo ../src/gallium/auxiliary/util/u_vbuf.c:1782
    #17 0x7f8e6c5d6322 in _mesa_draw_arrays ../src/mesa/main/draw.c:1204

Fixes: 5de814171bd0 ("r600/sfn: Allow skipping backend shader optimization for a subset of shaders")
Signed-off-by: Patrick Lerda <patrick9876@free.fr>
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27334>
(cherry picked from commit b660c7369318079ad61628f0540fceb0e08e8b6d)

4f57a4da

by Patrick Lerda at 2024-10-01T12:46:15+02:00

r600/sfn: fix class Shader object last_alu_with_indirect_reg memory leak

For instance, this issue is triggered with "piglit/bin/glsl-vs-arrays -auto -fbo":
Direct leak of 104 byte(s) in 1 object(s) allocated from:
    #0 0x7f2fab415f57 in operator new(unsigned long) (/usr/lib64/libasan.so.6+0xb2f57)
    #1 0x7f2f9fd9d541 in __gnu_cxx::new_allocator<std::__detail::_Hash_node_base*>::allocate(unsigned long, void const*) /usr/include/c++/11.4.0/ext/new_allocator.h:127
    #2 0x7f2f9fd9d541 in std::allocator_traits<std::allocator<std::__detail::_Hash_node_base*> >::allocate(std::allocator<std::__detail::_Hash_node_base*>&, unsigned long) /usr/include/c++/11.4.0/bits/alloc_traits.h:464
    #3 0x7f2f9fd9d541 in std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<std::pair<int const, r600::Instr*>, false> > >::_M_allocate_buckets(unsigned long) /usr/include/c++/11.4.0/bits/hashtable_policy.h:1927
    #4 0x7f2f9fd9d541 in std::_Hashtable<int, std::pair<int const, r600::Instr*>, std::allocator<std::pair<int const, r600::Instr*> >, std::__detail::_Select1st, std::equal_to<int>, std::hash<int>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_allocate_buckets(unsigned long) /usr/include/c++/11.4.0/bits/hashtable.h:440
    #5 0x7f2f9fd9d541 in std::_Hashtable<int, std::pair<int const, r600::Instr*>, std::allocator<std::pair<int const, r600::Instr*> >, std::__detail::_Select1st, std::equal_to<int>, std::hash<int>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_rehash_aux(unsigned long, std::integral_constant<bool, true>) /usr/include/c++/11.4.0/bits/hashtable.h:2382
    #6 0x7f2f9fd9d541 in std::_Hashtable<int, std::pair<int const, r600::Instr*>, std::allocator<std::pair<int const, r600::Instr*> >, std::__detail::_Select1st, std::equal_to<int>, std::hash<int>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_rehash(unsigned long, unsigned long const&) /usr/include/c++/11.4.0/bits/hashtable.h:2361
    #7 0x7f2f9fd9d541 in std::_Hashtable<int, std::pair<int const, r600::Instr*>, std::allocator<std::pair<int const, r600::Instr*> >, std::__detail::_Select1st, std::equal_to<int>, std::hash<int>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_insert_unique_node(unsigned long, unsigned long, std::__detail::_Hash_node<std::pair<int const, r600::Instr*>, false>*, unsigned long) /usr/include/c++/11.4.0/bits/hashtable.h:2021
    #8 0x7f2f9fd9e7f8 in std::__detail::_Map_base<int, std::pair<int const, r600::Instr*>, std::allocator<std::pair<int const, r600::Instr*> >, std::__detail::_Select1st, std::equal_to<int>, std::hash<int>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true>, true>::operator[](int&&) /usr/include/c++/11.4.0/bits/hashtable_policy.h:741
    #9 0x7f2f9fd9f6fe in std::unordered_map<int, r600::Instr*, std::hash<int>, std::equal_to<int>, std::allocator<std::pair<int const, r600::Instr*> > >::operator[](int&&) /usr/include/c++/11.4.0/bits/unordered_map.h:984
    #10 0x7f2f9fd9f6fe in r600::Shader::InstructionChain::visit(r600::AluInstr*) ../src/gallium/drivers/r600/sfn/sfn_shader.cpp:1358
    #11 0x7f2f9fd8f309 in r600::Shader::emit_instruction(r600::Instr*) ../src/gallium/drivers/r600/sfn/sfn_shader.cpp:1419
    #12 0x7f2f9fd8f822 in r600::RegisterReadHandler::visit(r600::LocalArray&) ../src/gallium/drivers/r600/sfn/sfn_shader.cpp:1040
    #13 0x7f2f9fd8e726 in r600::Shader::emit_load_reg_indirect(nir_intrinsic_instr*) ../src/gallium/drivers/r600/sfn/sfn_shader.cpp:993
    #14 0x7f2f9fd8de5c in r600::Shader::process_instr(nir_instr*) ../src/gallium/drivers/r600/sfn/sfn_shader.cpp:848
    #15 0x7f2f9fd8de5c in r600::Shader::process_block(nir_block*) ../src/gallium/drivers/r600/sfn/sfn_shader.cpp:836
    #16 0x7f2f9fd962f2 in r600::Shader::process_cf_node(nir_cf_node*) ../src/gallium/drivers/r600/sfn/sfn_shader.cpp:669
    #17 0x7f2f9fdac01a in r600::Shader::process(nir_shader*) ../src/gallium/drivers/r600/sfn/sfn_shader.cpp:537
    #18 0x7f2f9fdac3d1 in r600::Shader::translate_from_nir(nir_shader*, pipe_stream_output_info const*, r600_shader*, r600_shader_key const&, r600_chip_class, radeon_family) ../src/gallium/drivers/r600/sfn/sfn_shader.cpp:494
    #19 0x7f2f9fb5c8f5 in r600_shader_from_nir ../src/gallium/drivers/r600/r600_sfn.cpp:111
    #20 0x7f2f9fb5e50c in r600_pipe_shader_create ../src/gallium/drivers/r600/r600_shader.c:198
    #21 0x7f2f9fb96642 in r600_shader_select ../src/gallium/drivers/r600/r600_state_common.c:961
    #22 0x7f2f9fb97340 in r600_create_shader_state ../src/gallium/drivers/r600/r600_state_common.c:1056
    #23 0x7f2f9e060f82 in st_create_common_variant ../src/mesa/state_tracker/st_program.c:720
    #24 0x7f2f9e06e779 in st_get_common_variant ../src/mesa/state_tracker/st_program.c:773
    #25 0x7f2f9e06f78d in st_precompile_shader_variant ../src/mesa/state_tracker/st_program.c:1259
    #26 0x7f2f9e06f78d in st_finalize_program ../src/mesa/state_tracker/st_program.c:1345
    #27 0x7f2f9ead0f20 in st_link_glsl_to_nir ../src/mesa/state_tracker/st_glsl_to_nir.cpp:723
    #28 0x7f2f9ead0f20 in st_link_shader ../src/mesa/state_tracker/st_glsl_to_nir.cpp:951
    #29 0x7f2f9e9b0d15 in link_program ../src/mesa/main/shaderapi.c:1336
    #30 0x7f2f9e9b0d15 in link_program_error ../src/mesa/main/shaderapi.c:1447

Fixes: ddb167e81a18 ("r600/sfn: Handle indirect array load/store dependencies better")
Signed-off-by: Patrick Lerda <patrick9876@free.fr>
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27334>
(cherry picked from commit 242da61b9d33fe9e3cda9c156303792384ec7e2a)

f8b6a925

by Gert Wollny at 2024-10-01T12:46:18+02:00

nir/opt_algebraic: Allow two-step lowering of ftrunc@64 to use ffract@64

If ftrunc@64 is lowered by nir_lower_doubles it is turned into a
comparable long series of 32 bit operations. If the hardware
supports ffract@64 then nir_opt_algebraic can first lower ftrunc@64
to use some combinations with ffloor@64. They can then be turned
into a combination of fsub@64 and ffract@64 resulting in less
all-over instructions.

Fixes: 5218cff34b34cec4819a382c500934fd9d991a60
   nir/algebraic: avoid double lowering of some fp64 operations

Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29281>
(cherry picked from commit f19f1ec17b3da6019e57b92ae02679e8dad591c7)

5f702da3

by Gert Wollny at 2024-10-01T14:16:49+02:00

Revert: r600/sfn: call nir_lower_doubles explicitely"

This reverts commit 36c81b5e88e68e61e93bc287e243fd29abbff97a.

With

   nir/opt_algebraic: Allow two-step lowering of ftrunc@64 to use ffract@64

it is no longer necessary to call nir_lower_doubles explicitely in r600/sfn.

Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29281>
(cherry picked from commit 29fd096d91230f6232bda6e9adc9520e3b6b22b4)

912e2be8

by GKraats at 2024-10-01T14:16:55+02:00

i915g: fix texture3d npot mipmaps

At i945_texture_layout_3d() util_next_power_of_two() is called,
which oversizes the npot-blocks for every level to get power of 2
for width and height. Hardware doesnot expect these oversized
npot-blocks. The call is removed.

Code is added to align allocation of npot-blocks correctly.

Also at i915_texture_layout_3d() the util_next_power_of_two() call
is removed. Besides the computation of block-allocation is changed,
because it still was using classic i915-coding.

Cc: mesa-stable

Signed-off-by: GKraats <vd.kraats@hccnet.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31057>
(cherry picked from commit a95bd2dcf0ec16b41b474eb09e50e742c5569439)

b2a0d88a

by Caio Oliveira at 2024-10-01T15:42:09+02:00

intel/brw: Skip per-primitive inputs when computing flat input mask

The per-primitive have their own separate section in the FS thread
payload, and are not considered when setting the mask in
3STATE_SBE's ConstantInterpolationEnable.

This is also consistent with what is done for brw_interp_reg().

Fixes
- dEQP-VK.mesh_shader.ext.misc.clip_geom_provoking_last
- dEQP-VK.mesh_shader.ext.misc.clip_geom_and_task_shader_provoking_last

Backport-to: 24.2
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11844
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31417>
(cherry picked from commit 93c3780bc1d6f829126e0472300fc71f281ce187)

a307748a

by Sviatoslav Peleshko at 2024-10-01T15:42:28+02:00

intel/brw: Don't apply discard_if condition opt if it can change results

We can't just always negate the alu instruction's cmod, because negating
it can produce different results when the argument is NaN float. We can
still do that if the condition is == or !=.

Fixes: 0ba9497e ("intel/fs: Improve discard_if code generation")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11800
Signed-off-by: Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31042>
(cherry picked from commit 57344052b6abe57b528cabc789556db9098b5629)

3598b41e

by GKraats at 2024-10-02T15:12:48+02:00

X11: fix crash of gnome-shell if mesa is compiled with legacy-x11=dri2

X11 starts up if Mesa is compiled with legacy-x11=dri2 and shows
the desktop.
It crashes with segfault as soon as an application is started.
At src/egl/drivers/dri2/platform_x11.c function dri2_from_names
(at src/gallium/frontends/dri/dri2.c) should be called
with offset address instead of with offset value.

Signed-off-by: GKraats <vd.kraats@hccnet.nl>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31406>
(cherry picked from commit 6c84103276a9a212764e83abcd09f2c663c256fd)

2a0537c5

by Eric Engestrom at 2024-10-02T15:13:18+02:00

.pick_status.json: Update to 61f3294786d52f3a95f0fa314eb21d90a0485624

f62fb5a0

by Tapani Pälli at 2024-10-02T15:13:24+02:00

drirc/anv: force_vk_vendor=-1 for Faaast Penguin

Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11955
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31438>
(cherry picked from commit 8d82b7cfe80eb1e73fe1d5685728a0a195bde958)

35f27de9

by Rhys Perry at 2024-10-02T15:13:26+02:00

nir/opt_loop: rematerialize header block derefs in their use blocks

Otherwise, we could end up with phis of derefs.

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Fixes: 6b4b04473986 ("nir/opt_loop: add loop peeling optimization")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31324>
(cherry picked from commit 0484044b1a1e9b54d05ffdcd74264b66d0187d29)

8512574c

by Mike Blumenkrantz at 2024-10-02T15:13:27+02:00

util/vbuf: delete/fix broken incompatible stride calc

this was accidentally duplicated from the conditional below,
except this one didn't have the buffer_stride_unaligned
caps check, which meant any 4-byte attrib which was
unaligned got marked for rewrites even on drivers
supporting unaligned strides

the correct change should have checked the stride against
the component size in the top case

Fixes: 76725452239 ("gallium: move vertex stride to CSO")

Acked-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31425>
(cherry picked from commit 8a1ce9a1447f23e50f0dc9042afae16c4aac3e52)

04f96230

by Aleksi Sapon at 2024-10-02T15:13:28+02:00

llvmpipe: fix quad group helper invocation masking

https://docs.vulkan.org/spec/latest/chapters/shaders.html#shaders-helper-invocations

Concretely, this fixes implicit derivatives of SSBO
variables on triangle edges, which are used in USD.

cc: mesa-stable

Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31047>
(cherry picked from commit 942a584db26e75dc62fd5e49533f86a0aa5e3727)

be0dcb15

by Aleksi Sapon at 2024-10-02T15:13:29+02:00

llvmpipe: correctly implement output variables loads

GLSL 4.60 spec, section 4.3.6: output variables
should behave like private variables during shader
execution. Framebuffer fetching now also checks
that fb_fetch_output is set on the variable.

cc: mesa-stable

Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31047>
(cherry picked from commit 06dfcffd205af0db5e23cdaea72ee0c1bb2512c5)

f2c69e6a

by Mike Blumenkrantz at 2024-10-02T15:50:54+02:00

mesa: fix sample count handling for MSRTT

this extension specifies error checking (which was not implemented)
and also sample count clamping needs to be done since the samples
specified are just min samples and not an exact param

cc: mesa-stable

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31235>
(cherry picked from commit 894b37e06099c60f371e9b181e3f84cfc29c49bb)

bb41acfc

by Eric Engestrom at 2024-10-03T11:31:26+02:00

.pick_status.json: Update to 023277173ce1d84c448626ded21e4d2b66363b41

5ee91030

by Erik Faye-Lund at 2024-10-03T11:49:00+02:00

panfrost: unify compressed formats

This reduces some duplication, and we're going to start needing the
texfeat format on valhall anyway...

Fixes: 0c1fde956bf ("panfrost: Add Valhall compressed formats")
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31419>
(cherry picked from commit 8072c901e1d7c518ada48a2fd8436c6294f79e2a)

d3d55ac4

by Erik Faye-Lund at 2024-10-03T11:49:05+02:00

panfrost: store texfeat_bit in panfrost_format

To avoid increasing memory usage, make sure we pack this together with
the hw format.

This will be used in the next commit.

Fixes: 0c1fde956bf ("panfrost: Add Valhall compressed formats")
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31419>
(cherry picked from commit 1637fa3d85756be4926d1d77f402540a4a07946e)

5f51b9ad

by Erik Faye-Lund at 2024-10-03T11:49:06+02:00

panfrost: check fmt.bitfeat_bit for compressed-support

Because we map compressed formats to the interchange-formats on V9 and
later, we end up not actually checking for compressed support here, but
instead always checking bit 0, which is reserved in the spec.

So let's instead explicitly check bitfeat_bit here instead, which we
conveniently stored away in the previous commit.

Use 1u instead of 1 for the shifted constant, to avoid undefined
behavior when we're testing bit 31.

Fixes: 0c1fde956bf ("panfrost: Add Valhall compressed formats")
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31419>
(cherry picked from commit 23cad7c695c0e95e50c4cb3996d86e3f5e261d73)

6d49aada

by Lionel Landwerlin at 2024-10-03T11:49:38+02:00

anv: limit 22018402687 to impacted platforms

ARL is impacted, but LNL is not.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Backport-to: 24.2
Reviewed-by: Rohan Garg <rohan.garg@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31481>
(cherry picked from commit 18e2c25dad9a2f0d69a634b7a852313153a7d238)

50db8bd4

by Lionel Landwerlin at 2024-10-03T11:49:39+02:00

anv: consolidate pre/post draw workaround in helpers

This avoids sprinkling those all over the code base. Debug breakpoints
are put in there too.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Backport-to: 24.2
Reviewed-by: Rohan Garg <rohan.garg@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31481>
(cherry picked from commit 4cdb5de1638cb389c077289a5ddb1c991ca7f7e4)

8add14f8

by Lionel Landwerlin at 2024-10-03T11:49:40+02:00

anv: optimize WA 16011107343/22018402687

No need to emit the instruction twice.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Backport-to: 24.2
Reviewed-by: Rohan Garg <rohan.garg@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31481>
(cherry picked from commit 1f2ad64b63944257075f798e9f009c002102cbee)

232aef4e

by Eric Engestrom at 2024-10-03T11:50:28+02:00

egl: fix dri2_from_names() call

The offset argument is `int *offsets`.

!31406 pointed this out and I checked for other instances of the same bug.

Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31484>
(cherry picked from commit 842a7b2821e21b5869160025b3efd85626e87578)

bbc6bb1f

by Marek Olšák at 2024-10-03T11:50:56+02:00

nir/opt_vectorize_io: fix skipped output vectorization if inputs were vectorized

Fixes: 2514999c9c5d4b64b00 - nir: add nir_opt_vectorize_io, vectorizing lowered IO

Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31454>
(cherry picked from commit f546df95a6662c187a5fa15aa20de9af89e17488)

f041e058

by Timothy Arceri at 2024-10-03T11:50:57+02:00

glsl: fix gl_{Clip,Cull}Distance error messages

The error message in the linker that checked
gl_MaxCombinedClipAndCullDistances would never be issued because the
compiler was already doing the check. I think the compiler might have
been done this way in the original commit d656736b as the linker
only sets the size when the clip/cull outputs are written so the
piglit test for this wouldn't have been triggered as it does not
write to the outputs.

Here we move the error to the compiler and fix things up so the
correct messages are triggered.

Fixes: d656736bbf92 ("glsl: Add arb_cull_distance support (v3)")

Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31471>
(cherry picked from commit 1c58f513c4a0389091ddc5f620f1a72ffe99a0a9)

8a95d7d8

by David Rosca at 2024-10-03T11:56:47+02:00

frontends/va: Fix AV1 packed header parsing

AV1 has no startcode, so the packed header will not contain any
additional data at the beginning of the buffer that we would need
to skip to get to the OBU header.
Also ignore OBU types that we are not parsing.
Fixes assertions with libva-utils/av1encode.

Fixes: 5edbecb8569 ("frontends/va: adding va av1 encoding functions")
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31359>
(cherry picked from commit 023277173ce1d84c448626ded21e4d2b66363b41)

caa7eb65
by Eric Engestrom at 2024-10-03T17:37:57+02:00
```
docs: add release notes for 24.2.4
```
e2ab51c4
by Eric Engestrom at 2024-10-03T17:38:59+02:00
```
VERSION: bump for 24.2.4
```

a899c20c

by Timo Aaltonen at 2024-10-03T22:10:50+03:00

Merge branch 'upstream-unstable' into debian-unstable

5ec6068b
by Timo Aaltonen at 2024-10-03T22:11:08+03:00
```
version bump
```
a13b026a
by Timo Aaltonen at 2024-10-03T22:12:49+03:00
```
clc-find-opencl-headers.diff: Dropped, upstream.
```
c67e4162
by Timo Aaltonen at 2024-10-03T22:19:18+03:00
```
releasing package mesa version 24.2.4-1
```

4d32b6d7

by Dylan Aïssi at 2024-10-17T21:53:27+02:00

Merge tag 'debian/24.2.4-1' into debian/bookworm-backports

tagging package mesa version debian/24.2.4-1

c6447b68

by Dylan Aïssi at 2024-10-17T21:55:06+02:00

Release mesa version 24.2.4-1~bpo12+1

Signed-off-by: Dylan Aïssi <dylan.aissi@collabora.com>

30 changed files:

.gitlab-ci/container/alpine/x86_64_build.sh
.pick_status.json
VERSION
bin/install_megadrivers.py
debian/changelog
+ debian/patches/fix-armhf-build.diff
debian/patches/series
docs/relnotes.rst
docs/relnotes/24.2.2.rst
+ docs/relnotes/24.2.3.rst
+ docs/relnotes/24.2.4.rst
src/amd/ci/radv-navi21-aco-flakes.txt
src/amd/ci/radv-navi31-aco-flakes.txt
src/amd/ci/radv-tahiti-aco-fails.txt
src/amd/ci/radv-vangogh-aco-flakes.txt
src/amd/compiler/aco_assembler.cpp
src/amd/compiler/aco_instruction_selection.cpp
src/amd/compiler/aco_print_asm.cpp
src/amd/compiler/tests/test_assembler.cpp
src/amd/vulkan/nir/radv_nir.h
src/amd/vulkan/nir/radv_nir_lower_view_index.c
src/amd/vulkan/nir/radv_nir_lower_vs_inputs.c
src/amd/vulkan/nir/radv_nir_rt_shader.c
src/amd/vulkan/radv_buffer.c
src/amd/vulkan/radv_device.c
src/amd/vulkan/radv_formats.c
src/amd/vulkan/radv_instance.c
src/amd/vulkan/radv_instance.h
src/amd/vulkan/radv_pipeline_graphics.c
src/amd/vulkan/radv_pipeline_rt.c

[Git][xorg-team/lib/mesa][debian/bookworm-backports] 163 commits: docs: update sha sums for 24.2.2

Dylan Aïssi pushed to branch debian/bookworm-backports at X Strike Force / lib / mesa

Commits:

30 changed files:

The diff was not included because it is too large.