Bug#840881: xserver-xorg-video-vmware: Please announce supported hardware using AppStream
- To: 840881@bugs.debian.org
- Subject: Bug#840881: xserver-xorg-video-vmware: Please announce supported hardware using AppStream
- From: Petter Reinholdtsen <pere@hungry.com>
- Date: Sun, 04 Aug 2024 07:15:12 +0200
- Message-id: <[🔎] sa6wmkwx40v.fsf@hjemme.reinholdtsen.name>
- Reply-to: Petter Reinholdtsen <pere@hungry.com>, 840881@bugs.debian.org
- In-reply-to: <1478322225.1979.22.camel@debian.org>
- References: <2fleg3h7915.fsf@diskless.uio.no> <20161016115134.h5yq2mm2pv4e3hc2@betterave.cristau.org> <2fl1szg79ud.fsf@diskless.uio.no> <20161016130943.vtocuweyfh3tqtr5@betterave.cristau.org> <1478322225.1979.22.camel@debian.org> <2fleg3h7915.fsf@diskless.uio.no>
Control: tags -1 + patch
Here is an upstreamable patch to fix this.
diff --git a/debian/patches/1000-appstream-metainfo.patch b/debian/patches/1000-appstream-metainfo.patch
new file mode 100644
index 0000000..632babb
--- /dev/null
+++ b/debian/patches/1000-appstream-metainfo.patch
@@ -0,0 +1,29 @@
+Description: Added AppStream metainfo XML with hardware provide info.
+ This allow isenkram to propose this package when the virtual hardware
+ is present.
+Author: Petter Reinholdtsen
+Forwarded: no
+Last-Update: 2024-08-04
+---
+Index: xserver-xorg-video-vmware-13.3.0/org.x.video.vmware.metainfo.xml
+===================================================================
+--- /dev/null 1970-01-01 00:00:00.000000000 +0000
++++ xserver-xorg-video-vmware-13.3.0/org.x.video.vmware.metainfo.xml 2024-08-04 07:07:49.177086657 +0200
+@@ -0,0 +1,17 @@
++<?xml version="1.0" encoding="UTF-8"?>
++<component>
++ <id>org.x.video.vmware</id>
++ <metadata_license>MIT</metadata_license>
++ <name>xserver-xorg-video-vmware</name>
++ <summary>X.Org X server -- VMware display driver</summary>
++ <description>
++ <p>This package provides the driver for VMware client sessions,
++ i.e. if Linux is running inside a VMware session.</p>
++ <p>This package is built from the X.org xf86-video-vmware driver
++ module.</p>
++ </description>
++ <url type="homepage">https://www.x.org</url>
++ <provides>
++ <modalias>dmi:*:svnVMWare*:*</modalias>
++ </provides>
++</component>
diff --git a/debian/patches/series b/debian/patches/series
index 30b4052..8e90d38 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
0001-vmwgfx-fix-missing-array-notation.patch
+1000-appstream-metainfo.patch
diff --git a/debian/xserver-xorg-video-vmware.install b/debian/xserver-xorg-video-vmware.install
index daa64ce..4cf5bb1 100644
--- a/debian/xserver-xorg-video-vmware.install
+++ b/debian/xserver-xorg-video-vmware.install
@@ -1,3 +1,4 @@
usr/lib/xorg/modules/drivers/*.so
usr/share/man/man4/*
usr/bin/vmwarectrl
+org.x.video.vmware.metainfo.xml usr/share/metainfo
The state of the git repository (no way to generate upstream tarball)
and the source .dsc (both inline patches and debian/patches/ patches)
made me unsure how to properly adjust the package, but I decided to use
the debian/patches/ approach to separate the change into a separate
file.
--
Happy hacking
Petter Reinholdtsen
Reply to: