[Git][xorg-team/vulkan/vulkan-validationlayers][upstream-unstable] 288 commits: layers: Label new VUID from 280 spec

Timo Aaltonen pushed to branch upstream-unstable at X Strike Force / vulkan / vulkan-validationlayers

Commits:

fbb23c2c
by spencer-lunarg at 2024-03-12T22:04:39+09:00
```
layers: Label new VUID from 280 spec
```
7b18a765
by spencer-lunarg at 2024-03-13T13:37:07+09:00
```
layers: Fix Tessellation component limit check
```

926b2d44

by spencer-lunarg at 2024-03-13T14:44:15+09:00

bp: Track vertex buffer through whole command buffer

1f7b93aa
by spencer-lunarg at 2024-03-13T14:45:03+09:00
```
layers: Improve format feature error messages
```

38311dd8

by spencer-lunarg at 2024-03-13T17:35:38+09:00

layers: Ignore dynamic color blend with no attachment

ebc5ca6f
by spencer-lunarg at 2024-03-13T21:12:36+09:00
```
layers: Cleanup error_msg name
```
550d5379
by spencer-lunarg at 2024-03-13T21:12:36+09:00
```
layers: Add GPL Layout union compatible check
```

c8e11cf2

by spencer-lunarg at 2024-03-13T23:56:11+09:00

layers: Fix aliasing image bindings with different types

e3e803c5

by Artem Kharytoniuk at 2024-03-14T10:08:45+09:00

sync: Fix WaitForFences leak

There are syncval endpoints that compute state in the Validate phase
and use thread local storage to propagate it to the Record stage,
which does the final update.

This change fixes one side effect of this approach in the multithreaded
environment.

In following scenario two threads work with the same queue.
The queue access is externally synchronized.

1. Thread A: Submits some memory accesses. Signals a fence.
2. Thread B: Submits empty command buffer. Finishes only Validate.
   This imports acccesses from step 1 and the batch is stored in the
   thread local storage to be consumed later by the Record.
3. Thread A: Calls WaitForFences with a fence from step 1.
   This processes accesses from step 1, but can not see the copy
   of those accesses (in TLS) produced by step 2.
4. Thread B. Finishes Record. This restores accesses from step 2, that
   otherwise should have been processed by the WaitForFences.
5. Thread A. Submits more accesses. They hazard with accesses that
   were restored in step 4.

55745159
by Artem Kharytoniuk at 2024-03-14T10:08:45+09:00
```
tests: Add regression tests for WaitForFences leak
```
07999bb6
by spencer-lunarg at 2024-03-14T11:36:26+09:00
```
layers: Remove strncmp for Location
```
05be1149
by spencer-lunarg at 2024-03-14T13:44:41+09:00
```
layers: Split up ValidatePnextStructContents
```
c921c07a
by spencer-lunarg at 2024-03-14T13:52:56+09:00
```
layers: Fix checking null imported handle type
```
cef6fd07
by spencer-lunarg at 2024-03-14T14:38:02+09:00
```
layers: Fix std build error in main
```
096b9cef
by spencer-lunarg at 2024-03-14T14:38:10+09:00
```
tests: Use Handle for pipeline helpers
```
8bf8ca00
by spencer-lunarg at 2024-03-14T15:33:36+09:00
```
layers: Ignore attachmentCount with dynamic state
```
96e38cba
by spencer-lunarg at 2024-03-14T16:28:54+09:00
```
build: Fix CI Sanitizer failures
```
b1bb3d5b
by spencer-lunarg at 2024-03-14T23:04:45+09:00
```
tests: Make dedicated Copy test files
```
ab83c470
by spencer-lunarg at 2024-03-14T23:05:26+09:00
```
layers: Combined image region loop logic
```

f1c1b432

by spencer-lunarg at 2024-03-14T23:06:33+09:00

layers: Linear Sampler check for MinMax reduction mode

56c64a9d
by ziga-lunarg at 2024-03-14T23:12:31+09:00
```
layers: Fix validating swapchain images
```

4bfc56f3

by ziga-lunarg at 2024-03-14T23:12:31+09:00

tests: Test acquire before getting swapchain image

7a8f7b6d

by Artem Kharytoniuk at 2024-03-14T20:44:14+01:00

layers: Add VkSwapchainPresentFenceInfoEXT fence sync support

aa6f2d11

by Artem Kharytoniuk at 2024-03-14T20:44:14+01:00

tests: Test VkSwapchainPresentFenceInfoEXT synchronization

84f925d9
by spencer-lunarg at 2024-03-15T15:53:59+09:00
```
layers: Check for valid fragment shader state
```
7e4503af
by Artem Kharytoniuk at 2024-03-15T11:53:52+01:00
```
tests: Fix wsi test for the latest nvidia drivers
```
8e676853
by ziga-lunarg at 2024-03-18T09:54:15+09:00
```
layers: Fix vuid 01214 message
```
c9cfc339
by spencer-lunarg at 2024-03-18T11:19:57+09:00
```
scripts: Default caching the generated source file
```
63d67a92
by spencer-lunarg at 2024-03-18T12:34:20+09:00
```
layers: Create VUID Map file
```
07d8cf32
by spencer-lunarg at 2024-03-18T16:06:18+09:00
```
layers: Fix crash from sampler pNext
```
234414b8
by spencer-lunarg at 2024-03-18T18:51:55+09:00
```
scripts: Create union of pointer group
```
5b8af92a
by spencer-lunarg at 2024-03-18T18:52:05+09:00
```
layers: Removed inline query VUID struct
```
99a389c9
by spencer-lunarg at 2024-03-19T16:22:17+09:00
```
layers: Use IsPrimary() and IsSeconary()
```
bbb6515a
by spencer-lunarg at 2024-03-19T16:22:17+09:00
```
layers: Use handle name for state tracking
```
57084b5d
by spencer-lunarg at 2024-03-19T16:22:17+09:00
```
layers: State tracking uses same create_info
```
30f28571
by spencer-lunarg at 2024-03-19T22:14:10+09:00
```
tests: Cleanup vkt::Fence inits
```
9452b828
by spencer-lunarg at 2024-03-19T22:31:24+09:00
```
layers: Don't check for used object if Device Lost
```

88189c94

by spencer-lunarg at 2024-03-20T12:05:54+09:00

layers: Move SubresourceRangeErrorCodes to map file

af257b1c
by spencer-lunarg at 2024-03-20T18:21:19+09:00
```
layers: Check DEVICE_LOST for vkDestroyCommandPool
```
5df44678
by Ramy El Garawany at 2024-03-20T12:00:18+01:00
```
layers: Fix Encode2D/3D for compressed textures
```
b95fbf02
by spencer-lunarg at 2024-03-20T21:59:44+09:00
```
scripts: Split up object tracker no autogen
```

9729ddd8

by Artem Kharytoniuk at 2024-03-20T15:11:21+01:00

tests: Simplify test and make it positive

It's two copies instead of three and this signals intent well - two
non-overlapping copies should not result in WRITE-AFTER-WRITE hazard.

2718dced
by Artem Kharytoniuk at 2024-03-20T18:18:46+01:00
```
layers: Cleanup subresource adapter
```
cefe406b
by Jeremy Gebben at 2024-03-20T12:45:18-06:00
```
layers: Remove unused file sparse_containers.h
```
2cb7ca8f
by spencer-lunarg at 2024-03-21T09:43:36+09:00
```
layers: Make more use of const ref
```

acc3b8f1

by Arno at 2024-03-21T11:31:23+09:00

gpu: Deprecate NV RT accel structs validation

Validation was only done for the Nvidia extension, which has
essentially been replaced by the KHR one, so the cost
of maintaining that part of the code base (changes to the logging
system have to be propagated here) is not worth it

6b44cc44
by spencer-lunarg at 2024-03-21T14:06:25+09:00
```
tests: Add SetDesiredError
```
4d8d35db
by spencer-lunarg at 2024-03-21T18:20:49+09:00
```
tests: Use new SetDesiredError
```

5906251b

by spencer-lunarg at 2024-03-21T18:23:49+09:00

layers: Add proper vkGetDescriptorSetLayoutSupport support

d71d38c6

by spencer-lunarg at 2024-03-21T18:23:49+09:00

tests: Add proper vkGetDescriptorSetLayoutSupport support

c4b3bdc7
by spencer-lunarg at 2024-03-21T22:11:39+09:00
```
layers: Add Mesh DrawIndex undefined value
```
d5d644ba
by spencer-lunarg at 2024-03-21T22:12:11+09:00
```
layers: Track lifetime of pipeline libraries
```

b4209d30

by Artem Kharytoniuk at 2024-03-22T00:16:21+01:00

layers: Remove unused comparison operator

We used to store SemOps in a map and that requires comparison.
It is an array now.

720f675d

by Artem Kharytoniuk at 2024-03-22T00:16:21+01:00

layers: Do not store payload in timeline SemOps

TimePoint's SemOps store the same payload value and it is always
accessible through other means. This also allows to remove the asserts
that check that payloads are the same for all wait operations.

That's one step towards storing in timeline only references to
submissions.

edfb2946

by Artem Kharytoniuk at 2024-03-22T00:16:21+01:00

layers: Use OpType instead of SemOp in filter function

3a97e6ba

by Artem Kharytoniuk at 2024-03-22T00:16:21+01:00

layers: Do not store OpType in timeline SemOps

Inside Timepoint object the OpType is determined by the variable that
is used for storage: signal_op, wait_ops or acquire. In the case of
wait ops array this also removes some duplication of information.

That's one more step towards storing in timeline only references to
submissions.

06f7aff3

by Artem Kharytoniuk at 2024-03-22T00:16:21+01:00

layers: Do not store acquire command in timeline SemOps

For acquire operation we don't need queue/seq. It can be represented
in a more compact form separately.

In some places this makes logic more specific. No need to check
acquire if we need to signal something on the queue (TimePoint::Notify).
But in general it's one more check in addition to signal. This is not
necessarily bad - this makes acquire paths more explicit and we can
think more about them.

That's one more step towards storing in timeline only references to
submissions.

413e21c4

by Artem Kharytoniuk at 2024-03-22T00:16:21+01:00

layers: Store submit reference instead of SemOp in timeline

This commit changes timeline semantics. Now it does not store SemOps,
but a references to queue submissions. SemOps are still used outside of
timeline context.

c02d1ba3

by Jeremy Gebben at 2024-03-22T08:23:43+09:00

tests: Fix PositiveWsi.CreateXcbSurface on llvmpipe

This test was failing because the surface handle wasn't initialized.

01be973b
by Eearslya Sleiarion at 2024-03-22T08:26:35+09:00
```
layers: Fix out-of-bounds memory access in BP
```
98b69dca
by spencer-lunarg at 2024-03-22T07:38:16+01:00
```
layers: Pass ValidationStateTracker as reference
```
5e85879c
by spencer-lunarg at 2024-03-22T17:47:33+09:00
```
tests: Fix NegativeProtectedMemory.Memory
```

7e2bba94

by Corentin Noël at 2024-03-22T18:05:51+09:00

layers: Mention the actual api version number of the device

Previously, the validation message could lead to something like:

> pProperties->pNext includes a pointer to a VkStructureType
> (VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_1_3_PROPERTIES) which was
> added in VK_API_VERSION_1_3 but the current effective API version
> is 1.3.0 (0x00403000)

Use the actual version it is comparing with in the validation message.

Signed-off-by: Corentin Noël <corentin.noel@collabora.com>

e31eb55b

by spencer-lunarg at 2024-03-22T18:36:16+09:00

tests: Split up NegativeDescriptorBuffer.BindingAndOffsets

c15d5a39
by spencer-lunarg at 2024-03-22T18:37:00+09:00
```
tests: Fix some test running on lavapipe
```
0a932814
by spencer-lunarg at 2024-03-22T20:11:39+09:00
```
scripts: Fix VkDisplayKHR handle wrapping
```

a7aa809e

by spencer-lunarg at 2024-03-22T20:11:39+09:00

scripts: Remove unnecessary commands from no autogen

b43e6ab1

by Jeremy Gebben at 2024-03-22T10:50:17-06:00

build: Update SPIRV-Headers, SPIRV-Tools and glslang to latest

33b884a4
by ziga-lunarg at 2024-03-24T12:30:36+09:00
```
layers: Fix nested cmd buffers with queries
```
060c235d
by ziga-lunarg at 2024-03-24T12:30:36+09:00
```
tests: Test nested cmd buffers with queries
```
1d60da22
by ziga-lunarg at 2024-03-24T12:34:17+09:00
```
layers: Remove broken shader object vuids
```
0e956b60
by ziga-lunarg at 2024-03-24T12:34:17+09:00
```
tests: Remove tests for removed vuids
```
d1113589
by ziga-lunarg at 2024-03-25T10:28:55+09:00
```
layers: Fix sync crash with local read
```
89db729b
by ziga-lunarg at 2024-03-25T10:28:55+09:00
```
tests: Test local read image barrier
```
21475ed5
by spencer-lunarg at 2024-03-25T11:56:34+09:00
```
layers: Move functions into DebugReport and rename
```

d25c0df7

by spencer-lunarg at 2024-03-25T12:09:16+09:00

gpuav: Don't crash if shader_map fails to find handle

5c9b07eb
by spencer-lunarg at 2024-03-25T17:27:46+09:00
```
layers: Move some state tracking out of stateless
```
00888c5a
by spencer-lunarg at 2024-03-25T23:09:06+09:00
```
layers: Remove void pointer with struct name
```
01156a11
by spencer-lunarg at 2024-03-25T23:09:06+09:00
```
layers: Make chassis namespace
```
db1d12b2
by Mike Schuchardt at 2024-03-25T17:07:27-06:00
```
build: Update to header 1.3.281
```
0ff231c4
by spencer-lunarg at 2024-03-26T10:22:47+09:00
```
layers: VU fixes for 1.3.281
```
96a3adbe
by ziga-lunarg at 2024-03-26T10:26:07+09:00
```
layers: Fix vuid 09542 for buffer usage 2
```

becb7f75

by ziga-lunarg at 2024-03-26T10:26:07+09:00

tests: Test get AS device address with buffer usage 2

a37b827a
by Artem Kharytoniuk at 2024-03-26T10:30:26+09:00
```
layers: Fix arrayPitch computation for ASTC_10x10
```
845c3209
by Artem Kharytoniuk at 2024-03-26T10:30:26+09:00
```
tests: Add regression tests for ASTC_10x10 issues
```
d7f69350
by Gareth Webb at 2024-03-26T10:30:56+09:00
```
tests: False failure of test
```
fbdaf4c8
by Gareth Webb at 2024-03-26T10:30:56+09:00
```
tests: Test not checking for feature
```
706e5d21
by Gareth Webb at 2024-03-26T10:30:56+09:00
```
layers: Segfaulting test
```
a9d6fc8d
by Gareth Webb at 2024-03-26T12:35:35+09:00
```
layers: Avoid UB in array validation
```

b9c9a529

by spencer-lunarg at 2024-03-26T17:44:18+09:00

gpuav: Split debug instructions and make a switch case

4d661920
by spencer-lunarg at 2024-03-26T17:44:44+09:00
```
layers: Use VkBufferUsageFlags2 everywhere
```
b9fc73ab
by spencer-lunarg at 2024-03-26T20:25:47+09:00
```
layers: Use vvl custom container
```

f63e66ea

by Artem Kharytoniuk at 2024-03-26T15:52:44+01:00

layers: Remove WSI validation dependency on GetSwapchainImages

2ac49e5c
by spencer-lunarg at 2024-03-27T01:45:50+09:00
```
tests: Fix Host Image Copy for Lavapipe
```

d9044afd

by Arno at 2024-03-27T01:49:54+01:00

gpu: Move spir-v byte code to source files

543e9a9a

by Arno at 2024-03-27T01:49:54+01:00

gpu: One error buffer per cmd buffer

Move to one error buffer per command buffer.
Code modifications allow to properly log multiple errors
in instrumentation/diagnostic shader dispatches.
This can lead to a swarm of errors if say all fragments
emit errors. To mitigate that, a `kMaxErrorsPerCmd` constant
has been introduced. The error buffer itself can hold a
maximum of `kErrorRecordCounts`.
Having one error buffer per command buffer makes
maintaining the mapping between an error record
and its corresponding resources
(including its origin) a problem. Currently it is
solved by storing an resources index in an error record.
Instrumentation does not allow the use of push constants
to transfer the index to the GPU, a solution that
would have been efficient and easier to maintain.
Instead, a index buffer is created at device creation
time, holding `gpuav::cst::indices_count`indices.
The correct index is transmitted to instrumentation/
diagnostic shader dispatches using dynamic offsets
in calls to `vkCmdBindDescriptorSets`.

Misc:
- All descriptor sets/binding indices have
now named constants, to make the mapping between
CPU code and shaders easier to maintain
- Add to change expected errors count in
some tests that are now emitting
the proper amount of errors.

d12d78bf

by Arno at 2024-03-27T01:49:54+01:00

gpu: Add several errors in several cmd buffs test

Also add same test but with one command buffer where invalid
commands are registered

d56365c9
by Arno at 2024-03-27T01:49:54+01:00
```
gpu: Rename debug_record to error_record
```

85c28abf

by arno-lunarg at 2024-03-27T01:49:54+01:00

gpu: Fix shader objects handling

State was not restored for shader objects.
Also in the test, the render are was one pixel, so only one error
would be emitted in the fragment shaders. Now render area spans whole
target image.

73f15cd8
by spencer-lunarg at 2024-03-27T13:08:17+09:00
```
glsl: Unify style and fix script for python3.10
```
1689210b
by spencer-lunarg at 2024-03-27T13:09:08+09:00
```
layers: Single name for chassis state
```
1584a712
by spencer-lunarg at 2024-03-27T13:09:08+09:00
```
layers: Cleanup pipeline class
```
ea5117b5
by spencer-lunarg at 2024-03-27T13:09:08+09:00
```
layers: Seperate Pipeline State tracking
```
d70c1049
by spencer-lunarg at 2024-03-27T22:11:09+09:00
```
layers: Don't use safe struct when not needed
```
ce59ac61
by spencer-lunarg at 2024-03-27T22:11:34+09:00
```
gpuav: Pass Location down for DebugPrintF
```
c9f79c59
by spencer-lunarg at 2024-03-27T22:14:04+09:00
```
tests: Cleanup and split GPU-AV GPL tests
```
c9734ff5
by spencer-lunarg at 2024-03-27T23:16:57+09:00
```
tests: Add Host Image Copy support for Max Profile
```

baf43a4c

by spencer-lunarg at 2024-03-28T00:10:50+09:00

gpuav: Don't create an entire spirv::Module for errors

33a5dbf4
by Artem Kharytoniuk at 2024-03-27T20:46:09+01:00
```
layers: Cleanup semaphore interface
```
89baac01
by Artem Kharytoniuk at 2024-03-27T20:46:09+01:00
```
layers: Update SemOp constructor signature
```

30acac36

by Artem Kharytoniuk at 2024-03-27T20:46:09+01:00

layers: Replace queue/seq pairs with SubmissionReference

1250028c

by Artem Kharytoniuk at 2024-03-27T20:46:09+01:00

layers: Rename SubmissionReference variables

Ref suffix in the variable name does not convey enough intuition
that it's information about submission. Submit suffix works better.
Type name (SubmissionReference ) seems fine.

This also matches how SubmissionReference is used in the PresentSync
code where this type was originally introduced:
   small_vector<SubmissionReference, 2, uint32_t> submissions;

4f1bef3c

by Artem Kharytoniuk at 2024-03-27T20:46:09+01:00

layers: Update seq default value in SubmissionReference

The initial idea was to use kU64Max to refer to the entire queue's
workload (similar to how we do this in the Notify API). But it was
never used this way in the PresentSync path, from what I can observe.

Since SubmissionReference is used now in other places, it makes sense
to use zero as default seq value. This will match the previous way to
enqueue operations that do not happen on the queue (null queue, zero
seq).

Also renamed GetLastBinarySignalSubmission ->
GetPendingBinarySignalSubmission. "Last" can include operations that
already retired (as in LastOp).

081b053e

by Artem Kharytoniuk at 2024-03-27T22:08:49+01:00

layers: Fix false-positive when reusing binary semaphore

46685201
by Artem Kharytoniuk at 2024-03-27T22:08:49+01:00
```
tests: Add regression test for binary semaphore reuse
```
9cf24df5
by ziga-lunarg at 2024-03-28T01:30:30+01:00
```
tests: Add missing checks in coop matrix tests
```
d0db7cf3
by spencer-lunarg at 2024-03-28T12:24:29+09:00
```
layers: Add new vkCmdBeginTransformFeedbackEXT VU
```
522f7f4e
by spencer-lunarg at 2024-03-28T18:16:52+09:00
```
scripts: Use promoted SPIR-V names
```
7d1c995b
by spencer-lunarg at 2024-03-28T23:57:42+09:00
```
layers: Move things out of chassis.h
```
5e65d654
by spencer-lunarg at 2024-03-28T23:59:25+09:00
```
printf: Add proper vk_layer_settings support
```
3902697e
by spencer-lunarg at 2024-03-29T00:00:29+09:00
```
gpuav: Add Multiple EntryPoint support
```

071c9ef3

by Artem Kharytoniuk at 2024-03-28T16:50:59+01:00

tests: Add test to demo multiple entries in binary timeline

d3a9b55e

by Jeremy Gebben at 2024-03-28T10:15:39-06:00

build: Update SPIRV-Headers, -Tools and glslang to latest

1f658b51

by Artem Kharytoniuk at 2024-03-28T21:06:17+01:00

layers: Expose semaphore payload instead of operation object

Trying to remove SemOp usage in the Semaphore public interface.

In some place places where Completed() was called, the code uses
"current" payload terminology, which seems logical. Hense the new name
of the method.

362787e2

by spencer-lunarg at 2024-03-29T08:05:10+09:00

layers: Move valid_enum_values.cpp out from Chassis level

17b74f1f

by spencer-lunarg at 2024-03-29T08:05:10+09:00

layers: Move valid_flag_values.cpp out from Chassis level

22960b1e

by spencer-lunarg at 2024-03-29T08:05:10+09:00

layers: Move valid_enum_values.h out from Chassis level

5d79677e

by Jeremy Gebben at 2024-03-29T08:08:32+09:00

scripts: Fix PlatformGuardHelper.add_guard()

Comparison to the existing guard should be `!=` not `is not`

3771c344
by Jeremy Gebben at 2024-03-29T08:23:00+09:00
```
layers: Use new safe struct code from VUL
```

d347cca4

by Arno at 2024-03-29T02:22:52+01:00

layers: Add back RT VUs 03703 03704 03705

899fa3ac
by Arno at 2024-03-29T02:22:52+01:00
```
tests: Add back 03703 03704 03705
```

6220e460

by Arno at 2024-03-29T13:59:35+09:00

gpu: Fix crash

Running a replay with GFXReconstruct showed that I was not handling
an early return correctly

242b6f33
by spencer-lunarg at 2024-03-29T18:29:17+09:00
```
tests: Remove comment with incorrect link
```

491f7a91

by spencer-lunarg at 2024-03-30T01:12:39+09:00

chassis: Created dedicated are for chassis level logic

d017f41d
by Artem Kharytoniuk at 2024-04-02T09:01:59+02:00
```
layers: Add use cases when to ignore allocation size
```

e5aac035

by Artem Kharytoniuk at 2024-04-02T09:01:59+02:00

tests: Check that allocation size is ignored for DX import

9ad5c6aa
by spencer-lunarg at 2024-04-02T16:42:26+09:00
```
tests: Add Multi EntryPoint tests for DebugPrintF
```
2e253521
by ziga-lunarg at 2024-04-02T16:43:02+09:00
```
layers: Fix VUID 09510 message
```
0da2b226
by ziga-lunarg at 2024-04-02T16:43:39+09:00
```
layers: Fix null render pass crash
```

c9787072

by ziga-lunarg at 2024-04-02T16:43:39+09:00

tests: Begin invalid command buffer with imageless framebuffer

74c8eb7d

by ziga-lunarg at 2024-04-02T16:44:28+09:00

layers: Fix attachment check for vkCmdClearAttachments

2fab3f6d
by ziga-lunarg at 2024-04-02T16:44:28+09:00
```
tests: Test local read clearing attachments
```
215b1f04
by ziga-lunarg at 2024-04-02T16:45:21+09:00
```
layers: Fix swapped FSR VUIDs
```
e1f6c94d
by ziga-lunarg at 2024-04-02T16:45:21+09:00
```
tests: Fix swapped FSR VUIDs
```

b515a9bc

by Artem Kharytoniuk at 2024-04-03T08:49:09+02:00

layers: Ignore non-zero binary semaphore payload

That's how it worked for QueueSubmit and now do the same for
QueueSubmit2.

3492699f

by Artem Kharytoniuk at 2024-04-03T08:49:09+02:00

tests: Add regression test for binary semaphore payload

78de46b2

by Jeremy Gebben at 2024-04-05T10:02:10-06:00

build: Update SPIRV-Tools and glslang to latest

SPIRV-Headers has not changed.

fc9589f1
by spencer-lunarg at 2024-04-08T11:46:32+09:00
```
layers: Add util for stage flags
```
90e11f5e
by ziga-lunarg at 2024-04-08T12:18:44+09:00
```
layers: Fix imageless framebuffer clear crash
```

309ef1c6

by ziga-lunarg at 2024-04-08T12:18:44+09:00

tests: Test clearing attachments of imageless framebuffer

88c21274
by spencer-lunarg at 2024-04-08T13:17:07+09:00
```
tests: Add timer for shader instrumentation
```
c1ec8e04
by spencer-lunarg at 2024-04-08T14:31:51+09:00
```
layers: Report VU for bad vkGetDeviceProcAddr
```

19204151

by spencer-lunarg at 2024-04-08T23:20:25+09:00

tests: Create dedicated secondary command buffer tests

f2d62742
by ziga-lunarg at 2024-04-09T08:44:02+09:00
```
layers: Add missing skips
```

dc9a7170

by spencer-lunarg at 2024-04-09T18:21:11+09:00

layers: Check if device struct is called from instance func

29c6bbf5
by spencer-lunarg at 2024-04-10T13:26:03+09:00
```
ci: Add Artifact Uploads
```
176244a9
by Spencer Fricke at 2024-04-10T15:40:39+09:00
```
ci: Fix job that is protected from main
```
301ab9c4
by Spencer Fricke at 2024-04-10T15:40:39+09:00
```
ci: Set retention-days to match repo settings
```

d103c3b3

by spencer-lunarg at 2024-04-10T16:57:50+09:00

layers: Move Secondary CommandBuffer tracking to chassis

8a38e1a4
by Artem Kharytoniuk at 2024-04-10T15:18:22+02:00
```
layers: Refactor surface caps caching
```
43000bd1
by Artem Kharytoniuk at 2024-04-10T15:18:22+02:00
```
tests: Add regression test for issue 7786
```
e80d6f79
by ziga-lunarg at 2024-04-11T09:26:51+09:00
```
layers: Validate render pass contents
```
5c83efe1
by ziga-lunarg at 2024-04-11T09:26:51+09:00
```
tests: Test invalid render pass contents
```

fd9ed749

by Spencer Fricke at 2024-04-11T09:47:04+09:00

docs: Add how to get binaries to README

closes https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/6356

84f8a12a

by Arno at 2024-04-11T14:15:30+09:00

gpu: Update to address validation

Bug fix: early exit in gpuav::Validator::UpdateBuffer would skip
table cleanup
Improvements:
- Remove unnecessary "copy to vector" step when getting device
addresses, instead directly copy to GPU memory
- Redid GPU buffer device address table management:
It is now a 1 to 1 mapping with what is held on the CPU,
which IMO simplify things
- Rework validation shader, it was hard to understand

Tests:
- Basic test is not working, there is at least an issue in how
buffer address accesses length
are computed. Access size seems to always be 8,
or the size of a pointer, and not the size of the type pointed to.

1742b4e2
by Arno at 2024-04-11T14:15:30+09:00
```
gpu: Add new OOB tests
```
e0fbc279
by Artem Kharytoniuk at 2024-04-11T09:01:22+02:00
```
layers: Add explanation why to cache surface caps
```
48c6e641
by spencer-lunarg at 2024-04-11T17:03:56+09:00
```
tests: Re-enable GPU-AV BDA tests
```
fcfd4094
by Arno at 2024-04-11T17:35:10+09:00
```
gpu: Fix spirv struct length computation
```
89e4f8a4
by spencer-lunarg at 2024-04-11T17:52:37+09:00
```
scripts: Add InterceptId where possible
```
f1f4d7d1
by Artem Kharytoniuk at 2024-04-11T14:51:12+02:00
```
layers: Clarify mock icd workaround
```

97ed9666

by Christophe at 2024-04-11T22:14:49+02:00

layers: Fix missing sync_queue_submit to true in Sync preset

08a00d5a
by spencer-lunarg at 2024-04-12T09:14:13+09:00
```
layers: Create a core::CommandBuffer
```
534125b7
by spencer-lunarg at 2024-04-12T17:09:49+09:00
```
layers: Move UNASSIGNED to Warning
```
ad8718d1
by spencer-lunarg at 2024-04-12T17:10:42+09:00
```
layer: Cleanup of manual dispatch variables
```

5bbe8d26

by spencer-lunarg at 2024-04-12T17:11:42+09:00

layers: Warn if Layer is written to a single layer FB

31054a8c

by Arno at 2024-04-12T17:33:18+09:00

layers: Add 03704 for host accel structs builds

71a5ba17
by Arno at 2024-04-12T17:33:18+09:00
```
tests: Add 03704
```

8eacefee

by spencer-lunarg at 2024-04-12T22:21:11+09:00

gpu: Fix Descriptor Indexing assuming pipeline bound first

a9b3f651

by Jeremy Gebben at 2024-04-13T11:33:12+09:00

build: Update glslang and SPIRV-Tools

Once again, no SPIRV-Headers changes

2fab60ab
by spencer-lunarg at 2024-04-13T11:40:31+09:00
```
layers: Unify all GPU-AV settings
```

06237a73

by ziga-lunarg at 2024-04-14T09:22:11+09:00

layers: Fix clearing local read depth attachment

1597e78b

by ziga-lunarg at 2024-04-14T09:22:11+09:00

tests: Test clearing local read depth attachment

d89ce7ad
by Shahbaz Youssefi at 2024-04-15T17:20:19+02:00
```
build: Add missing header to gn build
```
200ba9c2
by spencer-lunarg at 2024-04-16T04:38:29+09:00
```
layers: Label 09631 VUID
```
fe7742d4
by spencer-lunarg at 2024-04-16T04:38:40+09:00
```
layers: Add draw time primitiveRestartEnable check
```

c7dc4db0

by Daniel Rakos at 2024-04-16T04:40:16+09:00

layers: Relax usage requirements for video formats

b35c5538
by Alex Rønne Petersen at 2024-04-16T13:53:41+09:00
```
update_deps.py: Fix to handle Windows Arm64
```

c64f16a6

by Artem Kharytoniuk at 2024-04-16T08:08:43+02:00

layers: Fix UpdateCapabilitiesCache

It should always update (does not try to use cached data).
The caching is for getters.

4c390e9c

by Artem Kharytoniuk at 2024-04-17T09:58:35+02:00

tests: Rename xxx_queues() -> QueuesWithXXXCapability()

To make clear it's only about capability.

Common naming convention is that compute/tranfer queues are the queues
that have support for compute/transfer capabilities but _without_
graphics/(graphics+compute) capabilities. The hardware often has
special support for these configurations. This rename is to avoid
potential confusion with such naming convention.

Some hardware examples. A queue with compute capability but also with a
graphics capability does not necessarily support scheduling needed for
async compute type of rendering. A queue with a tranfer and compute
capabilities probably won't utilize dedicated DMA bus.

0a8baf3b
by Artem Kharytoniuk at 2024-04-17T09:58:35+02:00
```
tests: Add {Compute/Transfer}QueueFamily helpers
```
15152489
by Artem Kharytoniuk at 2024-04-17T09:58:35+02:00
```
tests: Update queue family matching routines
```
6bb4f917
by Artem Kharytoniuk at 2024-04-17T14:09:08+02:00
```
tests: Add helpers to get queue directly
```
28db9178
by spencer-lunarg at 2024-04-17T21:39:09+09:00
```
layers: Print Patch in interface error message
```
b11c199a
by Mike Schuchardt at 2024-04-17T12:18:56-07:00
```
build: Update to header 1.3.282
```
86b282ec
by spencer-lunarg at 2024-04-19T01:06:39+09:00
```
layers: Check linked GPL for stageCount not zero
```
4db6f879
by spencer-lunarg at 2024-04-19T01:07:11+09:00
```
layers: Add VU 09635
```

7943b436

by Graeme Leese at 2024-04-19T01:17:43+09:00

layer: Stop checking removed VU

VUID-vkCmdDraw-None-04912 has been removed from the Vulkan spec because
it's redundant. Remove the check from the layer and update the tests.

299198f3
by Graeme Leese at 2024-04-19T01:17:43+09:00
```
layers: Remove unneeded VUID plumbing
```

1e4340d8

by Graeme Leese at 2024-04-19T06:54:39+09:00

tests: Fix image usage/layout confusion

The VkAmdBestPracticesLayerTest.ImageToImageCopy was mistakently setting
the image create usage to a layout define. Both usage and layout seem to
be needed, so set them both to the appropriate values.

5094f385

by Artem Kharytoniuk at 2024-04-19T00:19:34+02:00

tests: Add second helper queue

When default queue is not enough

0f561c1c
by spencer-lunarg at 2024-04-19T17:19:31+09:00
```
tests: Fix MaxSampleMaskWords tests
```

d1316e54

by spencer-lunarg at 2024-04-19T17:44:33+09:00

layers: Add robustness check to drawn time vertex buffer

0409ac63
by spencer-lunarg at 2024-04-20T00:03:51+09:00
```
layers: Improve Shader Interface errors
```
5e7f4ee0
by Mike Schuchardt at 2024-04-20T04:46:46+09:00
```
build: Update to header 1.3.283
```
b7044aa1
by Artem Kharytoniuk at 2024-04-19T22:00:50+02:00
```
layers: Add Sync1 host stage VUs
```
d84c3a5f
by Artem Kharytoniuk at 2024-04-19T22:00:50+02:00
```
tests: Test Sync1 host stage VUs
```

12f7fa5e

by Charles Giessen at 2024-04-22T14:33:08+09:00

test: Set VK_LAYER_PATH automatically if missing

Changes:
* Add mechanism to set VK_LAYER_PATH automatically if it isn't set or if
it is set but doesn't contain a path to a valid layer manifest.
* Search VK_ADD_LAYER_PATH in addition to VK_LAYER_PATH when looking for
the layer manifest
* Enhance searching of the layer manifest to include directory support
rather than only allowing files
* Enhance VK_ICD_FILENAMES & VK_DRIVER_FILES checking to support files in
addition to the existing support for directories
* Update docs to indicate VK_LAYER_PATH is automatically set

2e26d97e

by Spencer Fricke at 2024-04-22T19:01:25+09:00

scripts: Update VUL

grabs changes from
https://github.com/KhronosGroup/Vulkan-Utility-Libraries/pull/201

8e6de849
by spencer-lunarg at 2024-04-22T20:39:05+09:00
```
layers: Add Draw VK_EXT_legacy_dithering VU
```

930e1356

by spencer-lunarg at 2024-04-22T20:39:34+09:00

layers: Label RenderPass 1 VUID for nestedCommandBuffer

def345b6
by spencer-lunarg at 2024-04-22T20:39:44+09:00
```
layers: Add Protected buffer usage flag combo
```
392b1278
by spencer-lunarg at 2024-04-22T21:34:19+09:00
```
layers: Nit cleanup in GPU-AV
```
5a91c8a8
by Jeremy Gebben at 2024-04-22T11:32:01-06:00
```
build: Update SPIRV-Tools and glslang to latest
```

ee2291f2

by spencer-lunarg at 2024-04-23T02:52:17+09:00

layers: Add dynamic state VK_EXT_conservative_rasterization

8e5a2830
by Christophe at 2024-04-22T22:45:03+02:00
```
layers: Fix CreateInstance layer setting msg
```

9ca6171e

by spencer-lunarg at 2024-04-23T22:37:28+09:00

printf: Add way to disconnect from chassis on abort

6db5d67d
by spencer-lunarg at 2024-04-23T22:44:05+09:00
```
tests: Fix MaxSampleMaskWords
```
1d64b3cd
by spencer-lunarg at 2024-04-23T23:38:16+09:00
```
layers: Ignore ColorBlendState attachmentCount
```

055c2be5

by Tomek Bury at 2024-04-23T18:21:15+02:00

tests: Avoid race in Sync2SignalSemaphoreValue

Fixes #7885.

The previously used wait value of 5 is already signalled (at the
semaphore creation time). This makes the queue submission immediately
executable and may signal the semaphore[0] = 20 at any time now.

The queue will race with the subsequent signal operations.
If queue signals first then the subsequent semaphore[0] = 25 becomes
a valid use (no pending signal operations, change from 20 to 25) rather
than a violation of the VUID-VkSemaphoreSignalInfo-value-03259.

The next signal of the semaphore[0] = 15 becomes invalid use violating
the VUID-VkSemaphoreSignalInfo-value-03258 (change from 25 back to 15).

Change-Id: I2768ef5c6b3868f00965ac7d881ad1f6ac7ee515
Signed-off-by: Tomek Bury <tomek.bury@broadcom.com>

a9ec5ff4
by spencer-lunarg at 2024-04-24T05:50:29+09:00
```
tests: Don't use max queueCount
```
46ab6106
by spencer-lunarg at 2024-04-25T01:47:40+09:00
```
scripts: VkPipelineLayoutCreateInfo common parent
```
3425dfa1
by spencer-lunarg at 2024-04-25T01:48:43+09:00
```
layers: Rework DispatchGetDescriptorEXT
```
5f1e3835
by Artem Kharytoniuk at 2024-04-25T01:20:03+02:00
```
layers: Notify queues in deterministic order
```

12f70655

by Artem Kharytoniuk at 2024-04-25T08:44:26+02:00

layers: Cleanup queue's Notify/Wait

Makes it more convenient to use Notify and Wait separately when
NotifyAndWait is not the best choice (e.g. need to issue multiple
Notify before waiting).

a2e7966b
by Artem Kharytoniuk at 2024-04-25T08:44:26+02:00
```
layers: Fix vkDeviceWaitIdle deadlock
```

c70a230c

by Artem Kharytoniuk at 2024-04-25T08:44:26+02:00

tests: Add regression test for vkDeviceWaitIdle deadlock

17c8bcb0
by spencer-lunarg at 2024-04-25T17:29:57+09:00
```
layers: Fix drawtime vertex VU 04008
```
c1fc23ca
by spencer-lunarg at 2024-04-25T23:17:15+09:00
```
layers: Don't count ImageQuery as image accesses
```
33216c29
by Artem Kharytoniuk at 2024-04-26T00:32:53+02:00
```
layers: Fix secondary buffer query deadlock
```
9911e85d
by Artem Kharytoniuk at 2024-04-26T00:32:53+02:00
```
tests: Add regression test for issue 7874
```

d405f992

by Jeremy Gebben at 2024-04-26T10:32:49-06:00

build: Update SPIRV-Headers, -Tools and glslang to latest

aa835d1f

by Artem Kharytoniuk at 2024-04-26T22:57:25+02:00

tests: Break vkt::CommandBuffer and vkt::Queue dependency

62c65a61
by Artem Kharytoniuk at 2024-04-26T22:57:25+02:00
```
tests: Remove QueueCommandBuffer method
```
bacc84ef
by Mehmet Oguz Derin at 2024-04-28T14:14:00+09:00
```
layers: Fix typo in VUID 00344
```
72856ef1
by spencer-lunarg at 2024-04-29T11:34:00+09:00
```
scripts: Update VUL
```

ea1a0c3b