[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#995809: marked as done (libinput: please make the build reproducible)

Your message dated Sun, 17 Dec 2023 00:19:15 +0000
with message-id <E1rEesF-00FD1C-U4@fasolo.debian.org>
and subject line Bug#995809: fixed in libinput 1.23.0-2.1
has caused the Debian Bug report #995809,
regarding libinput: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
995809: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=995809
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: libinput
Version: 1.19.1-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
libinput could not be built reproducibly.

This is due to the use of the LIBINPUT_QUIRKS_DIR macro which includes
the absolute build path.

It is not entirely clear (during a very brief look) when/where this
value is even used — the testsuite still passes even if this is set to
a dummy value (see attached dummy patch). And, of course, the build
path cannot be relied upon at runtime.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

--- a/debian/patches/0001-reproducible-build.patch	1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/0001-reproducible-build.patch	2021-10-06 10:05:03.555141278 +0100
@@ -0,0 +1,15 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby@debian.org>
+Last-Update: 2021-10-06
+
+--- libinput-1.19.1.orig/meson.build
++++ libinput-1.19.1/meson.build
+@@ -13,7 +13,7 @@ dir_libexec     = get_option('prefix') /
+ dir_lib         = get_option('prefix') / get_option('libdir')
+ dir_man1        = get_option('prefix') / get_option('mandir') / 'man1'
+ dir_system_udev = get_option('prefix') / 'lib' / 'udev'
+-dir_src_quirks  = meson.current_source_dir() / 'quirks'
++dir_src_quirks  = '/nonexistent'
+ dir_src_test    = meson.current_source_dir() / 'test'
+ dir_src         = meson.current_source_dir() / 'src'
+ 
--- a/debian/patches/series	2021-10-06 09:35:40.889907597 +0100
--- b/debian/patches/series	2021-10-06 10:00:57.178902346 +0100
@@ -1 +1,2 @@
 #placeholder
+0001-reproducible-build.patch

--- End Message ---
--- Begin Message --- 
Source: libinput
Source-Version: 1.23.0-2.1
Done: Vagrant Cascadian <vagrant@reproducible-builds.org>

We believe that the bug you reported is fixed in the latest version of
libinput, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 995809@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@reproducible-builds.org> (supplier of updated libinput package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 06 Dec 2023 15:10:33 -0800
Source: libinput
Architecture: source
Version: 1.23.0-2.1
Distribution: unstable
Urgency: medium
Maintainer: Debian X Strike Force <debian-x@lists.debian.org>
Changed-By: Vagrant Cascadian <vagrant@reproducible-builds.org>
Closes: 995809
Changes:
 libinput (1.23.0-2.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * tools: Remove references to LIBINPUT_QUIRKS_SRCDIR. (Closes: #995809)
Checksums-Sha1:
 c13b918d1500071b233e2aac1a93ac4cdc84a4e5 2040 libinput_1.23.0-2.1.dsc
 2340e68b0bf7e9b297fc1a2e9b2fe4d334e62a0b 10616 libinput_1.23.0-2.1.debian.tar.xz
Checksums-Sha256:
 e03d05109141973f93ad6688d86b09eae430bf9ff3bafc727621b673e6f9a5e5 2040 libinput_1.23.0-2.1.dsc
 a30a3c7c26b986e0b574022ca98ec4721e72dca9f484e107825313b8c83ae3f5 10616 libinput_1.23.0-2.1.debian.tar.xz
Files:
 3640ca815ca4dbb1b954a826e35769cb 2040 libs optional libinput_1.23.0-2.1.dsc
 5e0cce6070be84d05944ae812a1d877d 10616 libs optional libinput_1.23.0-2.1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iJYEARYKAD4WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZXECbSAcdmFncmFudEBy
ZXByb2R1Y2libGUtYnVpbGRzLm9yZwAKCRDcUY/If5cWqmUaAQDFbnS2CUiXvkNb
61fWkn9pzWkSEn5Vb6258QK+in/UXQEAnZkhzKDXyfZ8K0NsbIfmYs/vie1WkeKO
T26IcmfrNwk=
=n7RQ
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: