On Tuesday, 7 November 2023 14:06:23 CET Helmut Grohne wrote: > On Tue, Nov 07, 2023 at 11:35:28AM +0100, Diederik de Haas wrote: > > > I am not sure what you mean with heavy-handed here and why that would be > > > an issue. > > > > Not fully understanding it, it felt like "some tests may be problematic, > > let's disable all them" > > Do I understand correctly that this no longer is your understanding? Yep, it adds the option to not do the test and in that case you also don't need the build dependency. Thus it doesn't unconditionally disable (all) the test, but gives the option/flexibility to do so. Thinking about it some more, I actually use it myself a lot when building kernels. I pretty much always use the 'nodoc' profile, which saves ~1 GB of dependencies to install (IIRC, mostly due to texlive-latex-extra). Or use the 'cross' profile when cross-compiling a kernel. There's still a lot of magic (to me) involved and I don't fully/properly understand how it works (yet), but I do use it. > > While I'm now less clueless about this then before, I don't feel > > comfortable enough that I would be able to 'defend' the inclusion of the > > <!nocheck> annotation, so I won't include that part in the MR I'm working > > on. > Fair enough. I can offer you two ways forward. You may add me as > reviewer, so I can do the defending part if it becomes necessary. The > correctness of a nocheck build profile can be technically validated. If > you locally perform a build with and without nocheck and both produce > the same artifacts (the reproducible bit-identical ense), then that's a > very strong clue that the dependency wasn't used for building (but maybe > used for testing). And since "nocheck" really means disabling all tests, > you're right in thus annotating the dependency. I actually have now build libdrm locally, but I usually let Salsa's CI do that for me. And I'm compiling it on my main PC and have yet to learn how to do it with tools like sbuild. It's on my TODO, but I'm not there yet. I also want to learn tools like diffoscope (I think R-B is amazing), but I don't understand (its output) one bit. One day I will, but that will not be in the near future. Did I miss option 2? Thanks again, Diederik
Attachment:
signature.asc
Description: This is a digitally signed message part.