[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1038648: Xspice crashes on start



Control: tags patch

I think I found the problem. It seems to be
Fix-a-build-error-with-Xorg-master.patch

To be honest, I don't really understand the patch. According to the
comment, instead of just changing one renamed parameter, it changes
the calling conventions at the cost of an unnecessary "slight
performance drop" in not one but three functions "for consistency"
and goes on to explain why it should work which sounds questionable
to me and apparently doesn't work after all.

So instead doing the simple thing seems to work. I suggest replacing
the patch with this one:

Index: xserver-xorg-video-qxl-0.1.5+git20200331/src/qxl_option_helpers.c
===================================================================
--- xserver-xorg-video-qxl-0.1.5+git20200331.orig/src/qxl_option_helpers.c
+++ xserver-xorg-video-qxl-0.1.5+git20200331/src/qxl_option_helpers.c
@@ -34,7 +34,7 @@ int get_bool_option(OptionInfoPtr option
     const char* value = getenv(env_name);
 
     if (!value) {
-        return options[option_index].value.bool;
+        return options[option_index].value.boolean;
     }
     if (strcmp(value, "0") == 0 ||
         strcasecmp(value, "off") == 0 ||


Reply to: