[Git][xorg-team/vulkan/vulkan-validationlayers][debian-unstable] 254 commits: state: Simplify CMD_BUFFER

Timo Aaltonen pushed to branch debian-unstable at X Strike Force / vulkan / vulkan-validationlayers

Commits:

ee0d6201

by Jeremy Gebben at 2022-12-08T09:04:00-07:00

state: Simplify CMD_BUFFER_STATE object tracking

Remove the `framebuffers` map since it is redundant with
`object_bindings`.

Work around a possible race condition in NotifyInvalidate. Due to
interactions between the BASE_NODE::tree_lock_ and
CMD_BUFFER_STATE::lock it was possible for a (not really) 'bad'
binding to get added to `broken_bindings`. Try to fix this by
only adding a node to `broken_bindings` if it was still found in
`object_bindings`.

9788bc18
by spencer-lunarg at 2022-12-08T09:48:30-07:00
```
layers: Label NV RTX 02787 VUID
```
550786f2
by Tony-LunarG at 2022-12-08T11:31:33-07:00
```
gpu: Restructure pipeline layout selection
```

b6028624

by Tony-LunarG at 2022-12-08T11:31:33-07:00

tests: Add test for GPU-AV with destroyed pipeline layout

f72e1323
by Tony-LunarG at 2022-12-08T11:31:33-07:00
```
gpu: Fix VMA memory leak
```

a54a9aaa

by Mike Schuchardt at 2022-12-08T11:36:49-08:00

build: Update to header 1.3.237

- Update known-good
- Generate source

581e1428

by spencer-lunarg at 2022-12-09T07:56:03+09:00

layers: Combine and cleanup ValidateCBDynamicStatus calls

ab8b42a8
by spencer-lunarg at 2022-12-09T07:56:03+09:00
```
layers: Create Pipeline ColorBlendState helper
```
84e450be
by spencer-lunarg at 2022-12-09T07:56:03+09:00
```
layers: Consistent name for pipeline const ref
```
f72a5f7e
by spencer-lunarg at 2022-12-09T07:56:03+09:00
```
layers: Create Pipeline PreRasterState helper
```
09592c5c
by spencer-lunarg at 2022-12-09T07:56:03+09:00
```
layers: Create Pipeline RasterizationState helper
```
bfa7a420
by spencer-lunarg at 2022-12-09T07:56:03+09:00
```
layers: Create Pipeline MultisampleState helper
```

d6fbdcf3

by spencer-lunarg at 2022-12-09T07:56:03+09:00

layers: Create Pipeline DynamicState helper

Git seems to have a hard time showing the simple move diff

2bbe7a9d
by spencer-lunarg at 2022-12-09T07:56:20+09:00
```
layers: Remove legacy lvl_* vk_typemap_helper
```

8a899b50

by Jeremy Gebben at 2022-12-08T17:28:46-07:00

layers: Fix descriptor buffer VUIDs 08115 and 08117

These 2 VUIDs are about which pipelines are compatible with
vkCmdBindDescriptorSets() or vkCmdSetDescriptorBufferOffsetsEXT().
The old code was looking at state set by
vkCmdBindDescriptorBuffersEXT(). It should be valid to have
descriptors bound but not used to allow switching back and
forth between pipelines that use descriptor sets and descriptor
buffers.

Fixes #4913

5c7df620

by Jeremy Gebben at 2022-12-08T17:28:46-07:00

tests: Make vk_testing::PipelineLayout::init more intuitive

When you only have a single DescriptorSetLayout, it makes more
sense to set up the create info yourself rather than making
a vector of 1 pointer.

934d2bdd

by Boris Zanin at 2022-12-08T17:28:46-07:00

tests: Add tests for descriptor buffer VUIDs 08115 and 08117

3127f8b0
by Juan Ramos at 2022-12-09T11:09:38-07:00
```
layers: Fix mem leak
```
cf001e2e
by Juan Ramos at 2022-12-09T11:40:58-07:00
```
layers: Fix potentiall nullptr issue
```

ea3180d8

by Mark Young at 2022-12-09T13:04:04-07:00

docs: Update layer config

Update layer config doc with latest changes on enabling environment
variables using the command-line.

7348666a
by Juan Ramos at 2022-12-09T13:55:45-07:00
```
cmake: Remove Copyright_cmake.txt
```

9487f4b0

by Ian Hickson at 2022-12-09T15:51:28-07:00

layers: Move Valve copyright into more appropriate place

f6f7c0fd
by Juan Ramos at 2022-12-10T10:39:36-07:00
```
cmake: Fixup usage of BINARY_DIR
```
7140eba9
by spencer-lunarg at 2022-12-11T08:46:37+09:00
```
layers: Add helper function for counting bits set
```
46f343d0
by spencer-lunarg at 2022-12-12T12:21:29+09:00
```
layers: Fix 06887 to check stencil write mask
```
c5ab0019
by spencer-lunarg at 2022-12-13T11:51:33+09:00
```
layers: Fix 06897 check for mesh shaders
```
2e2a258d
by spencer-lunarg at 2022-12-13T14:49:01+09:00
```
layers: Collapse 2d view compatible logic
```
cb5cab11
by spencer-lunarg at 2022-12-13T14:49:01+09:00
```
layers: Add 2d view compatible VU
```
e7a0c9bc
by spencer-lunarg at 2022-12-13T14:49:01+09:00
```
tests: Add 2d view compatible VU
```

ecdbdd06

by Jeremy Gebben at 2022-12-13T07:55:12-07:00

corechecks: Fix VUID 08049

This check had a copy / paste error, which was found by a 'set but not
used' warning from clang-15.

4afd224e

by Jeremy Gebben at 2022-12-13T14:33:27-07:00

tests: Use auto with LvlInit<>() in descriptor tests

ac2e4c2c
by Jeremy Gebben at 2022-12-13T14:33:27-07:00
```
scripts: Make LvlInitStruct<>() be variadic
```

08eb7a34

by Jeremy Gebben at 2022-12-13T14:33:27-07:00

tests: Use variadic LvlInitStruct in descriptor tests

666ed655

by Jeremy Gebben at 2022-12-13T14:33:27-07:00

tests: Add size32() helper functions

These make it easier to set vulkan uint32_t size fields
without tons of casting.

8c5fb30b
by Jeremy Gebben at 2022-12-13T14:33:27-07:00
```
tests: Use size32() in descriptor tests
```

b96a1646

by spencer-lunarg at 2022-12-14T07:58:23+09:00

layers: Move CreateRenderPassGeneric to source file

There are not any other cases of doing VU checks in the header
file the way CreateRenderPassGeneric was doing.

a0bb9e53
by spencer-lunarg at 2022-12-14T07:58:23+09:00
```
layers: Improve RenderPass Param Util message
```
7dc83a05
by spencer-lunarg at 2022-12-14T07:58:23+09:00
```
layers: Add matching VkAttachmentDescription2 VUs
```
684f2c0d
by spencer-lunarg at 2022-12-14T07:58:23+09:00
```
layers: Label VkAttachmentDescription2 06247 06248
```
698654ae
by spencer-lunarg at 2022-12-14T07:58:23+09:00
```
layers: Add Depth layout check for DS formats
```
370267ce
by spencer-lunarg at 2022-12-14T07:58:23+09:00
```
layers: Add Sync2 attachment layout VUs
```
e4f9c09d
by spencer-lunarg at 2022-12-14T07:58:23+09:00
```
layers: Use common stencil layout variable
```
4e1a8ff6
by spencer-lunarg at 2022-12-14T07:58:23+09:00
```
tests: Fix TestRenderPassCreate checking for KHR
```
6d4b9f28
by spencer-lunarg at 2022-12-14T13:48:39+09:00
```
layers: Make bool const where possible
```

ac331e59

by Nathaniel Cesario at 2022-12-13T21:53:59-07:00

layers: Fix 00736 trigger

00736 should only be triggered when vertex input state (not just
pre-raster state) is present.

56e3ebda
by Nathaniel Cesario at 2022-12-13T21:53:59-07:00
```
tests: Test tess-related VUIDs with GPL
```

14f450d4

by Christophe at 2022-12-14T16:07:14+01:00

layers: Expose Imagination Tech best practice in manifest

881d4fa0
by spencer-lunarg at 2022-12-15T01:07:11+09:00
```
tests: Remove CheckCreateRenderPass2Support
```

33935a16

by Juan Ramos at 2022-12-14T09:12:26-07:00

cmake: Fix code duplication

- Multiple VK_USE_PLATFORM_*
- Multiple ANNOTATED_SPEC_LINK

e80426cd

by Juan Ramos at 2022-12-14T09:12:26-07:00

cmake: Remove unused win32/android pre-preproccessor defines

4177f9fe
by Tony-LunarG at 2022-12-14T11:04:04-07:00
```
tests: Fix GPU-AV test getting 06481
```
d6df9168
by Juan Ramos at 2022-12-14T15:35:35-07:00
```
layers: Remove layer_data::optional typedef
```
b3b574a1
by spencer-lunarg at 2022-12-15T08:03:15+09:00
```
layers: Combine Maintenance1 VU checks
```
c57d65cb
by spencer-lunarg at 2022-12-15T08:03:15+09:00
```
layers: Create VkImageType a variable
```
40946276
by spencer-lunarg at 2022-12-15T08:03:15+09:00
```
layers: Add Copy Image Type VU
```
d1659b43
by spencer-lunarg at 2022-12-15T08:03:15+09:00
```
layers: Add helper bool in ValidateCmdCopyImage
```
68324eb8
by spencer-lunarg at 2022-12-15T08:07:54+09:00
```
layers: Move dynamic state tracking to PostCall
```
91625759
by spencer-lunarg at 2022-12-15T08:07:54+09:00
```
layers: Combine promoted dynamic state calls
```
21839cd4
by spencer-lunarg at 2022-12-15T08:07:54+09:00
```
layers: Use DS dynamic state for draw time checks
```

58acad30

by Jeremy Gebben at 2022-12-14T16:27:16-07:00

tests: Add destroy() methods to vk_testing:: objects

Make it easier to destroy (and clear) the vulkan handle
contained in these objects, since this is commonly done
in tests.

a1e63714

by Jeremy Gebben at 2022-12-14T16:27:16-07:00

tests: Add vk_testing::Buffer::address()

Add a method to call vkGetBufferDeviceAddress() and a
constructor to make it easier to create buffers that
support device addresses.

2beda7f6

by Jeremy Gebben at 2022-12-14T16:27:16-07:00

tests: Use vk_testing:: objects in descriptor tests

e4a4c165

by Jeremy Gebben at 2022-12-15T08:07:43-07:00

tests: Remove VkPositiveLayerTest.GetTimelineSemThreadRace

This test isn't functioning correctly on most platforms we test.

Fixes #4917

3784a0d8
by Juan Ramos at 2022-12-15T15:29:06-07:00
```
tests: Use /LARGEADDRESSAWARE
```

081dc9e6

by Juan Ramos at 2022-12-16T15:30:25-07:00

ci: Fix CI deprecation warnings

Update to checkout@v3
Update to setup-python@v4

df33af3b

by Mike Schuchardt at 2022-12-19T09:34:27-08:00

build: Update to header 1.3.238

- Update known-good
- Generate source

59a23a3e

by arno-lunarg at 2022-12-20T16:36:32+01:00

layers: Fix layer_data::span

Container argument in constructor should not be const
Add empty() method
Add data() const method

147ab369

by arno-lunarg at 2022-12-20T16:36:32+01:00

layers: Fix erroneous 1:1 mapping address<->buffer

There is no 1:1 mapping between a buffer and a buffer device address.
A buffer device address can be associated to multiple buffers
if they are bound to overlapping memory locations

Add some trace rays KHR VUIDs
Added:
VUID-vkCmdTraceRaysKHR-pRayGenShaderBindingTable-03680
VUID-vkCmdTraceRaysKHR-pRayGenShaderBindingTable-03681
VUID-vkCmdTraceRaysKHR-pMissShaderBindingTable-03683
VUID-vkCmdTraceRaysKHR-pMissShaderBindingTable-03684
VUID-vkCmdTraceRaysKHR-pHitShaderBindingTable-03687
VUID-vkCmdTraceRaysKHR-pHitShaderBindingTable-03688
VUID-vkCmdTraceRaysKHR-pCallableShaderBindingTable-03691
VUID-vkCmdTraceRaysKHR-pCallableShaderBindingTable-03692

VUID-vkCmdTraceRaysIndirectKHR-pRayGenShaderBindingTable-03680
VUID-vkCmdTraceRaysIndirectKHR-pRayGenShaderBindingTable-03681
VUID-vkCmdTraceRaysIndirectKHR-pMissShaderBindingTable-03683
VUID-vkCmdTraceRaysIndirectKHR-pMissShaderBindingTable-03684
VUID-vkCmdTraceRaysIndirectKHR-pHitShaderBindingTable-03687
VUID-vkCmdTraceRaysIndirectKHR-pHitShaderBindingTable-03688
VUID-vkCmdTraceRaysIndirectKHR-pCallableShaderBindingTable-03691
VUID-vkCmdTraceRaysIndirectKHR-pCallableShaderBindingTable-03692

VUID-VkStridedDeviceAddressRegionKHR-size-04631
VUID-VkStridedDeviceAddressRegionKHR-size-04632

cc2a37a0

by arno-lunarg at 2022-12-20T16:36:32+01:00

tests: Add BuffersAndBufferDeviceAddressesMapping

2074a9f6

by arno-lunarg at 2022-12-20T16:36:32+01:00

docs: Update GPU-AV doc

Mention that there is no 1:1 mapping between a VkBuffer and a
buffer device address

6f04ef6c

by arno-lunarg at 2022-12-20T16:36:32+01:00

tests: Add ray tracing test cases

Add test cases to RayTracingValidateCmdTraceRaysKHR

a1faebf1

by arno-lunarg at 2022-12-20T16:36:32+01:00

layers: Add TODOs for GetBuffersByAddress

Update to GetBuffersByAddress needs to be properly handled

c557a003

by Daniel Rakos at 2022-12-20T11:48:24-07:00

layers: Add best practices VU for secondary command buffers

a0a07df6
by sourav parmar at 2022-12-22T07:45:37+09:00
```
layers: Use stage from pipleline library
```
346612f4
by spencer-lunarg at 2022-12-22T22:27:33+09:00
```
layers: Label new NV RTX VUID
```

cb16c644

by spencer-lunarg at 2022-12-22T23:47:53+09:00

layers: Update CmdDrawIndexedBufferSize to check robustness

c25c21e8
by spencer-lunarg at 2022-12-23T11:22:55+09:00
```
tests: Use LvlInitStruct<VkRenderPassBeginInfo>
```

8c0817e7

by spencer-lunarg at 2022-12-23T11:23:11+09:00

layers: Remove GetImageSubresourceLayout2 tiling VU

6a9d2b5c

by Nathaniel Cesario at 2022-12-23T10:29:17-07:00

layers: Do not allow binding empty DS

This effectively reverts c82d75fe22, which allowed binding empty
descriptor sets.

Closes #4768.

e16e7949
by Nathaniel Cesario at 2022-12-23T10:29:17-07:00
```
tests: Check binding empty descriptor set
```

051f8fa7

by Juan Ramos at 2022-12-23T12:58:32-07:00

tests: Check developer environment variables

Checks VK_ICD_FILENAMES and VK_LAYER_PATH before running tests.

45d6a175
by Juan Ramos at 2022-12-23T18:08:32-07:00
```
docs: Use VK_DRIVER_FILES
```
bea667d3
by Juan Ramos at 2022-12-23T18:08:32-07:00
```
ci: Use VK_DRIVER_FILES
```

4b0639f2

by Jeremy Gebben at 2022-12-26T06:13:34-07:00

layers: Fix intermittent VUID 03047 false positives

Make sure to remove the parent node if we're cleaning up an
object_bindings entry in CMD_BUFFER_STATE::NotifyInvalidate().
Without this, child objects could have a stale parent and think
they are in use when they're not.

Fixes #4981

ee3c2745
by spencer-lunarg at 2022-12-26T22:58:52-07:00
```
tests: Fix VK_LAYER_PATH check
```
93a6b402
by spencer-lunarg at 2022-12-28T00:34:58+09:00
```
layers: Label VUID vkCmdCopyImage 07744
```
1b23eed9
by Hans-Kristian Arntzen at 2022-12-27T08:54:34-07:00
```
layers: Handle SAMPLED_READ in sync2 validation
```
20701bce
by spencer-lunarg at 2022-12-28T12:25:37+09:00
```
layers: Use IsExtEnabled everywhere
```
e77ea2ce
by spencer-lunarg at 2022-12-28T12:25:37+09:00
```
layers: Fix VK_EXT_image_2d_view_of_3d check
```

523b59bc

by spencer-lunarg at 2022-12-28T22:32:03+09:00

layers: Use new LogObjectList multi arg constructor

fa8a85a9

by Juan Ramos at 2022-12-28T09:11:24-07:00

layers: Fix UpdateDescriptorSets race conditions

Found running ThreadUpdateDescriptorUpdateAfterBindNoCollision w/
-fsanitize=thread

cb72ab4a

by Juan Ramos at 2022-12-28T10:04:24-07:00

layers: Use ValidationObject pointer instead of auto

848aa812

by Juan Ramos at 2022-12-28T10:04:24-07:00

doc: Clarify why to avoid using auto in generated code

8b30098b

by Jeremy Gebben at 2022-12-28T12:48:44-07:00

corechecks: Improve vkQueuePresentKHR semaphore validation

Use the common validation code to implement VUIDs 01294, 01295
and 03268.

Fixes #4869

a785be18
by Jeremy Gebben at 2022-12-28T12:48:44-07:00
```
tests: Clean up WSI tests
```
834f9f90
by Jeremy Gebben at 2022-12-28T12:48:44-07:00
```
tests: Add vkQueuePresentKHR semaphore tests
```

aeb96b9f

by Jeremy Gebben at 2022-12-28T19:32:45-07:00

build: Fix windows build when the source path includes spaces

95824127

by ziga-lunarg at 2022-12-29T16:50:29+01:00

layers: Add video usage bits to valid image usage

e9637174
by arno-lunarg at 2022-12-29T16:54:53+01:00
```
layers: Add VU family 07272
```
9f680dde
by arno-lunarg at 2022-12-29T16:54:53+01:00
```
tests: Add VU family 07272
```
f865a613
by spencer-lunarg at 2022-12-30T13:42:29+09:00
```
tests: Update extension enabling
```

3a7ab5ca

by Juan Ramos at 2022-12-30T10:01:06-07:00

layers: Fix CMD_BUFFER_STATE potential deadlock

closes #5011

7ddf6b84

by Juan Ramos at 2022-12-30T18:28:35-07:00

docs: Remove "Coding Conventions for CMake" section

94338e82
by Juan Ramos at 2022-12-30T18:28:35-07:00
```
docs: Remove CCACHE section
```
b3bc1045
by Juan Ramos at 2022-12-30T18:28:35-07:00
```
docs: Update Requirements section
```

78ed2f9a

by Juan Ramos at 2022-12-30T18:30:32-07:00

layers: Mark ValidationObject::ReadLock method as const

0f265cf7

by Juan Ramos at 2022-12-30T18:31:27-07:00

layers: Cleanup CMD_BUFFER_STATE::ExecuteCommands

- Use span
- Use MaxTypeValue
- Use |=
- Use emplace_back

85a4da5b
by spencer-lunarg at 2023-01-01T12:59:58+09:00
```
layers: Add GetBitWidth SPIR-V helper
```
4a54be5d
by spencer-lunarg at 2023-01-01T13:00:08+09:00
```
layers: Remove old spirv_inst_iter system
```
50db0d9f
by spencer-lunarg at 2023-01-03T01:06:42+09:00
```
layers: Add Shader input attachment VU
```

c94dfedc

by Jeremy Gebben at 2023-01-02T13:34:09-07:00

scripts: Improve copyright checking in check_code_format.py

VerifyCopyrights() checks the date range on the LunarG copyright
lines. Only LunarG employees should claim copyright for LunarG.

VerifyCopyrights() should use the author date of the commit(s)
in the PR, rather than the year on whichever day the script runs.

Happy New Year!!!

3a09ea1b

by Daniel Rakos at 2023-01-03T07:42:07-07:00

layers: Add support for video core and decode extensions

6d3a9c7c

by spencer-lunarg at 2023-01-03T07:53:54-07:00

deps: Update SPIR-V Tools and Headers version

Current SPIR-V Tools had build issue that is now fixed

92bd5a9c

by Jeremy Gebben at 2023-01-03T11:56:11-07:00

layers: Clean up vk_layer_logging.h

Add vk_layer_logging.cpp, so that most of the logging functions
can be de-inlined. This appears to reduce compiled code size for
the validation layer by 11% to 33% (on linux).

Change LogMsgLocked() to LogMsg() and restructure it to avoid
duplicated code in class ValidationObject.

Remove use of vasprintf() and snprintf() into a std::string instead.
vasprintf() calls malloc internally and VVL must call free. When
overriding malloc, this gets complicated because libc and VVL can
end up using different malloc and free implementations.

5eb7718a

by Juan Ramos at 2023-01-03T12:53:24-07:00

cmake: Raise minimum to 3.17.2

spirv-tools updated their cmake minimum to 3.17.2

28b4faee
by Jeremy Gebben at 2023-01-03T13:07:28-07:00
```
scripts: Run code format checks commit-by-commit
```

896073cd

by Juan Ramos at 2023-01-03T18:51:42-07:00

cmake: Use target_link_options/add_link_options

92f4c7b6
by spencer-lunarg at 2023-01-05T00:22:13+09:00
```
layers: Fix discard rectangle draw VU
```

65c3bef0

by spencer-lunarg at 2023-01-05T00:35:44+09:00

layers: Make separate FragmentShadingRateState helper

b3184719

by spencer-lunarg at 2023-01-05T00:35:44+09:00

layers: Make sparate DynamicRendering pipeline helper

2df3509c
by spencer-lunarg at 2023-01-05T00:35:44+09:00
```
layers: Combine LibraryFlags checks together
```

b4e93d11

by Artem Kharytoniuk at 2023-01-04T19:43:18+01:00

docs: Update python executable name on Windows

According to requirements Python 3.x is required to build the project.
Python 3.x Windows distributions usually provide python.exe but not
python3.exe. Windows app store distribution has both python3.exe
and python.exe.

f89cb21c

by arno-lunarg at 2023-01-04T20:35:04+01:00

layers: Fix shader binding device address

When VkStridedDeviceAddressRegionKHR.deviceAddress is 0, the region
is considered unused, and this is a valid behavior

9d77a976
by spencer-lunarg at 2023-01-05T10:31:01+09:00
```
layers: Make RENDER_PASS_STATE const ref
```
0ddbb1ed
by spencer-lunarg at 2023-01-06T00:18:07+09:00
```
layers: Collapse ValidateShaderModuleId logic
```

9063f8dd

by Juan Ramos at 2023-01-05T09:01:57-07:00

cmake: Cleanup VkLayer_utils

- Add vital documentation
- Use modern CMake features
- Generate LAYER_UTIL_FILES from SOURCES property

b7386b6e

by Juan Ramos at 2023-01-05T09:02:08-07:00

build: Remove unused AMD_EXTENSIONS / NV_EXTENSIONS

81e27015
by Juan Ramos at 2023-01-05T11:07:14-07:00
```
github: Add CODEOWNERS
```
a2ad3263
by Nathaniel Cesario at 2023-01-05T15:42:28-07:00
```
docs: Update repo contacts
```

a6b3c1bc

by Tony-LunarG at 2023-01-05T16:31:35-07:00

gpu: Add debug option to validate instrumented shaders

47d0952f
by spencer-lunarg at 2023-01-06T08:59:34+09:00
```
layers: New pipeline_validation for CoreCheck
```
516677f3
by spencer-lunarg at 2023-01-06T09:01:53+09:00
```
layers: Fix mislabled Video VUID
```
93e19664
by spencer-lunarg at 2023-01-06T09:04:37+09:00
```
layers: Remove unused DecorationSet fields
```

7b467a1f

by spencer-lunarg at 2023-01-06T09:04:37+09:00

layers: Cleanup DecorationSet

Comments and Has() function

78a6fe8f

by spencer-lunarg at 2023-01-06T09:04:37+09:00

layers: Move InputAttachmentIndex tracking to entrypoint

e395ba36

by spencer-lunarg at 2023-01-06T09:04:37+09:00

layers: Move Descriptor InterfaceVariable to Entrypoint

f39b7170
by spencer-lunarg at 2023-01-06T09:04:37+09:00
```
layers: Cleanup of shader interface
```
e4a3c3c6
by spencer-lunarg at 2023-01-06T09:14:29+09:00
```
layers: New wsi_validation for CoreChecks
```
c2fa2832
by spencer-lunarg at 2023-01-06T23:45:34+09:00
```
layers: Use BINDABLE state sparse field
```

cbe7546a

by Martin Freebody at 2023-01-07T00:59:09+09:00

layers: Update validation layer checks for dynamic rendering

Enhance validation state checking for renderpass instance
suspend and resume to include secondary command buffers.

b8f8a7c9

by Martin Freebody at 2023-01-07T00:59:09+09:00

tests: Expand Dynamic rendering suspend & resume

Add two new tests covering the use of dynamic rendering
suspend and resume in secondary command buffers.

4050be7c
by Juan Ramos at 2023-01-06T10:51:11-07:00
```
cmake: Delete VVLGenerateSourceCode.cmake
```

3a567905

by arno-lunarg at 2023-01-06T20:53:33+01:00

layers: Only validate non sparse buffers

For the shader binding table buffers mentioned in trace rays cmds,
only validate memory binding if buffer is not sparse.

82380330

by Artem Kharytoniuk at 2023-01-06T22:06:14+00:00

cmake: Replace Visual Studio user file with cmake properties

482f5d14

by Nathaniel Cesario at 2023-01-06T16:35:44-07:00

layers: Allow binding empty DS with empty layout

Allow an empty descriptor set to be bound if the current layout also
defines an empty descriptor set.

21b5ba4c
by Nathaniel Cesario at 2023-01-06T16:35:44-07:00
```
tests: Bind empty DS with empty layout
```
c2f13244
by spencer-lunarg at 2023-01-08T13:03:38+09:00
```
layers: Move Video CoreCheck to own file
```
9830c496
by spencer-lunarg at 2023-01-08T13:03:38+09:00
```
layers: Use GetBitSetCount in VideoProfileInfo
```
d5426ea2
by spencer-lunarg at 2023-01-08T13:07:03+09:00
```
layers: Move CoreChecks to Ray Tracing file
```

042ffcc0

by spencer-lunarg at 2023-01-08T14:47:40+09:00

layers: Fix check for VK_DYNAMIC_STATE_DISCARD_RECTANGLE_EXT

13064d6e
by spencer-lunarg at 2023-01-09T18:25:47+09:00
```
layers: Move Android CoreChecks to own file
```

1ac18e88

by spencer-lunarg at 2023-01-09T18:25:47+09:00

layers: Remove buffer_validation.h

The file was providing no use.
Other *_validation.cpp files don't have a header file neither

8a2cc88d
by spencer-lunarg at 2023-01-09T18:32:41+09:00
```
layers: Move Query CoreChecks to own file
```
e2ef1302
by spencer-lunarg at 2023-01-09T21:21:50+09:00
```
layers: Move device memory CoreCheck to own file
```

e3a7ea71

by Jeremy Gebben at 2023-01-09T07:31:23-07:00

layers: Fix includes in shader_instruction.h

This file uses std::string but was relying on other headers
to #include <string>.

6d6acb9a

by Jeremy Gebben at 2023-01-09T07:31:23-07:00

build: Make USE_ROBIN_HOOD_HASHING more sensible

Make robin_hood a non-REQUIRED package and use it if found.

748f00e1
by Artem Kharytoniuk at 2023-01-09T19:31:33+00:00
```
tests: Add note about implicit validation layers
```

38be3b2c

by Juan Ramos at 2023-01-09T14:00:11-07:00

cmake: Optimize MSVC build

- Enable /LTCG
- Enable /OPT:REF
- Enable /OPT:ICF

d786eab6

by Juan Ramos at 2023-01-10T10:55:21-07:00

cmake: Fix usage of Vulkan::Registry

Vulkan::Registry was deprecated by Vulkan-Headers

Use 'VULKAN_HEADERS_REGISTRY_DIRECTORY' instead.

4ebcf9bc

by Karl Schultz at 2023-01-10T13:37:58-07:00

tests: Fix jump to null function pointer

Found on lavapipe 22.3.2.

Lavapipe doesn't support the VK_KHR_SAMPLER_YCBCR_CONVERSION_EXTENSION.

This test uses this extension by calling one of its functions to test
the case where one of its dependent extensions isn't enabled.  The
trouble with this is that if the sampler extension isn't supported, the
test should not call the extension function and should skip the rest of
the test.

This commit modifies the check for the extension to skip the test in
this situation.

0ee326ed

by Juan Ramos at 2023-01-10T17:37:13-07:00

cmake: Fix LunarG/VulkanTools build

Regression caused by 4050be7c1960ae0aec00b421bb47be8d67cabe63

Currently LunarG/VulkanTools will fail to build.
This is due to disabling BUILD_LAYERS and BUILD_TESTS, which
causes the SPIRV-Headers::SPIRV-Headers dependency to not exist.

1debf6c5
by spencer-lunarg at 2023-01-11T11:58:19+09:00
```
layers: Move RenderPass CoreCheck to own file
```
e4d0a215
by Artem Kharytoniuk at 2023-01-11T17:59:18+01:00
```
layers: Ensure object handle is not null
```
544e0687
by Juan Ramos at 2023-01-11T11:24:42-07:00
```
layers: Remove optick instrumentation
```

b5fcd77e

by Jeremy Gebben at 2023-01-11T14:26:07-07:00

build: Use mimalloc to improve win64 performance

When instrumenting shaders for GPU-AV, SPIRV-Tools spends a large
amount of time allocating and freeing small buffers. Using mimalloc
instead of the standard system malloc can improve performance for
this use case by about 20%. Other validation use cases appear to have
performance improvement of 5-10% from this change.

Currently this is only enabled for 64-bit MSVC builds. Testing on other
OSes shows stability problems when statically linking mimalloc into the
layer. For these platforms, mimalloc can be used by including
mimalloc.so in `LD_PRELOAD`.

39e84c7d
by spencer-lunarg at 2023-01-12T08:12:51+09:00
```
layers: Move RenderPass function to RP file
```
cb1f0ebd
by spencer-lunarg at 2023-01-12T08:12:51+09:00
```
layers: Move subpass CoreChecks to RP file
```

0e8c94c8

by spencer-lunarg at 2023-01-12T08:12:51+09:00

layers: Move ValidateImageSampleCount to buffer val

556b35ee

by spencer-lunarg at 2023-01-12T08:12:51+09:00

layers: Move descriptor CoreChecks to descriptor file

c0aa4c2e
by spencer-lunarg at 2023-01-12T08:12:51+09:00
```
layers: Move DynamicState CoreCheck to own file
```
430dca08
by spencer-lunarg at 2023-01-12T08:13:18+09:00
```
layers: Use reference for color blend state
```

ca243212

by spencer-lunarg at 2023-01-12T08:13:18+09:00

layers: Add VkPipelineColorBlendStateCreateInfo count VU

e1338046

by spencer-lunarg at 2023-01-12T08:13:18+09:00

tests: Add VkPipelineColorBlendStateCreateInfo count VU

e0389b0d

by spencer-lunarg at 2023-01-12T08:13:18+09:00

layers: Add VkPipelineColorWriteCreateInfoEXT count VU

9f796e21
by spencer-lunarg at 2023-01-12T08:13:18+09:00
```
layers: Label VUID 07609
```
30ab6d2c
by spencer-lunarg at 2023-01-12T08:13:18+09:00
```
layers: Label dynamicState3 Sampler Location VUIDs
```
97122831
by spencer-lunarg at 2023-01-12T08:13:18+09:00
```
tests: Removed unneeded features2 struct
```

544e93ec

by Juan Ramos at 2023-01-11T16:26:55-07:00

cmake: Add VVL_ENABLE_TSAN

Adds thread sanitization to the build.

dbb9f6b6
by spencer-lunarg at 2023-01-12T14:21:19+09:00
```
tests: Cleanup tests to be more robust
```

d9be0372

by spencer-lunarg at 2023-01-12T14:21:19+09:00

tests: Update Device Profiles

For now just pick 3 simple profiles.
Goal to add more with more features/extensions slowly after

b69f8c7d
by Juan Ramos at 2023-01-12T09:06:27-07:00
```
cmake: Use target_sources consistently
```

9f2c2922

by Jan Beich at 2023-01-12T12:16:21-07:00

cmake: Restore X11/Wayland support on non-Linux after 33935a1619

bd2785d1
by Artem Kharytoniuk at 2023-01-12T23:46:02+01:00
```
layers: Use fallthrough attribute and enable warning
```

982ab4db

by Mike Schuchardt at 2023-01-12T15:15:57-08:00

scripts: Add extension VU coverage report

Add option -extension_coverage to generate a csv report with VUID counts
broken down by extension. If a single VUID interacts with multiple
extensions, it will be added to the counts for each one.

95e6d1a7

by Mike Schuchardt at 2023-01-12T15:15:57-08:00

scripts: Refactor stats script argument parsing

Replace the goofy C-style argument parser with the argparse module. New
version should accept all the same arguments as before and be more
robust.

3b9d7211

by Mark Lobodzinski at 2023-01-12T16:22:35-07:00

layers: Fix handle wrapping for new extension structure

VK_EXT_swapchain_maintenance1 added a new struct containing a handle
to the pNext chain of vkPresentInfoKHR in vkQueuePresent(). The
dispatch function is handled manually, so codegen didn't cover the new
case.

Change-Id: I1ccbdb2f6361f1f232ec30e088787c78c0aa00bd

c0880f6e

by Mark Lobodzinski at 2023-01-12T16:22:35-07:00

layers: Add support for VK_EXT_swapchain/surface_maintenance1

These extensions allow increased flexibility and control of creating
and managing swapchains. This patch adds support for the
instance extension VK_EXT_surface_maintenance1 and the
device extension VK_EXT_swapchain_maintenance1.

Change-Id: I7df3b5c3dd7f81dcb60a63967bd7d1da709af5f7

dcad1344

by Mark Lobodzinski at 2023-01-12T16:22:35-07:00

tests: Add coverage for new surface/swapchain_maintenance1 VUs

Change-Id: I9bc89a0e4725dc0b0426dca689c1b8a77eef2664

5ec235bb

by Mark Lobodzinski at 2023-01-12T16:22:35-07:00

layers: Combine swapchain_maint1 present_mode data structures

Unifies the legacy present_modes_ data structure with the the new
version that contains optional swapchain_maintenance1 data.

Change-Id: Id5d75ec57949bd4d2a337c9575e29a9345154eac

fb5f8b2a

by Mark Lobodzinski at 2023-01-12T16:22:35-07:00

layers: Use spans where appropriate, use auto with LvlInitStruct

Change-Id: Iee29180c040db24c8ab350d9cd8e07f814b1b520

6c021b78

by Juan Ramos at 2023-01-12T17:25:12-07:00

cmake: Use target_compile_definitions & add_compile_definitions

de7dead6

by Nathaniel Cesario at 2023-01-13T08:17:09-07:00

layers: Fix GCC release build with -Werror

Fixes a warning on gcc 12.2 when building release with -Werror.

8bcc3f6d
by David Neto at 2023-01-13T12:20:31-07:00
```
build: Remove unused functions

Fixes: #5106
```
30cce9e1
by Juan Ramos at 2023-01-13T13:58:56-07:00
```
docs: Remove mention of travis
```
ad0b11a5
by spencer-lunarg at 2023-01-15T15:08:54+09:00
```
scripts: Remove false positive for sType
```

068826e6

by Jeremy Gebben at 2023-01-16T11:32:27-07:00

corechecks: Include relevant objects in transfer command errors

Many transfer commands VUIDs were not including the VkCommandBuffer,
VkBuffer or VkImage in their error messages. Improve this, and
de-pointer many of the invovled helper methods.

5cd199be

by Juan Ramos at 2023-01-16T13:13:14-07:00

ci: Test CMake min with GitHub action

Removes need for custom cmake scripts

466cc680