[Git][xorg-team/app/renderdoc][debian/master] 300 commits: Bump version to v1.21

Jordan Justen pushed to branch debian/master at X Strike Force / app / renderdoc

Commits:

e89cee8f
by baldurk at 2022-05-27T17:10:54+01:00
```
Bump version to v1.21
```

49df2e44

by baldurk at 2022-05-30T11:18:31+01:00

Include a few more things in verbose command recording logs

b3e8bdb0

by baldurk at 2022-05-30T15:58:30+01:00

Only show base EID not EID range when exporting actions

6d7d4829
by baldurk at 2022-05-30T17:09:17+01:00
```
Fix docs build on sphinx 5
```

f01dfbec

by baldurk at 2022-05-31T11:26:59+01:00

Add a python extension function to access picked location. Refs #2065

77232e02

by baldurk at 2022-05-31T13:06:42+01:00

Fix lookup of HLSL direct cbuffer variable references

c3dd785a

by baldurk at 2022-06-01T21:05:37+01:00

Don't add source files to SPIR-V reflection with no filename

3059cc61

by baldurk at 2022-06-02T17:00:52+01:00

Fix error code for linux programs failing to run

fcc7eada

by baldurk at 2022-06-02T17:01:48+01:00

Ignore whitespace when matching variable tooltip expressions

21d4d4c0

by baldurk at 2022-06-02T17:02:30+01:00

Fix debugging of SPIR-V with offsets in image sampling operations

c625f9db

by baldurk at 2022-06-02T18:13:29+01:00

Add debug option for showing DebugValue opcodes

2a97762b

by baldurk at 2022-06-02T18:16:30+01:00

Handle indexes and partial source mapping in SPIR-V debug info

c4b4c528

by baldurk at 2022-06-02T18:18:58+01:00

Add a testing option to step to DebugValue instructions

958e568c

by Jake Turner at 2022-06-06T18:12:53+01:00

Added wrapped MTLRenderCommandEncoder

Implemented capture serialisation for APIs:
MTLCommandBuffer::renderCommandEncoderWithDescriptor
MTLRenderCommandEncoder::setRenderPipelineState
MTLRenderCommandEncoder::setFragmentTexture
MTLRenderCommandEncoder::setViewport
MTLRenderCommandEncoder::drawPrimitives
MTLRenderCommandEncoder::endEncoding

Serialisation for helper types:
MTL::PrimitiveType
MTL::LoadAction
MTL::StoreAction
MTL::StoreActionOptions
MTL::ClearColor
MTL::Viewport
MTL::MultisampleDepthResolveFilter
MTL::MultisampleStencilResolveFilter
MTL::SamplePosition
MTL::RenderPassDescriptor
MTL::RenderPassAttachmentDescriptor
MTL::RenderPassColorAttachmentDescriptor
MTL::RenderPassDepthAttachmentDescriptor
MTL::RenderPassStencilAttachmentDescriptor
MTL::RenderPassSampleBufferAttachmentDescriptor

c73c54dd

by baldurk at 2022-06-06T18:35:29+01:00

Be more informative with 'capture incompatible' error messages on vulkan

3e9a7207

by baldurk at 2022-06-06T18:35:29+01:00

Update to latest VK and SPIR-V headers

* This also adds support for VK_KHR_fragment_shader_barycentric as a mostly in-
  place upgrade from the NV extension

e50e114c

by baldurk at 2022-06-06T18:35:29+01:00

Show error/unavailable status for postvs data in mesh view. Refs #2595

c81a5223

by baldurk at 2022-06-07T12:19:50+01:00

Fix entry-point remapping when editing compute shaders on vulkan

dc7d79a5

by baldurk at 2022-06-07T21:05:06+01:00

Resetting command pools should free in-flight recording pages

* Command buffers that have grabbed pages in their allocators should have those
  pages freed if the pool is reset and the command buffer is never ended.

5ff8f2c4

by baldurk at 2022-06-07T22:22:02+01:00

Fix state inheritance properly for library pipelines

a68f9ba8

by baldurk at 2022-06-07T22:31:02+01:00

Don't use dynamic rendering when we replace with a fixed renderpass

ed9ac9f7

by baldurk at 2022-06-09T16:56:02+01:00

Add a hack flag to allow subgroup bitwise or

1e8425c3

by baldurk at 2022-06-14T18:05:07+01:00

Refactor handling of device/window pairs and overlay text

7142bf16

by baldurk at 2022-06-14T18:36:33+01:00

Handle non-infinite arrays of UBOs in vulkan shader debugging

85af87c2
by baldurk at 2022-06-14T20:38:43+01:00
```
Fix unused variable warning
```
22b22728
by Jake Turner at 2022-06-15T13:02:27+01:00
```
Added wrapped MTLBuffer
```

31b97ab0

by Jake Turner at 2022-06-15T13:02:27+01:00

Updated TODO: about BinaryArchive & DynamicLibrary

They will both need to be wrapped.
When WrappedMTLBinaryArchive and WrappedMTLDynamicLibrary exist then can serialize:
binaryArchives
vertexPreloadedLibraries
fragmentPreloadedLibraries

15a99155

by baldurk at 2022-06-16T15:53:49+01:00

Fix checks for individual features in EXT dyn state 2

f6ac09c4

by baldurk at 2022-06-16T15:53:49+01:00

Workaround intel mesa issue reading invalid sample locations

4d8fdf4e

by baldurk at 2022-06-16T15:53:49+01:00

Use inline asm for debugbreak on linux to remove stack frames

* raise() adds several stack frames in debug builds, and even an inline function
  will too, regardless of always_inline status.

9f66c125

by baldurk at 2022-06-16T15:53:50+01:00

Add color attachment usage for MSAA targets for discard patterns

* In most cases we expect this to already be there, and if not it likely will
  not penalise anything in the driver since MSAA is designed for rendering to.

fc39299d

by baldurk at 2022-06-16T15:53:50+01:00

Don't require GL_OVR_multiview2 when GL_OVR_multiview is enough

* This is also all we check for in code.

59804c1d

by baldurk at 2022-06-16T15:53:50+01:00

When using GLES on desktop, use same API for child context. Closes #2612

0fce39ff

by baldurk at 2022-06-16T15:53:50+01:00

Implement workaround for broken occlusion queries on Intel. Closes #2591

* If a draw has no effects (color mask writes off, no depth attachment) then
  Intel will not return proper occlusion query results. Forcibly patching in a
  storage write works around the problem.

1eee00f0
by baldurk at 2022-06-16T16:30:00+01:00
```
Remove unnecessary sRGB conversions
```

6a006625

by baldurk at 2022-06-17T10:46:14+01:00

Ignore rasterizerDiscardEnable == true if it is dynamic. Closes #2617

* Normally we have to ignore subsequent states as potentially garbage pointers
  if discard is enabled, but when it's dynamic state we have to ignore its
  valid.

825f1c69
by Jason Chen at 2022-06-17T16:09:22+01:00
```
Fix typo
```

623cd019

by Danylo Piliaiev at 2022-06-17T17:26:16+01:00

Do not use inline asm for debugbreak on non i386/x86_64 targets

Fixes compilation on non i386/x86_64 Linux targets.

Don't use arch specific assembly for other architectures because
in most cases it breaks gdb ability to do next step.

Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>

fd2ae37a

by baldurk at 2022-06-17T17:27:30+01:00

Test overlay rendering with separable shader programs

46a1f904

by baldurk at 2022-06-17T17:27:30+01:00

Disable depth bounds test when rendering GL overlay

ef003ec8
by baldurk at 2022-06-17T17:27:30+01:00
```
Test depth bounds serialisation on GL
```
20b496fc
by baldurk at 2022-06-17T17:27:30+01:00
```
Add test of integer bare uniforms on GL
```

71d7f000

by baldurk at 2022-06-17T17:27:30+01:00

Add test for D3D12 texture contents including with DENY_SHADER_RESOURCE

4a0bc691

by baldurk at 2022-06-17T17:27:30+01:00

Add test that solid/lit rendering works on points and lines

95c8a3f4
by baldurk at 2022-06-17T17:27:30+01:00
```
Test swizzles of UAV reads
```

db06aaa2

by baldurk at 2022-06-17T17:27:30+01:00

Test that recreating renderbuffers doesn't leak resources

e15df3a7

by baldurk at 2022-06-17T17:27:30+01:00

Test that glBindProgramPipeline(0) generates no errors

028d71fc

by baldurk at 2022-06-17T18:13:06+01:00

Remove DENY_SHADER_RESOURCE flag in all resource creation functions

59b43510

by William Hjelm at 2022-06-17T19:47:21+01:00

Fix typo in in intercepted CreateCommittedResource

f5a2bae2

by Jake Turner at 2022-06-20T10:12:40+01:00

Set the enable state for Save, Delete actions

Disable the actions when no captures are selected

c6fff16b

by Jake Turner at 2022-06-20T10:14:34+01:00

Reserve Chunk for modifying MTLBuffer contents

MTLBuffer_InternalModifyCPUContents

e7669288
by Jake Turner at 2022-06-20T10:14:34+01:00
```
DoStringise for MetalChunk
```

0431e411

by baldurk at 2022-06-20T16:47:50+01:00

Handle D3D12 renderpass resolves. Closes #2622

183f50bf
by baldurk at 2022-06-20T16:47:50+01:00
```
Fix patching of qt dependencies
```

687c11ba

by baldurk at 2022-06-20T16:47:50+01:00

Fix handling of 64-bit integer vertex attributes in mesh output fetch

e903589e

by baldurk at 2022-06-20T17:20:51+01:00

Fix bitcast between types of different column counts

2020a71c

by baldurk at 2022-06-21T12:51:31+01:00

Account for flip in face culling winding for GL clip origin

* The GL clip origin when changed from lower left to upper left will also invert
  the face culling sense. This is deliberate to counteract the fact that
  otherwise CW wound triangles would be CCW wound, so the flip means that if
  GL_CCW is the front face state and back faces are culled, then visibly CCW
  wound triangles will be culled.

7d9a1a05

by baldurk at 2022-06-21T15:31:41+01:00

Correctly handle programs that don't create graphics queues

86845853

by Orson Baines at 2022-06-22T13:17:24+01:00

Add WIP OpenGL Pixel History code for PostMod pixel value

The OpenGL Pixel History feature is hidden behind the OpenGL_PixelHistory config toggle.
For now, we only run an occlusion query and then replay the events
and read back the pixel values to return to the UI.

45ac6242

by Orson Baines at 2022-06-22T13:17:24+01:00

OpenGL Pixel History address PR feedback

- add missing destroy resources call
- restore framebuffer binding after replaying draw
- disable more state bits for occlusion querying
- read back query results after executing all queries

d1dcb81a

by Orson Baines at 2022-06-22T13:17:24+01:00

use WrappedOpenGL::SetFetchCounters in occlusion query

8838a878

by baldurk at 2022-06-22T20:04:42+01:00

Show the current event in texture viewer usage context menu

2bf91773

by baldurk at 2022-06-22T20:04:42+01:00

When using debug info, don't use first store as variable live point

* We already will have a live point when the variable is declared

c8f67313

by baldurk at 2022-06-22T20:04:42+01:00

Fix handling of local variable mappings around function entry & calls

20f42fea

by baldurk at 2022-06-22T20:04:42+01:00

Improve mapping of breakpoints to disassembly & source

* We breakpoint directly on source/disassembly lines rather than trying to map
  to instructions that may get stepped over and skipped.

f18d1b3b

by baldurk at 2022-06-22T20:04:42+01:00

Improve ordering of source declared variables for debug info

c13366d1

by baldurk at 2022-06-22T20:04:42+01:00

Fix capturing frame 0 if the first window is never presented

* The first window created becomes active, if it never presents then a frame 0
  capture never finishes.

81436706

by Jake Turner at 2022-06-23T12:10:35+01:00

Recursive patching of qt external dependencies

Recursively copy and repoint the external libraries and their external dylib dependencies

c7b6d629

by Jake Turner at 2022-06-23T12:11:57+01:00

Serialization for Metal types

structs

MTL::Origin
MTL::Region
MTL::Size

enums

MTL::BlitOption
MTL::DeviceLocation
MTL::ArgumentBuffersTier
MTL::DepthClipMode
MTL::TriangleFillMode
MTL::CullMode

0499c2af
by Jake Turner at 2022-06-23T12:11:57+01:00
```
Serialization for enum MetalResourceType
```

1f6b2abc

by Jake Turner at 2022-06-23T12:11:57+01:00

ObjC helpers MTL::Drawable, CALayer, CAMetalLayer

Get_Texture(MTL::Drawable *drawable);
Get_Layer(MTL::Drawable *drawable);
CALayer_GetSize(void *layerHandle, int &width, int &height);
CAMetalLayer_Set_drawableSize(void *layerHandle, int w, int h);
CAMetalLayer_Set_device(void *layerHandle, MTL::Device *device);
CAMetalLayer_Set_framebufferOnly(void *layerHandle, bool enable);
CAMetalLayer_Set_pixelFormat(void *layerHandle, MTL::PixelFormat format);
CA::MetalDrawable *CAMetalLayer_nextDrawable(void *layerHandle);

d3e2231b
by Jake Turner at 2022-06-23T12:11:57+01:00
```
Use bytebuf::assign() instead of resize, memcpy
```

b44a75ed

by Jake Turner at 2022-06-23T12:11:57+01:00

Helpers to convert MTL Blend, ColorWriteMask enums

MakeBlendMultiplier(MTL::BlendFactor blend);
MakeBlendOp(MTL::BlendOperation op);
MakeWriteMask(MTL::ColorWriteMask mask);

5919085e
by baldurk at 2022-06-23T12:12:06+01:00
```
Fix unused lambda capture compile warning
```

e310f729

by baldurk at 2022-06-23T18:38:03+01:00

Delete chunks upon re-beginning a command buffer

* If a command buffer had an unbalanced begin/end, some chunks may still be left
  in the record that haven't been baked. Delete these before beginning to record
  again.

a4859114

by baldurk at 2022-06-23T18:39:30+01:00

Load stencil state from stencil attachment correctly

67920a37
by baldurk at 2022-06-24T11:10:57+01:00
```
Update RGA backend to include gfx1035
```

4d9f5342

by baldurk at 2022-06-24T12:22:13+01:00

Check queue availability in vulkan compute-only test

1928315d

by baldurk at 2022-06-24T13:34:46+01:00

Fix a copy-paste error in D3D12_Compute_Only test

5096d024

by Jake Turner at 2022-06-24T21:03:36+01:00

Future proofing MakeBlendMultiplier & MakeBlendOp

Remove default from switch statements to trigger compile errors if MTL::BlendFactor or MTL::BlendOperation enumerations change in the future.

b6787686

by Jake Turner at 2022-06-24T21:03:36+01:00

Helpers for Texture byte size and ResourceFormat

public Methods

MakeResourceFormat(MTL::PixelFormat format);
GetByteSize(uint32_t width, uint32_t height, uint32_t depth, MTL::PixelFormat format, uint32_t mip);

private helper Methods

IsOneComponent(MTL::PixelFormat mtlFormat);
IsTwoComponent(MTL::PixelFormat mtlFormat);
IsThreeComponent(MTL::PixelFormat mtlFormat);
IsFourComponent(MTL::PixelFormat mtlFormat);
IsBlockFormat(MTL::PixelFormat mtlFormat);
IsDepthOrStencilFormat(MTL::PixelFormat mtlFormat);
IsUNormFormat(MTL::PixelFormat mtlFormat);
IsSNormFormat(MTL::PixelFormat mtlFormat);
IsFloatFormat(MTL::PixelFormat mtlFormat);
IsUIntFormat(MTL::PixelFormat mtlFormat);
IsSIntFormat(MTL::PixelFormat mtlFormat);
IsSRGBFormat(MTL::PixelFormat mtlFormat);
IsYUVFormat(MTL::PixelFormat format);
GetBlockShape(MTL::PixelFormat format, uint32_t plane);
GetPlaneByteSize(uint32_t width, uint32_t height, uint32_t depth, MTL::PixelFormat format, uint32_t mip, uint32_t plane);

98075c67

by Jake Turner at 2022-06-24T21:03:36+01:00

Unit tests for Metal format helper methods

Basic tests for public methods:
MakeResourceFormat(MTL::PixelFormat format);
GetByteSize(uint32_t width, uint32_t height, uint32_t depth, MTL::PixelFormat format, uint32_t mip);

One test for helper method:
GetPlaneByteSize(uint32_t width, uint32_t height, uint32_t depth, MTL::PixelFormat format, uint32_t mip, uint32_t plane);

d34c2cf6
by Jake Turner at 2022-06-27T11:03:22+01:00
```
Do not clear catch failure return state
```

dd58dd01

by Jake Turner at 2022-06-27T11:03:22+01:00

Update expected error message to match code

Fixes failing "Buffer format parsing" unit test

0a4fbe8c

by Jake Turner at 2022-06-27T11:07:46+01:00

Improve Xcode project generation for qrenderdoc

Xcode does not match the cmake behaviour of rerunning the target every time if the output file does not exist and then letting the Qt build system handle dependency checking.
Xcode has a property to behave like this, however that is not exposed by cmake.
To improve this for the Xcode qrenderdoc project manually add qrenderdoc sources files as dependencies.

Changed the Xcode project for qrenderdoc to add the files to the UI grouped by the file system folders using the cmake source_group(TREE *) command.

d257b501

by Jake Turner at 2022-06-28T12:33:45+01:00

Wrapped MtlBlitCommandEncoder

Added temporary implementation of GetWrapped() and Unwrap() for the unimplemented Metal types used by MTLBlitCommandEncoder APIs (MTLFence, MTLIndirectCommandBuffer, MTLCounterSampleBuffer).
The API synchronizeResource uses ObjC inheritance for MTLResource, which uses new helper methods for MTLResource without implementing the complete type.

MTLResource helper methods: GetResID(), Unwrap(), GetWrapped().
The WrappedMTLResource* is cast to WrappedMTLObject* to get the ID and real resource.

For the unimplemented Metal types: MTLFence, MTLIndirectCommandBuffer, MTLCounterSampleBuffer have added temporary implementations of GetWrapped() and Unwrap().
These temporary implementations perform the appropriate casting. There is no actual implementation of the unimplemented wrapped types. These unimplemented wrapped types are a temporary solution to enable the ObjC bridge to be implemented.

The APIs related to retrieving GPU counters have been hooked with basic serialization. It is expected the replay and capture will need to be specific ie. capture & serialize the buffer data, then at replay upload the serialized buffer data to the GPU buffer.

44f4fdaf
by Remi Palandri at 2022-06-29T11:03:38+01:00
```
fix preview window bug post-activity destruction
```
4ba631d8
by Christian Voss-Wolff at 2022-06-29T11:04:01+01:00
```
Fix Vulkan crash when viewing NV12 in TextureViewer
```

681611d3

by Jake Turner at 2022-06-30T11:40:09+01:00

MTLCommandBuffer API: enqueue, waitUntilCompleted

Hook and capture serialization for enqueue() & waitUntilCompleted()

4d699623

by Jake Turner at 2022-06-30T11:40:09+01:00

Return the WrappedMTLCommandQueue from CmdBuffer

Previous API return goes back to usage for objective C calls and this is not required now the objective C and C++ wrapping/unwrapping has advanced and simplified.
More sense/natural/correct to return type without casting it.

ee82cf14
by Jake Turner at 2022-06-30T11:40:09+01:00
```
Add MetalCmdBufferStatus enum
```

8b8027ff

by Jake Turner at 2022-06-30T11:40:09+01:00

Update MetalCmdBufferRecordingInfo data

Switch to caching the CA::MetalLayer & WrappedMTLTexture from the MTL::Drawable.
This is to avoid validation asserts about accessing the texture of a MTL::Drawable after calling MTLCommandBuffer::presentDrawable.

Switch "bool present" to "uint32_t flags" to future proof being able to store multiple flags on the command buffer recoring info

1816bb80

by Jake Turner at 2022-06-30T11:40:09+01:00

Use capture mode directly : don't use local var

ie. replace

bool backframe = IsBackgroundCapturing(m_State);
if(backframe)

with

if(IsBackgroundCapturing(m_State))

b9e5e2fd

by baldurk at 2022-06-30T13:24:36+01:00

Use QList for variables in ShaderViewer

* Using a linked list instead of a vector makes insert/erase operations for
  variables being created and destroyed significantly faster.

7990254b

by baldurk at 2022-06-30T13:51:26+01:00

Avoid copying shader debug states, only move them

6870329a

by baldurk at 2022-06-30T13:51:26+01:00

Detect java not being in PATH at all, document java PATH requirement

337704df
by baldurk at 2022-06-30T13:51:26+01:00
```
Use a dense map for SPIR-V ID deaths
```
de619024
by baldurk at 2022-06-30T13:51:26+01:00
```
Test for extended UAV support in D3D11 test
```

8e4b44ae

by baldurk at 2022-06-30T13:51:26+01:00

Add test of integer offsets on texture sample for D3D shader debug

9603f5a9

by baldurk at 2022-06-30T13:51:27+01:00

Pre-compile shaders for math and sampling opcodes during shader debug

* D3D12 math shader was already precompiled, but on D3D11 we now allocate
  everything up front and on D3D12 we also up-front compile sampling.
* The only exception is const offsets which can't be variable, so we cache these
  (likely we'll only see a few variants per shader/capture) and create them on
  demand.

c817b6f9
by baldurk at 2022-06-30T14:49:02+01:00
```
Fix clang warning
```

4dc80c17

by baldurk at 2022-06-30T15:41:45+01:00

Use non-legacy ASIC to generate AMDIL

* This may break on drivers old enough to not recognise the first non-legacy
  ASIC, but that is much rarer than new drivers that have dropped support for
  the old ones.

02103a96
by Jake Turner at 2022-07-04T10:15:25+01:00
```
Set non-replay state to BackgroundCapturing
```

c7dae679

by Jake Turner at 2022-07-04T10:15:25+01:00

Use objc_constructInstance in AllocateObjCBridge

This constructs in-place the ObjC bridge class.
This fixes a bug where the reference count of the ObjC bridge class was not guaranteed to be initialized on construction.

8c41ff71

by Jake Turner at 2022-07-04T10:15:25+01:00

Added MetalResourceManager::ReleaseWrappedResource

c56beb77

by Jake Turner at 2022-07-04T10:15:25+01:00

Added DeallocateObjCBridge(WrappedMTL<type> *)

This replaces WrappedMTLObject::Dealloc() which was not implemented or hooked up (it was a TODO).
Deleted WrappedMTLObject::Dealloc()
DeallocateObjCBridge calls resource manager ReleaseWrappedResource().

1fdb7db0

by baldurk at 2022-07-04T14:22:59+01:00

Don't use shader compile flags when editing decompiled shader

049884f5

by baldurk at 2022-07-04T15:00:36+01:00

Don't make decisions based on legacy GL contexts

* This is especially relevant on Android where we fetch all function pointers at
  init time, so any that we replace via emulation are gone, but it is also
  generally true that we expect GL contexts to be representative.

2f30ad3e

by Jake Turner at 2022-07-05T11:23:03+01:00

Make METAL_NOT_HOOKED() be Fatal instead of Error

d361ebf7

by Jake Turner at 2022-07-05T13:01:00+01:00

Allow command line to override Apple cmake options

CMAKE_OSX_ARCHITECTURES
ENABLE_PYRENDERDOC
CMAKE_OSX_DEPLOYMENT_TARGET

Remove CMAKE_OSX_ARCHITECTURES default setting to build for multiple architectures.
Enable ENABLE_PYRENDERDOC to On by default for Apple.

398a92ba

by baldurk at 2022-07-05T13:13:24+01:00

Fix error introduced in 4ba631d where stencil byte offset was always 0

530c8cf0

by baldurk at 2022-07-05T13:13:24+01:00

Don't call SPIR-V callback with optional IDs not present

5b2b988b

by Jake Turner at 2022-07-05T13:37:47+01:00

Test changing vulkan compute shader entry-point

Commit for original bug fix:
"Fix entry-point remapping when editing compute shaders on vulkan"
c81a522360820e89c5cfdf1a364d473a62d21e44

01184079

by Jake Turner at 2022-07-05T13:37:47+01:00

Test editing vulkan compute shader

Replace existing HLSL compute shader with a GLSL compute shader

988e7723

by John Kattukudiyil at 2022-07-08T11:07:21+01:00

Update OpenGL Pixel History with failed tests

- Use samples passed query to add pixel modification data per fragment
- detect draw events that failed culling, scissor, stencil, and depth tests

420efa41
by Orson Baines at 2022-07-08T11:07:21+01:00
```
Only create one history item per event for now
```

4e13b1ad

by Jake Turner at 2022-07-08T11:08:18+01:00

Update Metal CPP to support tests project

Copy Metal driver metal-cpp files to the tests project for use in the tests project

Add extensions from Learn Metal-cpp project: https://developer.apple.com/metal/cpp/

https://developer.apple.com/metal/LearnMetalCPP.zip

Custom additions to Metal CPP to get NSApplication, NSView, NSWindow, CAMetalLayer to work stand alone without requiring MetalKit library.

c83851e8

by Jake Turner at 2022-07-08T11:08:18+01:00

First Apple platform support for Vulkan demos

Uses Metal-CPP-Extensions code to create window and the event loop.
Does not include support for Nuklear

6d7832df

by Jake Turner at 2022-07-08T11:08:18+01:00

Update testing docs with info about Apple

Adding note about using "--demos-binary" option to specify the filepath of the demos binary as an alternative to making sure the demos binary is in the PATH.

Fixed a typo "can'tbe" -> "can't be"

c395bb2c

by baldurk at 2022-07-08T11:08:40+01:00

Work around NV driver bug on D3D11 copying from >2GB buffer

2307c3b0

by baldurk at 2022-07-08T11:08:40+01:00

Add explicit error message for fetching counters without developer mode

* Now that we can report proper error messages, also return more information and
  don't use a separate message box.

92971fb0

by baldurk at 2022-07-08T11:08:40+01:00

List the current EID when a fatal error is detected

83bff08f

by baldurk at 2022-07-08T11:25:57+01:00

Don't enable global hook if short paths are unavailable. Closes #2645

* AppInit_DLLs requires short paths to be specified, if they can't be created on
  the volume we can't reliably enable the global hook.
* Detecting this programmatically is quite complex, but since we know the shim
  file is always longer than 8.3, if we detect that the short path is the same
  length as the long path we know short names weren't used.

52c00efb

by baldurk at 2022-07-11T12:59:49+01:00

Apply matrix stride to inner children for multi-dimensional arrays

d39197a4

by baldurk at 2022-07-11T13:00:18+01:00

Arrays of float3 with a stride of 12 is only possible in scalar packing

* Previously this would be treated as std430 due to being 'tight' array packed,
  even though std430 only allows as tight as the base alignment - which for a
  float3 is 16-bytes still.

7bdf26d3

by baldurk at 2022-07-11T13:02:23+01:00

Implement location tracking and goto for GS printfs

* We can't debug geometry shaders but we can scroll to them, as long as we have
  the primitive. We can't differentiate instances currently without passing that
  data through from the VS (and through tessellation, if it exists).
* This also disables the debug and goto buttons for printfs from shader stages
  that don't support those operations.

c14fad42

by baldurk at 2022-07-11T13:02:35+01:00

Put quotes around the right parameter in disassembled debug printfs

5ef82943

by baldurk at 2022-07-11T13:03:54+01:00

Pass through include paths properly when compiling shaders. Closes #2646

7c68746f

by baldurk at 2022-07-11T13:48:28+01:00

Add missing reference to struct in python docs

6095606b

by baldurk at 2022-07-12T14:36:46+01:00

Don't replay initial states for GL texture buffers with no buffer

bbe9624b

by baldurk at 2022-07-13T11:32:18+01:00

Rejig some code around to avoid stack size explosion in vulkan serialise

c7e41000

by baldurk at 2022-07-13T12:09:31+01:00

Remove hacky 'validation' of draws in render passes

* This was an extremely old bit of code from before vulkan 1.0 to detect a
  common error. RenderDoc does not validate in general so delete this rather
  than keep it up to date.

2833ea4a

by baldurk at 2022-07-13T12:10:40+01:00

Handle state changes on first event in a command buffer. Closes #2648

* When selecting the first event in a command buffer the render state wouldn't
  properly be updated. This is particularly bad if the state that changed is
  being in/out of a renderpass.

b3ad3a20

by baldurk at 2022-07-13T12:11:35+01:00

Don't overwrite secondary command buffer renderpass state if inactive

* With dynamic rendering, secondary command buffers don't always inherit
  renderpass state from the primary, they can start their own.

c3a6a8a9

by baldurk at 2022-07-14T14:01:08+01:00

If there's no fixed data don't fetch the whole buffer

1494a8f7

by baldurk at 2022-07-15T16:04:13+01:00

Checking for the upload location variable being set in CI

* This helps downstream forks to run CI without seeing a false negative in the
  mac release build due to being unable to upload the final package to the
  server.

12350916

by baldurk at 2022-07-15T18:00:38+01:00

Compile shaders in debug when self-hosting captures

23426264

by baldurk at 2022-07-15T18:07:08+01:00

Fix calculation of small mip co-ordinates for NPOT textures

2d34834a
by Jake Turner at 2022-07-18T12:41:44+01:00
```
Add CAMetalLayer::device() to Metal-CPP
```

2d6290ba

by Jake Turner at 2022-07-18T12:41:44+01:00

Basic Metal capture support

Captures can be manually triggered from renderdoccmd capture <application> using F12 or from the UI on the in-development Metal replay branch.
The captures can be loaded and replayed on the in-development Metal replay branch.

The command buffer tracking and serialization are done by GPU submission order which is not necessarily the same as CPU commit order. The command buffer tracking for GPU submission order is currently using an rdcarray, this might change in the future to use a linked list if the performance of appending and deleting from the rdcarray becomes a performance bottleneck.

Does not include support for the presented MTLDrawable ie.
* Thumbnail generation of the final presented image.
* Serializing the presented texture ID.

Does not include support for initial state data.
No MTLBuffer data contents are serialized.

There is a lot missing and a lot of TODOs.
This is the basic structure for capturing which is then built upon.

Includes:
* register the Metal device as a frame capturer ie. AddDeviceFrameCapturer
* logic for triggering captures at Present ie. AddActiveDriver, StartFrameCapture, EndFrameCapture.
* Stopped declaring MetalResourceManager as a friend of WrappedMTLDevice which meant making the initial state-related APIs public instead of private.
* IFrameCapturer interface APIs
* Command buffer tracking for including in the output capture CaptureCmdBufCommit and CaptureCmdBufEnqueue.
* Serialise_MTLCreateSystemDefaultDevice(SerialiserType &ser)
* A helper class MetalCapturer which is derived from IFrameCapturer and registered with the RenderDoc instance. This is because Wrapped Metal classes can't have virtual tables as a requirement for how the C++ and Objective C overlay is implemented.
* The frame capture chunk and API AddFrameCaptureRecordChunk
* MetalInitParams data and serialization.

Helper Methods and Members in MTLDevice
* WaitForGPU()
* MTL::CommandQueue *m_mtlCommandQueue which is used to implement WaitForGPU()
* CaptureClearSubmittedCmdBuffers() & CaptureCmdBufSubmit()
* RegisterMetalLayer() & UnregisterMetalLayer() used to track active Metal swapchains

Details on the memory lifetime for WrappedMTLCommandBuffer

retain the real resource in WrappedMTLCommandBuffer::commit()
release the real resource when no longer needed to be tracked: for background capture in during WrappedMTLDevice::CaptureCmdBufSubmit, for active capture in WrappedMTLDevice::EndFrameCapture.

During capture (Background or Active)
* AddRef() record when command buffer is enqueued (explicit or implicit)
* Delete() record at end of command buffer submit

During Active capture
* AddRef() record in command buffer submit
* Delete() submitted command buffers as part of finalizing the capture

Added TrackedCAMetalLayer & ObjCTrackedCAMetalLayer to track the lifetime of CA::MetalLayer.
The CA::MetalLayer is tracked in the hook for CAMetalLayer::nextDrawable(), with ObjCTrackedCAMetalLayer set as an association to the CAMetalLayer. Then ObjCTrackedCAMetalLayer::dealloc() triggers ending the tracking.

fca14eac

by Jake Turner at 2022-07-18T13:13:37+01:00

Apple minimal Nuklear implementation using AppKit

fb91e736

by Ryan Houdek at 2022-07-18T19:40:55+01:00

Add support for vulkan layer suffixes

While Renderdoc already supported multiarch for where to install the
libraries with the LIB_SUFFIX option. The Vulkan layer was left out of
this loop.

Vulkan layers living in `/usr/share/vulkan/implicit_layer.d/` will use a
suffix before the `.json` to separate libraries of different
architectures. These layer files will then point to the architecture
specific `library_path` inside that json file.

Also updates the check in `LayerRegistrationPath` so it handles the
suffix as well. This way `renderdoccmd` won't complain about conflicting
json files.

3b00cf24
by baldurk at 2022-07-19T10:11:31+01:00
```
Fix crash when structured exporting on D3D
```

43462ea3

by Nicola Cerone at 2022-07-20T10:38:38+01:00

Fix arcball navigation by updating the basis matrix.

8a0af20c

by Jake Turner at 2022-07-21T10:32:32+01:00

metal-cpp : add CA::MetalLayer::setFramebufferOnly

Minor code formatting tidy on a couple of previous changes to better match the surrounding code style

9e8be240

by Jake Turner at 2022-07-21T10:32:32+01:00

Deleted ObjC::CAMetalLayer_Set_framebufferOnly

Use the metal-cpp implementation instead of the helper version

97efa7cf

by Jake Turner at 2022-07-21T10:32:32+01:00

Capture support for the presented MTLDrawable

Generate the capture thumbnail image from the presented `MTLTexture`
Serialize the capture `PresentedImage` ID in the `CaptureEnd` chunk.

d7f286fb
by Jake Turner at 2022-07-21T11:49:49+01:00
```
Enable Clang warning "-Wshadow"
```

1622667b